Laravel-Backpack / CRUD

src/app/Library/Widget.php

Spacing +2 added lines, -2 removed lines

@@ -134,7 +134,7 @@ 
         }
 
         $type = $this->type;
-        $paths = array_map(function ($item) use ($type) {
+        $paths = array_map(function($item) use ($type) {
             return $item.'.'.$type;
         }, config('backpack.base.component_view_namespaces.widgets'));
 
@@ -227,7 +227,7 @@ 
     {
         $itemExists = $this->collection()->contains('name', $this->attributes['name']);
 
-        if (! $itemExists) {
+        if (!$itemExists) {
             $this->collection()->put($this->attributes['name'], $this);
         } else {
             $this->collection()[$this->name] = $this;

tests/Unit/CrudPanel/CrudPanelCreateTest.php

Spacing +1 added lines, -1 removed lines

@@ -596,7 +596,7 @@
                 'nickname' => 'i_have_has_one',
                 'profile_picture' => 'ohh my picture 1.jpg',
                 'article' => 1,
-                'addresses' => [ // HasOne is tested in other test function
+                'addresses' => [// HasOne is tested in other test function
                     [
                         'city' => 'test',
                         'street' => 'test',

tests/config/database/migrations/2020_03_31_114745_create_pivotable_relations_tables.php

Spacing +13 added lines, -13 removed lines

@@ -13,14 +13,14 @@ 
      */
     public function up()
     {
-        Schema::create('comments', function (Blueprint $table) {
+        Schema::create('comments', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->string('text')->nullable();
             $table->morphs('commentable');
             $table->timestamps();
         });
 
-        Schema::create('recommendables', function (Blueprint $table) {
+        Schema::create('recommendables', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->string('text')->nullable();
             $table->morphs('recommendable');
@@ -28,7 +28,7 @@ 
             $table->timestamps();
         });
 
-        Schema::create('billables', function (Blueprint $table) {
+        Schema::create('billables', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->string('text')->nullable();
             $table->morphs('billable');
@@ -36,7 +36,7 @@ 
             $table->timestamps();
         });
 
-        Schema::create('articles_user', function (Blueprint $table) {
+        Schema::create('articles_user', function(Blueprint $table) {
             $table->increments('id');
             $table->integer('article_id')->unsigned();
             $table->integer('user_id')->unsigned();
@@ -44,54 +44,54 @@ 
             $table->nullableTimestamps();
         });
 
-        Schema::create('recommends', function (Blueprint $table) {
+        Schema::create('recommends', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->string('title')->nullable();
             $table->timestamps();
         });
 
-        Schema::create('bills', function (Blueprint $table) {
+        Schema::create('bills', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->string('title')->nullable();
             $table->timestamps();
         });
 
-        Schema::create('stars', function (Blueprint $table) {
+        Schema::create('stars', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->string('starable_type');
             $table->bigInteger('starable_id');
             $table->string('title')->nullable();
         });
 
-        Schema::create('universes', function (Blueprint $table) {
+        Schema::create('universes', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->bigInteger('user_id');
             $table->string('title')->nullable();
         });
 
-        Schema::create('planets', function (Blueprint $table) {
+        Schema::create('planets', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->bigInteger('user_id')->nullable();
             $table->string('title')->nullable();
         });
 
-        Schema::create('comets', function (Blueprint $table) {
+        Schema::create('comets', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->bigInteger('user_id')->default(0);
         });
 
-        Schema::create('bangs', function (Blueprint $table) {
+        Schema::create('bangs', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->string('name');
         });
 
-        Schema::create('account_details_bang', function (Blueprint $table) {
+        Schema::create('account_details_bang', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->bigInteger('account_details_id');
             $table->bigInteger('bang_id');
         });
 
-        Schema::create('account_details_bangs_pivot', function (Blueprint $table) {
+        Schema::create('account_details_bangs_pivot', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->bigInteger('account_details_id');
             $table->bigInteger('bang_id');

src/helpers.php

Spacing +18 added lines, -18 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-if (! function_exists('backpack_url')) {
+if (!function_exists('backpack_url')) {
     /**
      * Appends the configured backpack prefix and returns
      * the URL using the standard Laravel helpers.
@@ -10,13 +10,13 @@ 
      */
     function backpack_url($path = null, $parameters = [], $secure = null)
     {
-        $path = ! $path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
+        $path = !$path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
 
         return url(config('backpack.base.route_prefix', 'admin').$path, $parameters, $secure);
     }
 }
 
-if (! function_exists('backpack_authentication_column')) {
+if (!function_exists('backpack_authentication_column')) {
     /**
      * Return the username column name.
      * The Laravel default (and Backpack default) is 'email'.
@@ -29,7 +29,7 @@ 
     }
 }
 
-if (! function_exists('backpack_form_input')) {
+if (!function_exists('backpack_form_input')) {
     /**
      * Parse the submitted input in request('form') to an usable array.
      * Joins the multiple[] fields in a single key and transform the dot notation fields into arrayed ones.
@@ -58,7 +58,7 @@ 
             }
 
             if (is_null($input_arg)) {
-                if (! isset($result[$input_key])) {
+                if (!isset($result[$input_key])) {
                     $result[$input_key] = $start ? [$row['value']] : $row['value'];
                 } else {
                     array_push($result[$input_key], $row['value']);
@@ -72,7 +72,7 @@ 
     }
 }
 
-if (! function_exists('backpack_users_have_email')) {
+if (!function_exists('backpack_users_have_email')) {
     /**
      * Check if the email column is present on the user table.
      *
@@ -87,7 +87,7 @@ 
     }
 }
 
-if (! function_exists('backpack_avatar_url')) {
+if (!function_exists('backpack_avatar_url')) {
     /**
      * Returns the avatar URL of a user.
      *
@@ -119,7 +119,7 @@ 
     }
 }
 
-if (! function_exists('backpack_middleware')) {
+if (!function_exists('backpack_middleware')) {
     /**
      * Return the key of the middleware used across Backpack.
      * That middleware checks if the visitor is an admin.
@@ -133,7 +133,7 @@ 
     }
 }
 
-if (! function_exists('backpack_guard_name')) {
+if (!function_exists('backpack_guard_name')) {
     /*
      * Returns the name of the guard defined
      * by the application config
@@ -144,7 +144,7 @@ 
     }
 }
 
-if (! function_exists('backpack_auth')) {
+if (!function_exists('backpack_auth')) {
     /*
      * Returns the user instance if it exists
      * of the currently authenticated admin
@@ -156,7 +156,7 @@ 
     }
 }
 
-if (! function_exists('backpack_user')) {
+if (!function_exists('backpack_user')) {
     /*
      * Returns back a user instance without
      * the admin guard, however allows you
@@ -168,7 +168,7 @@ 
     }
 }
 
-if (! function_exists('mb_ucfirst')) {
+if (!function_exists('mb_ucfirst')) {
     /**
      * Capitalize the first letter of a string,
      * even if that string is multi-byte (non-latin alphabet).
@@ -189,7 +189,7 @@ 
     }
 }
 
-if (! function_exists('backpack_view')) {
+if (!function_exists('backpack_view')) {
     /**
      * Returns a new displayable view based on the configured backpack view namespace.
      * If that view doesn't exist, it will load the one from the original theme.
@@ -208,7 +208,7 @@ 
 
         $returnView = $theme.$view;
 
-        if (! view()->exists($returnView)) {
+        if (!view()->exists($returnView)) {
             $returnView = $originalTheme.$view;
         }
 
@@ -216,7 +216,7 @@ 
     }
 }
 
-if (! function_exists('square_brackets_to_dots')) {
+if (!function_exists('square_brackets_to_dots')) {
     /**
      * Turns a string from bracket-type array to dot-notation array.
      * Ex: array[0][property] turns into array.0.property.
@@ -232,7 +232,7 @@ 
     }
 }
 
-if (! function_exists('is_countable')) {
+if (!function_exists('is_countable')) {
     /**
      * We need this because is_countable was only introduced in PHP 7.3,
      * and in PHP 7.2 you should check if count() argument is really countable.
@@ -247,7 +247,7 @@ 
     }
 }
 
-if (! function_exists('old_empty_or_null')) {
+if (!function_exists('old_empty_or_null')) {
     /**
      * This method is an alternative to Laravel's old() helper, which mistakenly
      * returns NULL it two cases:
@@ -279,7 +279,7 @@ 
     }
 }
 
-if (! function_exists('is_multidimensional_array')) {
+if (!function_exists('is_multidimensional_array')) {
     /**
      * If any of the items inside a given array is an array, the array is considered multidimensional.
      *

src/app/Library/CrudPanel/Traits/Relationships.php

Spacing +7 added lines, -7 removed lines

@@ -71,7 +71,7 @@ 
         $model = $this->getRelationModel($entity, -1);
         $lastSegmentAfterDot = Str::of($field['entity'])->afterLast('.');
 
-        if (! method_exists($model, $lastSegmentAfterDot)) {
+        if (!method_exists($model, $lastSegmentAfterDot)) {
             return (string) Str::of($field['entity'])->beforeLast('.');
         }
 
@@ -92,7 +92,7 @@ 
 
         return collect($this->getCleanStateFields())
             ->whereIn('relation_type', $relation_types)
-            ->filter(function ($item) use ($nested) {
+            ->filter(function($item) use ($nested) {
                 if ($nested) {
                     return true;
                 }
@@ -136,14 +136,14 @@ 
      */
     private function getRelationFieldsWithoutRelationType($relations, $include_nested = false)
     {
-        if (! is_array($relations)) {
+        if (!is_array($relations)) {
             $relations = [$relations];
         }
 
         $fields = $this->getRelationFields();
 
         foreach ($relations as $relation) {
-            $fields = array_filter($fields, function ($field) use ($relation, $include_nested) {
+            $fields = array_filter($fields, function($field) use ($relation, $include_nested) {
                 if ($include_nested) {
                     return $field['relation_type'] !== $relation || ($field['relation_type'] === $relation && Str::contains($field['name'], '.'));
                 }
@@ -228,8 +228,8 @@ 
     {
         $all_relation_fields = $this->getRelationFields();
 
-        return Arr::where($all_relation_fields, function ($value, $key) {
-            return isset($value['pivot']) && ! $value['pivot'];
+        return Arr::where($all_relation_fields, function($value, $key) {
+            return isset($value['pivot']) && !$value['pivot'];
         });
     }
 
@@ -242,7 +242,7 @@ 
     {
         $all_relation_fields = $this->getRelationFields();
 
-        return Arr::where($all_relation_fields, function ($value, $key) {
+        return Arr::where($all_relation_fields, function($value, $key) {
             return isset($value['pivot']) && $value['pivot'];
         });
     }

src/app/Library/CrudPanel/Traits/Update.php

Spacing +8 added lines, -8 removed lines

@@ -56,7 +56,7 @@ 
         }
 
         // always have a hidden input for the entry id
-        if (! array_key_exists('id', $fields)) {
+        if (!array_key_exists('id', $fields)) {
             $fields['id'] = [
                 'name'  => $entry->getKeyName(),
                 'value' => $entry->getKey(),
@@ -98,7 +98,7 @@ 
     {
         [$related_model, $relation_method] = $this->getModelAndMethodFromEntity($model, $field);
 
-        if (! method_exists($related_model, $relation_method)) {
+        if (!method_exists($related_model, $relation_method)) {
             return $related_model->{$relation_method};
         }
 
@@ -110,7 +110,7 @@ 
             case 'BelongsToMany':
             case 'MorphToMany':
                 // use subfields aka. pivotFields
-                if (! isset($field['subfields'])) {
+                if (!isset($field['subfields'])) {
                     return $related_model->{$relation_method};
                 }
 
@@ -140,13 +140,13 @@ 
                 break;
             case 'HasOne':
             case 'MorphOne':
-                if (! method_exists($related_model, $relation_method)) {
+                if (!method_exists($related_model, $relation_method)) {
                     return;
                 }
 
                 $related_entry = $related_model->{$relation_method};
 
-                if (! $related_entry) {
+                if (!$related_entry) {
                     return;
                 }
 
@@ -162,7 +162,7 @@ 
                         $name = is_string($subfield) ? $subfield : $subfield['name'];
                         // if the subfield name does not contain a dot we just need to check
                         // if it has subfields and return the result accordingly.
-                        if (! Str::contains($name, '.')) {
+                        if (!Str::contains($name, '.')) {
                             // when subfields are present, $related_entry->{$name} returns a model instance
                             // otherwise returns the model attribute.
                             if (isset($subfield['subfields'])) {
@@ -179,7 +179,7 @@ 
                                 $iterator = $iterator->$part;
                             }
 
-                            Arr::set($result, $name, (! is_string($iterator) ? $iterator->getAttributes() : $iterator));
+                            Arr::set($result, $name, (!is_string($iterator) ? $iterator->getAttributes() : $iterator));
                         }
                     }
 
@@ -201,7 +201,7 @@ 
 
         $relation_array = explode('.', $relational_entity);
 
-        $related_model = array_reduce(array_splice($relation_array, 0, -1), function ($obj, $method) {
+        $related_model = array_reduce(array_splice($relation_array, 0, -1), function($obj, $method) {
             $method = Str::endsWith($method, '_id') ? Str::replaceLast('_id', '', $method) : $method;
 
             return $obj->{$method} ? $obj->{$method} : $obj;

src/app/Library/CrudPanel/Traits/Create.php

Spacing +12 added lines, -12 removed lines

@@ -96,11 +96,11 @@ 
      */
     private function createRelationsForItem($item, $formattedRelations)
     {
-        if (! isset($formattedRelations['relations'])) {
+        if (!isset($formattedRelations['relations'])) {
             return false;
         }
         foreach ($formattedRelations['relations'] as $relationMethod => $relationDetails) {
-            if (! isset($relationDetails['model'])) {
+            if (!isset($relationDetails['model'])) {
                 continue;
             }
             $relation = $item->{$relationMethod}();
@@ -124,7 +124,7 @@ 
                     // - a single dimensional array: [1,2,3]
                     // - an array of arrays: [[1][2][3]]
                     // if is as single dimensional array we can only attach.
-                    if ($relationValues === null || ! is_multidimensional_array($relationValues)) {
+                    if ($relationValues === null || !is_multidimensional_array($relationValues)) {
                         $this->attachManyRelation($item, $relation, $relationDetails, $relationValues);
                     } else {
                         $this->createManyEntries($item, $relation, $relationMethod, $relationDetails);
@@ -146,7 +146,7 @@ 
 
                     // if there is no relation data, and the values array is single dimensional we have
                     // an array of keys with no aditional pivot data. sync those.
-                    if (empty($relationValues) && ! is_multidimensional_array($values)) {
+                    if (empty($relationValues) && !is_multidimensional_array($values)) {
                         $relationValues = array_values($values);
                     }
 
@@ -224,7 +224,7 @@ 
             return $removed_entries->delete();
         }
 
-        if (! $relation_column_is_nullable && $model_instance->dbColumnHasDefault($relation_foreign_key)) {
+        if (!$relation_column_is_nullable && $model_instance->dbColumnHasDefault($relation_foreign_key)) {
             return $removed_entries->update([$relation_foreign_key => $model_instance->getDbColumnDefault($relation_foreign_key)]);
         }
 
@@ -247,7 +247,7 @@ 
         $created_ids = [];
 
         foreach ($items as $item) {
-            if (isset($item[$relation_local_key]) && ! empty($item[$relation_local_key])) {
+            if (isset($item[$relation_local_key]) && !empty($item[$relation_local_key])) {
                 $entry->{$relationMethod}()->where($relation_local_key, $item[$relation_local_key])->update(Arr::except($item, $relation_local_key));
             } else {
                 $created_ids[] = $entry->{$relationMethod}()->create($item)->{$relation_local_key};
@@ -257,7 +257,7 @@ 
         // get from $items the sent ids, and merge the ones created.
         $relatedItemsSent = array_merge(array_filter(Arr::pluck($items, $relation_local_key)), $created_ids);
 
-        if (! empty($relatedItemsSent)) {
+        if (!empty($relatedItemsSent)) {
             // we perform the cleanup of removed database items
             $entry->{$relationMethod}()->whereNotIn($relation_local_key, $relatedItemsSent)->delete();
         }
@@ -287,12 +287,12 @@ 
         $relationFields = $this->getRelationFields();
 
         // exclude the already attached belongs to relations in the main entry but include nested belongs to.
-        $relationFields = Arr::where($relationFields, function ($field, $key) {
+        $relationFields = Arr::where($relationFields, function($field, $key) {
             return $field['relation_type'] !== 'BelongsTo' || ($field['relation_type'] === 'BelongsTo' && Str::contains($field['name'], '.'));
         });
 
         //remove fields that are not in the submitted form input
-        $relationFields = array_filter($relationFields, function ($field) use ($input) {
+        $relationFields = array_filter($relationFields, function($field) use ($input) {
             return Arr::has($input, $field['name']);
         });
 
@@ -325,11 +325,11 @@ 
         $relationEntity = $field['entity'];
         $attributeName = (string) Str::of($field['name'])->afterLast('.');
 
-        if (! $parent) {
+        if (!$parent) {
             $key = implode('.relations.', explode('.', $this->getOnlyRelationEntity($field)));
             $fieldDetails = Arr::get($relationDetails, 'relations.'.$key, []);
             if ($field['relation_type'] === 'HasOne' || $field['relation_type'] === 'MorphOne') {
-                if (! isset($field['subfields'])) {
+                if (!isset($field['subfields'])) {
                     $fieldDetails['values'][$attributeName] = is_array(Arr::get($input, $relationEntity)) ? current(Arr::get($input, $relationEntity)) : Arr::get($input, $relationEntity);
                 } else {
                     $fieldDetails['values'] = is_array(Arr::get($input, $relationEntity)) ? current(Arr::get($input, $relationEntity)) : Arr::get($input, $relationEntity);
@@ -347,7 +347,7 @@ 
                     return $relationDetails;
                 }
             }
-            if (! isset($fieldDetails['values'])) {
+            if (!isset($fieldDetails['values'])) {
                 $fieldDetails['values'] = Arr::get($input, $relationEntity);
             }
         } else {

src/app/Library/CrudPanel/Traits/Fields.php

Spacing +14 added lines, -14 removed lines

@@ -64,7 +64,7 @@ 
                     $subfield = ['name' => $subfield];
                 }
 
-                if (! isset($field['model'])) {
+                if (!isset($field['model'])) {
                     // we're inside a simple 'repeatable' with no model/relationship, so
                     // we assume all subfields are supposed to be text fields
                     $subfield['type'] = $subfield['type'] ?? 'text';
@@ -140,7 +140,7 @@ 
      */
     public function afterField($targetFieldName)
     {
-        $this->transformFields(function ($fields) use ($targetFieldName) {
+        $this->transformFields(function($fields) use ($targetFieldName) {
             return $this->moveField($fields, $targetFieldName, false);
         });
     }
@@ -152,7 +152,7 @@ 
      */
     public function beforeField($targetFieldName)
     {
-        $this->transformFields(function ($fields) use ($targetFieldName) {
+        $this->transformFields(function($fields) use ($targetFieldName) {
             return $this->moveField($fields, $targetFieldName, true);
         });
     }
@@ -164,7 +164,7 @@ 
      */
     public function makeFirstField()
     {
-        if (! $this->fields()) {
+        if (!$this->fields()) {
             return false;
         }
 
@@ -179,7 +179,7 @@ 
      */
     public function removeField($name)
     {
-        $this->transformFields(function ($fields) use ($name) {
+        $this->transformFields(function($fields) use ($name) {
             Arr::forget($fields, $name);
 
             return $fields;
@@ -193,7 +193,7 @@ 
      */
     public function removeFields($array_of_names)
     {
-        if (! empty($array_of_names)) {
+        if (!empty($array_of_names)) {
             foreach ($array_of_names as $name) {
                 $this->removeField($name);
             }
@@ -206,7 +206,7 @@ 
     public function removeAllFields()
     {
         $current_fields = $this->getCleanStateFields();
-        if (! empty($current_fields)) {
+        if (!empty($current_fields)) {
             foreach ($current_fields as $field) {
                 $this->removeField($field['name']);
             }
@@ -298,7 +298,7 @@ 
                 $jsonCastables = ['array', 'object', 'json'];
                 $fieldCasting = $casted_attributes[$field['name']];
 
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
                     try {
                         $data[$field['name']] = json_decode($data[$field['name']]);
                     } catch (\Exception $e) {
@@ -327,7 +327,7 @@ 
      */
     public function orderFields($order)
     {
-        $this->transformFields(function ($fields) use ($order) {
+        $this->transformFields(function($fields) use ($order) {
             return $this->applyOrderToFields($fields, $order);
         });
     }
@@ -353,7 +353,7 @@ 
     public function hasUploadFields()
     {
         $fields = $this->getCleanStateFields();
-        $upload_fields = Arr::where($fields, function ($value, $key) {
+        $upload_fields = Arr::where($fields, function($value, $key) {
             return isset($value['upload']) && $value['upload'] == true;
         });
 
@@ -416,7 +416,7 @@ 
         $alreadyLoaded = $this->getLoadedFieldTypes();
         $type = $this->getFieldTypeWithNamespace($field);
 
-        if (! in_array($type, $this->getLoadedFieldTypes(), true)) {
+        if (!in_array($type, $this->getLoadedFieldTypes(), true)) {
             $alreadyLoaded[] = $type;
             $this->setLoadedFieldTypes($alreadyLoaded);
 
@@ -457,7 +457,7 @@ 
      */
     public function fieldTypeNotLoaded($field)
     {
-        return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
+        return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
     }
 
     /**
@@ -497,7 +497,7 @@ 
      */
     public function hasFieldWhere($attribute, $value)
     {
-        $match = Arr::first($this->getCleanStateFields(), function ($field, $fieldKey) use ($attribute, $value) {
+        $match = Arr::first($this->getCleanStateFields(), function($field, $fieldKey) use ($attribute, $value) {
             return isset($field[$attribute]) && $field[$attribute] == $value;
         });
 
@@ -513,7 +513,7 @@ 
      */
     public function firstFieldWhere($attribute, $value)
     {
-        return Arr::first($this->getCleanStateFields(), function ($field, $fieldKey) use ($attribute, $value) {
+        return Arr::first($this->getCleanStateFields(), function($field, $fieldKey) use ($attribute, $value) {
             return isset($field[$attribute]) && $field[$attribute] == $value;
         });
     }