QueryBuilder::runSelect() - Code Metrics - Inspection of "poc query optimization" - Laravel-Backpack/CRUD - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — optimize-queries ( 9b3855 )

by Pedro

created 2023-01-02 19:19 UTC

QueryBuilder::runSelect() A

↳ Parent: QueryBuilder

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	6
nc	2
nop	0
dl	0
loc	12
rs	10
c	1
b	0
f	0

<?php

namespace Backpack\CRUD\app\Library\Database;

use Illuminate\Database\Query\Builder;

class QueryBuilder extends Builder
{
    /**
     * Run the query as a "select" statement against the connection.
     *
     * @return array
     */
    protected function runSelect()
    {
        $query = base64_encode(json_encode([$this->toSql() => $this->getBindings()]));

        if (app('crud')->hasQuery($query)) {
            return app('crud')->getQuery($query);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        }

        $result = parent::runSelect();
        app('crud')->saveQuery($query, $result);

        return $result;
    }
}


1			<?php
2
3			namespace Backpack\CRUD\app\Library\Database;
4
5			use Illuminate\Database\Query\Builder;
6
7			class QueryBuilder extends Builder
8			{
9			/**
10			* Run the query as a "select" statement against the connection.
11			*
12			* @return array
13			*/
14			protected function runSelect()
15			{
16			$query = base64_encode(json_encode([$this->toSql() => $this->getBindings()]));
17
18			if (app('crud')->hasQuery($query)) {
19			return app('crud')->getQuery($query);
			0 ignored issues – show Bug introduced 2023-01-02 19:31 UTC by Report Bug Copy Issue Report Are you sure the usage of `app('crud')->getQuery($query)` targeting `Backpack\CRUD\app\Librar...l\CrudPanel::getQuery()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history... Bug Best Practice introduced 2023-01-02 19:31 UTC by Report Bug Copy Issue Report The expression `return app('crud')->getQuery($query)` returns the type `void` which is incompatible with the documented return type `array`. Loading history...
20			}
21
22			$result = parent::runSelect();
23			app('crud')->saveQuery($query, $result);
24
25			return $result;
26			}
27			}
28

Laravel-Backpack / CRUD

Scrutinizer GitHub App not installed

Push — optimize-queries ( 9b3855 )

QueryBuilder::runSelect() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like