Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#2508)
by Cristian
11:37
created
src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php 1 patch
Spacing   +7 added lines, -8 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
 
51 51
         // make sure the column has a priority in terms of visibility
52 52
         // if no priority has been defined, use the order in the array plus one
53
-        if (! array_key_exists('priority', $column)) {
53
+        if (!array_key_exists('priority', $column)) {
54 54
             $position_in_columns_array = (int) array_search($column['key'], array_keys($this->columns()));
55 55
             $allColumns[$column['key']]['priority'] = $position_in_columns_array + 1;
56 56
         }
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
             $column = ['name' => $column];
72 72
         }
73 73
 
74
-        if (is_array($column) && ! isset($column['name'])) {
74
+        if (is_array($column) && !isset($column['name'])) {
75 75
             $column['name'] = 'anonymous_column_'.Str::random(5);
76 76
         }
77 77
 
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
      */
88 88
     protected function makeSureColumnHasLabel($column)
89 89
     {
90
-        if (! isset($column['label'])) {
90
+        if (!isset($column['label'])) {
91 91
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
92 92
         }
93 93
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
      */
103 103
     protected function makeSureColumnHasType($column)
104 104
     {
105
-        if (! isset($column['type'])) {
105
+        if (!isset($column['type'])) {
106 106
             $column['type'] = 'text';
107 107
         }
108 108
 
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
      */
120 120
     protected function makeSureColumnHasKey($column)
121 121
     {
122
-        if (! isset($column['key'])) {
122
+        if (!isset($column['key'])) {
123 123
             $column['key'] = str_replace('.', '__', $column['name']);
124 124
         }
125 125
 
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
     {
138 138
         // if this is a relation type field and no corresponding model was specified,
139 139
         // get it from the relation method defined in the main model
140
-        if (isset($column['entity']) && ! isset($column['model'])) {
140
+        if (isset($column['entity']) && !isset($column['model'])) {
141 141
             $column['model'] = $this->getRelationModel($column['entity']);
142 142
         }
143 143
 
@@ -158,8 +158,7 @@  discard block
 block discarded – undo
158 158
         $columnsArray = $this->columns();
159 159
 
160 160
         if (array_key_exists($targetColumnName, $columnsArray)) {
161
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
162
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
161
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
163 162
 
164 163
             $element = array_pop($columnsArray);
165 164
             $beginningPart = array_slice($columnsArray, 0, $targetColumnPosition, true);
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/AutoSet.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -12,12 +12,12 @@  discard block
 block discarded – undo
12 12
      */
13 13
     public function setFromDb()
14 14
     {
15
-        if (! $this->driverIsMongoDb()) {
15
+        if (!$this->driverIsMongoDb()) {
16 16
             $this->setDoctrineTypesMapping();
17 17
             $this->getDbColumnTypes();
18 18
         }
19 19
 
20
-        array_map(function ($field) {
20
+        array_map(function($field) {
21 21
             $new_field = [
22 22
                 'name'       => $field,
23 23
                 'label'      => $this->makeLabel($field),
@@ -29,11 +29,11 @@  discard block
 block discarded – undo
29 29
                 'autoset'    => true,
30 30
             ];
31 31
 
32
-            if (! isset($this->fields()[$field])) {
32
+            if (!isset($this->fields()[$field])) {
33 33
                 $this->addField($new_field);
34 34
             }
35 35
 
36
-            if (! in_array($field, $this->model->getHidden()) && ! in_array($field, $this->columns())) {
36
+            if (!in_array($field, $this->model->getHidden()) && !in_array($field, $this->columns())) {
37 37
                 $this->addColumn([
38 38
                     'name'    => $field,
39 39
                     'label'   => $this->makeLabel($field),
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 
106 106
         $dbColumnTypes = $this->getDbColumnTypes();
107 107
 
108
-        if (! isset($dbColumnTypes[$fieldName])) {
108
+        if (!isset($dbColumnTypes[$fieldName])) {
109 109
             return 'text';
110 110
         }
111 111
 
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
         $types = ['enum' => 'string'];
164 164
         $platform = $this->getSchema()->getConnection()->getDoctrineConnection()->getDatabasePlatform();
165 165
         foreach ($types as $type_key => $type_value) {
166
-            if (! $platform->hasDoctrineTypeMappingFor($type_key)) {
166
+            if (!$platform->hasDoctrineTypeMappingFor($type_key)) {
167 167
                 $platform->registerDoctrineTypeMapping($type_key, $type_value);
168 168
             }
169 169
         }
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
             // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model
223 223
             $columns = $this->model->getConnection()->getSchemaBuilder()->getColumnListing($this->model->getTable());
224 224
 
225
-            if (! empty($fillable)) {
225
+            if (!empty($fillable)) {
226 226
                 $columns = array_intersect($columns, $fillable);
227 227
             }
228 228
         }
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelSaveActionsTest.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -21,10 +21,10 @@  discard block
 block discarded – undo
21 21
 
22 22
         $this->singleSaveAction = [
23 23
             'name' => 'save_action_one',
24
-            'redirect' => function ($crud, $request, $itemId) {
24
+            'redirect' => function($crud, $request, $itemId) {
25 25
                 return $crud->route;
26 26
             },
27
-            'visible' => function ($crud) {
27
+            'visible' => function($crud) {
28 28
                 return true;
29 29
             },
30 30
         ];
@@ -32,19 +32,19 @@  discard block
 block discarded – undo
32 32
         $this->multipleSaveActions = [
33 33
             [
34 34
                 'name' => 'save_action_one',
35
-                'redirect' => function ($crud, $request, $itemId) {
35
+                'redirect' => function($crud, $request, $itemId) {
36 36
                     return $crud->route;
37 37
                 },
38
-                'visible' => function ($crud) {
38
+                'visible' => function($crud) {
39 39
                     return true;
40 40
                 },
41 41
             ],
42 42
             [
43 43
                 'name' => 'save_action_two',
44
-                'redirect' => function ($crud, $request, $itemId) {
44
+                'redirect' => function($crud, $request, $itemId) {
45 45
                     return $crud->route;
46 46
                 },
47
-                'visible' => function ($crud) {
47
+                'visible' => function($crud) {
48 48
                     return true;
49 49
                 },
50 50
             ],
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/InlineCreateOperation.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
      */
50 50
     public function getInlineCreateModal()
51 51
     {
52
-        if (! request()->has('entity')) {
52
+        if (!request()->has('entity')) {
53 53
             abort(400, 'No "entity" inside the request.');
54 54
         }
55 55
 
Please login to merge, or discard this patch.
src/app/Library/Auth/ResetsPasswords.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
         // will update the password on an actual user model and persist it to the
46 46
         // database. Otherwise we will parse the error and return the response.
47 47
         $response = $this->broker()->reset(
48
-            $this->credentials($request), function ($user, $password) {
48
+            $this->credentials($request), function($user, $password) {
49 49
                 $this->resetPassword($user, $password);
50 50
             }
51 51
         );
Please login to merge, or discard this patch.
src/app/Library/Auth/VerifiesEmails.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -34,11 +34,11 @@
 block discarded – undo
34 34
      */
35 35
     public function verify(Request $request)
36 36
     {
37
-        if (! hash_equals((string) $request->route('id'), (string) $request->user()->getKey())) {
37
+        if (!hash_equals((string) $request->route('id'), (string) $request->user()->getKey())) {
38 38
             throw new AuthorizationException;
39 39
         }
40 40
 
41
-        if (! hash_equals((string) $request->route('hash'), sha1($request->user()->getEmailForVerification()))) {
41
+        if (!hash_equals((string) $request->route('hash'), sha1($request->user()->getEmailForVerification()))) {
42 42
             throw new AuthorizationException;
43 43
         }
44 44
 
Please login to merge, or discard this patch.
src/app/Console/Commands/Install.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
                     $createUploadDirectoryCommand = ['mkdir', '-p', 'public/uploads'];
95 95
                     break;
96 96
                 case '\\': // windows
97
-                    if (! file_exists('public\uploads')) {
97
+                    if (!file_exists('public\uploads')) {
98 98
                         $createUploadDirectoryCommand = ['mkdir', 'public\uploads'];
99 99
                     }
100 100
                     break;
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
         $command = is_string($command) ? explode(' ', $command) : $command;
148 148
 
149 149
         $process = new Process($command, null, null, null, $this->option('timeout'));
150
-        $process->run(function ($type, $buffer) {
150
+        $process->run(function($type, $buffer) {
151 151
             if (Process::ERR === $type) {
152 152
                 $this->echo('comment', $buffer);
153 153
             } else {
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
         });
157 157
 
158 158
         // executes after the command finishes
159
-        if (! $process->isSuccessful()) {
159
+        if (!$process->isSuccessful()) {
160 160
             throw new ProcessFailedException($process);
161 161
         }
162 162
 
Please login to merge, or discard this patch.
src/app/Models/Traits/HasFakeFields.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
     public function addFakes($columns = ['extras'])
21 21
     {
22 22
         foreach ($columns as $key => $column) {
23
-            if (! isset($this->attributes[$column])) {
23
+            if (!isset($this->attributes[$column])) {
24 24
                 continue;
25 25
             }
26 26
 
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
      */
70 70
     public function shouldDecodeFake($column)
71 71
     {
72
-        return ! in_array($column, array_keys($this->casts));
72
+        return !in_array($column, array_keys($this->casts));
73 73
     }
74 74
 
75 75
     /**
@@ -81,6 +81,6 @@  discard block
 block discarded – undo
81 81
      */
82 82
     public function shouldEncodeFake($column)
83 83
     {
84
-        return ! in_array($column, array_keys($this->casts));
84
+        return !in_array($column, array_keys($this->casts));
85 85
     }
86 86
 }
Please login to merge, or discard this patch.
src/app/Models/Traits/HasRelationshipFields.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@
 block discarded – undo
84 84
             // check for NOT NULL
85 85
             $notNull = $column->getNotnull();
86 86
             // return the value of nullable (aka the inverse of NOT NULL)
87
-            return ! $notNull;
87
+            return !$notNull;
88 88
         } catch (\Exception $e) {
89 89
             return true;
90 90
         }
Please login to merge, or discard this patch.