Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — main (#4988)
by Cristian
34:41 queued 19:42
created
src/app/Library/CrudPanel/Traits/Fields.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
      */
139 139
     public function afterField($targetFieldName)
140 140
     {
141
-        $this->transformFields(function ($fields) use ($targetFieldName) {
141
+        $this->transformFields(function($fields) use ($targetFieldName) {
142 142
             return $this->moveField($fields, $targetFieldName, false);
143 143
         });
144 144
     }
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
      */
151 151
     public function beforeField($targetFieldName)
152 152
     {
153
-        $this->transformFields(function ($fields) use ($targetFieldName) {
153
+        $this->transformFields(function($fields) use ($targetFieldName) {
154 154
             return $this->moveField($fields, $targetFieldName, true);
155 155
         });
156 156
     }
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
      */
163 163
     public function makeFirstField()
164 164
     {
165
-        if (! $this->fields()) {
165
+        if (!$this->fields()) {
166 166
             return false;
167 167
         }
168 168
 
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
      */
178 178
     public function removeField($name)
179 179
     {
180
-        $this->transformFields(function ($fields) use ($name) {
180
+        $this->transformFields(function($fields) use ($name) {
181 181
             Arr::forget($fields, $name);
182 182
 
183 183
             return $fields;
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
      */
192 192
     public function removeFields($array_of_names)
193 193
     {
194
-        if (! empty($array_of_names)) {
194
+        if (!empty($array_of_names)) {
195 195
             foreach ($array_of_names as $name) {
196 196
                 $this->removeField($name);
197 197
             }
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
     public function removeAllFields()
205 205
     {
206 206
         $current_fields = $this->getCleanStateFields();
207
-        if (! empty($current_fields)) {
207
+        if (!empty($current_fields)) {
208 208
             foreach ($current_fields as $field) {
209 209
                 $this->removeField($field['name']);
210 210
             }
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
                 $jsonCastables = ['array', 'object', 'json'];
300 300
                 $fieldCasting = $casted_attributes[$field['name']];
301 301
 
302
-                if (in_array($fieldCasting, $jsonCastables) && isset($input[$field['name']]) && ! empty($input[$field['name']]) && ! is_array($input[$field['name']])) {
302
+                if (in_array($fieldCasting, $jsonCastables) && isset($input[$field['name']]) && !empty($input[$field['name']]) && !is_array($input[$field['name']])) {
303 303
                     try {
304 304
                         $input[$field['name']] = json_decode($input[$field['name']]);
305 305
                     } catch (\Exception $e) {
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
      */
329 329
     public function orderFields($order)
330 330
     {
331
-        $this->transformFields(function ($fields) use ($order) {
331
+        $this->transformFields(function($fields) use ($order) {
332 332
             return $this->applyOrderToFields($fields, $order);
333 333
         });
334 334
     }
@@ -354,7 +354,7 @@  discard block
 block discarded – undo
354 354
     public function hasUploadFields()
355 355
     {
356 356
         $fields = $this->getCleanStateFields();
357
-        $upload_fields = Arr::where($fields, function ($value, $key) {
357
+        $upload_fields = Arr::where($fields, function($value, $key) {
358 358
             // check if any subfields have uploads
359 359
             if (isset($value['subfields'])) {
360 360
                 foreach ($value['subfields'] as $subfield) {
@@ -426,7 +426,7 @@  discard block
 block discarded – undo
426 426
         $alreadyLoaded = $this->getLoadedFieldTypes();
427 427
         $type = $this->getFieldTypeWithNamespace($field);
428 428
 
429
-        if (! in_array($type, $this->getLoadedFieldTypes(), true)) {
429
+        if (!in_array($type, $this->getLoadedFieldTypes(), true)) {
430 430
             $alreadyLoaded[] = $type;
431 431
             $this->setLoadedFieldTypes($alreadyLoaded);
432 432
 
@@ -467,7 +467,7 @@  discard block
 block discarded – undo
467 467
      */
468 468
     public function fieldTypeNotLoaded($field)
469 469
     {
470
-        return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
470
+        return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
471 471
     }
472 472
 
473 473
     /**
@@ -516,7 +516,7 @@  discard block
 block discarded – undo
516 516
      */
517 517
     public function hasFieldWhere($attribute, $value)
518 518
     {
519
-        $match = Arr::first($this->getCleanStateFields(), function ($field, $fieldKey) use ($attribute, $value) {
519
+        $match = Arr::first($this->getCleanStateFields(), function($field, $fieldKey) use ($attribute, $value) {
520 520
             return isset($field[$attribute]) && $field[$attribute] == $value;
521 521
         });
522 522
 
@@ -532,7 +532,7 @@  discard block
 block discarded – undo
532 532
      */
533 533
     public function firstFieldWhere($attribute, $value)
534 534
     {
535
-        return Arr::first($this->getCleanStateFields(), function ($field, $fieldKey) use ($attribute, $value) {
535
+        return Arr::first($this->getCleanStateFields(), function($field, $fieldKey) use ($attribute, $value) {
536 536
             return isset($field[$attribute]) && $field[$attribute] == $value;
537 537
         });
538 538
     }
Please login to merge, or discard this patch.
src/BackpackServiceProvider.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -66,24 +66,24 @@  discard block
 block discarded – undo
66 66
         include_once __DIR__.'/macros.php';
67 67
 
68 68
         // Bind the CrudPanel object to Laravel's service container
69
-        $this->app->scoped('crud', function ($app) {
69
+        $this->app->scoped('crud', function($app) {
70 70
             return new CrudPanel();
71 71
         });
72 72
 
73
-        $this->app->scoped('DatabaseSchema', function ($app) {
73
+        $this->app->scoped('DatabaseSchema', function($app) {
74 74
             return new DatabaseSchema();
75 75
         });
76 76
 
77
-        $this->app->singleton('BackpackViewNamespaces', function ($app) {
77
+        $this->app->singleton('BackpackViewNamespaces', function($app) {
78 78
             return new ViewNamespaces();
79 79
         });
80 80
 
81 81
         // Bind the widgets collection object to Laravel's service container
82
-        $this->app->singleton('widgets', function ($app) {
82
+        $this->app->singleton('widgets', function($app) {
83 83
             return new Collection();
84 84
         });
85 85
 
86
-        $this->app->scoped('UploadersRepository', function ($app) {
86
+        $this->app->scoped('UploadersRepository', function($app) {
87 87
             return new UploadersRepository();
88 88
         });
89 89
 
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
         $middleware_key = config('backpack.base.middleware_key');
100 100
         $middleware_class = config('backpack.base.middleware_class');
101 101
 
102
-        if (! is_array($middleware_class)) {
102
+        if (!is_array($middleware_class)) {
103 103
             $router->pushMiddlewareToGroup($middleware_key, $middleware_class);
104 104
 
105 105
             return;
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
         $operationConfigs = scandir(__DIR__.'/config/backpack/operations/');
216 216
         $operationConfigs = array_diff($operationConfigs, ['.', '..']);
217 217
 
218
-        if (! count($operationConfigs)) {
218
+        if (!count($operationConfigs)) {
219 219
             return;
220 220
         }
221 221
 
Please login to merge, or discard this patch.
src/macros.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -19,8 +19,8 @@  discard block
 block discarded – undo
19 19
  *      - when true: `address[street]`
20 20
  *      - when false: `[address][street]`
21 21
  */
22
-if (! Str::hasMacro('dotsToSquareBrackets')) {
23
-    Str::macro('dotsToSquareBrackets', function ($string, $ignore = [], $keyFirst = true) {
22
+if (!Str::hasMacro('dotsToSquareBrackets')) {
23
+    Str::macro('dotsToSquareBrackets', function($string, $ignore = [], $keyFirst = true) {
24 24
         $stringParts = explode('.', $string);
25 25
         $result = '';
26 26
 
@@ -34,8 +34,8 @@  discard block
 block discarded – undo
34 34
         return $result;
35 35
     });
36 36
 }
37
-if (! CrudColumn::hasMacro('withFiles')) {
38
-    CrudColumn::macro('withFiles', function ($uploadDefinition = [], $subfield = null) {
37
+if (!CrudColumn::hasMacro('withFiles')) {
38
+    CrudColumn::macro('withFiles', function($uploadDefinition = [], $subfield = null) {
39 39
         /** @var CrudField|CrudColumn $this */
40 40
         RegisterUploadEvents::handle($this, $uploadDefinition, 'withFiles', $subfield);
41 41
 
@@ -43,8 +43,8 @@  discard block
 block discarded – undo
43 43
     });
44 44
 }
45 45
 
46
-if (! CrudField::hasMacro('withFiles')) {
47
-    CrudField::macro('withFiles', function ($uploadDefinition = [], $subfield = null) {
46
+if (!CrudField::hasMacro('withFiles')) {
47
+    CrudField::macro('withFiles', function($uploadDefinition = [], $subfield = null) {
48 48
         /** @var CrudField|CrudColumn $this */
49 49
         RegisterUploadEvents::handle($this, $uploadDefinition, 'withFiles', $subfield);
50 50
 
@@ -58,8 +58,8 @@  discard block
 block discarded – undo
58 58
  *
59 59
  * It will go to the given CrudController and get the setupRoutes() method on it.
60 60
  */
61
-if (! Route::hasMacro('crud')) {
62
-    Route::macro('crud', function ($name, $controller) {
61
+if (!Route::hasMacro('crud')) {
62
+    Route::macro('crud', function($name, $controller) {
63 63
         // put together the route name prefix,
64 64
         // as passed to the Route::group() statements
65 65
         $routeName = '';
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Support/MacroableWithAttributes.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
             if (isset($attributes['subfields'])) {
47 47
                 foreach ($attributes['subfields'] as $subfield) {
48 48
                     if (isset($subfield[$macro])) {
49
-                        $config = ! is_array($subfield[$macro]) ? [] : $subfield[$macro];
49
+                        $config = !is_array($subfield[$macro]) ? [] : $subfield[$macro];
50 50
                         $this->{$macro}($config, $subfield);
51 51
                     }
52 52
                 }
Please login to merge, or discard this patch.
src/app/Library/Uploaders/SingleBase64Image.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
         $value = $value ?? CRUD::getRequest()->get($this->getName());
15 15
         $previousImage = $entry->getOriginal($this->getName());
16 16
 
17
-        if (! $value && $previousImage) {
17
+        if (!$value && $previousImage) {
18 18
             Storage::disk($this->getDisk())->delete($previousImage);
19 19
 
20 20
             return null;
Please login to merge, or discard this patch.
src/app/Library/Uploaders/MultipleFiles.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@  discard block
 block discarded – undo
10 10
 
11 11
 class MultipleFiles extends Uploader
12 12
 {
13
-    public static function for(array $field, $configuration): UploaderInterface
13
+    public static function for (array $field, $configuration): UploaderInterface
14 14
     {
15 15
         return (new self($field, $configuration))->multiple();
16 16
     }
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
         $value = $value ?? CRUD::getRequest()->file($this->getName());
22 22
         $previousFiles = $entry->getOriginal($this->getName()) ?? [];
23 23
         
24
-        if (! is_array($previousFiles) && is_string($previousFiles)) {
24
+        if (!is_array($previousFiles) && is_string($previousFiles)) {
25 25
             $previousFiles = json_decode($previousFiles, true);
26 26
         }
27 27
 
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
                 if (in_array($previousFile, $filesToDelete)) {
31 31
                     Storage::disk($this->getDisk())->delete($previousFile);
32 32
 
33
-                    $previousFiles = Arr::where($previousFiles, function ($value, $key) use ($previousFile) {
33
+                    $previousFiles = Arr::where($previousFiles, function($value, $key) use ($previousFile) {
34 34
                         return $value != $previousFile;
35 35
                     });
36 36
                 }
Please login to merge, or discard this patch.
src/app/Library/Uploaders/Uploader.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
     /*******************************
57 57
      * Static methods
58 58
      *******************************/
59
-    public static function for(array $crudObject, array $definition): UploaderInterface
59
+    public static function for (array $crudObject, array $definition): UploaderInterface
60 60
     {
61 61
         return new static($crudObject, $definition);
62 62
     }
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
     public function deleteUploadedFiles(Model $entry): void
88 88
     {
89 89
         if ($this->deleteWhenEntryIsDeleted) {
90
-            if (! in_array(SoftDeletes::class, class_uses_recursive($entry), true)) {
90
+            if (!in_array(SoftDeletes::class, class_uses_recursive($entry), true)) {
91 91
                 $this->performFileDeletion($entry);
92 92
 
93 93
                 return;
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
     {
170 170
         $value = $entry->{$this->name};
171 171
 
172
-        if ($this->handleMultipleFiles && ! isset($entry->getCasts()[$this->name]) && is_string($value)) {
172
+        if ($this->handleMultipleFiles && !isset($entry->getCasts()[$this->name]) && is_string($value)) {
173 173
             $entry->{$this->name} = json_decode($value, true);
174 174
 
175 175
             return $entry;
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
 
187 187
         if ($this->handleMultipleFiles) {
188 188
             // ensure we have an array of values when field is not casted in model.
189
-            if (! isset($entry->getCasts()[$this->name]) && is_string($values)) {
189
+            if (!isset($entry->getCasts()[$this->name]) && is_string($values)) {
190 190
                 $values = json_decode($values, true);
191 191
             }
192 192
             foreach ($values as $value) {
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
 
203 203
     private function performFileDeletion(Model $entry)
204 204
     {
205
-        if ($this->isRelationship || ! $this->handleRepeatableFiles) {
205
+        if ($this->isRelationship || !$this->handleRepeatableFiles) {
206 206
             $this->deleteFiles($entry);
207 207
 
208 208
             return;
Please login to merge, or discard this patch.
src/app/Library/Uploaders/SingleFile.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
             return $this->getPath().$fileName;
24 24
         }
25 25
 
26
-        if (! $value && CrudPanelFacade::getRequest()->has($this->getName()) && $previousFile) {
26
+        if (!$value && CrudPanelFacade::getRequest()->has($this->getName()) && $previousFile) {
27 27
             Storage::disk($this->getDisk())->delete($previousFile);
28 28
 
29 29
             return null;
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         }
48 48
 
49 49
         foreach ($previousRepeatableValues as $row => $file) {
50
-            if ($file && ! isset($orderedFiles[$row])) {
50
+            if ($file && !isset($orderedFiles[$row])) {
51 51
                 $orderedFiles[$row] = null;
52 52
                 Storage::disk($this->getDisk())->delete($file);
53 53
             }
Please login to merge, or discard this patch.
src/app/Library/Uploaders/Support/RegisterUploadEvents.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -13,18 +13,18 @@  discard block
 block discarded – undo
13 13
     private string $crudObjectType;
14 14
 
15 15
     public function __construct(
16
-        private readonly CrudField|CrudColumn $crudObject,
16
+        private readonly CrudField | CrudColumn $crudObject,
17 17
         private readonly array $uploaderConfiguration,
18 18
         private readonly string $macro
19 19
         ) {
20 20
         $this->crudObjectType = is_a($crudObject, CrudField::class) ? 'field' : (is_a($crudObject, CrudColumn::class) ? 'column' : null);
21 21
 
22
-        if (! $this->crudObjectType) {
22
+        if (!$this->crudObjectType) {
23 23
             abort(500, 'Upload handlers only work for CrudField and CrudColumn classes.');
24 24
         }
25 25
     }
26 26
 
27
-    public static function handle(CrudField|CrudColumn $crudObject, array $uploaderConfiguration, string $macro, ?array $subfield = null): void
27
+    public static function handle(CrudField | CrudColumn $crudObject, array $uploaderConfiguration, string $macro, ?array $subfield = null): void
28 28
     {
29 29
         $instance = new self($crudObject, $uploaderConfiguration, $macro);
30 30
 
@@ -34,9 +34,9 @@  discard block
 block discarded – undo
34 34
     /*******************************
35 35
      * Private methods - implementation
36 36
      *******************************/
37
-    private function registerEvents(array|null $subfield = []): void
37
+    private function registerEvents(array | null $subfield = []): void
38 38
     {
39
-        if (! empty($subfield)) {
39
+        if (!empty($subfield)) {
40 40
             $this->registerSubfieldEvent($subfield);
41 41
 
42 42
             return;
@@ -71,12 +71,12 @@  discard block
 block discarded – undo
71 71
 
72 72
         // for subfields, we only register one event so that we have access to the repeatable container name.
73 73
         // all the uploaders for a given container are stored in the UploadersRepository.
74
-        if (! app('UploadersRepository')->hasRepeatableUploadersFor($uploader->getRepeatableContainerName())) {
74
+        if (!app('UploadersRepository')->hasRepeatableUploadersFor($uploader->getRepeatableContainerName())) {
75 75
             $this->setupModelEvents($model, $uploader);
76 76
         }
77 77
 
78 78
         $subfields = collect($this->crudObject->getAttributes()['subfields']);
79
-        $subfields = $subfields->map(function ($item) use ($subfield, $uploader) {
79
+        $subfields = $subfields->map(function($item) use ($subfield, $uploader) {
80 80
             if ($item['name'] === $subfield['name']) {
81 81
                 $item['upload'] = true;
82 82
                 $item['disk'] = $uploader->getDisk();
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
         }
107 107
 
108 108
         if ($this->crudObjectType === 'field') {
109
-            $model::saving(function ($entry) use ($uploader) {
109
+            $model::saving(function($entry) use ($uploader) {
110 110
                 $updatedCountKey = 'uploaded_'.($uploader->getRepeatableContainerName() ?? $uploader->getName()).'_count';
111 111
 
112 112
                 CRUD::set($updatedCountKey, CRUD::get($updatedCountKey) ?? 0);
@@ -117,11 +117,11 @@  discard block
 block discarded – undo
117 117
             });
118 118
         }
119 119
 
120
-        $model::retrieved(function ($entry) use ($uploader) {
120
+        $model::retrieved(function($entry) use ($uploader) {
121 121
             $entry = $uploader->retrieveUploadedFiles($entry);
122 122
         });
123 123
 
124
-        $model::deleting(function ($entry) use ($uploader) {
124
+        $model::deleting(function($entry) use ($uploader) {
125 125
             $uploader->deleteUploadedFiles($entry);
126 126
         });
127 127
 
@@ -144,13 +144,13 @@  discard block
 block discarded – undo
144 144
         $customUploader = isset($uploaderConfiguration['uploader']) && class_exists($uploaderConfiguration['uploader']);
145 145
 
146 146
         if ($customUploader) {
147
-            return $uploaderConfiguration['uploader']::for($crudObject, $uploaderConfiguration);
147
+            return $uploaderConfiguration['uploader']::for ($crudObject, $uploaderConfiguration);
148 148
         }
149 149
 
150 150
         $uploader = app('UploadersRepository')->hasUploadFor($crudObject['type'], $this->macro);
151 151
 
152 152
         if ($uploader) {
153
-            return app('UploadersRepository')->getUploadFor($crudObject['type'], $this->macro)::for($crudObject, $uploaderConfiguration);
153
+            return app('UploadersRepository')->getUploadFor($crudObject['type'], $this->macro)::for ($crudObject, $uploaderConfiguration);
154 154
         }
155 155
 
156 156
         throw new Exception('Undefined upload type for '.$this->crudObjectType.' type: '.$crudObject['type']);
Please login to merge, or discard this patch.