Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Failed
Pull Request — main (#4529)
by Cristian
27:11 queued 12:09
created
src/app/Library/CrudPanel/Traits/Validation.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -46,10 +46,10 @@  discard block
 block discarded – undo
46 46
     private function getValidationRulesFromFieldsAndSubfields($fields)
47 47
     {
48 48
         $rules = collect($fields)
49
-            ->filter(function ($value, $key) {
49
+            ->filter(function($value, $key) {
50 50
                 // only keep fields where 'validationRules' OR there are subfields
51 51
                 return array_key_exists('validationRules', $value) || array_key_exists('subfields', $value);
52
-            })->map(function ($item, $key) {
52
+            })->map(function($item, $key) {
53 53
                 $validationRules = [];
54 54
                 // only keep the rules, not the entire field definition
55 55
                 if (isset($item['validationRules'])) {
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
                 }
58 58
                 // add validation rules for subfields
59 59
                 if (array_key_exists('subfields', $item)) {
60
-                    $subfieldsWithValidation = array_filter($item['subfields'], function ($subfield) {
60
+                    $subfieldsWithValidation = array_filter($item['subfields'], function($subfield) {
61 61
                         return array_key_exists('validationRules', $subfield);
62 62
                     });
63 63
 
@@ -82,10 +82,10 @@  discard block
 block discarded – undo
82 82
     {
83 83
         $messages = [];
84 84
         collect($fields)
85
-            ->filter(function ($value, $key) {
85
+            ->filter(function($value, $key) {
86 86
                 // only keep fields where 'validationMessages' OR there are subfields
87 87
                 return array_key_exists('validationMessages', $value) || array_key_exists('subfields', $value);
88
-            })->each(function ($item, $key) use (&$messages) {
88
+            })->each(function($item, $key) use (&$messages) {
89 89
                 if (isset($item['validationMessages'])) {
90 90
                     foreach ($item['validationMessages'] as $rule => $message) {
91 91
                         $messages[$key.'.'.$rule] = $message;
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
                 }
94 94
                 // add messages from subfields
95 95
                 if (array_key_exists('subfields', $item)) {
96
-                    $subfieldsWithValidationMessages = array_filter($item['subfields'], function ($subfield) {
96
+                    $subfieldsWithValidationMessages = array_filter($item['subfields'], function($subfield) {
97 97
                         return array_key_exists('validationRules', $subfield);
98 98
                     });
99 99
 
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
      */
130 130
     public function setValidation($classOrRulesArray = false, $messages = [])
131 131
     {
132
-        if (! $classOrRulesArray) {
132
+        if (!$classOrRulesArray) {
133 133
             $this->setValidationFromFields();
134 134
         } elseif (is_array($classOrRulesArray)) {
135 135
             $this->setValidationFromArray($classOrRulesArray, $messages);
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
210 210
             return $this->checkRequestValidity($extendedRules, $extendedMessages, $formRequest);
211 211
         }
212 212
 
213
-        return ! empty($rules) ? $this->checkRequestValidity($rules, $messages) : $this->getRequest();
213
+        return !empty($rules) ? $this->checkRequestValidity($rules, $messages) : $this->getRequest();
214 214
     }
215 215
 
216 216
     /**
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
     {
226 226
         $extendedRules = [];
227 227
         $requestRules = $this->getRequestRulesAsArray($request);
228
-        $rules = array_map(function ($ruleDefinition) {
228
+        $rules = array_map(function($ruleDefinition) {
229 229
             return is_array($ruleDefinition) ? $ruleDefinition : explode('|', $ruleDefinition);
230 230
         }, $rules);
231 231
 
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
      */
323 323
     public function isRequired($inputKey)
324 324
     {
325
-        if (! $this->hasOperationSetting('requiredFields')) {
325
+        if (!$this->hasOperationSetting('requiredFields')) {
326 326
             return false;
327 327
         }
328 328
 
@@ -343,7 +343,7 @@  discard block
 block discarded – undo
343 343
     {
344 344
         [$rules, $messages] = $this->getValidationRulesAndMessagesFromField($field, $parent);
345 345
 
346
-        if (! empty($rules)) {
346
+        if (!empty($rules)) {
347 347
             $this->setValidation($rules, $messages);
348 348
         }
349 349
     }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Query.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
      */
100 100
     public function customOrderBy($column, $columnDirection = 'asc')
101 101
     {
102
-        if (! isset($column['orderLogic'])) {
102
+        if (!isset($column['orderLogic'])) {
103 103
             return $this->query;
104 104
         }
105 105
 
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
      */
190 190
     public function getTotalQueryCount()
191 191
     {
192
-        if (! $this->getOperationSetting('showEntryCount')) {
192
+        if (!$this->getOperationSetting('showEntryCount')) {
193 193
             return 0;
194 194
         }
195 195
 
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
228 228
      */
229 229
     private function getCountFromQuery(Builder $query)
230 230
     {
231
-        if (! $this->driverIsSql()) {
231
+        if (!$this->driverIsSql()) {
232 232
             return $query->count();
233 233
         }
234 234
 
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
         $expressionColumns = [];
248 248
 
249 249
         foreach ($crudQuery->columns as $column) {
250
-            if (! is_string($column) && is_a($column, 'Illuminate\Database\Query\Expression')) {
250
+            if (!is_string($column) && is_a($column, 'Illuminate\Database\Query\Expression')) {
251 251
                 $expressionColumns[] = $column;
252 252
             }
253 253
         }
Please login to merge, or discard this patch.
src/app/Console/Commands/PublishAssets.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -41,12 +41,12 @@
 block discarded – undo
41 41
     private function runConsoleCommand($command)
42 42
     {
43 43
         $process = new Process($command, null, null, null, 60, null);
44
-        $process->run(function ($type, $buffer) {
44
+        $process->run(function($type, $buffer) {
45 45
             $this->line($buffer);
46 46
         });
47 47
 
48 48
         // executes after the command finishes
49
-        if (! $process->isSuccessful()) {
49
+        if (!$process->isSuccessful()) {
50 50
             throw new ProcessFailedException($process);
51 51
         }
52 52
     }
Please login to merge, or discard this patch.
src/helpers.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-if (! function_exists('backpack_url')) {
3
+if (!function_exists('backpack_url')) {
4 4
     /**
5 5
      * Appends the configured backpack prefix and returns
6 6
      * the URL using the standard Laravel helpers.
@@ -10,13 +10,13 @@  discard block
 block discarded – undo
10 10
      */
11 11
     function backpack_url($path = null, $parameters = [], $secure = null)
12 12
     {
13
-        $path = ! $path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
13
+        $path = !$path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
14 14
 
15 15
         return url(config('backpack.base.route_prefix', 'admin').$path, $parameters, $secure);
16 16
     }
17 17
 }
18 18
 
19
-if (! function_exists('backpack_authentication_column')) {
19
+if (!function_exists('backpack_authentication_column')) {
20 20
     /**
21 21
      * Return the username column name.
22 22
      * The Laravel default (and Backpack default) is 'email'.
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
     }
30 30
 }
31 31
 
32
-if (! function_exists('backpack_email_column')) {
32
+if (!function_exists('backpack_email_column')) {
33 33
     /**
34 34
      * Return the email column name.
35 35
      * The Laravel default (and Backpack default) is 'email'.
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
     }
43 43
 }
44 44
 
45
-if (! function_exists('backpack_form_input')) {
45
+if (!function_exists('backpack_form_input')) {
46 46
     /**
47 47
      * Parse the submitted input in request('form') to an usable array.
48 48
      * Joins the multiple[] fields in a single key and transform the dot notation fields into arrayed ones.
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
     }
100 100
 }
101 101
 
102
-if (! function_exists('backpack_users_have_email')) {
102
+if (!function_exists('backpack_users_have_email')) {
103 103
     /**
104 104
      * Check if the email column is present on the user table.
105 105
      *
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
     }
115 115
 }
116 116
 
117
-if (! function_exists('backpack_avatar_url')) {
117
+if (!function_exists('backpack_avatar_url')) {
118 118
     /**
119 119
      * Returns the avatar URL of a user.
120 120
      *
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
     {
126 126
         switch (config('backpack.base.avatar_type')) {
127 127
             case 'gravatar':
128
-                if (backpack_users_have_email() && ! empty($user->email)) {
128
+                if (backpack_users_have_email() && !empty($user->email)) {
129 129
                     return Gravatar::fallback(config('backpack.base.gravatar_fallback'))->get($user->email);
130 130
                 }
131 131
                 break;
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
     }
137 137
 }
138 138
 
139
-if (! function_exists('backpack_middleware')) {
139
+if (!function_exists('backpack_middleware')) {
140 140
     /**
141 141
      * Return the key of the middleware used across Backpack.
142 142
      * That middleware checks if the visitor is an admin.
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
     }
151 151
 }
152 152
 
153
-if (! function_exists('backpack_guard_name')) {
153
+if (!function_exists('backpack_guard_name')) {
154 154
     /*
155 155
      * Returns the name of the guard defined
156 156
      * by the application config
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
     }
162 162
 }
163 163
 
164
-if (! function_exists('backpack_auth')) {
164
+if (!function_exists('backpack_auth')) {
165 165
     /*
166 166
      * Returns the user instance if it exists
167 167
      * of the currently authenticated admin
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
     }
174 174
 }
175 175
 
176
-if (! function_exists('backpack_user')) {
176
+if (!function_exists('backpack_user')) {
177 177
     /*
178 178
      * Returns back a user instance without
179 179
      * the admin guard, however allows you
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
     }
186 186
 }
187 187
 
188
-if (! function_exists('mb_ucfirst')) {
188
+if (!function_exists('mb_ucfirst')) {
189 189
     /**
190 190
      * Capitalize the first letter of a string,
191 191
      * even if that string is multi-byte (non-latin alphabet).
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
     }
207 207
 }
208 208
 
209
-if (! function_exists('backpack_view')) {
209
+if (!function_exists('backpack_view')) {
210 210
     /**
211 211
      * Returns a new displayable view based on the configured backpack view namespace.
212 212
      * If that view doesn't exist, it will load the one from the original theme.
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
 
226 226
         $returnView = $theme.$view;
227 227
 
228
-        if (! view()->exists($returnView)) {
228
+        if (!view()->exists($returnView)) {
229 229
             $returnView = $originalTheme.$view;
230 230
         }
231 231
 
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
     }
234 234
 }
235 235
 
236
-if (! function_exists('square_brackets_to_dots')) {
236
+if (!function_exists('square_brackets_to_dots')) {
237 237
     /**
238 238
      * Turns a string from bracket-type array to dot-notation array.
239 239
      * Ex: array[0][property] turns into array.0.property.
@@ -249,7 +249,7 @@  discard block
 block discarded – undo
249 249
     }
250 250
 }
251 251
 
252
-if (! function_exists('old_empty_or_null')) {
252
+if (!function_exists('old_empty_or_null')) {
253 253
     /**
254 254
      * This method is an alternative to Laravel's old() helper, which mistakenly
255 255
      * returns NULL it two cases:
@@ -281,7 +281,7 @@  discard block
 block discarded – undo
281 281
     }
282 282
 }
283 283
 
284
-if (! function_exists('is_multidimensional_array')) {
284
+if (!function_exists('is_multidimensional_array')) {
285 285
     /**
286 286
      * If any of the items inside a given array is an array, the array is considered multidimensional.
287 287
      *
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
300 300
     }
301 301
 }
302 302
 
303
-if (! function_exists('backpack_pro')) {
303
+if (!function_exists('backpack_pro')) {
304 304
     /**
305 305
      * Check if the backpack/pro package is installed.
306 306
      *
@@ -311,7 +311,7 @@  discard block
 block discarded – undo
311 311
         if (app()->runningUnitTests()) {
312 312
             return true;
313 313
         }
314
-        if (! \Composer\InstalledVersions::isInstalled('backpack/pro')) {
314
+        if (!\Composer\InstalledVersions::isInstalled('backpack/pro')) {
315 315
             return false;
316 316
         }
317 317
 
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelOperationsTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
 
17 17
     public function testItCanConfigureOperations()
18 18
     {
19
-        $this->crudPanel->operation(['create', 'update'], function () {
19
+        $this->crudPanel->operation(['create', 'update'], function() {
20 20
             $this->crudPanel->addField(['name' => 'test', 'type' => 'text']);
21 21
         });
22 22
         $this->crudPanel->applyConfigurationFromSettings('create');
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/SaveActions.php 1 patch
Spacing   +16 added lines, -17 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
         $higherAction = $this->getSaveActionByOrder(1);
29 29
 
30 30
         //if there is an higher action and that action is not the backpack default higher one `save_and_back` we return it.
31
-        if (! empty($higherAction) && key($higherAction) !== 'save_and_back') {
31
+        if (!empty($higherAction) && key($higherAction) !== 'save_and_back') {
32 32
             return key($higherAction);
33 33
         }
34 34
 
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
      */
48 48
     public function getSaveActionByOrder($order)
49 49
     {
50
-        return array_filter($this->getOperationSetting('save_actions') ?? [], function ($arr) use ($order) {
50
+        return array_filter($this->getOperationSetting('save_actions') ?? [], function($arr) use ($order) {
51 51
             return $arr['order'] == $order;
52 52
         });
53 53
     }
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
         $orderCounter = $this->getOperationSetting('save_actions') !== null ? (count($this->getOperationSetting('save_actions')) + 1) : 1;
82 82
         //check for some mandatory fields
83 83
         $saveAction['name'] ?? abort(500, 'Please define save action name.');
84
-        $saveAction['redirect'] = $saveAction['redirect'] ?? function ($crud, $request, $itemId) {
84
+        $saveAction['redirect'] = $saveAction['redirect'] ?? function($crud, $request, $itemId) {
85 85
             return $request->has('_http_referrer') ? $request->get('_http_referrer') : $crud->route;
86 86
         };
87 87
         $saveAction['visible'] = $saveAction['visible'] ?? true;
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 
91 91
         $actions = $this->getOperationSetting('save_actions') ?? [];
92 92
 
93
-        if (! in_array($saveAction['name'], $actions)) {
93
+        if (!in_array($saveAction['name'], $actions)) {
94 94
             $actions[$saveAction['name']] = $saveAction;
95 95
         }
96 96
 
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
     public function orderSaveAction(string $saveAction, int $wantedOrder)
108 108
     {
109 109
         $actions = $this->getOperationSetting('save_actions') ?? [];
110
-        if (! empty($actions)) {
110
+        if (!empty($actions)) {
111 111
             $replaceOrder = isset($actions[$saveAction]) ? $actions[$saveAction]['order'] : count($actions) + 1;
112 112
 
113 113
             foreach ($actions as $key => $sv) {
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
     public function orderSaveActions(array $saveActions)
202 202
     {
203 203
         foreach ($saveActions as $sv => $order) {
204
-            if (! is_int($order)) {
204
+            if (!is_int($order)) {
205 205
                 $this->orderSaveAction($order, $sv + 1);
206 206
             } else {
207 207
                 $this->orderSaveAction($sv, $order);
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
     {
219 219
         $actions = $this->getOperationSetting('save_actions') ?? [];
220 220
 
221
-        uasort($actions, function ($a, $b) {
221
+        uasort($actions, function($a, $b) {
222 222
             return $a['order'] <=> $b['order'];
223 223
         });
224 224
 
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
             }
241 241
         }
242 242
 
243
-        return array_filter($actions, function ($action) {
243
+        return array_filter($actions, function($action) {
244 244
             return $action['visible'] == true;
245 245
         }, ARRAY_FILTER_USE_BOTH);
246 246
     }
@@ -303,8 +303,7 @@  discard block
 block discarded – undo
303 303
      */
304 304
     public function setSaveAction($forceSaveAction = null)
305 305
     {
306
-        $saveAction = $forceSaveAction ?:
307
-            \Request::input('_save_action', $this->getFallBackSaveAction());
306
+        $saveAction = $forceSaveAction ?: \Request::input('_save_action', $this->getFallBackSaveAction());
308 307
 
309 308
         $showBubble = $this->getOperationSetting('showSaveActionChange') ?? config('backpack.crud.operations.'.$this->getCurrentOperation().'.showSaveActionChange') ?? true;
310 309
 
@@ -371,20 +370,20 @@  discard block
 block discarded – undo
371 370
         $defaultSaveActions = [
372 371
             [
373 372
                 'name' => 'save_and_back',
374
-                'visible' => function ($crud) {
373
+                'visible' => function($crud) {
375 374
                     return $crud->hasAccess('list');
376 375
                 },
377
-                'redirect' => function ($crud, $request, $itemId = null) {
376
+                'redirect' => function($crud, $request, $itemId = null) {
378 377
                     return $request->request->has('_http_referrer') ? $request->request->get('_http_referrer') : $crud->route;
379 378
                 },
380 379
                 'button_text' => trans('backpack::crud.save_action_save_and_back'),
381 380
             ],
382 381
             [
383 382
                 'name' => 'save_and_edit',
384
-                'visible' => function ($crud) {
383
+                'visible' => function($crud) {
385 384
                     return $crud->hasAccess('update');
386 385
                 },
387
-                'redirect' => function ($crud, $request, $itemId = null) {
386
+                'redirect' => function($crud, $request, $itemId = null) {
388 387
                     $itemId = $itemId ?: $request->request->get('id');
389 388
                     $redirectUrl = $crud->route.'/'.$itemId.'/edit';
390 389
                     if ($request->request->has('_locale')) {
@@ -396,17 +395,17 @@  discard block
 block discarded – undo
396 395
 
397 396
                     return $redirectUrl;
398 397
                 },
399
-                'referrer_url' => function ($crud, $request, $itemId) {
398
+                'referrer_url' => function($crud, $request, $itemId) {
400 399
                     return url($crud->route.'/'.$itemId.'/edit');
401 400
                 },
402 401
                 'button_text' => trans('backpack::crud.save_action_save_and_edit'),
403 402
             ],
404 403
             [
405 404
                 'name' => 'save_and_new',
406
-                'visible' => function ($crud) {
405
+                'visible' => function($crud) {
407 406
                     return $crud->hasAccess('create');
408 407
                 },
409
-                'redirect' => function ($crud, $request, $itemId = null) {
408
+                'redirect' => function($crud, $request, $itemId = null) {
410 409
                     return $this->route.'/create';
411 410
                 },
412 411
                 'button_text' => trans('backpack::crud.save_action_save_and_new'),
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelFieldsTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -609,7 +609,7 @@  discard block
 block discarded – undo
609 609
     {
610 610
         $this->crudPanel->setOperationSetting(
611 611
             'strippedRequest',
612
-            static function (Request $request) {
612
+            static function(Request $request) {
613 613
                 return $request->toArray();
614 614
             },
615 615
             'update'
@@ -743,7 +743,7 @@  discard block
 block discarded – undo
743 743
                         ->validationMessages(['required' => 'is_required', 'min' => 'min_2'])
744 744
                         ->store_in('some')
745 745
                         ->size(6)
746
-                        ->on('created', function () {
746
+                        ->on('created', function() {
747 747
                         })
748 748
                         ->subfields([['name' => 'sub_1']])
749 749
                         ->entity('bang');
@@ -775,7 +775,7 @@  discard block
 block discarded – undo
775 775
                 'class' => 'form-group col-md-6',
776 776
             ],
777 777
             'events' => [
778
-                'created' => function () {
778
+                'created' => function() {
779 779
                 },
780 780
             ],
781 781
             'subfields' => [
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelValidationTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
             'password' => 'test',
37 37
         ]);
38 38
 
39
-        $request->setRouteResolver(function () use ($request) {
39
+        $request->setRouteResolver(function() use ($request) {
40 40
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Unit\Http\Controllers\UserCrudController', 'create']))->bind($request);
41 41
         });
42 42
 
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
             'password' => 'test',
76 76
         ]);
77 77
 
78
-        $request->setRouteResolver(function () use ($request) {
78
+        $request->setRouteResolver(function() use ($request) {
79 79
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Unit\Http\Controllers\UserCrudController', 'create']))->bind($request);
80 80
         });
81 81
 
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
             'password' => 'test',
111 111
         ]);
112 112
 
113
-        $request->setRouteResolver(function () use ($request) {
113
+        $request->setRouteResolver(function() use ($request) {
114 114
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Unit\Http\Controllers\UserCrudController', 'create']))->bind($request);
115 115
         });
116 116
 
Please login to merge, or discard this patch.