Backpack\CRUD\app\Library\Validation\Rules\ValidUploadMultiple

Complexity

Total Complexity

8

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Importance

Changes	5
Bugs	3	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	validate()	0	44	8

<?php

namespace Backpack\CRUD\app\Library\Validation\Rules;

use Backpack\CRUD\app\Library\CrudPanel\CrudPanelFacade;
use Closure;

class ValidUploadMultiple extends ValidFileArray
{
    /**
     * Run the validation rule.
     *
     * @param  string  $attribute
     * @param  mixed  $value
     * @param  \Closure(string): \Illuminate\Translation\PotentiallyTranslatedString  $fail
     * @return void
     */
    public function validate(string $attribute, mixed $value, Closure $fail): void
    {
        if (! $value = self::ensureValidValue($value)) {
            $fail('Unable to determine the value type.');

            return;
        }

        $entry = CrudPanelFacade::getCurrentEntry() !== false ? CrudPanelFacade::getCurrentEntry() : null;

The method getCurrentEntry() does not exist on Backpack\CRUD\app\Library\CrudPanel\CrudPanelFacade. Since you implemented __callStatic, consider adding a @method annotation.

        // `upload_multiple` sends [[0 => null]] when user doesn't upload anything
        // assume that nothing changed on field so nothing is sent on the request.
        if (count($value) === 1 && empty($value[0])) {
            if ($entry) {
                unset($this->data[$attribute]);
            } else {
                $this->data[$attribute] = [];
            }
            $value = [];
        }

        $previousValues = $entry?->{$attribute} ?? [];
        if (is_string($previousValues)) {
            $previousValues = json_decode($previousValues, true) ?? [];
        }

        $value = array_merge($previousValues, $value);

It seems like $value can also be of type false; however, parameter $arrays of array_merge() does only seem to accept array, maybe add an additional type check?

        if ($entry) {
            $filesDeleted = CrudPanelFacade::getRequest()->input('clear_'.$attribute) ?? [];

The method getRequest() does not exist on Backpack\CRUD\app\Library\CrudPanel\CrudPanelFacade. Since you implemented __callStatic, consider adding a @method annotation.

            $data = $this->data;
            $data[$attribute] = array_diff($value, $filesDeleted);

            $this->validateArrayData($attribute, $fail, $data);

            $this->validateItems($attribute, $value, $fail);

            return;
        }

        $this->validateArrayData($attribute, $fail);

        $this->validateItems($attribute, $value, $fail);
    }
}