Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Setup Failed
Pull Request — master (#2406)
by ziming
05:45
created
src/app/Library/CrudPanel/Traits/FakeColumns.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -24,19 +24,19 @@
 block discarded – undo
24 24
             if (isset($field['fake']) && $field['fake'] == true) {
25 25
                 // add it to the request in its appropriate variable - the one defined, if defined
26 26
                 if (isset($field['store_in'])) {
27
-                    if (! in_array($field['store_in'], $fakeFieldsColumnsArray, true)) {
27
+                    if (!in_array($field['store_in'], $fakeFieldsColumnsArray, true)) {
28 28
                         array_push($fakeFieldsColumnsArray, $field['store_in']);
29 29
                     }
30 30
                 } else {
31 31
                     //otherwise in the one defined in the $crud variable
32
-                    if (! in_array('extras', $fakeFieldsColumnsArray, true)) {
32
+                    if (!in_array('extras', $fakeFieldsColumnsArray, true)) {
33 33
                         array_push($fakeFieldsColumnsArray, 'extras');
34 34
                     }
35 35
                 }
36 36
             }
37 37
         }
38 38
 
39
-        if (! count($fakeFieldsColumnsArray)) {
39
+        if (!count($fakeFieldsColumnsArray)) {
40 40
             $fakeFieldsColumnsArray = ['extras'];
41 41
         }
42 42
 
Please login to merge, or discard this patch.
src/app/Http/Requests/ChangePasswordRequest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -41,9 +41,9 @@
 block discarded – undo
41 41
      */
42 42
     public function withValidator($validator)
43 43
     {
44
-        $validator->after(function ($validator) {
44
+        $validator->after(function($validator) {
45 45
             // check old password matches
46
-            if (! Hash::check($this->input('old_password'), backpack_auth()->user()->password)) {
46
+            if (!Hash::check($this->input('old_password'), backpack_auth()->user()->password)) {
47 47
                 $validator->errors()->add('old_password', trans('backpack::base.old_password_incorrect'));
48 48
             }
49 49
         });
Please login to merge, or discard this patch.
src/config/backpack/base.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
     ],
44 44
 
45 45
     // CSS files that are loaded in all pages, using Laravel's mix() helper
46
-    'mix_styles' => [ // file_path => manifest_directory_path
46
+    'mix_styles' => [// file_path => manifest_directory_path
47 47
         // 'css/app.css' => '',
48 48
     ],
49 49
 
Please login to merge, or discard this patch.
src/Stats.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
     private function sendUsageStats()
39 39
     {
40 40
         // only send usage stats in production
41
-        if (! $this->runningInProduction()) {
41
+        if (!$this->runningInProduction()) {
42 42
             return;
43 43
         }
44 44
 
Please login to merge, or discard this patch.
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@  discard block
 block discarded – undo
8 8
      * Check if the application is running in normal conditions
9 9
      * (production env, not in console, not in unit tests).
10 10
      *
11
-     * @return void
11
+     * @return boolean
12 12
      */
13 13
     private function runningInProduction()
14 14
     {
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
      * @param string $url     URL to point the request at.
86 86
      * @param array  $payload The data you want sent to the URL.
87 87
      *
88
-     * @return void
88
+     * @return boolean
89 89
      */
90 90
     private function makeCurlRequest($method, $url, $payload)
91 91
     {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Read.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -175,6 +175,7 @@
 block discarded – undo
175 175
 
176 176
     /**
177 177
      * Set the number of rows that should be show on the list view.
178
+     * @param integer $value
178 179
      */
179 180
     public function setDefaultPageLength($value)
180 181
     {
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
     {
39 39
         $id = $this->getCurrentEntryId();
40 40
 
41
-        if (! $id) {
41
+        if (!$id) {
42 42
             return false;
43 43
         }
44 44
 
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
      */
55 55
     public function getEntry($id)
56 56
     {
57
-        if (! $this->entry) {
57
+        if (!$this->entry) {
58 58
             $this->entry = $this->model->findOrFail($id);
59 59
             $this->entry = $this->entry->withFakes();
60 60
         }
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
     {
204 204
         // If the default Page Length isn't in the menu's values, Add it the beginnin and resort all to show a croissant list.
205 205
         // assume both arrays are the same length.
206
-        if (! in_array($this->getDefaultPageLength(), $this->getOperationSetting('pageLengthMenu')[0])) {
206
+        if (!in_array($this->getDefaultPageLength(), $this->getOperationSetting('pageLengthMenu')[0])) {
207 207
             // Loop through 2 arrays of prop. pageLengthMenu
208 208
             foreach ($this->getOperationSetting('pageLengthMenu') as $key => &$page_length_choices) {
209 209
                 // This is a condition that should be always true.
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Views.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -301,6 +301,9 @@  discard block
 block discarded – undo
301 301
         return $this->getShowView();
302 302
     }
303 303
 
304
+    /**
305
+     * @param string $view
306
+     */
304 307
     public function setPreviewView($view)
305 308
     {
306 309
         return $this->setShowView($view);
@@ -311,6 +314,9 @@  discard block
 block discarded – undo
311 314
         return $this->getEditView();
312 315
     }
313 316
 
317
+    /**
318
+     * @param string $view
319
+     */
314 320
     public function setUpdateView($view)
315 321
     {
316 322
         return $this->setEditView($view);
Please login to merge, or discard this patch.
src/BackpackServiceProvider.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -54,13 +54,13 @@  discard block
 block discarded – undo
54 54
     public function register()
55 55
     {
56 56
         // Bind the CrudPanel object to Laravel's service container
57
-        $this->app->singleton('crud', function ($app) {
57
+        $this->app->singleton('crud', function($app) {
58 58
             return new \Backpack\CRUD\app\Library\CrudPanel\CrudPanel($app);
59 59
         });
60 60
 
61 61
         // load a macro for Route,
62 62
         // helps developers load all routes for a CRUD resource in one line
63
-        if (! Route::hasMacro('crud')) {
63
+        if (!Route::hasMacro('crud')) {
64 64
             $this->addRouteMacro();
65 65
         }
66 66
 
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
         // }
82 82
 
83 83
         // map the elfinder prefix
84
-        if (! \Config::get('elfinder.route.prefix')) {
84
+        if (!\Config::get('elfinder.route.prefix')) {
85 85
             \Config::set('elfinder.route.prefix', \Config::get('backpack.base.route_prefix').'/elfinder');
86 86
         }
87 87
     }
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
         $middleware_key = config('backpack.base.middleware_key');
92 92
         $middleware_class = config('backpack.base.middleware_class');
93 93
 
94
-        if (! is_array($middleware_class)) {
94
+        if (!is_array($middleware_class)) {
95 95
             $router->pushMiddlewareToGroup($middleware_key, $middleware_class);
96 96
 
97 97
             return;
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
      */
196 196
     private function addRouteMacro()
197 197
     {
198
-        Route::macro('crud', function ($name, $controller) {
198
+        Route::macro('crud', function($name, $controller) {
199 199
             // put together the route name prefix,
200 200
             // as passed to the Route::group() statements
201 201
             $routeName = '';
Please login to merge, or discard this patch.
src/LicenseCheck.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
             return;
18 18
         }
19 19
 
20
-        if (! $this->validCode(config('backpack.base.license_code'))) {
20
+        if (!$this->validCode(config('backpack.base.license_code'))) {
21 21
             \Alert::add('warning', "<strong>You're using unlicensed software.</strong> Please ask your web developer to <a target='_blank' class='alert-link text-white' href='http://backpackforlaravel.com'>purchase a license code</a> to hide this message.");
22 22
         }
23 23
     }
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ReorderOperation.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
     /**
10 10
      * Define which routes are needed for this operation.
11 11
      *
12
-     * @param string $name       Name of the current entity (singular). Used as first URL segment.
13 12
      * @param string $routeName  Prefix of the route name.
14 13
      * @param string $controller Name of the current CrudController.
15 14
      */
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -36,11 +36,11 @@  discard block
 block discarded – undo
36 36
         $this->crud->set('reorder.enabled', true);
37 37
         $this->crud->allowAccess('reorder');
38 38
 
39
-        $this->crud->operation('reorder', function () {
39
+        $this->crud->operation('reorder', function() {
40 40
             $this->crud->loadDefaultOperationSettingsFromConfig();
41 41
         });
42 42
 
43
-        $this->crud->operation('list', function () {
43
+        $this->crud->operation('list', function() {
44 44
             $this->crud->addButton('top', 'reorder', 'view', 'crud::buttons.reorder');
45 45
         });
46 46
     }
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
     {
57 57
         $this->crud->hasAccessOrFail('reorder');
58 58
 
59
-        if (! $this->crud->isReorderEnabled()) {
59
+        if (!$this->crud->isReorderEnabled()) {
60 60
             abort(403, 'Reorder is disabled.');
61 61
         }
62 62
 
Please login to merge, or discard this patch.