Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#1935)
by Cristian
06:00 queued 03:19
created
src/PanelTraits/Access.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
             $this->set($op.'.access', false);
34 34
         }
35 35
 
36
-        return ! $this->hasAccessToAny($operation);
36
+        return !$this->hasAccessToAny($operation);
37 37
     }
38 38
 
39 39
     /**
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
     public function hasAccessToAll($operation_array)
74 74
     {
75 75
         foreach ((array) $operation_array as $key => $operation) {
76
-            if (! $this->get($operation.'.access')) {
76
+            if (!$this->get($operation.'.access')) {
77 77
                 return false;
78 78
             }
79 79
         }
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
      */
91 91
     public function hasAccessOrFail($operation)
92 92
     {
93
-        if (! $this->get($operation.'.access')) {
93
+        if (!$this->get($operation.'.access')) {
94 94
             throw new AccessDeniedException(trans('backpack::crud.unauthorized_access', ['access' => $operation]));
95 95
         }
96 96
 
Please login to merge, or discard this patch.
src/PanelTraits/Tabs.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
      */
33 33
     public function tabsDisabled()
34 34
     {
35
-        return ! $this->tabsEnabled();
35
+        return !$this->tabsEnabled();
36 36
     }
37 37
 
38 38
     public function setTabsType($type)
@@ -114,8 +114,8 @@  discard block
 block discarded – undo
114 114
     {
115 115
         $all_fields = $this->getCurrentFields();
116 116
 
117
-        $fields_without_a_tab = collect($all_fields)->filter(function ($value, $key) {
118
-            return ! isset($value['tab']);
117
+        $fields_without_a_tab = collect($all_fields)->filter(function($value, $key) {
118
+            return !isset($value['tab']);
119 119
         });
120 120
 
121 121
         return $fields_without_a_tab;
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
         if ($this->tabExists($label)) {
132 132
             $all_fields = $this->getCurrentFields();
133 133
 
134
-            $fields_for_current_tab = collect($all_fields)->filter(function ($value, $key) use ($label) {
134
+            $fields_for_current_tab = collect($all_fields)->filter(function($value, $key) use ($label) {
135 135
                 return isset($value['tab']) && $value['tab'] == $label;
136 136
             });
137 137
 
@@ -150,11 +150,11 @@  discard block
 block discarded – undo
150 150
         $fields = $this->getCurrentFields();
151 151
 
152 152
         $fields_with_tabs = collect($fields)
153
-            ->filter(function ($value, $key) {
153
+            ->filter(function($value, $key) {
154 154
                 return isset($value['tab']);
155 155
             })
156
-            ->each(function ($value, $key) use (&$tabs) {
157
-                if (! in_array($value['tab'], $tabs)) {
156
+            ->each(function($value, $key) use (&$tabs) {
157
+                if (!in_array($value['tab'], $tabs)) {
158 158
                     $tabs[] = $value['tab'];
159 159
                 }
160 160
             });
Please login to merge, or discard this patch.
src/PanelTraits/Read.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
     {
39 39
         $id = $this->getCurrentEntryId();
40 40
 
41
-        if (! $id) {
41
+        if (!$id) {
42 42
             return false;
43 43
         }
44 44
 
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
      */
55 55
     public function getEntry($id)
56 56
     {
57
-        if (! $this->entry) {
57
+        if (!$this->entry) {
58 58
             $this->entry = $this->model->findOrFail($id);
59 59
             $this->entry = $this->entry->withFakes();
60 60
         }
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
     {
200 200
         // If the default Page Length isn't in the menu's values, Add it the beginnin and resort all to show a croissant list.
201 201
         // assume both arrays are the same length.
202
-        if (! in_array($this->getDefaultPageLength(), $this->getOperationSetting('pageLengthMenu')[0])) {
202
+        if (!in_array($this->getDefaultPageLength(), $this->getOperationSetting('pageLengthMenu')[0])) {
203 203
             // Loop through 2 arrays of prop. page_length_menu
204 204
             foreach ($this->getOperationSetting('pageLengthMenu') as $key => &$page_length_choices) {
205 205
                 // This is a condition that should be always true.
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
     public function getPageLengthMenu()
231 231
     {
232 232
         // if already set, use that
233
-        if (! $this->getOperationSetting('pageLengthMenu')) {
233
+        if (!$this->getOperationSetting('pageLengthMenu')) {
234 234
             // try to get the menu settings from the config file
235 235
             $this->setOperationSetting('pageLengthMenu', config('backpack.crud.page_length_menu') ?? [[10, 25, 50, 100, -1], [10, 25, 50, 100, 'backpack::crud.all']]);
236 236
 
Please login to merge, or discard this patch.
src/PanelTraits/Buttons.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
          */
93 93
         $button = $this->buttons()->firstWhere('name', $name);
94 94
 
95
-        if (! $button) {
95
+        if (!$button) {
96 96
             abort(500, 'CRUD Button "'.$name.'" not found. Please check the button exists before you modify it.');
97 97
         }
98 98
 
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
      */
114 114
     public function removeButton($name, $stack = null)
115 115
     {
116
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
116
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
117 117
             return $stack == null ? $button->name == $name : ($button->stack == $stack) && ($button->name == $name);
118 118
         }));
119 119
     }
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
      */
125 125
     public function removeButtons($names, $stack = null)
126 126
     {
127
-        if (! empty($names)) {
127
+        if (!empty($names)) {
128 128
             foreach ($names as $name) {
129 129
                 $this->removeButton($name, $stack);
130 130
             }
@@ -138,14 +138,14 @@  discard block
 block discarded – undo
138 138
 
139 139
     public function removeAllButtonsFromStack($stack)
140 140
     {
141
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($stack) {
141
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($stack) {
142 142
             return $button->stack == $stack;
143 143
         }));
144 144
     }
145 145
 
146 146
     public function removeButtonFromStack($name, $stack)
147 147
     {
148
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
148
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
149 149
             return $button->name == $name && $button->stack == $stack;
150 150
         }));
151 151
     }
Please login to merge, or discard this patch.
src/PanelTraits/AutoSet.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -12,12 +12,12 @@  discard block
 block discarded – undo
12 12
      */
13 13
     public function setFromDb()
14 14
     {
15
-        if (! $this->driverIsMongoDb()) {
15
+        if (!$this->driverIsMongoDb()) {
16 16
             $this->setDoctrineTypesMapping();
17 17
             $this->getDbColumnTypes();
18 18
         }
19 19
 
20
-        array_map(function ($field) {
20
+        array_map(function($field) {
21 21
             $new_field = [
22 22
                 'name'       => $field,
23 23
                 'label'      => $this->makeLabel($field),
@@ -29,11 +29,11 @@  discard block
 block discarded – undo
29 29
                 'autoset'    => true,
30 30
             ];
31 31
 
32
-            if (! isset($this->fields()[$field])) {
32
+            if (!isset($this->fields()[$field])) {
33 33
                 $this->addField($new_field);
34 34
             }
35 35
 
36
-            if (! in_array($field, $this->model->getHidden()) && ! isset($this->columns[$field])) {
36
+            if (!in_array($field, $this->model->getHidden()) && !isset($this->columns[$field])) {
37 37
                 $this->addColumn([
38 38
                     'name'  => $field,
39 39
                     'label' => $this->makeLabel($field),
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
         $types = ['enum' => 'string'];
164 164
         $platform = $this->getSchema()->getConnection()->getDoctrineConnection()->getDatabasePlatform();
165 165
         foreach ($types as $type_key => $type_value) {
166
-            if (! $platform->hasDoctrineTypeMappingFor($type_key)) {
166
+            if (!$platform->hasDoctrineTypeMappingFor($type_key)) {
167 167
                 $platform->registerDoctrineTypeMapping($type_key, $type_value);
168 168
             }
169 169
         }
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
             // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model
223 223
             $columns = $this->model->getConnection()->getSchemaBuilder()->getColumnListing($this->model->getTable());
224 224
 
225
-            if (! empty($fillable)) {
225
+            if (!empty($fillable)) {
226 226
                 $columns = array_intersect($columns, $fillable);
227 227
             }
228 228
         }
Please login to merge, or discard this patch.
src/PanelTraits/Create.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
     {
82 82
         $all_relation_fields = $this->getRelationFields();
83 83
 
84
-        return array_where($all_relation_fields, function ($value, $key) {
84
+        return array_where($all_relation_fields, function($value, $key) {
85 85
             return isset($value['pivot']) && $value['pivot'];
86 86
         });
87 87
     }
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
      */
157 157
     private function createRelationsForItem($item, $formattedData)
158 158
     {
159
-        if (! isset($formattedData['relations'])) {
159
+        if (!isset($formattedData['relations'])) {
160 160
             return false;
161 161
         }
162 162
 
@@ -213,11 +213,11 @@  discard block
 block discarded – undo
213 213
                 $key = implode('.relations.', explode('.', $relationField['entity']));
214 214
                 $fieldData = array_get($relationData, 'relations.'.$key, []);
215 215
 
216
-                if (! array_key_exists('model', $fieldData)) {
216
+                if (!array_key_exists('model', $fieldData)) {
217 217
                     $fieldData['model'] = $relationField['model'];
218 218
                 }
219 219
 
220
-                if (! array_key_exists('parent', $fieldData)) {
220
+                if (!array_key_exists('parent', $fieldData)) {
221 221
                     $fieldData['parent'] = $this->getRelationModel($relationField['entity'], -1);
222 222
                 }
223 223
 
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelButtonsTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -247,7 +247,7 @@
 block discarded – undo
247 247
 
248 248
     private function getButtonByName($name)
249 249
     {
250
-        return $this->crudPanel->buttons()->first(function ($value) use ($name) {
250
+        return $this->crudPanel->buttons()->first(function($value) use ($name) {
251 251
             return $value->name == $name;
252 252
         });
253 253
     }
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ListOperation.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -110,14 +110,14 @@
 block discarded – undo
110 110
         // if there was an order set, this will be the last one (after all others were applied)
111 111
         $orderBy = $this->crud->query->getQuery()->orders;
112 112
         $hasOrderByPrimaryKey = false;
113
-        collect($orderBy)->each(function ($item, $key) use ($hasOrderByPrimaryKey) {
113
+        collect($orderBy)->each(function($item, $key) use ($hasOrderByPrimaryKey) {
114 114
             if ($item['column'] == $this->crud->model->getKeyName()) {
115 115
                 $hasOrderByPrimaryKey = true;
116 116
 
117 117
                 return false;
118 118
             }
119 119
         });
120
-        if (! $hasOrderByPrimaryKey) {
120
+        if (!$hasOrderByPrimaryKey) {
121 121
             $this->crud->query->orderByDesc($this->crud->model->getKeyName());
122 122
         }
123 123
 
Please login to merge, or discard this patch.
src/PanelTraits/Settings.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
      */
50 50
     public function settings()
51 51
     {
52
-        return \Arr::sort($this->settings, function ($value, $key) {
52
+        return \Arr::sort($this->settings, function($value, $key) {
53 53
             return $key;
54 54
         });
55 55
     }
Please login to merge, or discard this patch.