Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#1935)
by Cristian
06:00 queued 03:19
created
src/app/Http/Controllers/Operations/BulkCloneOperation.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,6 @@
 block discarded – undo
24 24
     /**
25 25
      * Create duplicates of multiple entries in the datatabase.
26 26
      *
27
-     * @param int $id
28 27
      *
29 28
      * @return Response
30 29
      */
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
     {
30 30
         $this->crud->allowAccess('bulkClone');
31 31
 
32
-        $this->crud->operation('list', function () {
32
+        $this->crud->operation('list', function() {
33 33
             $this->crud->enableBulkActions();
34 34
             $this->crud->addButton('bottom', 'bulk_clone', 'view', 'crud::buttons.bulk_clone', 'beginning');
35 35
         });
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/CloneOperation.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
      *
27 27
      * @param int $id
28 28
      *
29
-     * @return Response
29
+     * @return string
30 30
      */
31 31
     public function clone($id)
32 32
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
     {
30 30
         $this->crud->allowAccess('clone');
31 31
 
32
-        $this->crud->operation(['list', 'show'], function () {
32
+        $this->crud->operation(['list', 'show'], function() {
33 33
             $this->crud->addButton('line', 'clone', 'view', 'crud::buttons.clone', 'end');
34 34
         });
35 35
     }
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ReorderOperation.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
     /**
10 10
      * Define which routes are needed for this operation.
11 11
      *
12
-     * @param  string $name       Name of the current entity (singular). Used as first URL segment.
13 12
      * @param  string $routeName    Prefix of the route name.
14 13
      * @param  string $controller Name of the current CrudController.
15 14
      */
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
         $this->crud->set('reorder.enabled', true);
37 37
         $this->crud->allowAccess('reorder');
38 38
 
39
-        $this->crud->operation('list', function () {
39
+        $this->crud->operation('list', function() {
40 40
             $this->crud->addButton('top', 'reorder', 'view', 'crud::buttons.reorder');
41 41
         });
42 42
     }
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
         $this->crud->applyConfigurationFromSettings('reorder');
54 54
         $this->crud->hasAccessOrFail('reorder');
55 55
 
56
-        if (! $this->crud->isReorderEnabled()) {
56
+        if (!$this->crud->isReorderEnabled()) {
57 57
             abort(403, 'Reorder is disabled.');
58 58
         }
59 59
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/UpdateOperation.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
     /**
10 10
      * Define which routes are needed for this operation.
11 11
      *
12
-     * @param  string $name       Name of the current entity (singular). Used as first URL segment.
13 12
      * @param  string $routeName    Prefix of the route name.
14 13
      * @param  string $controller Name of the current CrudController.
15 14
      */
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -42,13 +42,13 @@
 block discarded – undo
42 42
     {
43 43
         $this->crud->allowAccess('update');
44 44
 
45
-        $this->crud->operation('update', function () {
45
+        $this->crud->operation('update', function() {
46 46
             $this->crud->set('update.groupedErrors', config('backpack.crud.show_grouped_errors', true));
47 47
             $this->crud->set('update.inlineErrors', config('backpack.crud.show_inline_errors', true));
48 48
             $this->crud->set('update.autoFocusOnFirstField', true);
49 49
         });
50 50
 
51
-        $this->crud->operation(['list', 'show'], function () {
51
+        $this->crud->operation(['list', 'show'], function() {
52 52
             $this->crud->addButton('line', 'update', 'view', 'crud::buttons.update', 'end');
53 53
         });
54 54
     }
Please login to merge, or discard this patch.
src/resources/views/fields/datetime.blade.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@
 block discarded – undo
3 3
 <?php
4 4
 // if the column has been cast to Carbon or Date (using attribute casting)
5 5
 // get the value as a date string
6
-if (isset($field['value']) && ( $field['value'] instanceof \Carbon\CarbonInterface )) {
6
+if (isset($field['value']) && ($field['value'] instanceof \Carbon\CarbonInterface)) {
7 7
     $field['value'] = $field['value']->toDateTimeString();
8 8
 }
9 9
 ?>
Please login to merge, or discard this patch.
src/resources/views/fields/date_picker.blade.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3,11 +3,11 @@
 block discarded – undo
3 3
 <?php
4 4
     // if the column has been cast to Carbon or Date (using attribute casting)
5 5
     // get the value as a date string
6
-    if (isset($field['value']) && ( $field['value'] instanceof \Carbon\CarbonInterface )) {
6
+    if (isset($field['value']) && ($field['value'] instanceof \Carbon\CarbonInterface)) {
7 7
         $field['value'] = $field['value']->format('Y-m-d');
8 8
     }
9 9
 
10
-    $field_language = isset($field['date_picker_options']['language'])?$field['date_picker_options']['language']:\App::getLocale();
10
+    $field_language = isset($field['date_picker_options']['language']) ? $field['date_picker_options']['language'] : \App::getLocale();
11 11
 
12 12
     if (!isset($field['attributes']['style'])) {
13 13
         $field['attributes']['style'] = 'background-color: white!important;';
Please login to merge, or discard this patch.
src/resources/views/fields/date.blade.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@
 block discarded – undo
3 3
 <?php
4 4
 // if the column has been cast to Carbon or Date (using attribute casting)
5 5
 // get the value as a date string
6
-if (isset($field['value']) && ( $field['value'] instanceof \Carbon\CarbonInterface )) {
6
+if (isset($field['value']) && ($field['value'] instanceof \Carbon\CarbonInterface)) {
7 7
     $field['value'] = $field['value']->toDateString();
8 8
 }
9 9
 ?>
Please login to merge, or discard this patch.
src/resources/views/fields/datetime_picker.blade.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3,11 +3,11 @@
 block discarded – undo
3 3
 <?php
4 4
 // if the column has been cast to Carbon or Date (using attribute casting)
5 5
 // get the value as a date string
6
-if (isset($field['value']) && ( $field['value'] instanceof \Carbon\CarbonInterface )) {
6
+if (isset($field['value']) && ($field['value'] instanceof \Carbon\CarbonInterface)) {
7 7
     $field['value'] = $field['value']->format('Y-m-d H:i:s');
8 8
 }
9 9
 
10
-    $field_language = isset($field['datetime_picker_options']['language'])?$field['datetime_picker_options']['language']:\App::getLocale();
10
+    $field_language = isset($field['datetime_picker_options']['language']) ? $field['datetime_picker_options']['language'] : \App::getLocale();
11 11
 ?>
12 12
 
13 13
 <div @include('crud::inc.field_wrapper_attributes') >
Please login to merge, or discard this patch.
src/CrudServiceProvider.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -86,13 +86,13 @@  discard block
 block discarded – undo
86 86
     public function register()
87 87
     {
88 88
         // Bind the CrudPanel object to Laravel's service container
89
-        $this->app->singleton('crud', function ($app) {
89
+        $this->app->singleton('crud', function($app) {
90 90
             return new CrudPanel($app);
91 91
         });
92 92
 
93 93
         // load a macro for Route,
94 94
         // for developers to be able to load all routes for a CRUD resource in one line
95
-        if (! Route::hasMacro('crud')) {
95
+        if (!Route::hasMacro('crud')) {
96 96
             $this->addRouteMacro();
97 97
         }
98 98
 
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
         $this->commands($this->commands);
104 104
 
105 105
         // map the elfinder prefix
106
-        if (! \Config::get('elfinder.route.prefix')) {
106
+        if (!\Config::get('elfinder.route.prefix')) {
107 107
             \Config::set('elfinder.route.prefix', \Config::get('backpack.base.route_prefix').'/elfinder');
108 108
         }
109 109
     }
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
      */
117 117
     private function addRouteMacro()
118 118
     {
119
-        Route::macro('crud', function ($name, $controller) {
119
+        Route::macro('crud', function($name, $controller) {
120 120
             // put together the route name prefix,
121 121
             // as passed to the Route::group() statements
122 122
             $routeName = '';
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
     {
163 163
         $crudPubPath = public_path('vendor/backpack/crud');
164 164
 
165
-        if (! is_dir($crudPubPath)) {
165
+        if (!is_dir($crudPubPath)) {
166 166
             return true;
167 167
         }
168 168
 
Please login to merge, or discard this patch.