Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#1935)
by Cristian
06:00 queued 03:19
created
src/app/Http/Controllers/Operations/BulkDeleteOperation.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
     {
30 30
         $this->crud->allowAccess('bulkDelete');
31 31
 
32
-        $this->crud->operation('list', function () {
32
+        $this->crud->operation('list', function() {
33 33
             $this->crud->enableBulkActions();
34 34
             $this->crud->addButton('bottom', 'bulk_delete', 'view', 'crud::buttons.bulk_delete');
35 35
         });
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/CreateOperation.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -42,13 +42,13 @@
 block discarded – undo
42 42
     {
43 43
         $this->crud->allowAccess('create');
44 44
 
45
-        $this->crud->operation('create', function () {
45
+        $this->crud->operation('create', function() {
46 46
             $this->crud->set('create.groupedErrors', config('backpack.crud.show_grouped_errors', true));
47 47
             $this->crud->set('create.inlineErrors', config('backpack.crud.show_inline_errors', true));
48 48
             $this->crud->set('create.autoFocusOnFirstField', true);
49 49
         });
50 50
 
51
-        $this->crud->operation('list', function () {
51
+        $this->crud->operation('list', function() {
52 52
             $this->crud->addButton('top', 'create', 'view', 'crud::buttons.create');
53 53
         });
54 54
     }
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ShowOperation.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
     {
30 30
         $this->crud->allowAccess('show');
31 31
 
32
-        $this->crud->operation('list', function () {
32
+        $this->crud->operation('list', function() {
33 33
             $this->crud->addButton('line', 'show', 'view', 'crud::buttons.show', 'beginning');
34 34
         });
35 35
     }
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/CloneOperation.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
     {
30 30
         $this->crud->allowAccess('clone');
31 31
 
32
-        $this->crud->operation(['list', 'show'], function () {
32
+        $this->crud->operation(['list', 'show'], function() {
33 33
             $this->crud->addButton('line', 'clone', 'view', 'crud::buttons.clone', 'end');
34 34
         });
35 35
     }
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/DeleteOperation.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
     {
30 30
         $this->crud->allowAccess('delete');
31 31
 
32
-        $this->crud->operation(['list', 'show'], function () {
32
+        $this->crud->operation(['list', 'show'], function() {
33 33
             $this->crud->addButton('line', 'delete', 'view', 'crud::buttons.delete', 'end');
34 34
         });
35 35
     }
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
 
28 28
         // call the setup function inside this closure to also have the request there
29 29
         // this way, developers can use things stored in session (auth variables, etc)
30
-        $this->middleware(function ($request, $next) {
30
+        $this->middleware(function($request, $next) {
31 31
             // make a new CrudPanel object, from the one stored in Laravel's service container
32 32
             $this->crud = app()->make('crud');
33 33
             $this->request = $request;
Please login to merge, or discard this patch.
src/PanelTraits/Filters.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
         $this->enableFilters();
60 60
 
61 61
         // check if another filter with the same name exists
62
-        if (! isset($options['name'])) {
62
+        if (!isset($options['name'])) {
63 63
             abort(500, 'All your filters need names.');
64 64
         }
65 65
         if ($this->filters()->contains('name', $options['name'])) {
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
     {
202 202
         $filter = $this->filters()->firstWhere('name', $name);
203 203
 
204
-        if (! $filter) {
204
+        if (!$filter) {
205 205
             abort(500, 'CRUD Filter "'.$name.'" not found. Please check the filter exists before you modify it.');
206 206
         }
207 207
 
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
 
217 217
     public function removeFilter($name)
218 218
     {
219
-        $strippedFiltersCollection = $this->filters()->reject(function ($filter) use ($name) {
219
+        $strippedFiltersCollection = $this->filters()->reject(function($filter) use ($name) {
220 220
             return $filter->name == $name;
221 221
         });
222 222
 
@@ -278,16 +278,16 @@  discard block
 block discarded – undo
278 278
 
279 279
     public function checkOptionsIntegrity($options)
280 280
     {
281
-        if (! isset($options['name'])) {
281
+        if (!isset($options['name'])) {
282 282
             abort(500, 'Please make sure all your filters have names.');
283 283
         }
284
-        if (! isset($options['type'])) {
284
+        if (!isset($options['type'])) {
285 285
             abort(500, 'Please make sure all your filters have types.');
286 286
         }
287
-        if (! \View::exists('crud::filters.'.$options['type'])) {
287
+        if (!\View::exists('crud::filters.'.$options['type'])) {
288 288
             abort(500, 'No filter view named "'.$options['type'].'.blade.php" was found.');
289 289
         }
290
-        if (! isset($options['label'])) {
290
+        if (!isset($options['label'])) {
291 291
             abort(500, 'Please make sure all your filters have labels.');
292 292
         }
293 293
     }
Please login to merge, or discard this patch.
src/PanelTraits/Columns.php 1 patch
Spacing   +14 added lines, -15 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
     public function addColumn($column)
64 64
     {
65 65
         // if a string was passed, not an array, change it to an array
66
-        if (! is_array($column)) {
66
+        if (!is_array($column)) {
67 67
             $column = ['name' => $column];
68 68
         }
69 69
 
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
         $column_with_details = $this->addDefaultLabel($column);
72 72
 
73 73
         // make sure the column has a name
74
-        if (! array_key_exists('name', $column_with_details)) {
74
+        if (!array_key_exists('name', $column_with_details)) {
75 75
             $column_with_details['name'] = 'anonymous_column_'.str_random(5);
76 76
         }
77 77
 
@@ -79,27 +79,27 @@  discard block
 block discarded – undo
79 79
         $columnExistsInDb = $this->hasColumn($this->model->getTable(), $column_with_details['name']);
80 80
 
81 81
         // make sure the column has a type
82
-        if (! array_key_exists('type', $column_with_details)) {
82
+        if (!array_key_exists('type', $column_with_details)) {
83 83
             $column_with_details['type'] = 'text';
84 84
         }
85 85
 
86 86
         // make sure the column has a key
87
-        if (! array_key_exists('key', $column_with_details)) {
87
+        if (!array_key_exists('key', $column_with_details)) {
88 88
             $column_with_details['key'] = $column_with_details['name'];
89 89
         }
90 90
 
91 91
         // make sure the column has a tableColumn boolean
92
-        if (! array_key_exists('tableColumn', $column_with_details)) {
92
+        if (!array_key_exists('tableColumn', $column_with_details)) {
93 93
             $column_with_details['tableColumn'] = $columnExistsInDb ? true : false;
94 94
         }
95 95
 
96 96
         // make sure the column has a orderable boolean
97
-        if (! array_key_exists('orderable', $column_with_details)) {
97
+        if (!array_key_exists('orderable', $column_with_details)) {
98 98
             $column_with_details['orderable'] = $columnExistsInDb ? true : false;
99 99
         }
100 100
 
101 101
         // make sure the column has a searchLogic
102
-        if (! array_key_exists('searchLogic', $column_with_details)) {
102
+        if (!array_key_exists('searchLogic', $column_with_details)) {
103 103
             $column_with_details['searchLogic'] = $columnExistsInDb ? true : false;
104 104
         }
105 105
 
@@ -108,14 +108,14 @@  discard block
 block discarded – undo
108 108
 
109 109
         // make sure the column has a priority in terms of visibility
110 110
         // if no priority has been defined, use the order in the array plus one
111
-        if (! array_key_exists('priority', $column_with_details)) {
111
+        if (!array_key_exists('priority', $column_with_details)) {
112 112
             $position_in_columns_array = (int) array_search($column_with_details['key'], array_keys($this->columns()));
113 113
             $columnsArray[$column_with_details['key']]['priority'] = $position_in_columns_array + 1;
114 114
         }
115 115
 
116 116
         // if this is a relation type field and no corresponding model was specified, get it from the relation method
117 117
         // defined in the main model
118
-        if (isset($column_with_details['entity']) && ! isset($column_with_details['model'])) {
118
+        if (isset($column_with_details['entity']) && !isset($column_with_details['model'])) {
119 119
             $columnsArray[$column_with_details['key']]['model'] = $this->getRelationModel($column_with_details['entity']);
120 120
         }
121 121
 
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
      */
165 165
     public function makeFirstColumn()
166 166
     {
167
-        if (! $this->columns()) {
167
+        if (!$this->columns()) {
168 168
             return false;
169 169
         }
170 170
 
@@ -186,8 +186,7 @@  discard block
 block discarded – undo
186 186
         $columnsArray = $this->columns();
187 187
 
188 188
         if (array_key_exists($targetColumnName, $columnsArray)) {
189
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
190
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
189
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
191 190
 
192 191
             $element = array_pop($columnsArray);
193 192
             $beginningPart = array_slice($columnsArray, 0, $targetColumnPosition, true);
@@ -225,7 +224,7 @@  discard block
 block discarded – undo
225 224
      */
226 225
     public function addDefaultLabel($array)
227 226
     {
228
-        if (! array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
227
+        if (!array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
229 228
             $array = array_merge(['label' => mb_ucfirst($this->makeLabel($array['name']))], $array);
230 229
 
231 230
             return $array;
@@ -253,7 +252,7 @@  discard block
 block discarded – undo
253 252
      */
254 253
     public function removeColumns($columns)
255 254
     {
256
-        if (! empty($columns)) {
255
+        if (!empty($columns)) {
257 256
             foreach ($columns as $columnKey) {
258 257
                 $this->removeColumn($columnKey);
259 258
             }
@@ -331,7 +330,7 @@  discard block
 block discarded – undo
331 330
     {
332 331
         $columns = $this->columns();
333 332
 
334
-        return collect($columns)->pluck('entity')->reject(function ($value, $key) {
333
+        return collect($columns)->pluck('entity')->reject(function($value, $key) {
335 334
             return $value == null;
336 335
         })->toArray();
337 336
     }
Please login to merge, or discard this patch.
src/PanelTraits/Fields.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -38,23 +38,23 @@  discard block
 block discarded – undo
38 38
 
39 39
         // if this is a relation type field and no corresponding model was specified, get it from the relation method
40 40
         // defined in the main model
41
-        if (isset($newField['entity']) && ! isset($newField['model'])) {
41
+        if (isset($newField['entity']) && !isset($newField['model'])) {
42 42
             $newField['model'] = $this->getRelationModel($newField['entity']);
43 43
         }
44 44
 
45 45
         // if the label is missing, we should set it
46
-        if (! isset($newField['label'])) {
46
+        if (!isset($newField['label'])) {
47 47
             $newField['label'] = mb_ucfirst(str_replace('_', ' ', $newField['name']));
48 48
         }
49 49
 
50 50
         // if the field type is missing, we should set it
51
-        if (! isset($newField['type'])) {
51
+        if (!isset($newField['type'])) {
52 52
             $newField['type'] = $this->getFieldTypeFromDbColumnType($newField['name']);
53 53
         }
54 54
 
55 55
         // if a tab was mentioned, we should enable it
56 56
         if (isset($newField['tab'])) {
57
-            if (! $this->tabsEnabled()) {
57
+            if (!$this->tabsEnabled()) {
58 58
                 $this->enableTabs();
59 59
             }
60 60
         }
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
      */
90 90
     public function afterField($targetFieldName)
91 91
     {
92
-        $this->transformFields(function ($fields) use ($targetFieldName) {
92
+        $this->transformFields(function($fields) use ($targetFieldName) {
93 93
             return $this->moveField($fields, $targetFieldName, false);
94 94
         });
95 95
     }
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
      */
103 103
     public function beforeField($targetFieldName)
104 104
     {
105
-        $this->transformFields(function ($fields) use ($targetFieldName) {
105
+        $this->transformFields(function($fields) use ($targetFieldName) {
106 106
             return $this->moveField($fields, $targetFieldName, true);
107 107
         });
108 108
     }
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
      */
146 146
     public function removeField($name)
147 147
     {
148
-        $this->transformFields(function ($fields) use ($name) {
148
+        $this->transformFields(function($fields) use ($name) {
149 149
             array_forget($fields, $name);
150 150
 
151 151
             return $fields;
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
      */
160 160
     public function removeFields($array_of_names)
161 161
     {
162
-        if (! empty($array_of_names)) {
162
+        if (!empty($array_of_names)) {
163 163
             foreach ($array_of_names as $name) {
164 164
                 $this->removeField($name);
165 165
             }
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
     public function removeAllFields()
173 173
     {
174 174
         $current_fields = $this->getCurrentFields();
175
-        if (! empty($current_fields)) {
175
+        if (!empty($current_fields)) {
176 176
             foreach ($current_fields as $field) {
177 177
                 $this->removeField($field['name']);
178 178
             }
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
                 $jsonCastables = ['array', 'object', 'json'];
247 247
                 $fieldCasting = $casted_attributes[$field['name']];
248 248
 
249
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
249
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
250 250
                     try {
251 251
                         $data[$field['name']] = json_decode($data[$field['name']]);
252 252
                     } catch (\Exception $e) {
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
      */
276 276
     public function orderFields($order)
277 277
     {
278
-        $this->transformFields(function ($fields) use ($order) {
278
+        $this->transformFields(function($fields) use ($order) {
279 279
             return $this->applyOrderToFields($fields, $order);
280 280
         });
281 281
     }
@@ -338,7 +338,7 @@  discard block
 block discarded – undo
338 338
     public function hasUploadFields()
339 339
     {
340 340
         $fields = $this->getFields();
341
-        $upload_fields = array_where($fields, function ($value, $key) {
341
+        $upload_fields = array_where($fields, function($value, $key) {
342 342
             return isset($value['upload']) && $value['upload'] == true;
343 343
         });
344 344
 
Please login to merge, or discard this patch.