Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — add-method-to-get-ajax-uploade... ( 4a3e5a...2230c6 )
by Pedro
14:58
created
src/routes/backpack/testing.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
     (array) config('backpack.base.middleware_key', 'admin'),
16 16
     'prefix' => config('backpack.base.route_prefix', 'admin'),
17 17
 ],
18
-    function () {
18
+    function() {
19 19
         Route::crud('users', 'Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController');
20 20
     }
21 21
 );
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/AutoSet.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -14,8 +14,8 @@  discard block
 block discarded – undo
14 14
     {
15 15
         $this->getDbColumnTypes();
16 16
 
17
-        array_map(function ($field) use ($setFields, $setColumns) {
18
-            if ($setFields && ! isset($this->getCleanStateFields()[$field])) {
17
+        array_map(function($field) use ($setFields, $setColumns) {
18
+            if ($setFields && !isset($this->getCleanStateFields()[$field])) {
19 19
                 $this->addField([
20 20
                     'name' => $field,
21 21
                     'label' => $this->makeLabel($field),
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
                 ]);
29 29
             }
30 30
 
31
-            if ($setColumns && ! in_array($field, $this->model->getHidden()) && ! isset($this->columns()[$field])) {
31
+            if ($setColumns && !in_array($field, $this->model->getHidden()) && !isset($this->columns()[$field])) {
32 32
                 $this->addColumn([
33 33
                     'name' => $field,
34 34
                     'label' => $this->makeLabel($field),
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
     {
51 51
         $dbColumnTypes = [];
52 52
 
53
-        if (! $this->driverIsSql()) {
53
+        if (!$this->driverIsSql()) {
54 54
             return $dbColumnTypes;
55 55
         }
56 56
 
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
 
116 116
         $dbColumnTypes = $this->getDbColumnTypes();
117 117
 
118
-        if (! isset($dbColumnTypes[$fieldName])) {
118
+        if (!isset($dbColumnTypes[$fieldName])) {
119 119
             return 'text';
120 120
         }
121 121
 
@@ -212,12 +212,12 @@  discard block
 block discarded – undo
212 212
     {
213 213
         $fillable = $this->model->getFillable();
214 214
 
215
-        if (! $this->driverIsSql()) {
215
+        if (!$this->driverIsSql()) {
216 216
             $columns = $fillable;
217 217
         } else {
218 218
             // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model
219 219
             $columns = $this->model::getDbTableSchema()->getColumnsNames();
220
-            if (! empty($fillable)) {
220
+            if (!empty($fillable)) {
221 221
                 $columns = array_intersect($columns, $fillable);
222 222
             }
223 223
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Update.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         }
48 48
 
49 49
         // always have a hidden input for the entry id
50
-        if (! array_key_exists('id', $fields)) {
50
+        if (!array_key_exists('id', $fields)) {
51 51
             $fields['id'] = [
52 52
                 'name' => $entry->getKeyName(),
53 53
                 'value' => $entry->getKey(),
@@ -72,12 +72,12 @@  discard block
 block discarded – undo
72 72
         $fieldEntity = $field['entity'] ?? false;
73 73
         $fakeField = $field['fake'] ?? false;
74 74
 
75
-        if ($fieldEntity && ! $fakeField) {
75
+        if ($fieldEntity && !$fakeField) {
76 76
             return $this->getModelAttributeValueFromRelationship($model, $field);
77 77
         }
78 78
 
79 79
         if ($this->holdsMultipleInputs($field['name'])) {
80
-            $result = array_map(function ($item) use ($model) {
80
+            $result = array_map(function($item) use ($model) {
81 81
                 return $model->{$item};
82 82
             }, explode(',', $field['name']));
83 83
 
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
     {
100 100
         [$relatedModel, $relationMethod] = $this->getModelAndMethodFromEntity($model, $field);
101 101
 
102
-        if (! method_exists($relatedModel, $relationMethod)) {
102
+        if (!method_exists($relatedModel, $relationMethod)) {
103 103
             return $relatedModel->{$relationMethod};
104 104
         }
105 105
 
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
                     $model = $this->setupRelatedModelLocale($model);
119 119
                     // when subfields are NOT set we don't need to get any more values
120 120
                     // we just return the plain models as we only need the ids
121
-                    if (! isset($field['subfields'])) {
121
+                    if (!isset($field['subfields'])) {
122 122
                         $result->push($model);
123 123
 
124 124
                         continue;
@@ -146,13 +146,13 @@  discard block
 block discarded – undo
146 146
                 break;
147 147
             case 'HasOne':
148 148
             case 'MorphOne':
149
-                if (! method_exists($relatedModel, $relationMethod)) {
149
+                if (!method_exists($relatedModel, $relationMethod)) {
150 150
                     return;
151 151
                 }
152 152
 
153 153
                 $model = $relatedModel->{$relationMethod};
154 154
 
155
-                if (! $model) {
155
+                if (!$model) {
156 156
                     return;
157 157
                 }
158 158
 
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
 
234 234
         $relationArray = explode('.', $relationEntity);
235 235
 
236
-        $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function ($obj, $method) {
236
+        $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function($obj, $method) {
237 237
             // if the string ends with `_id` we strip it out
238 238
             $method = Str::endsWith($method, '_id') ? Str::replaceLast('_id', '', $method) : $method;
239 239
 
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
260 260
             // if the subfield name does not contain a dot we just need to check
261 261
             // if it has subfields and return the result accordingly.
262 262
             foreach ((array) $subfield['name'] as $name) {
263
-                if (! Str::contains($name, '.')) {
263
+                if (!Str::contains($name, '.')) {
264 264
                     // when subfields are present, $relatedModel->{$name} returns a model instance
265 265
                     // otherwise returns the model attribute.
266 266
                     if ($relatedModel->{$name}) {
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ListOperation.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
             'operation' => 'list',
28 28
         ]);
29 29
 
30
-        if (! isset($this->setupDetailsRowRoute) || $this->setupDetailsRowRoute === true) {
30
+        if (!isset($this->setupDetailsRowRoute) || $this->setupDetailsRowRoute === true) {
31 31
             Route::get($segment.'/{id}/details', [
32 32
                 'as' => $routeName.'.showDetailsRow',
33 33
                 'uses' => $controller.'@showDetailsRow',
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
     {
44 44
         $this->crud->allowAccess('list');
45 45
 
46
-        $this->crud->operation('list', function () {
46
+        $this->crud->operation('list', function() {
47 47
             $this->crud->loadDefaultOperationSettingsFromConfig();
48 48
         });
49 49
     }
Please login to merge, or discard this patch.
tests/BaseTestClass.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
             (array) config('backpack.base.middleware_key', 'admin'),
24 24
             'prefix' => config('backpack.base.route_prefix', 'admin'),
25 25
         ],
26
-            function () {
26
+            function() {
27 27
                 Route::get('articles/{id}/show/{detail}', ['as' => 'article.show.detail', 'action' => 'Backpack\CRUD\Tests\config\Http\Controllers\ArticleCrudController@detail']);
28 28
                 Route::crud('users', 'Backpack\CRUD\Tests\config\Http\Controllers\UserCrudController');
29 29
                 Route::crud('articles', 'Backpack\CRUD\Tests\config\Http\Controllers\ArticleCrudController');
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelCreateTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -605,7 +605,7 @@  discard block
 block discarded – undo
605 605
 
606 606
     public function testCreateBelongsToFake()
607 607
     {
608
-        $belongsToField = [   // select_grouped
608
+        $belongsToField = [// select_grouped
609 609
             'label' => 'Select_grouped',
610 610
             'type' => 'select_grouped', //https://github.com/Laravel-Backpack/CRUD/issues/502
611 611
             'name' => 'bang_relation_field',
@@ -741,7 +741,7 @@  discard block
 block discarded – undo
741 741
                 'nickname' => 'i_have_has_one',
742 742
                 'profile_picture' => 'ohh my picture 1.jpg',
743 743
                 'article' => 1,
744
-                'addresses' => [ // HasOne is tested in other test function
744
+                'addresses' => [// HasOne is tested in other test function
745 745
                     [
746 746
                         'city' => 2,
747 747
                         'street' => 'test',
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelValidationTest.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
             'password' => 'test',
46 46
         ]);
47 47
 
48
-        $request->setRouteResolver(function () use ($request) {
48
+        $request->setRouteResolver(function() use ($request) {
49 49
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController', 'create']))->bind($request);
50 50
         });
51 51
 
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
             'email' => '',
86 86
         ]);
87 87
 
88
-        $request->setRouteResolver(function () use ($request) {
88
+        $request->setRouteResolver(function() use ($request) {
89 89
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController', 'create']))->bind($request);
90 90
         });
91 91
 
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
             'password' => 'test',
126 126
         ]);
127 127
 
128
-        $request->setRouteResolver(function () use ($request) {
128
+        $request->setRouteResolver(function() use ($request) {
129 129
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController', 'create']))->bind($request);
130 130
         });
131 131
 
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
             'name' => 'test',
248 248
         ]);
249 249
 
250
-        $request->setRouteResolver(function () use ($request) {
250
+        $request->setRouteResolver(function() use ($request) {
251 251
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController', 'create']))->bind($request);
252 252
         });
253 253
 
Please login to merge, or discard this patch.
src/app/Library/Uploaders/Support/Traits/HandleRepeatableUploads.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@  discard block
 block discarded – undo
13 13
 {
14 14
     public bool $handleRepeatableFiles = false;
15 15
 
16
-    public null|string $repeatableContainerName = null;
16
+    public null | string $repeatableContainerName = null;
17 17
 
18 18
     /*******************************
19 19
      * Setters - fluently configure the uploader
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
     /*******************************
31 31
      * Getters
32 32
      *******************************/
33
-    public function getRepeatableContainerName(): null|string
33
+    public function getRepeatableContainerName(): null | string
34 34
     {
35 35
         return $this->repeatableContainerName;
36 36
     }
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
         foreach (app('UploadersRepository')->getRepeatableUploadersFor($this->getRepeatableContainerName()) as $uploader) {
77 77
             $uploadedValues = $uploader->uploadRepeatableFiles($values->pluck($uploader->getAttributeName())->toArray(), $this->getPreviousRepeatableValues($entry, $uploader));
78 78
 
79
-            $values = $values->map(function ($item, $key) use ($uploadedValues, $uploader) {
79
+            $values = $values->map(function($item, $key) use ($uploadedValues, $uploader) {
80 80
                 $item[$uploader->getAttributeName()] = $uploadedValues[$key] ?? null;
81 81
 
82 82
                 return $item;
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 
97 97
         $values = $entry->{$this->getRepeatableContainerName()};
98 98
         $values = is_string($values) ? json_decode($values, true) : $values;
99
-        $values = array_map(function ($item) use ($repeatableUploaders) {
99
+        $values = array_map(function($item) use ($repeatableUploaders) {
100 100
             foreach ($repeatableUploaders as $upload) {
101 101
                 $item[$upload->getAttributeName()] = $this->getValuesWithPathStripped($item, $upload);
102 102
             }
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 
112 112
     private function retrieveRepeatableRelationFiles(Model $entry)
113 113
     {
114
-        switch($this->getRepeatableRelationType()) {
114
+        switch ($this->getRepeatableRelationType()) {
115 115
             case 'BelongsToMany':
116 116
             case 'MorphToMany':
117 117
                 $pivotClass = app('crud')->getModel()->{$this->getUploaderSubfield()['baseEntity']}()->getPivotClass();
@@ -157,12 +157,12 @@  discard block
 block discarded – undo
157 157
 
158 158
         $repeatableValues = collect($entry->{$this->getName()});
159 159
         foreach (app('UploadersRepository')->getRepeatableUploadersFor($this->getRepeatableContainerName()) as $upload) {
160
-            if (! $upload->shouldDeleteFiles()) {
160
+            if (!$upload->shouldDeleteFiles()) {
161 161
                 continue;
162 162
             }
163 163
             $values = $repeatableValues->pluck($upload->getName())->toArray();
164 164
             foreach ($values as $value) {
165
-                if (! $value) {
165
+                if (!$value) {
166 166
                     continue;
167 167
                 }
168 168
 
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
     /**
186 186
      * Given two multidimensional arrays/collections, merge them recursively.
187 187
      */
188
-    protected function mergeValuesRecursive(array|Collection $array1, array|Collection $array2): array|Collection
188
+    protected function mergeValuesRecursive(array | Collection $array1, array | Collection $array2): array | Collection
189 189
     {
190 190
         $merged = $array1;
191 191
         foreach ($array2 as $key => &$value) {
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
     {
208 208
         $items = CRUD::getRequest()->input('_order_'.$this->getRepeatableContainerName()) ?? [];
209 209
 
210
-        array_walk($items, function (&$key, $value) {
210
+        array_walk($items, function(&$key, $value) {
211 211
             $requestValue = $key[$this->getName()] ?? null;
212 212
             $key = $this->handleMultipleFiles ? (is_string($requestValue) ? explode(',', $requestValue) : $requestValue) : $requestValue;
213 213
         });
@@ -219,18 +219,18 @@  discard block
 block discarded – undo
219 219
     {
220 220
         $previousValues = json_decode($entry->getOriginal($uploader->getRepeatableContainerName()), true);
221 221
 
222
-        if (! empty($previousValues)) {
222
+        if (!empty($previousValues)) {
223 223
             $previousValues = array_column($previousValues, $uploader->getName());
224 224
         }
225 225
 
226 226
         return $previousValues ?? [];
227 227
     }
228 228
 
229
-    private function getValuesWithPathStripped(array|string|null $item, UploaderInterface $upload)
229
+    private function getValuesWithPathStripped(array | string | null $item, UploaderInterface $upload)
230 230
     {
231 231
         $uploadedValues = $item[$upload->getName()] ?? null;
232 232
         if (is_array($uploadedValues)) {
233
-            return array_map(function ($value) use ($upload) {
233
+            return array_map(function($value) use ($upload) {
234 234
                 return Str::after($value, $upload->getPath());
235 235
             }, $uploadedValues);
236 236
         }
@@ -242,19 +242,19 @@  discard block
 block discarded – undo
242 242
     {
243 243
         if (in_array($this->getRepeatableRelationType(), ['BelongsToMany', 'MorphToMany'])) {
244 244
             $pivotAttributes = $entry->getAttributes();
245
-            $connectedPivot = $entry->pivotParent->{$this->getRepeatableContainerName()}->where(function ($item) use ($pivotAttributes) {
245
+            $connectedPivot = $entry->pivotParent->{$this->getRepeatableContainerName()}->where(function($item) use ($pivotAttributes) {
246 246
                 $itemPivotAttributes = $item->pivot->only(array_keys($pivotAttributes));
247 247
 
248 248
                 return $itemPivotAttributes === $pivotAttributes;
249 249
             })->first();
250 250
 
251
-            if (! $connectedPivot) {
251
+            if (!$connectedPivot) {
252 252
                 return;
253 253
             }
254 254
 
255 255
             $files = $connectedPivot->getOriginal()['pivot_'.$this->getAttributeName()];
256 256
 
257
-            if (! $files) {
257
+            if (!$files) {
258 258
                 return;
259 259
             }
260 260
 
Please login to merge, or discard this patch.
src/app/Library/Uploaders/SingleFile.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
             return $this->getPath().$fileName;
24 24
         }
25 25
 
26
-        if (! $value && CrudPanelFacade::getRequest()->has($this->getNameForRequest()) && $previousFile) {
26
+        if (!$value && CrudPanelFacade::getRequest()->has($this->getNameForRequest()) && $previousFile) {
27 27
             Storage::disk($this->getDisk())->delete($previousFile);
28 28
 
29 29
             return null;
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         }
48 48
 
49 49
         foreach ($previousRepeatableValues as $row => $file) {
50
-            if ($file && ! isset($orderedFiles[$row])) {
50
+            if ($file && !isset($orderedFiles[$row])) {
51 51
                 $orderedFiles[$row] = null;
52 52
                 Storage::disk($this->getDisk())->delete($file);
53 53
             }
Please login to merge, or discard this patch.