Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#574)
by Steven
02:52
created
src/PanelTraits/Create.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@
 block discarded – undo
87 87
     {
88 88
         $all_relation_fields = $this->getRelationFields($form);
89 89
 
90
-        return array_where($all_relation_fields, function ($value, $key) {
90
+        return array_where($all_relation_fields, function($value, $key) {
91 91
             return isset($value['pivot']) && $value['pivot'];
92 92
         });
93 93
     }
Please login to merge, or discard this patch.
src/PanelTraits/Update.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
 
47 47
         foreach ($fields as $k => $field) {
48 48
             // set the value
49
-            if (! isset($fields[$k]['value'])) {
49
+            if (!isset($fields[$k]['value'])) {
50 50
                 if (isset($field['subfields'])) {
51 51
                     $fields[$k]['value'] = [];
52 52
                     foreach ($field['subfields'] as $key => $subfield) {
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
         }
60 60
 
61 61
         // always have a hidden input for the entry id
62
-        if (! array_key_exists('id', $fields)) {
62
+        if (!array_key_exists('id', $fields)) {
63 63
             $fields['id'] = [
64 64
                 'name'  => $entry->getKeyName(),
65 65
                 'value' => $entry->getKey(),
Please login to merge, or discard this patch.
src/ModelTraits/SpatieTranslatable/SluggableObserver.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2,8 +2,8 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD\ModelTraits\SpatieTranslatable;
4 4
 
5
-use Illuminate\Database\Eloquent\Model;
6 5
 use Illuminate\Contracts\Events\Dispatcher;
6
+use Illuminate\Database\Eloquent\Model;
7 7
 
8 8
 class SluggableObserver extends \Cviebrock\EloquentSluggable\SluggableObserver
9 9
 {
Please login to merge, or discard this patch.
src/ModelTraits/SpatieTranslatable/SlugService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
      */
50 50
     protected function makeSlugUnique($slug, array $config, $attribute)
51 51
     {
52
-        if (! $config['unique']) {
52
+        if (!$config['unique']) {
53 53
             return $slug;
54 54
         }
55 55
 
Please login to merge, or discard this patch.
src/ModelTraits/SpatieTranslatable/Sluggable.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
         $separator = $config['separator'];
48 48
         $attribute = $attribute.'->'.$this->getLocale();
49 49
 
50
-        return $query->where(function (Builder $q) use ($attribute, $slug, $separator) {
50
+        return $query->where(function(Builder $q) use ($attribute, $slug, $separator) {
51 51
             $q->where($attribute, '=', $slug)
52 52
                 ->orWhere($attribute, 'LIKE', $slug.$separator.'%');
53 53
         });
Please login to merge, or discard this patch.
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -2,9 +2,9 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD\ModelTraits\SpatieTranslatable;
4 4
 
5
-use Illuminate\Database\Eloquent\Model;
6
-use Illuminate\Database\Eloquent\Builder;
7 5
 use Cviebrock\EloquentSluggable\Sluggable as OriginalSluggable;
6
+use Illuminate\Database\Eloquent\Builder;
7
+use Illuminate\Database\Eloquent\Model;
8 8
 
9 9
 trait Sluggable
10 10
 {
Please login to merge, or discard this patch.
src/ModelTraits/SpatieTranslatable/HasTranslations.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
      */
25 25
     public function getAttributeValue($key)
26 26
     {
27
-        if (! $this->isTranslatableAttribute($key)) {
27
+        if (!$this->isTranslatableAttribute($key)) {
28 28
             return parent::getAttributeValue($key);
29 29
         }
30 30
 
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
      */
73 73
     public function update(array $attributes = [], array $options = [])
74 74
     {
75
-        if (! $this->exists) {
75
+        if (!$this->exists) {
76 76
             return false;
77 77
         }
78 78
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudFeatures/Revisions.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
         $this->crud->hasAccessOrFail('revisions');
42 42
 
43 43
         $revisionId = \Request::input('revision_id', false);
44
-        if (! $revisionId) {
44
+        if (!$revisionId) {
45 45
             abort(500, 'Can\'t restore revision without revision_id');
46 46
         } else {
47 47
             $this->crud->restoreRevision($id, $revisionId); // do the update
Please login to merge, or discard this patch.
src/PanelTraits/AutoSet.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
     {
17 17
         $this->getDbColumnTypes();
18 18
 
19
-        array_map(function ($field) {
19
+        array_map(function($field) {
20 20
             // $this->labels[$field] = $this->makeLabel($field);
21 21
 
22 22
             $new_field = [
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
             $this->create_fields[$field] = $new_field;
31 31
             $this->update_fields[$field] = $new_field;
32 32
 
33
-            if (! in_array($field, $this->model->getHidden())) {
33
+            if (!in_array($field, $this->model->getHidden())) {
34 34
                 $this->columns[$field] = [
35 35
                     'name'  => $field,
36 36
                     'label' => ucfirst($field),
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
      */
68 68
     public function getFieldTypeFromDbColumnType($field)
69 69
     {
70
-        if (! array_key_exists($field, $this->db_column_types)) {
70
+        if (!array_key_exists($field, $this->db_column_types)) {
71 71
             return 'text';
72 72
         }
73 73
 
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
         $columns = $this->model->getConnection()->getSchemaBuilder()->getColumnListing($this->model->getTable());
149 149
         $fillable = $this->model->getFillable();
150 150
 
151
-        if (! empty($fillable)) {
151
+        if (!empty($fillable)) {
152 152
             $columns = array_intersect($columns, $fillable);
153 153
         }
154 154
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudController.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -27,12 +27,12 @@  discard block
 block discarded – undo
27 27
 
28 28
     public function __construct()
29 29
     {
30
-        if (! $this->crud) {
30
+        if (!$this->crud) {
31 31
             $this->crud = app()->make(CrudPanel::class);
32 32
 
33 33
             // call the setup function inside this closure to also have the request there
34 34
             // this way, developers can use things stored in session (auth variables, etc)
35
-            $this->middleware(function ($request, $next) {
35
+            $this->middleware(function($request, $next) {
36 36
                 $this->request = $request;
37 37
                 $this->crud->request = $request;
38 38
                 $this->setup();
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
         $this->data['title'] = ucfirst($this->crud->entity_name_plural);
63 63
 
64 64
         // get all entries if AJAX is not enabled
65
-        if (! $this->data['crud']->ajaxTable()) {
65
+        if (!$this->data['crud']->ajaxTable()) {
66 66
             $this->data['entries'] = $this->data['crud']->getEntries();
67 67
         }
68 68
 
Please login to merge, or discard this patch.
Unused Use Statements   +5 added lines, -7 removed lines patch added patch discarded remove patch
@@ -3,19 +3,17 @@
 block discarded – undo
3 3
 namespace Backpack\CRUD\app\Http\Controllers;
4 4
 
5 5
 use Backpack\CRUD\CrudPanel;
6
-use Illuminate\Http\Request;
7
-use Illuminate\Support\Facades\Form as Form;
6
+use Backpack\CRUD\app\Http\Controllers\CrudFeatures\AjaxTable;
7
+use Backpack\CRUD\app\Http\Controllers\CrudFeatures\Reorder;
8 8
 use Illuminate\Foundation\Bus\DispatchesJobs;
9
-use Illuminate\Routing\Controller as BaseController;
10 9
 use Illuminate\Foundation\Validation\ValidatesRequests;
11
-use Backpack\CRUD\app\Http\Controllers\CrudFeatures\Reorder;
12
-use Backpack\CRUD\app\Http\Controllers\CrudFeatures\AjaxTable;
10
+use Illuminate\Http\Request;
11
+use Illuminate\Routing\Controller as BaseController;
13 12
 // CRUD Traits for non-core features
14 13
 use Backpack\CRUD\app\Http\Controllers\CrudFeatures\Revisions;
15 14
 use Backpack\CRUD\app\Http\Controllers\CrudFeatures\SaveActions;
16
-use Backpack\CRUD\app\Http\Requests\CrudRequest as StoreRequest;
17
-use Backpack\CRUD\app\Http\Requests\CrudRequest as UpdateRequest;
18 15
 use Backpack\CRUD\app\Http\Controllers\CrudFeatures\ShowDetailsRow;
16
+use Backpack\CRUD\app\Http\Requests\CrudRequest as UpdateRequest;
19 17
 
20 18
 class CrudController extends BaseController
21 19
 {
Please login to merge, or discard this patch.