Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Failed
Pull Request — main (#5518)
by Pedro
34:25 queued 23:25
created
src/app/Library/Database/Table.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
 
23 23
                 public function getNotnull()
24 24
                 {
25
-                    return ! $this->column['nullable'];
25
+                    return !$this->column['nullable'];
26 26
                 }
27 27
 
28 28
                 public function getDefault()
Please login to merge, or discard this patch.
src/app/Models/Traits/HasIdentifiableAttribute.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
         // we get the first column from database
54 54
         // that is NOT indexed (usually primary, foreign keys)
55 55
         foreach ($columnNames as $columnName) {
56
-            if (! in_array($columnName, $indexes)) {
56
+            if (!in_array($columnName, $indexes)) {
57 57
                 //check for convention "field<_id>" in case developer didn't add foreign key constraints.
58 58
                 if (strpos($columnName, '_id') !== false) {
59 59
                     continue;
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/AutoSet.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -14,8 +14,8 @@  discard block
 block discarded – undo
14 14
     {
15 15
         $this->getDbColumnTypes();
16 16
 
17
-        array_map(function ($field) use ($setFields, $setColumns) {
18
-            if ($setFields && ! isset($this->getCleanStateFields()[$field])) {
17
+        array_map(function($field) use ($setFields, $setColumns) {
18
+            if ($setFields && !isset($this->getCleanStateFields()[$field])) {
19 19
                 $this->addField([
20 20
                     'name' => $field,
21 21
                     'label' => $this->makeLabel($field),
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
                 ]);
29 29
             }
30 30
 
31
-            if ($setColumns && ! in_array($field, $this->model->getHidden()) && ! isset($this->columns()[$field])) {
31
+            if ($setColumns && !in_array($field, $this->model->getHidden()) && !isset($this->columns()[$field])) {
32 32
                 $this->addColumn([
33 33
                     'name' => $field,
34 34
                     'label' => $this->makeLabel($field),
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
     {
51 51
         $dbColumnTypes = [];
52 52
 
53
-        if (! $this->driverIsSql()) {
53
+        if (!$this->driverIsSql()) {
54 54
             return $dbColumnTypes;
55 55
         }
56 56
         $dbColumns = $this->getDbTableColumns();
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
 
116 116
         $dbColumnTypes = $this->getDbColumnTypes();
117 117
 
118
-        if (! isset($dbColumnTypes[$fieldName])) {
118
+        if (!isset($dbColumnTypes[$fieldName])) {
119 119
             return 'text';
120 120
         }
121 121
 
@@ -210,12 +210,12 @@  discard block
 block discarded – undo
210 210
     {
211 211
         $fillable = $this->model->getFillable();
212 212
 
213
-        if (! $this->driverIsSql()) {
213
+        if (!$this->driverIsSql()) {
214 214
             $columns = $fillable;
215 215
         } else {
216 216
             // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model
217 217
             $columns = $this->model::getDbTableSchema()->getColumnsNames();
218
-            if (! empty($fillable)) {
218
+            if (!empty($fillable)) {
219 219
                 $columns = array_intersect($columns, $fillable);
220 220
             }
221 221
         }
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelAutoSetTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -848,7 +848,7 @@
 block discarded – undo
848 848
 
849 849
     public function testSetDoctrineTypesMapping()
850 850
     {
851
-        if (! method_exists($this->crudPanel->getModel()->getConnection(), 'getDoctrineConnection')) {
851
+        if (!method_exists($this->crudPanel->getModel()->getConnection(), 'getDoctrineConnection')) {
852 852
             $this->markTestSkipped('This test is only for Laravel 10, Laravel 11 does not have dbal as a dependency anymore');
853 853
         }
854 854
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
                     // - a single dimensional array: [1,2,3]
123 123
                     // - an array of arrays: [[1][2][3]]
124 124
                     // if is as single dimensional array we can only attach.
125
-                    if ($relationValues === null || ! is_multidimensional_array($relationValues)) {
125
+                    if ($relationValues === null || !is_multidimensional_array($relationValues)) {
126 126
                         $this->attachManyRelation($item, $relation, $relationDetails, $relationValues);
127 127
                     } else {
128 128
                         $this->createManyEntries($item, $relation, $relationMethod, $relationDetails);
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
         }
294 294
         // if column is not nullable in database, and there is no column default (null),
295 295
         // we will delete the entry from the database, otherwise it will throw and ugly DB error.
296
-        if (! $relationColumnIsNullable && $dbColumnDefault === null) {
296
+        if (!$relationColumnIsNullable && $dbColumnDefault === null) {
297 297
             return $removedEntries->lazy()->each->delete();
298 298
         }
299 299
 
@@ -338,7 +338,7 @@  discard block
 block discarded – undo
338 338
         }
339 339
 
340 340
         // use the collection of sent ids to match against database ids, delete the ones not found in the submitted ids.
341
-        if (! empty($relatedItemsSent)) {
341
+        if (!empty($relatedItemsSent)) {
342 342
             // we perform the cleanup of removed database items
343 343
             $entry->{$relationMethod}()->whereNotIn($relatedModelLocalKey, $relatedItemsSent)->lazy()->each->delete();
344 344
         }
Please login to merge, or discard this patch.
src/app/Models/Traits/HasRelationshipFields.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
     {
23 23
         $connection = DB::connection($this->getConnectionName());
24 24
 
25
-        if (! method_exists($connection, 'getDoctrineSchemaManager')) {
25
+        if (!method_exists($connection, 'getDoctrineSchemaManager')) {
26 26
             return $connection;
27 27
         }
28 28
 
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
         if (self::isSqlConnection()) {
36 36
             $platform = $connection->getDoctrineSchemaManager()->getDatabasePlatform();
37 37
             foreach ($types as $type_key => $type_value) {
38
-                if (! $platform->hasDoctrineTypeMappingFor($type_key)) {
38
+                if (!$platform->hasDoctrineTypeMappingFor($type_key)) {
39 39
                     $platform->registerDoctrineTypeMapping($type_key, $type_value);
40 40
                 }
41 41
             }
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      */
66 66
     public function getColumnType($columnName)
67 67
     {
68
-        if (! self::isSqlConnection()) {
68
+        if (!self::isSqlConnection()) {
69 69
             return 'text';
70 70
         }
71 71
 
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
      */
81 81
     public static function isColumnNullable($columnName)
82 82
     {
83
-        if (! self::isSqlConnection()) {
83
+        if (!self::isSqlConnection()) {
84 84
             return true;
85 85
         }
86 86
 
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
      */
96 96
     public static function dbColumnHasDefault($columnName)
97 97
     {
98
-        if (! self::isSqlConnection()) {
98
+        if (!self::isSqlConnection()) {
99 99
             return false;
100 100
         }
101 101
 
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
      */
111 111
     public static function getDbColumnDefault($columnName)
112 112
     {
113
-        if (! self::isSqlConnection()) {
113
+        if (!self::isSqlConnection()) {
114 114
             return false;
115 115
         }
116 116
 
Please login to merge, or discard this patch.
src/app/Library/Widget.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
         // if that widget name already exists in the widgets collection
38 38
         // then pick up all widget attributes from that entry
39 39
         // and overwrite them with the ones passed in $attributes
40
-        if ($existingItem = self::collection()->filter(function ($item) use ($attributes) {
40
+        if ($existingItem = self::collection()->filter(function($item) use ($attributes) {
41 41
             return $item->attributes['name'] === $attributes['name'];
42 42
         })->first()) {
43 43
             $attributes = array_merge($existingItem->attributes, $attributes);
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
             }
160 160
         }
161 161
         $type = $this->attributes['type'];
162
-        $paths = array_map(function ($item) use ($type) {
162
+        $paths = array_map(function($item) use ($type) {
163 163
             return $item.'.'.$type;
164 164
         }, ViewNamespaces::getWithFallbackFor('widgets', 'backpack.ui.component_view_namespaces.widgets'));
165 165
 
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
             }
170 170
         }
171 171
         // if no view exists, in any of the directories above... no bueno
172
-        if (! backpack_pro()) {
172
+        if (!backpack_pro()) {
173 173
             throw new BackpackProRequiredException('Cannot find the widget view: '.$this->attributes['type'].'. Please check for typos.'.(backpack_pro() ? '' : ' If you are trying to use a PRO widget, please first purchase and install the backpack/pro addon from backpackforlaravel.com'), 1);
174 174
         }
175 175
         abort(500, 'Cannot find the view for «'.$this->attributes['type'].'» widget type. Please check for typos.');
@@ -253,10 +253,10 @@  discard block
 block discarded – undo
253 253
      */
254 254
     private function save()
255 255
     {
256
-        $itemExists = $this->collection()->filter(function ($item) {
256
+        $itemExists = $this->collection()->filter(function($item) {
257 257
             return $item->attributes['name'] === $this->attributes['name'];
258 258
         })->isNotEmpty();
259
-        if (! $itemExists) {
259
+        if (!$itemExists) {
260 260
             $this->collection()->put($this->attributes['name'], $this);
261 261
         } else {
262 262
             $this->collection()[$this->attributes['name']] = $this;
Please login to merge, or discard this patch.
src/app/Library/Validation/Rules/ValidUploadMultiple.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,8 +23,7 @@
 block discarded – undo
23 23
         }
24 24
 
25 25
         $previousValues = str_contains($attribute, '.') ?
26
-                            (Arr::get($entry?->{Str::before($attribute, '.')} ?? [], Str::after($attribute, '.')) ?? []) :
27
-                            ($entry?->{$attribute} ?? []);
26
+                            (Arr::get($entry?->{Str::before($attribute, '.')} ?? [], Str::after($attribute, '.')) ?? []) : ($entry?->{$attribute} ?? []);
28 27
 
29 28
         if (is_string($previousValues)) {
30 29
             $previousValues = json_decode($previousValues, true) ?? [];
Please login to merge, or discard this patch.
src/app/Library/Uploaders/Support/UploadersRepository.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
      */
35 35
     public function markAsHandled(string $objectName): void
36 36
     {
37
-        if (! in_array($objectName, $this->handledUploaders)) {
37
+        if (!in_array($objectName, $this->handledUploaders)) {
38 38
             $this->handledUploaders[] = $objectName;
39 39
         }
40 40
     }
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
      */
85 85
     public function registerRepeatableUploader(string $uploadName, UploaderInterface $uploader): void
86 86
     {
87
-        if (! array_key_exists($uploadName, $this->repeatableUploaders) || ! in_array($uploader, $this->repeatableUploaders[$uploadName])) {
87
+        if (!array_key_exists($uploadName, $this->repeatableUploaders) || !in_array($uploader, $this->repeatableUploaders[$uploadName])) {
88 88
             $this->repeatableUploaders[$uploadName][] = $uploader;
89 89
         }
90 90
     }
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
      */
119 119
     public function getRegisteredUploadNames(string $uploadName): array
120 120
     {
121
-        return array_map(function ($uploader) {
121
+        return array_map(function($uploader) {
122 122
             return $uploader->getName();
123 123
         }, $this->getRepeatableUploadersFor($uploadName));
124 124
     }
@@ -149,11 +149,11 @@  discard block
 block discarded – undo
149 149
 
150 150
             $uploaders = $this->getRepeatableUploadersFor($repeatableContainerName);
151 151
 
152
-            $uploader = Arr::first($uploaders, function ($uploader) use ($requestInputName) {
152
+            $uploader = Arr::first($uploaders, function($uploader) use ($requestInputName) {
153 153
                 return $uploader->getName() === $requestInputName;
154 154
             });
155 155
             
156
-            if (! $uploader) {
156
+            if (!$uploader) {
157 157
                 abort(500, 'Could not find the field in the repeatable uploaders.');
158 158
             }
159 159
 
@@ -164,16 +164,16 @@  discard block
 block discarded – undo
164 164
             abort(500, 'Could not find the field in the CRUD fields.');
165 165
         }
166 166
 
167
-        if (! $uploaderMacro = $this->getUploadCrudObjectMacroType($crudObject)) {
167
+        if (!$uploaderMacro = $this->getUploadCrudObjectMacroType($crudObject)) {
168 168
             abort(500, 'There is no uploader defined for the given field type.');
169 169
         }
170 170
 
171
-        if (! $this->isValidUploadField($crudObject, $uploaderMacro)) {
171
+        if (!$this->isValidUploadField($crudObject, $uploaderMacro)) {
172 172
             abort(500, 'Invalid field for upload.');
173 173
         }
174 174
 
175 175
         $uploaderConfiguration = $crudObject[$uploaderMacro] ?? [];
176
-        $uploaderConfiguration = ! is_array($uploaderConfiguration) ? [] : $uploaderConfiguration;
176
+        $uploaderConfiguration = !is_array($uploaderConfiguration) ? [] : $uploaderConfiguration;
177 177
         $uploaderClass = $this->getUploadFor($crudObject['type'], $uploaderMacro);
178 178
 
179 179
         return new $uploaderClass(['name' => $requestInputName], $uploaderConfiguration);
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
     /**
183 183
      * Get the upload field macro type for the given object.
184 184
      */
185
-    private function getUploadCrudObjectMacroType(array $crudObject): string|null
185
+    private function getUploadCrudObjectMacroType(array $crudObject): string | null
186 186
     {
187 187
         return isset($crudObject['withFiles']) ? 'withFiles' : (isset($crudObject['withMedia']) ? 'withMedia' : null);
188 188
     }
@@ -191,11 +191,11 @@  discard block
 block discarded – undo
191 191
     {
192 192
         if (Str::contains($crudObject['name'], '#')) {
193 193
             $container = Str::before($crudObject['name'], '#');
194
-            $field = array_filter(CRUD::fields()[$container]['subfields'] ?? [], function ($item) use ($crudObject, $uploaderMacro) {
194
+            $field = array_filter(CRUD::fields()[$container]['subfields'] ?? [], function($item) use ($crudObject, $uploaderMacro) {
195 195
                 return $item['name'] === $crudObject['name'] && in_array($item['type'], $this->getAjaxUploadTypes($uploaderMacro));
196 196
             });
197 197
 
198
-            return ! empty($field);
198
+            return !empty($field);
199 199
         }
200 200
 
201 201
         return in_array($crudObject['type'], $this->getAjaxUploadTypes($uploaderMacro));
Please login to merge, or discard this patch.