Laravel-Backpack / CRUD

src/app/Library/CrudPanel/Traits/Fields.php

Doc Comments +2 added lines, -4 removed lines

@@ -326,8 +326,6 @@ 
      * Check if the create/update form has upload fields.
      * Upload fields are the ones that have "upload" => true defined on them.
      *
-     * @param string   $form create/update/both - defaults to 'both'
-     * @param bool|int $id   id of the entity - defaults to false
      *
      * @return bool
      */
@@ -358,7 +356,7 @@ 
     /**
      * Set an array of field type names as already loaded for the current operation.
      *
-     * @param array $fieldTypes
+     * @param string[] $fieldTypes
      */
     public function setLoadedFieldTypes($fieldTypes)
     {
@@ -369,7 +367,7 @@ 
      * Get a namespaced version of the field type name.
      * Appends the 'view_namespace' attribute of the field to the `type', using dot notation.
      *
-     * @param  array $field Field array
+     * @param  string $field Field array
      * @return string Namespaced version of the field type name. Ex: 'text', 'custom.view.path.text'
      */
     public function getFieldTypeWithNamespace($field)

Spacing +14 added lines, -14 removed lines

@@ -37,24 +37,24 @@ 
 
         // if this is a relation type field and no corresponding model was specified, get it from the relation method
         // defined in the main model
-        if (isset($newField['entity']) && ! isset($newField['model'])) {
+        if (isset($newField['entity']) && !isset($newField['model'])) {
             $newField['model'] = $this->getRelationModel($newField['entity']);
         }
 
         // if the label is missing, we should set it
-        if (! isset($newField['label'])) {
+        if (!isset($newField['label'])) {
             $label = is_array($newField['name']) ? $newField['name'][0] : $newField['name'];
             $newField['label'] = mb_ucfirst(str_replace('_', ' ', $label));
         }
 
         // if the field type is missing, we should set it
-        if (! isset($newField['type'])) {
+        if (!isset($newField['type'])) {
             $newField['type'] = $this->getFieldTypeFromDbColumnType($newField['name']);
         }
 
         // if a tab was mentioned, we should enable it
         if (isset($newField['tab'])) {
-            if (! $this->tabsEnabled()) {
+            if (!$this->tabsEnabled()) {
                 $this->enableTabs();
             }
         }
@@ -88,7 +88,7 @@ 
      */
     public function afterField($targetFieldName)
     {
-        $this->transformFields(function ($fields) use ($targetFieldName) {
+        $this->transformFields(function($fields) use ($targetFieldName) {
             return $this->moveField($fields, $targetFieldName, false);
         });
     }
@@ -100,7 +100,7 @@ 
      */
     public function beforeField($targetFieldName)
     {
-        $this->transformFields(function ($fields) use ($targetFieldName) {
+        $this->transformFields(function($fields) use ($targetFieldName) {
             return $this->moveField($fields, $targetFieldName, true);
         });
     }
@@ -142,7 +142,7 @@ 
      */
     public function removeField($name)
     {
-        $this->transformFields(function ($fields) use ($name) {
+        $this->transformFields(function($fields) use ($name) {
             array_forget($fields, $name);
 
             return $fields;
@@ -156,7 +156,7 @@ 
      */
     public function removeFields($array_of_names)
     {
-        if (! empty($array_of_names)) {
+        if (!empty($array_of_names)) {
             foreach ($array_of_names as $name) {
                 $this->removeField($name);
             }
@@ -169,7 +169,7 @@ 
     public function removeAllFields()
     {
         $current_fields = $this->getCurrentFields();
-        if (! empty($current_fields)) {
+        if (!empty($current_fields)) {
             foreach ($current_fields as $field) {
                 $this->removeField($field['name']);
             }
@@ -243,7 +243,7 @@ 
                 $jsonCastables = ['array', 'object', 'json'];
                 $fieldCasting = $casted_attributes[$field['name']];
 
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
                     try {
                         $data[$field['name']] = json_decode($data[$field['name']]);
                     } catch (\Exception $e) {
@@ -272,7 +272,7 @@ 
      */
     public function orderFields($order)
     {
-        $this->transformFields(function ($fields) use ($order) {
+        $this->transformFields(function($fields) use ($order) {
             return $this->applyOrderToFields($fields, $order);
         });
     }
@@ -335,7 +335,7 @@ 
     public function hasUploadFields()
     {
         $fields = $this->getFields();
-        $upload_fields = array_where($fields, function ($value, $key) {
+        $upload_fields = array_where($fields, function($value, $key) {
             return isset($value['upload']) && $value['upload'] == true;
         });
 
@@ -395,7 +395,7 @@ 
         $alreadyLoaded = $this->getLoadedFieldTypes();
         $type = $this->getFieldTypeWithNamespace($field);
 
-        if (! in_array($type, $this->getLoadedFieldTypes(), true)) {
+        if (!in_array($type, $this->getLoadedFieldTypes(), true)) {
             $alreadyLoaded[] = $type;
             $this->setLoadedFieldTypes($alreadyLoaded);
 
@@ -436,7 +436,7 @@ 
      */
     public function fieldTypeNotLoaded($field)
     {
-        return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
+        return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
     }
 
     /**

src/app/Console/Commands/Install.php

Doc Comments +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
     /**
      * Execute the console command.
      *
-     * @return mixed Command-line output
+     * @return false|null Command-line output
      */
     public function handle()
     {

Spacing +3 added lines, -3 removed lines

@@ -88,7 +88,7 @@ 
                     $createUploadDirectoryCommand = 'mkdir -p public/uploads';
                     break;
                 case '\\': // windows
-                    if (! file_exists('public\uploads')) {
+                    if (!file_exists('public\uploads')) {
                         $createUploadDirectoryCommand = 'mkdir public\uploads';
                     }
                     break;
@@ -133,7 +133,7 @@ 
         $this->echo('info', $beforeNotice ? ' '.$beforeNotice : $command);
 
         $process = new Process($command, null, null, null, $this->option('timeout'));
-        $process->run(function ($type, $buffer) {
+        $process->run(function($type, $buffer) {
             if (Process::ERR === $type) {
                 $this->echo('comment', $buffer);
             } else {
@@ -142,7 +142,7 @@ 
         });
 
         // executes after the command finishes
-        if (! $process->isSuccessful()) {
+        if (!$process->isSuccessful()) {
             throw new ProcessFailedException($process);
         }
 

src/app/Http/Controllers/Auth/LoginController.php

Doc Comments +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
      *
      * @param \Illuminate\Http\Request $request
      *
-     * @return mixed
+     * @return \Illuminate\Http\RedirectResponse
      */
     protected function loggedOut(Request $request)
     {

src/app/Http/Controllers/Operations/CreateOperation.php

Spacing +2 added lines, -2 removed lines

@@ -41,12 +41,12 @@
     {
         $this->crud->allowAccess('create');
 
-        $this->crud->operation('create', function () {
+        $this->crud->operation('create', function() {
             $this->crud->loadDefaultOperationSettingsFromConfig();
             $this->crud->setupDefaultSaveActions();
         });
 
-        $this->crud->operation('list', function () {
+        $this->crud->operation('list', function() {
             $this->crud->addButton('top', 'create', 'view', 'crud::buttons.create');
         });
     }

src/app/Models/Traits/HasIdentifiableAttribute.php

Spacing +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
         // we get the first column from database
         // that is NOT indexed (usually primary, foreign keys)
         foreach ($columns as $columnName => $columnProperties) {
-            if (! in_array($columnName, $indexedColumns)) {
+            if (!in_array($columnName, $indexedColumns)) {
 
                 //check for convention "field<_id>" in case developer didn't add foreign key constraints.
                 if (strpos($columnName, '_id') !== false) {

src/app/Http/Controllers/Operations/FetchOperation.php

Spacing +2 added lines, -2 removed lines

@@ -45,8 +45,8 @@
         // otherwise assume the arguments are actually the configuration array
         $config = [];
 
-        if (! is_array($arg)) {
-            if (! class_exists($arg)) {
+        if (!is_array($arg)) {
+            if (!class_exists($arg)) {
                 return response()->json(['error' => 'Class: '.$arg.' does not exists'], 500);
             }
             $config['model'] = $arg;

src/app/Library/CrudPanel/Traits/SaveActions.php

Spacing +15 added lines, -16 removed lines

@@ -46,7 +46,7 @@ 
      */
     public function getSaveActionByOrder($order)
     {
-        return array_filter($this->getOperationSetting('save_actions'), function ($arr) use ($order) {
+        return array_filter($this->getOperationSetting('save_actions'), function($arr) use ($order) {
             return $arr['order'] == $order;
         });
     }
@@ -80,7 +80,7 @@ 
         $orderCounter = $this->getOperationSetting('save_actions') !== null ? (count($this->getOperationSetting('save_actions')) + 1) : 1;
         //check for some mandatory fields
         $saveAction['name'] ?? abort(500, 'Please define save action name.');
-        $saveAction['redirect'] = $saveAction['redirect'] ?? function ($crud, $request, $itemId) {
+        $saveAction['redirect'] = $saveAction['redirect'] ?? function($crud, $request, $itemId) {
             return $request->has('http_referrer') ? $request->get('http_referrer') : $crud->route;
         };
         $saveAction['visible'] = $saveAction['visible'] ?? true;
@@ -89,7 +89,7 @@ 
 
         $actions = $this->getOperationSetting('save_actions') ?? [];
 
-        if (! in_array($saveAction['name'], $actions)) {
+        if (!in_array($saveAction['name'], $actions)) {
             $actions[$saveAction['name']] = $saveAction;
         }
 
@@ -106,7 +106,7 @@ 
     public function orderSaveAction(string $saveAction, int $wantedOrder)
     {
         $actions = $this->getOperationSetting('save_actions') ?? [];
-        if (! empty($actions)) {
+        if (!empty($actions)) {
             $replaceOrder = isset($actions[$saveAction]) ? $actions[$saveAction]['order'] : count($actions) + 1;
 
             foreach ($actions as $key => $sv) {
@@ -197,7 +197,7 @@ 
     public function orderSaveActions(array $saveActions)
     {
         foreach ($saveActions as $sv => $order) {
-            if (! is_int($order)) {
+            if (!is_int($order)) {
                 $this->orderSaveAction($order, $sv + 1);
             } else {
                 $this->orderSaveAction($sv, $order);
@@ -214,7 +214,7 @@ 
     {
         $actions = $this->getOperationSetting('save_actions') ?? [];
 
-        uasort($actions, function ($a, $b) {
+        uasort($actions, function($a, $b) {
             return $a['order'] <=> $b['order'];
         });
 
@@ -236,7 +236,7 @@ 
             }
         }
 
-        return array_filter($actions, function ($action) {
+        return array_filter($actions, function($action) {
             return $action['visible'] == true;
         }, ARRAY_FILTER_USE_BOTH);
     }
@@ -300,8 +300,7 @@ 
      */
     public function setSaveAction($forceSaveAction = null)
     {
-        $saveAction = $forceSaveAction ?:
-            \Request::input('save_action', $this->getFallBackSaveAction());
+        $saveAction = $forceSaveAction ?: \Request::input('save_action', $this->getFallBackSaveAction());
 
         $showBubble = $this->getOperationSetting('showSaveActionChange') ?? config('backpack.crud.operations.'.$this->getCurrentOperation().'.showSaveActionChange') ?? true;
 
@@ -369,20 +368,20 @@ 
         $defaultSaveActions = [
             [
                 'name' => 'save_and_back',
-                'visible' => function ($crud) {
+                'visible' => function($crud) {
                     return $crud->hasAccess('list');
                 },
-                'redirect' => function ($crud, $request, $itemId = null) {
+                'redirect' => function($crud, $request, $itemId = null) {
                     return $request->has('http_referrer') ? $request->get('http_referrer') : $crud->route;
                 },
                 'button_text' => trans('backpack::crud.save_action_save_and_back'),
             ],
             [
                 'name' => 'save_and_edit',
-                'visible' => function ($crud) {
+                'visible' => function($crud) {
                     return $crud->hasAccess('update');
                 },
-                'redirect' => function ($crud, $request, $itemId = null) {
+                'redirect' => function($crud, $request, $itemId = null) {
                     $itemId = $itemId ?: $request->input('id');
                     $redirectUrl = $crud->route.'/'.$itemId.'/edit';
                     if ($request->has('locale')) {
@@ -394,17 +393,17 @@ 
 
                     return $redirectUrl;
                 },
-                'referrer_url' => function ($crud, $request, $itemId) {
+                'referrer_url' => function($crud, $request, $itemId) {
                     return url($crud->route.'/'.$itemId.'/edit');
                 },
                 'button_text' => trans('backpack::crud.save_action_save_and_edit'),
             ],
             [
                 'name' => 'save_and_new',
-                'visible' => function ($crud) {
+                'visible' => function($crud) {
                     return $crud->hasAccess('create');
                 },
-                'redirect' => function ($crud, $request, $itemId = null) {
+                'redirect' => function($crud, $request, $itemId = null) {
                     return $this->route.'/create';
                 },
                 'button_text' => trans('backpack::crud.save_action_save_and_new'),

Doc Comments +2 added lines, -3 removed lines

@@ -155,7 +155,7 @@ 
     /**
      * Allow the developer to remove multiple save actions from settings.
      *
-     * @param array $saveActions
+     * @param string[] $saveActions
      * @return void
      */
     public function removeSaveActions(array $saveActions)
@@ -183,7 +183,6 @@ 
     /**
      * Allow the developer to unset all save actions.
      *
-     * @param string $saveAction
      * @return void
      */
     public function removeAllSaveActions()
@@ -194,7 +193,7 @@ 
     /**
      * Allows the developer to set save actions order. It could be ['action1','action2'] or ['action1' => 1, 'action2' => 2].
      *
-     * @param array $saveActions
+     * @param string[] $saveActions
      * @return void
      */
     public function orderSaveActions(array $saveActions)

src/resources/views/crud/columns/select_from_array.blade.php

Spacing +1 added lines, -1 removed lines

@@ -10,7 +10,7 @@
                 $array_of_values = [];
 
                 foreach ($values as $key => $value) {
-                    if (! is_null($value)) {
+                    if (!is_null($value)) {
                         $array_of_values[] = $column['options'][$value] ?? $value;
                     } else {
                         echo '-';

src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php

Spacing +7 added lines, -8 removed lines

@@ -50,7 +50,7 @@ 
 
         // make sure the column has a priority in terms of visibility
         // if no priority has been defined, use the order in the array plus one
-        if (! array_key_exists('priority', $column)) {
+        if (!array_key_exists('priority', $column)) {
             $position_in_columns_array = (int) array_search($column['key'], array_keys($this->columns()));
             $allColumns[$column['key']]['priority'] = $position_in_columns_array + 1;
         }
@@ -71,7 +71,7 @@ 
             $column = ['name' => $column];
         }
 
-        if (is_array($column) && ! isset($column['name'])) {
+        if (is_array($column) && !isset($column['name'])) {
             $column['name'] = 'anonymous_column_'.Str::random(5);
         }
 
@@ -87,7 +87,7 @@ 
      */
     protected function makeSureColumnHasLabel($column)
     {
-        if (! isset($column['label'])) {
+        if (!isset($column['label'])) {
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
         }
 
@@ -102,7 +102,7 @@ 
      */
     protected function makeSureColumnHasType($column)
     {
-        if (! isset($column['type'])) {
+        if (!isset($column['type'])) {
             $column['type'] = 'text';
         }
 
@@ -119,7 +119,7 @@ 
      */
     protected function makeSureColumnHasKey($column)
     {
-        if (! isset($column['key'])) {
+        if (!isset($column['key'])) {
             $column['key'] = str_replace('.', '__', $column['name']);
         }
 
@@ -137,7 +137,7 @@ 
     {
         // if this is a relation type field and no corresponding model was specified,
         // get it from the relation method defined in the main model
-        if (isset($column['entity']) && ! isset($column['model'])) {
+        if (isset($column['entity']) && !isset($column['model'])) {
             $column['model'] = $this->getRelationModel($column['entity']);
         }
 
@@ -158,8 +158,7 @@ 
         $columnsArray = $this->columns();
 
         if (array_key_exists($targetColumnName, $columnsArray)) {
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
 
             $element = array_pop($columnsArray);
             $beginningPart = array_slice($columnsArray, 0, $targetColumnPosition, true);