Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#710)
by Cristian
07:14
created
src/CrudServiceProvider.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD;
4 4
 
5
-use Route;
6 5
 use Illuminate\Support\ServiceProvider;
7 6
 
8 7
 class CrudServiceProvider extends ServiceProvider
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
      */
75 75
     public function register()
76 76
     {
77
-        $this->app->bind('CRUD', function ($app) {
77
+        $this->app->bind('CRUD', function($app) {
78 78
             return new CRUD($app);
79 79
         });
80 80
 
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
         $loader->alias('Image', \Intervention\Image\Facades\Image::class);
93 93
 
94 94
         // map the elfinder prefix
95
-        if (! \Config::get('elfinder.route.prefix')) {
95
+        if (!\Config::get('elfinder.route.prefix')) {
96 96
             \Config::set('elfinder.route.prefix', \Config::get('backpack.base.route_prefix').'/elfinder');
97 97
         }
98 98
     }
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
     {
113 113
         $crudPubPath = public_path('vendor/backpack/crud');
114 114
 
115
-        if (! is_dir($crudPubPath)) {
115
+        if (!is_dir($crudPubPath)) {
116 116
             return true;
117 117
         }
118 118
 
Please login to merge, or discard this patch.
src/resources/views/fields/checklist_dependency.blade.php 2 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -23,13 +23,13 @@
 block discarded – undo
23 23
             }
24 24
         }
25 25
 
26
-      //for update form, get initial state of the entity
27
-      if( isset($id) && $id ){
26
+        //for update form, get initial state of the entity
27
+        if( isset($id) && $id ){
28 28
 
29 29
         //get entity with relations for primary dependency
30 30
         $entity_dependencies = $entity_model->with($primary_dependency['entity'])
31
-          ->with($primary_dependency['entity'].'.'.$primary_dependency['entity_secondary'])
32
-          ->find($id);
31
+            ->with($primary_dependency['entity'].'.'.$primary_dependency['entity_secondary'])
32
+            ->find($id);
33 33
 
34 34
             $secondaries_from_primary = [];
35 35
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
         }
25 25
 
26 26
       //for update form, get initial state of the entity
27
-      if( isset($id) && $id ){
27
+      if (isset($id) && $id) {
28 28
 
29 29
         //get entity with relations for primary dependency
30 30
         $entity_dependencies = $entity_model->with($primary_dependency['entity'])
Please login to merge, or discard this patch.
src/PanelTraits/Fields.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -24,18 +24,18 @@  discard block
 block discarded – undo
24 24
         }
25 25
 
26 26
         // if the label is missing, we should set it
27
-        if (! isset($complete_field_array['label'])) {
27
+        if (!isset($complete_field_array['label'])) {
28 28
             $complete_field_array['label'] = ucfirst($complete_field_array['name']);
29 29
         }
30 30
 
31 31
         // if the field type is missing, we should set it
32
-        if (! isset($complete_field_array['type'])) {
32
+        if (!isset($complete_field_array['type'])) {
33 33
             $complete_field_array['type'] = $this->getFieldTypeFromDbColumnType($complete_field_array['name']);
34 34
         }
35 35
 
36 36
         // if a tab was mentioned, we should enable it
37 37
         if (isset($complete_field_array['tab'])) {
38
-            if (! $this->tabsEnabled()) {
38
+            if (!$this->tabsEnabled()) {
39 39
                 $this->enableTabs();
40 40
             }
41 41
         }
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
      */
147 147
     public function removeFields($array_of_names, $form = 'both')
148 148
     {
149
-        if (! empty($array_of_names)) {
149
+        if (!empty($array_of_names)) {
150 150
             foreach ($array_of_names as $name) {
151 151
                 $this->removeField($name, $form);
152 152
             }
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
                 $jsonCastables = ['array', 'object', 'json'];
209 209
                 $fieldCasting = $casted_attributes[$field['name']];
210 210
 
211
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
211
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
212 212
                     try {
213 213
                         $data[$field['name']] = json_decode($data[$field['name']]);
214 214
                     } catch (Exception $e) {
Please login to merge, or discard this patch.
src/PanelTraits/Tabs.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 
30 30
     public function tabsDisabled()
31 31
     {
32
-        return ! $this->tabsEnabled;
32
+        return !$this->tabsEnabled;
33 33
     }
34 34
 
35 35
     public function setTabsType($type)
@@ -92,13 +92,13 @@  discard block
 block discarded – undo
92 92
         if ($this->tabExists($label)) {
93 93
             $all_fields = $this->getCurrentFields();
94 94
 
95
-            $fields_for_current_tab = collect($all_fields)->filter(function ($value, $key) use ($label) {
95
+            $fields_for_current_tab = collect($all_fields)->filter(function($value, $key) use ($label) {
96 96
                 return isset($value['tab']) && $value['tab'] == $label;
97 97
             });
98 98
 
99 99
             if ($this->isLastTab($label)) {
100
-                $fields_without_a_tab = collect($all_fields)->filter(function ($value, $key) {
101
-                    return ! isset($value['tab']);
100
+                $fields_without_a_tab = collect($all_fields)->filter(function($value, $key) {
101
+                    return !isset($value['tab']);
102 102
                 });
103 103
 
104 104
                 $fields_for_current_tab = $fields_for_current_tab->merge($fields_without_a_tab);
@@ -116,11 +116,11 @@  discard block
 block discarded – undo
116 116
         $fields = $this->getCurrentFields();
117 117
 
118 118
         $fields_with_tabs = collect($fields)
119
-            ->filter(function ($value, $key) {
119
+            ->filter(function($value, $key) {
120 120
                 return isset($value['tab']);
121 121
             })
122
-            ->each(function ($value, $key) use (&$tabs) {
123
-                if (! in_array($value['tab'], $tabs)) {
122
+            ->each(function($value, $key) use (&$tabs) {
123
+                if (!in_array($value['tab'], $tabs)) {
124 124
                     $tabs[] = $value['tab'];
125 125
                 }
126 126
             });
Please login to merge, or discard this patch.
src/PanelTraits/Read.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
      * Get all entries from the database with conditions.
62 62
      *
63 63
      * @param string $length the number of records requested
64
-     * @param string $skip how many to skip
64
+     * @param integer $skip how many to skip
65 65
      * @param string $orderBy the column to order by
66 66
      * @param string $orderDirection how to order asc/desc
67 67
      * @param string $filter what string to filter the name by
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
      */
20 20
     public function getEntry($id)
21 21
     {
22
-        if (! $this->entry) {
22
+        if (!$this->entry) {
23 23
             $this->entry = $this->model->findOrFail($id);
24 24
             $this->entry = $this->entry->withFakes();
25 25
         }
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
 
82 82
         if ($filter !== null) {
83 83
             $modifiers = 1;
84
-            $entries = $this->query->where(function ($query) use ($filter) {
84
+            $entries = $this->query->where(function($query) use ($filter) {
85 85
                 foreach ($this->columns as $column) {
86 86
                     if ($this->getColumnQuery($column) !== null) {
87 87
                         $query->orWhere(
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
     public function hasUploadFields($form, $id = false)
173 173
     {
174 174
         $fields = $this->getFields($form, $id);
175
-        $upload_fields = array_where($fields, function ($value, $key) {
175
+        $upload_fields = array_where($fields, function($value, $key) {
176 176
             return isset($value['upload']) && $value['upload'] == true;
177 177
         });
178 178
 
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
270 270
      */
271 271
     public function getCellView($column, $entry)
272 272
     {
273
-        if (! isset($column['type'])) {
273
+        if (!isset($column['type'])) {
274 274
             return \View::make('crud::columns.text')->with('crud', $this)->with('column', $column)->with('entry',
275 275
                 $entry)->render();
276 276
         } else {
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudFeatures/AjaxTable.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -63,9 +63,9 @@
 block discarded – undo
63 63
         // add the details_row buttons as the first column
64 64
         if ($this->crud->details_row) {
65 65
             array_unshift($row_items, \View::make('crud::columns.details_row_button')
66
-                                           ->with('crud', $this->crud)
67
-                                           ->with('entry', $entry)
68
-                                           ->render());
66
+                                            ->with('crud', $this->crud)
67
+                                            ->with('entry', $entry)
68
+                                            ->render());
69 69
         }
70 70
 
71 71
         return $row_items;
Please login to merge, or discard this patch.