Read::getEntriesWithConditions() - Code Metrics - Inspection of "Fix all DataTables bugs and known issues" - Laravel-Backpack/CRUD - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#710)

by Cristian

created 2017-05-31 09:18 UTC

Read::getEntriesWithConditions() C

↳ Parent: Read

Complexity

Conditions	8
Paths	32

Size

Total Lines	47
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	8
eloc	29
c	0
b	0
f	0
nc	32
nop	5
dl	0
loc	47
rs	5.7377

<?php

namespace Backpack\CRUD\PanelTraits;

trait Read
{
    /*
    |--------------------------------------------------------------------------
    |                                   READ
    |--------------------------------------------------------------------------
    */

    /**
     * Find and retrieve an entry in the database or fail.
     *
     * @param  [int] The id of the row in the db to fetch.
     *
     * @return [Eloquent Collection] The row in the db.

     */
    public function getEntry($id)

    {
        if (! $this->entry) {
            $this->entry = $this->model->findOrFail($id);
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $this->entry = $this->entry->withFakes();
        }

        return $this->entry;
    }

    /**
     * Make the query JOIN all relationships used in the columns, too,
     * so there will be less database queries overall.
     */
    public function autoEagerLoadRelationshipColumns()
    {
        $relationships = $this->getColumnsRelationships();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        if (count($relationships)) {
            $this->with($relationships);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
    }

    /**
     * Get all entries from the database.
     *
     * @return [Collection of your model]

     */
    public function getEntries()

    {
        $this->autoEagerLoadRelationshipColumns();

        $entries = $this->query->get();
class MyClass { }

$x = new MyClass();
$x->foo = true;

        // add the fake columns for each entry
        foreach ($entries as $key => $entry) {
            $entry->addFakes($this->getFakeColumnsAsArray());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }

        return $entries;
    }

    /**
     * Get all entries from the database with conditions.
     *
     * @param string $length the number of records requested

     * @param string $skip how many to skip

     * @param string $orderBy the column to order by

     * @param string $orderDirection how to order asc/desc
     * @param string $filter what string to filter the name by

     *
     * @return [Collection of your model]

     */
    public function getEntriesWithConditions(

        $length = null,
        $skip = 0,
        $orderBy = null,
        $orderDirection = 'asc',
        $filter = null
    ) {
        $modifiers = 0;

        if ($filter !== null) {
            $modifiers = 1;
            $entries = $this->query->where(function ($query) use ($filter) {
                foreach ($this->columns as $column) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
                    if ($this->getColumnQuery($column) !== null) {
                        $query->orWhere(
                            $this->getColumnQuery($column),
                            'like',
                            '%'.$filter.'%'
                        );
                    }
                }
            });
        }

        if ($length !== null) {
            $modifiers = 1;
            $entries = $this->query->skip($skip)->take($length);
        }

        if ($orderBy !== null) {
            $modifiers = 1;
            $entries = $this->query->orderBy($orderBy, $orderDirection);
        }

        if ($modifiers == 0) {
            $entries = $this->query->get();
        } else {
            $entries = $entries->get();
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        }

        // add the fake columns for each entry
        foreach ($entries as $key => $entry) {
            $entry->addFakes($this->getFakeColumnsAsArray());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }

        return $entries;
    }

    /**
     * Receives a filter and tries to get all the columns to be filtered by that filter *Work in progress*.
     *
     * @param $column
     * @return null|string
     */
    private function getColumnQuery($column)
    {
        if (isset($column['type']) && $column['type'] == 'model_function') {
            return;
        }

        if (is_array($column)) {
            return $column['name'];
        }

        return Model::resolveConnection()->getQueryGrammar()->wrap($column);
    }

    /**
     * Get the fields for the create or update forms.
     *
     * @param  [form] create / update / both - defaults to 'both'
     * @param  [integer] the ID of the entity to be edited in the Update form
     *
     * @return [array] all the fields that need to be shown and their information

     */
    public function getFields($form, $id = false)

    {
        switch (strtolower($form)) {
            case 'create':
                return $this->getCreateFields();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

            case 'update':
                return $this->getUpdateFields($id);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

            default:
                return $this->getCreateFields();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        }
    }

    /**
     * Check if the create/update form has upload fields.
     * Upload fields are the ones that have "upload" => true defined on them.
     * @param  [form] create / update / both - defaults to 'both'
     * @param  [id] id of the entity - defaults to false
     * @return bool
     */
    public function hasUploadFields($form, $id = false)
    {
        $fields = $this->getFields($form, $id);
        $upload_fields = array_where($fields, function ($value, $key) {

            return isset($value['upload']) && $value['upload'] == true;
        });

        return count($upload_fields) ? true : false;
    }

    /**
     * Enable the DETAILS ROW functionality:.
     *
     * In the table view, show a plus sign next to each entry.
     * When clicking that plus sign, an AJAX call will bring whatever content you want from the EntityCrudController::showDetailsRow($id) and show it to the user.

     */
    public function enableDetailsRow()
    {
        $this->details_row = true;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Disable the DETAILS ROW functionality:.
     */
    public function disableDetailsRow()
    {
        $this->details_row = false;
    }

    /**
     * Set the number of rows that should be show on the table page (list view).
     */
    public function setDefaultPageLength($value)
    {
        $this->default_page_length = $value;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Get the number of rows that should be show on the table page (list view).
     */
    public function getDefaultPageLength()

    {
        // return the custom value for this crud panel, if set using setPageLength()
        if ($this->default_page_length) {
            return $this->default_page_length;
        }

        // otherwise return the default value in the config file
        if (config('backpack.crud.default_page_length')) {
            return config('backpack.crud.default_page_length');
        }

        return 25;
    }

    /*
    |--------------------------------------------------------------------------
    |                                AJAX TABLE
    |--------------------------------------------------------------------------
    */

    /**
     * Tell the list view to use AJAX for loading multiple rows.
     */
    public function enableAjaxTable()
    {
        $this->ajax_table = true;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Check if ajax is enabled for the table view.
     * @return bool
     */
    public function ajaxTable()
    {
        return $this->ajax_table;
    }

    /**
     * Get the HTML of the cells in a table row, for a certain DB entry.
     * @param  Entity $entry A db entry of the current entity;
     * @return array         Array of HTML cell contents.
     */
    public function getRowViews($entry)
    {
        $response = [];
        foreach ($this->columns as $key => $column) {
            $response[] = $this->getCellView($column, $entry);
        }

        return $response;
    }

    /**
     * Get the HTML of a cell, using the column types.
     * @param  array $column
     * @param  Entity $entry A db entry of the current entity;
     * @return HTML
     */
    public function getCellView($column, $entry)
    {
        if (! isset($column['type'])) {
            return \View::make('crud::columns.text')->with('crud', $this)->with('column', $column)->with('entry',
                $entry)->render();
        } else {
            if (view()->exists('vendor.backpack.crud.columns.'.$column['type'])) {
                return \View::make('vendor.backpack.crud.columns.'.$column['type'])->with('crud',
                    $this)->with('column', $column)->with('entry', $entry)->render();
            } else {
                if (view()->exists('crud::columns.'.$column['type'])) {
                    return \View::make('crud::columns.'.$column['type'])->with('crud', $this)->with('column',
                        $column)->with('entry', $entry)->render();
                } else {
                    return \View::make('crud::columns.text')->with('crud', $this)->with('column',
                        $column)->with('entry', $entry)->render();
                }
            }
        }
    }

    /*
    |--------------------------------------------------------------------------
    |                                EXPORT BUTTONS
    |--------------------------------------------------------------------------
    */

    /**
     * Tell the list view to show the DataTables export buttons.
     */
    public function enableExportButtons()
    {
        $this->export_buttons = true;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Check if export buttons are enabled for the table view.
     * @return bool
     */
    public function exportButtons()
    {
        return $this->export_buttons;
    }
}


Scrutinizer GitHub App not installed

Pull Request — master (#710)

Read::getEntriesWithConditions() C

Complexity

Size

Duplication

Importance

Available Fixes

1			<?php
2
3			namespace Backpack\CRUD\PanelTraits;
4
5			trait Read
6			{
7			/*
8			\|--------------------------------------------------------------------------
9			\| READ
10			\|--------------------------------------------------------------------------
11			*/
12
13			/**
14			* Find and retrieve an entry in the database or fail.
15			*
16			* @param [int] The id of the row in the db to fetch.
17			*
18			* @return [Eloquent Collection] The row in the db.
			0 ignored issues – show Documentation introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report The doc-type `Eloquent">[Eloquent` could not be parsed: Unknown type name "[" at position 0. [(view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
19			*/
20			public function getEntry($id)
			0 ignored issues – show Documentation introduced 2017-04-18 10:54 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
21			{
22			if (! $this->entry) {
23			$this->entry = $this->model->findOrFail($id);
			0 ignored issues – show Bug introduced 2017-02-13 15:30 UTC by Report Bug Copy Issue Report The property `entry` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2016-06-16 14:52 UTC by Report Bug Copy Issue Report The property `model` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24			$this->entry = $this->entry->withFakes();
25			}
26
27			return $this->entry;
28			}
29
30			/**
31			* Make the query JOIN all relationships used in the columns, too,
32			* so there will be less database queries overall.
33			*/
34			public function autoEagerLoadRelationshipColumns()
35			{
36			$relationships = $this->getColumnsRelationships();
			0 ignored issues – show Bug introduced 2017-04-18 11:15 UTC by Report Bug Copy Issue Report It seems like `getColumnsRelationships()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...

Laravel-Backpack / CRUD

Scrutinizer GitHub App not installed

Pull Request — master (#710)

Read::getEntriesWithConditions() C

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like