Tabs - Code Metrics - Inspection of "[Feature] Added the ability to add bootstrap tabs..." - Laravel-Backpack/CRUD - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#289)

by Cristian

created 2016-12-08 20:32 UTC

Tabs A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	104
Duplicated Lines	21.15 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	2
Bugs	1	Features	1

Metric	Value
c	2
b	1
f	1
dl	22
loc	104
rs	10
wmc	12
lcom	1
cbo	0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	initTabs()	0	7	2
A	enableVerticalTabs()	0	6	1
A	disableVerticalTabs()	0	6	1
A	enableHorizontalTabs()	0	6	1
A	disableHorizontalTabs()	0	6	1
A	clearTabs()	0	6	1
A	getTabs()	0	6	1
A	addTab()	0	15	1
A	removeTab()	0	10	1
A	getCreateTabs()	10	10	1
A	getUpdateTabs()	10	10	1

How to fix Duplicated Code

<?php

namespace Backpack\CRUD\PanelTraits;

trait Tabs
{
    public $tabs = [];
    public $tabsHorizontal = true;

    private function initTabs()
    {
        if (is_array($this->tabs)) {
            $this->tabs = collect([]);

            $this->tabsHorizontal = config('backpack.crud.tabs_horizontal', true);
        }
    }

    public function enableVerticalTabs()
    {
        $this->tabsHorizontal = false;

        return $this->tabsHorizontal;
    }

    public function disableVerticalTabs()
    {
        $this->tabsHorizontal = true;

        return $this->tabsHorizontal;
    }

    public function enableHorizontalTabs()
    {
        $this->tabsHorizontal = true;

        return $this->tabsHorizontal;
    }

    public function disableHorizontalTabs()
    {
        $this->tabsHorizontal = false;

        return $this->tabsHorizontal;
    }

    public function clearTabs()
    {
        $this->tabs = collect([]);


        return $this->tabs;
    }

    public function getTabs()

    {
        $this->initTabs();

        return $this->tabs;
    }

    public function addTab($label)

    {
        $this->initTabs();

        $newTab = (object) [
            'label' => $label,
            'name'  =>  snake_case($label),
            'fields' => collect([]),
            'horizontal' => $this->tabsHorizontal,
        ];

        $this->tabs->push($newTab);

        return $newTab;
    }

    public function removeTab($label)

    {
        $this->initTabs();

        $this->tabs = $this->tabs->reject(function ($tab) use ($label) {
            return $tab->label == $label;
        });

        return $this->tabs;
    }

    public function getCreateTabs()

    {
        return $this->tabs->filter(function (&$tab) {
            $tab->fields = $tab->fields->reject(function ($field) {
                return $field['method'] == 'update';
            });

            return $tab->fields->count();
        });
    }

    public function getUpdateTabs()

    {
        return $this->tabs->filter(function (&$tab) {
            $tab->fields = $tab->fields->reject(function ($field) {
                return $field['method'] == 'create';
            });

            return $tab->fields->count();
        });
    }
}


1		<?php
2
3		namespace Backpack\CRUD\PanelTraits;
4
5		trait Tabs
6		{
7		public $tabs = [];
8		public $tabsHorizontal = true;
9
10		private function initTabs()
11		{
12		if (is_array($this->tabs)) {
13		$this->tabs = collect([]);
		0 ignored issues – show Documentation Bug introduced 2016-12-05 17:31 UTC by Report Bug Copy Issue Report It seems like `collect(array())` of type `object<Illuminate\Support\Collection>` is incompatible with the declared type `array` of property `$tabs`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
14		$this->tabsHorizontal = config('backpack.crud.tabs_horizontal', true);
15		}
16		}
17
18		public function enableVerticalTabs()
19		{
20		$this->tabsHorizontal = false;
21
22		return $this->tabsHorizontal;
23		}
24
25		public function disableVerticalTabs()
26		{
27		$this->tabsHorizontal = true;
28
29		return $this->tabsHorizontal;
30		}
31
32		public function enableHorizontalTabs()
33		{
34		$this->tabsHorizontal = true;
35
36		return $this->tabsHorizontal;
37		}
38
39		public function disableHorizontalTabs()
40		{
41		$this->tabsHorizontal = false;
42
43		return $this->tabsHorizontal;
44		}
45
46		public function clearTabs()
47		{
48		$this->tabs = collect([]);
		0 ignored issues – show Documentation Bug introduced 2016-12-05 17:31 UTC by Report Bug Copy Issue Report It seems like `collect(array())` of type `object<Illuminate\Support\Collection>` is incompatible with the declared type `array` of property `$tabs`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
49
50		return $this->tabs;
51		}
52
53		public function getTabs()
		0 ignored issues – show Documentation introduced 2016-12-05 17:31 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
54		{
55		$this->initTabs();
56
57		return $this->tabs;
58		}
59
60		public function addTab($label)
		0 ignored issues – show Documentation introduced 2016-12-05 17:31 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
61		{
62		$this->initTabs();
63
64		$newTab = (object) [
65		'label' => $label,
66		'name' => snake_case($label),
67		'fields' => collect([]),
68		'horizontal' => $this->tabsHorizontal,
69		];
70
71		$this->tabs->push($newTab);
72
73		return $newTab;
74		}
75
76		public function removeTab($label)
		0 ignored issues – show Documentation introduced 2016-12-05 17:31 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
77		{
78		$this->initTabs();
79
80		$this->tabs = $this->tabs->reject(function ($tab) use ($label) {
81		return $tab->label == $label;
82		});
83
84		return $this->tabs;
85		}
86
87	View Code Duplication	public function getCreateTabs()
		0 ignored issues – show Documentation introduced 2016-12-08 20:34 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history... Duplication introduced 2016-12-08 20:34 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
88		{
89		return $this->tabs->filter(function (&$tab) {
90		$tab->fields = $tab->fields->reject(function ($field) {
91		return $field['method'] == 'update';
92		});
93
94		return $tab->fields->count();
95		});
96		}
97
98	View Code Duplication	public function getUpdateTabs()
		0 ignored issues – show Documentation introduced 2016-12-08 20:34 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history... Duplication introduced 2016-12-08 20:34 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
99		{
100		return $this->tabs->filter(function (&$tab) {
101		$tab->fields = $tab->fields->reject(function ($field) {
102		return $field['method'] == 'create';
103		});
104
105		return $tab->fields->count();
106		});
107		}
108		}
109

Laravel-Backpack / CRUD

Scrutinizer GitHub App not installed

Pull Request — master (#289)

Tabs A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

11 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like