Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Setup Failed
Pull Request — master (#2940)
by Cristian
14:45
created
src/app/Console/Commands/AddCustomRouteContent.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 
84 84
         // otherwise, in case the last line HAS been modified
85 85
         // return the last line that has an ending in it
86
-        $possible_end_lines = array_filter($file_lines, function ($k) {
86
+        $possible_end_lines = array_filter($file_lines, function($k) {
87 87
             return strpos($k, '});') === 0;
88 88
         });
89 89
 
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
      */
105 105
     private function getLastLineNumberThatContains($needle, $haystack)
106 106
     {
107
-        $matchingLines = array_filter($haystack, function ($k) use ($needle) {
107
+        $matchingLines = array_filter($haystack, function($k) use ($needle) {
108 108
             return strpos($k, $needle) !== false;
109 109
         });
110 110
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Relationships.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
         $relation_model = $this->getRelationModel($relation_field['entity'], -1);
56 56
         $related_method = Str::afterLast($relation_field['entity'], '.');
57 57
 
58
-        if (! method_exists($relation_model, $related_method)) {
58
+        if (!method_exists($relation_model, $related_method)) {
59 59
             return Str::beforeLast($relation_field['entity'], '.');
60 60
         }
61 61
 
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
194 194
         return collect($this->fields())
195 195
             ->where('model')
196 196
             ->whereIn('relation_type', $relation_types)
197
-            ->filter(function ($item) {
197
+            ->filter(function($item) {
198 198
                 $related_model = get_class($this->model->{Str::before($item['entity'], '.')}()->getRelated());
199 199
 
200 200
                 return Str::contains($item['entity'], '.') && $item['model'] !== $related_model ? false : true;
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/FieldsProtectedMethods.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
      */
70 70
     public function overwriteFieldNameFromDotNotationToArray($field)
71 71
     {
72
-        if (! is_array($field['name']) && strpos($field['name'], '.') !== false) {
72
+        if (!is_array($field['name']) && strpos($field['name'], '.') !== false) {
73 73
             $entity_array = explode('.', $field['name']);
74 74
             $name_string = '';
75 75
 
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
             return ['name' => $field];
97 97
         }
98 98
 
99
-        if (is_array($field) && ! isset($field['name'])) {
99
+        if (is_array($field) && !isset($field['name'])) {
100 100
             abort(500, 'All fields must have their name defined');
101 101
         }
102 102
 
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
     protected function overwriteFieldNameFromEntity($field)
155 155
     {
156 156
         // if the entity doesn't have a dot, it means we don't need to overwrite the name
157
-        if (! Str::contains($field['entity'], '.')) {
157
+        if (!Str::contains($field['entity'], '.')) {
158 158
             return $field;
159 159
         }
160 160
 
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
         if (count(explode('.', $field['entity'])) == count(explode('.', $this->getOnlyRelationEntity($field)))) {
167 167
             $field['name'] = implode('.', array_slice(explode('.', $field['entity']), 0, -1));
168 168
             $relation = $this->getRelationInstance($field);
169
-            if (! empty($field['name'])) {
169
+            if (!empty($field['name'])) {
170 170
                 $field['name'] .= '.';
171 171
             }
172 172
             $field['name'] .= $relation->getForeignKeyName();
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
     {
180 180
         // if there's a model defined, but no attribute
181 181
         // guess an attribute using the identifiableAttribute functionality in CrudTrait
182
-        if (isset($field['model']) && ! isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
182
+        if (isset($field['model']) && !isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
183 183
             $field['attribute'] = call_user_func([(new $field['model']), 'identifiableAttribute']);
184 184
         }
185 185
 
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
      */
196 196
     protected function makeSureFieldHasLabel($field)
197 197
     {
198
-        if (! isset($field['label'])) {
198
+        if (!isset($field['label'])) {
199 199
             $name = is_array($field['name']) ? $field['name'][0] : $field['name'];
200 200
             $name = str_replace('_id', '', $name);
201 201
             $field['label'] = mb_ucfirst(str_replace('_', ' ', $name));
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
      */
214 214
     protected function makeSureFieldHasType($field)
215 215
     {
216
-        if (! isset($field['type'])) {
216
+        if (!isset($field['type'])) {
217 217
             $field['type'] = isset($field['relation_type']) ? $this->inferFieldTypeFromFieldRelation($field) : $this->inferFieldTypeFromDbColumnType($field['name']);
218 218
         }
219 219
 
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
     {
231 231
         // if a tab was mentioned, we should enable it
232 232
         if (isset($field['tab'])) {
233
-            if (! $this->tabsEnabled()) {
233
+            if (!$this->tabsEnabled()) {
234 234
                 $this->enableTabs();
235 235
             }
236 236
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
     {
86 86
         $all_relation_fields = $this->getRelationFields();
87 87
 
88
-        return Arr::where($all_relation_fields, function ($value, $key) {
88
+        return Arr::where($all_relation_fields, function($value, $key) {
89 89
             return isset($value['pivot']) && $value['pivot'];
90 90
         });
91 91
     }
@@ -164,11 +164,11 @@  discard block
 block discarded – undo
164 164
      */
165 165
     private function createRelationsForItem($item, $formattedData)
166 166
     {
167
-        if (! isset($formattedData['relations'])) {
167
+        if (!isset($formattedData['relations'])) {
168 168
             return false;
169 169
         }
170 170
         foreach ($formattedData['relations'] as $relationMethod => $relationData) {
171
-            if (! isset($relationData['model'])) {
171
+            if (!isset($relationData['model'])) {
172 172
                 continue;
173 173
             }
174 174
             $model = $relationData['model'];
@@ -222,13 +222,13 @@  discard block
 block discarded – undo
222 222
         foreach ($relation_fields as $relation_field) {
223 223
             $attributeKey = $this->parseRelationFieldNamesFromHtml([$relation_field])[0]['name'];
224 224
 
225
-            if (! is_null(Arr::get($data, $attributeKey)) && isset($relation_field['pivot']) && $relation_field['pivot'] !== true) {
225
+            if (!is_null(Arr::get($data, $attributeKey)) && isset($relation_field['pivot']) && $relation_field['pivot'] !== true) {
226 226
                 $key = implode('.relations.', explode('.', $this->getOnlyRelationEntity($relation_field)));
227 227
                 $fieldData = Arr::get($relationData, 'relations.'.$key, []);
228
-                if (! array_key_exists('model', $fieldData)) {
228
+                if (!array_key_exists('model', $fieldData)) {
229 229
                     $fieldData['model'] = $relation_field['model'];
230 230
                 }
231
-                if (! array_key_exists('parent', $fieldData)) {
231
+                if (!array_key_exists('parent', $fieldData)) {
232 232
                     $fieldData['parent'] = $this->getRelationModel($attributeKey, -1);
233 233
                 }
234 234
                 $relatedAttribute = Arr::last(explode('.', $attributeKey));
Please login to merge, or discard this patch.
src/app/Console/Commands/RequireDevTools.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
         // Check if auth exists
49 49
         $details = null;
50 50
         $process = new Process(['composer', 'config', 'http-basic.backpackforlaravel.com']);
51
-        $process->run(function ($type, $buffer) use (&$details) {
51
+        $process->run(function($type, $buffer) use (&$details) {
52 52
             if ($type !== Process::ERR && $buffer !== '') {
53 53
                 $details = json_decode($buffer);
54 54
             } elseif (File::exists('auth.json')) {
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
         });
59 59
 
60 60
         // Create an auth.json file
61
-        if (! $details) {
61
+        if (!$details) {
62 62
             $this->info(' Creating auth.json file with your authentication token');
63 63
 
64 64
             $this->line(' (Find your access token details on https://backpackforlaravel.com/user/tokens)');
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
             $password = $this->ask('Access token password');
67 67
 
68 68
             $process = new Process(['composer', 'config', 'http-basic.backpackforlaravel.com', $username, $password]);
69
-            $process->run(function ($type, $buffer) use ($username, $password) {
69
+            $process->run(function($type, $buffer) use ($username, $password) {
70 70
                 if ($type === Process::ERR) {
71 71
                     // Fallback
72 72
                     $authFile = [
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
 
81 81
                     if (File::exists('auth.json')) {
82 82
                         $currentFile = json_decode(File::get('auth.json'), true);
83
-                        if (! ($currentFile['http-basic']['backpackforlaravel.com'] ?? false)) {
83
+                        if (!($currentFile['http-basic']['backpackforlaravel.com'] ?? false)) {
84 84
                             $authFile = array_merge_recursive($authFile, $currentFile);
85 85
                         }
86 86
                     }
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
         // Check if repositories exists
95 95
         $details = null;
96 96
         $process = new Process(['composer', 'config', 'repositories.backpack/devtools']);
97
-        $process->run(function ($type, $buffer) use (&$details) {
97
+        $process->run(function($type, $buffer) use (&$details) {
98 98
             if ($type !== Process::ERR && $buffer !== '') {
99 99
                 $details = json_decode($buffer);
100 100
             } else {
@@ -104,11 +104,11 @@  discard block
 block discarded – undo
104 104
         });
105 105
 
106 106
         // Create repositories
107
-        if (! $details) {
107
+        if (!$details) {
108 108
             $this->info(' Creating repositories entry in composer.json');
109 109
 
110 110
             $process = new Process(['composer', 'config', 'repositories.backpack/devtools', 'composer', 'https://repo.backpackforlaravel.com']);
111
-            $process->run(function ($type, $buffer) {
111
+            $process->run(function($type, $buffer) {
112 112
                 if ($type === Process::ERR) {
113 113
                     // Fallback
114 114
                     $composerJson = Str::of(File::get('composer.json'));
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
         // Require package
140 140
         $process = new Process(['composer', 'require', '--dev', '--with-all-dependencies', 'backpack/devtools']);
141 141
         $process->setTimeout(300);
142
-        $process->run(function ($type, $buffer) {
142
+        $process->run(function($type, $buffer) {
143 143
             $this->progressBar->advance();
144 144
         });
145 145
 
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
         $this->info(' Now running the DevTools installation command.');
153 153
 
154 154
         // manually include the command in the run-time
155
-        if (! class_exists(\Backpack\DevTools\Console\Commands\InstallDevTools::class)) {
155
+        if (!class_exists(\Backpack\DevTools\Console\Commands\InstallDevTools::class)) {
156 156
             include base_path('vendor/backpack/devtools/src/Console/Commands/InstallDevTools.php');
157 157
         }
158 158
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudPanel.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -102,11 +102,11 @@  discard block
 block discarded – undo
102 102
      */
103 103
     public function setModel($model_namespace)
104 104
     {
105
-        if (! class_exists($model_namespace)) {
105
+        if (!class_exists($model_namespace)) {
106 106
             throw new \Exception('The model does not exist.', 500);
107 107
         }
108 108
 
109
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
109
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
110 110
             throw new \Exception('Please use CrudTrait on the model.', 500);
111 111
         }
112 112
 
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
     {
196 196
         $complete_route = $route.'.index';
197 197
 
198
-        if (! \Route::has($complete_route)) {
198
+        if (!\Route::has($complete_route)) {
199 199
             throw new \Exception('There are no routes for this route name.', 404);
200 200
         }
201 201
 
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
      */
294 294
     public function getFirstOfItsTypeInArray($type, $array)
295 295
     {
296
-        return Arr::first($array, function ($item) use ($type) {
296
+        return Arr::first($array, function($item) use ($type) {
297 297
             return $item['type'] == $type;
298 298
         });
299 299
     }
@@ -310,8 +310,8 @@  discard block
 block discarded – undo
310 310
 
311 311
     public function sync($type, $fields, $attributes)
312 312
     {
313
-        if (! empty($this->{$type})) {
314
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
313
+        if (!empty($this->{$type})) {
314
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
315 315
                 if (in_array($field['name'], (array) $fields)) {
316 316
                     $field = array_merge($field, $attributes);
317 317
                 }
@@ -341,15 +341,15 @@  discard block
 block discarded – undo
341 341
     {
342 342
         $relationArray = explode('.', $relationString);
343 343
 
344
-        if (! isset($length)) {
344
+        if (!isset($length)) {
345 345
             $length = count($relationArray);
346 346
         }
347 347
 
348
-        if (! isset($model)) {
348
+        if (!isset($model)) {
349 349
             $model = $this->model;
350 350
         }
351 351
 
352
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
352
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
353 353
             try {
354 354
                 $result = $obj->$method();
355 355
 
@@ -384,7 +384,7 @@  discard block
 block discarded – undo
384 384
             if (is_array($entries)) {
385 385
                 //if attribute does not exist in main array we have more than one entry OR the attribute
386 386
                 //is an acessor that is not in $appends property of model.
387
-                if (! isset($entries[$attribute])) {
387
+                if (!isset($entries[$attribute])) {
388 388
                     //we first check if we don't have the attribute because it's an acessor that is not in appends.
389 389
                     if ($model_instance->hasGetMutator($attribute) && isset($entries[$modelKey])) {
390 390
                         $entry_in_database = $model_instance->find($entries[$modelKey]);
@@ -423,21 +423,21 @@  discard block
 block discarded – undo
423 423
      */
424 424
     public function parseTranslatableAttributes($model, $attribute, $value)
425 425
     {
426
-        if (! method_exists($model, 'isTranslatableAttribute')) {
426
+        if (!method_exists($model, 'isTranslatableAttribute')) {
427 427
             return $value;
428 428
         }
429 429
 
430
-        if (! $model->isTranslatableAttribute($attribute)) {
430
+        if (!$model->isTranslatableAttribute($attribute)) {
431 431
             return $value;
432 432
         }
433 433
 
434
-        if (! is_array($value)) {
434
+        if (!is_array($value)) {
435 435
             $decodedAttribute = json_decode($value, true);
436 436
         } else {
437 437
             $decodedAttribute = $value;
438 438
         }
439 439
 
440
-        if (is_array($decodedAttribute) && ! empty($decodedAttribute)) {
440
+        if (is_array($decodedAttribute) && !empty($decodedAttribute)) {
441 441
             if (isset($decodedAttribute[app()->getLocale()])) {
442 442
                 return $decodedAttribute[app()->getLocale()];
443 443
             } else {
@@ -463,7 +463,7 @@  discard block
 block discarded – undo
463 463
         $relation = $model->{$firstRelationName};
464 464
 
465 465
         $results = [];
466
-        if (! is_null($relation)) {
466
+        if (!is_null($relation)) {
467 467
             if ($relation instanceof Collection) {
468 468
                 $currentResults = $relation->all();
469 469
             } elseif (is_array($relation)) {
@@ -476,7 +476,7 @@  discard block
 block discarded – undo
476 476
 
477 477
             array_shift($relationArray);
478 478
 
479
-            if (! empty($relationArray)) {
479
+            if (!empty($relationArray)) {
480 480
                 foreach ($currentResults as $currentResult) {
481 481
                     $results = array_merge_recursive($results, $this->getRelatedEntries($currentResult, implode('.', $relationArray)));
482 482
                 }
Please login to merge, or discard this patch.
src/resources/views/crud/fields/checklist_dependency.blade.php 1 patch
Indentation   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -30,36 +30,36 @@
 block discarded – undo
30 30
             }
31 31
         }
32 32
 
33
-      //for update form, get initial state of the entity
34
-      if (isset($id) && $id) {
33
+        //for update form, get initial state of the entity
34
+        if (isset($id) && $id) {
35 35
 
36 36
         //get entity with relations for primary dependency
37
-          $entity_dependencies = $entity_model->with($primary_dependency['entity'])
38
-          ->with($primary_dependency['entity'].'.'.$primary_dependency['entity_secondary'])
39
-          ->find($id);
37
+            $entity_dependencies = $entity_model->with($primary_dependency['entity'])
38
+            ->with($primary_dependency['entity'].'.'.$primary_dependency['entity_secondary'])
39
+            ->find($id);
40 40
 
41
-          $secondaries_from_primary = [];
41
+            $secondaries_from_primary = [];
42 42
 
43
-          //convert relation in array
44
-          $primary_array = $entity_dependencies->{$primary_dependency['entity']}->toArray();
43
+            //convert relation in array
44
+            $primary_array = $entity_dependencies->{$primary_dependency['entity']}->toArray();
45 45
 
46
-          $secondary_ids = [];
46
+            $secondary_ids = [];
47 47
 
48
-          //create secondary dependency from primary relation, used to check what checkbox must be checked from second checklist
49
-          if (old($primary_dependency['name'])) {
50
-              foreach (old($primary_dependency['name']) as $primary_item) {
51
-                  foreach ($dependencyArray[$primary_item] as $second_item) {
52
-                      $secondary_ids[$second_item] = $second_item;
53
-                  }
54
-              }
55
-          } else { //create dependencies from relation if not from validate error
56
-              foreach ($primary_array as $primary_item) {
57
-                  foreach ($primary_item[$secondary_dependency['entity']] as $second_item) {
58
-                      $secondary_ids[$second_item['id']] = $second_item['id'];
59
-                  }
60
-              }
61
-          }
62
-      }
48
+            //create secondary dependency from primary relation, used to check what checkbox must be checked from second checklist
49
+            if (old($primary_dependency['name'])) {
50
+                foreach (old($primary_dependency['name']) as $primary_item) {
51
+                    foreach ($dependencyArray[$primary_item] as $second_item) {
52
+                        $secondary_ids[$second_item] = $second_item;
53
+                    }
54
+                }
55
+            } else { //create dependencies from relation if not from validate error
56
+                foreach ($primary_array as $primary_item) {
57
+                    foreach ($primary_item[$secondary_dependency['entity']] as $second_item) {
58
+                        $secondary_ids[$second_item['id']] = $second_item['id'];
59
+                    }
60
+                }
61
+            }
62
+        }
63 63
 
64 64
         //json encode of dependency matrix
65 65
         $dependencyJson = json_encode($dependencyArray);
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/AutoSet.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -16,8 +16,8 @@  discard block
 block discarded – undo
16 16
             $this->getDbColumnTypes();
17 17
         }
18 18
 
19
-        array_map(function ($field) use ($setFields, $setColumns) {
20
-            if ($setFields && ! isset($this->fields()[$field])) {
19
+        array_map(function($field) use ($setFields, $setColumns) {
20
+            if ($setFields && !isset($this->fields()[$field])) {
21 21
                 $this->addField([
22 22
                     'name'       => $field,
23 23
                     'label'      => $this->makeLabel($field),
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
                 ]);
31 31
             }
32 32
 
33
-            if ($setColumns && ! in_array($field, $this->model->getHidden()) && ! isset($this->columns()[$field])) {
33
+            if ($setColumns && !in_array($field, $this->model->getHidden()) && !isset($this->columns()[$field])) {
34 34
                 $this->addColumn([
35 35
                     'name'    => $field,
36 36
                     'label'   => $this->makeLabel($field),
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 
108 108
         $dbColumnTypes = $this->getDbColumnTypes();
109 109
 
110
-        if (! isset($dbColumnTypes[$fieldName])) {
110
+        if (!isset($dbColumnTypes[$fieldName])) {
111 111
             return 'text';
112 112
         }
113 113
 
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
         $types = ['enum' => 'string'];
166 166
         $platform = $this->getSchema()->getConnection()->getDoctrineSchemaManager()->getDatabasePlatform();
167 167
         foreach ($types as $type_key => $type_value) {
168
-            if (! $platform->hasDoctrineTypeMappingFor($type_key)) {
168
+            if (!$platform->hasDoctrineTypeMappingFor($type_key)) {
169 169
                 $platform->registerDoctrineTypeMapping($type_key, $type_value);
170 170
             }
171 171
         }
@@ -216,13 +216,13 @@  discard block
 block discarded – undo
216 216
     {
217 217
         $fillable = $this->model->getFillable();
218 218
 
219
-        if (! $this->driverIsSql()) {
219
+        if (!$this->driverIsSql()) {
220 220
             $columns = $fillable;
221 221
         } else {
222 222
             // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model
223 223
             $columns = $this->model->getConnection()->getSchemaBuilder()->getColumnListing($this->model->getTable());
224 224
 
225
-            if (! empty($fillable)) {
225
+            if (!empty($fillable)) {
226 226
                 $columns = array_intersect($columns, $fillable);
227 227
             }
228 228
         }
Please login to merge, or discard this patch.