Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — prevent-errors ( 948fda )
by Pedro
11:17
created
src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php 1 patch
Spacing   +8 added lines, -9 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
             $column = ['name' => $column];
51 51
         }
52 52
 
53
-        if (is_array($column) && ! isset($column['name'])) {
53
+        if (is_array($column) && !isset($column['name'])) {
54 54
             $column['name'] = 'anonymous_column_'.Str::random(5);
55 55
         }
56 56
 
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
      */
67 67
     protected function makeSureColumnHasLabel($column)
68 68
     {
69
-        if (! isset($column['label'])) {
69
+        if (!isset($column['label'])) {
70 70
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
71 71
         }
72 72
 
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
151 151
      */
152 152
     protected function makeSureColumnHasKey($column)
153 153
     {
154
-        if (! isset($column['key'])) {
154
+        if (!isset($column['key'])) {
155 155
             $column['key'] = str_replace('.', '__', $column['name']);
156 156
         }
157 157
 
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
      */
170 170
     protected function makeSureColumnHasWrapper($column)
171 171
     {
172
-        if (! isset($column['wrapper'])) {
172
+        if (!isset($column['wrapper'])) {
173 173
             $column['wrapper'] = [];
174 174
         }
175 175
 
@@ -254,7 +254,7 @@  discard block
 block discarded – undo
254 254
     {
255 255
         // if this is a relation type field and no corresponding model was specified,
256 256
         // get it from the relation method defined in the main model
257
-        if (isset($column['entity']) && $column['entity'] !== false && ! isset($column['model'])) {
257
+        if (isset($column['entity']) && $column['entity'] !== false && !isset($column['model'])) {
258 258
             $column['model'] = $this->getRelationModel($column['entity']);
259 259
         }
260 260
 
@@ -291,8 +291,7 @@  discard block
 block discarded – undo
291 291
         $columnsArray = $this->columns();
292 292
 
293 293
         if (array_key_exists($targetColumnName, $columnsArray)) {
294
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
295
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
294
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
296 295
 
297 296
             $element = array_pop($columnsArray);
298 297
             $beginningPart = array_slice($columnsArray, 0, $targetColumnPosition, true);
@@ -314,7 +313,7 @@  discard block
 block discarded – undo
314 313
     {
315 314
         static $cache = [];
316 315
 
317
-        if (! $this->driverIsSql()) {
316
+        if (!$this->driverIsSql()) {
318 317
             return true;
319 318
         }
320 319
 
@@ -330,7 +329,7 @@  discard block
 block discarded – undo
330 329
     /**
331 330
      * Prepare the column attributes and add it to operation settings.
332 331
      */
333
-    private function prepareAttributesAndAddColumn(array|string $column): CrudColumn
332
+    private function prepareAttributesAndAddColumn(array | string $column): CrudColumn
334 333
     {
335 334
         $column = $this->makeSureColumnHasNeededAttributes($column);
336 335
         $this->addColumnToOperationSettings($column);
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Columns.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
     /**
75 75
      * Add a column at the end of the CRUD object's "columns" array and return it.
76 76
      */
77
-    public function addAndReturnColumn(array|string $column): CrudColumn
77
+    public function addAndReturnColumn(array | string $column): CrudColumn
78 78
     {
79 79
         $column = $this->prepareAttributesAndAddColumn($column);
80 80
 
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
      */
123 123
     public function makeFirstColumn()
124 124
     {
125
-        if (! $this->columns()) {
125
+        if (!$this->columns()) {
126 126
             return false;
127 127
         }
128 128
 
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
      */
167 167
     public function removeColumns($columns)
168 168
     {
169
-        if (! empty($columns)) {
169
+        if (!empty($columns)) {
170 170
             foreach ($columns as $columnKey) {
171 171
                 $this->removeColumn($columnKey);
172 172
             }
@@ -260,8 +260,8 @@  discard block
 block discarded – undo
260 260
     {
261 261
         $columns = $this->columns();
262 262
 
263
-        return collect($columns)->pluck('entity')->reject(function ($value, $key) {
264
-            return ! $value;
263
+        return collect($columns)->pluck('entity')->reject(function($value, $key) {
264
+            return !$value;
265 265
         })->toArray();
266 266
     }
267 267
 
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
      */
336 336
     public function hasColumnWhere($attribute, $value)
337 337
     {
338
-        $match = Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
338
+        $match = Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
339 339
             return isset($column[$attribute]) && $column[$attribute] == $value;
340 340
         });
341 341
 
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
      */
352 352
     public function firstColumnWhere($attribute, $value)
353 353
     {
354
-        return Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
354
+        return Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
355 355
             return isset($column[$attribute]) && $column[$attribute] == $value;
356 356
         });
357 357
     }
@@ -400,8 +400,8 @@  discard block
 block discarded – undo
400 400
      */
401 401
     public function countColumnsWithoutActions()
402 402
     {
403
-        return collect($this->columns())->filter(function ($column, $key) {
404
-            return ! isset($column['hasActions']) || $column['hasActions'] == false;
403
+        return collect($this->columns())->filter(function($column, $key) {
404
+            return !isset($column['hasActions']) || $column['hasActions'] == false;
405 405
         })->count();
406 406
     }
407 407
 
Please login to merge, or discard this patch.
src/app/Library/Uploaders/Support/Traits/HandleRepeatableUploads.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
         foreach (app('UploadersRepository')->getRepeatableUploadersFor($this->getRepeatableContainerName()) as $uploader) {
77 77
             $uploadedValues = $uploader->uploadRepeatableFiles($values->pluck($uploader->getAttributeName())->toArray(), $this->getPreviousRepeatableValues($entry, $uploader));
78 78
 
79
-            $values = $values->map(function ($item, $key) use ($uploadedValues, $uploader) {
79
+            $values = $values->map(function($item, $key) use ($uploadedValues, $uploader) {
80 80
                 $item[$uploader->getAttributeName()] = $uploadedValues[$key] ?? null;
81 81
 
82 82
                 return $item;
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 
97 97
         $values = $entry->{$this->getRepeatableContainerName()};
98 98
         $values = is_string($values) ? json_decode($values, true) : $values;
99
-        $values = array_map(function ($item) use ($repeatableUploaders) {
99
+        $values = array_map(function($item) use ($repeatableUploaders) {
100 100
             foreach ($repeatableUploaders as $upload) {
101 101
                 $item[$upload->getAttributeName()] = $this->getValuesWithPathStripped($item, $upload);
102 102
             }
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 
112 112
     private function retrieveRepeatableRelationFiles(Model $entry)
113 113
     {
114
-        switch($this->getRepeatableRelationType()) {
114
+        switch ($this->getRepeatableRelationType()) {
115 115
             case 'BelongsToMany':
116 116
             case 'MorphToMany':
117 117
                 $pivotClass = app('crud')->getModel()->{$this->getUploaderSubfield()['baseEntity']}()->getPivotClass();
@@ -156,12 +156,12 @@  discard block
 block discarded – undo
156 156
 
157 157
         $repeatableValues = collect($entry->{$this->getName()});
158 158
         foreach (app('UploadersRepository')->getRepeatableUploadersFor($this->getRepeatableContainerName()) as $upload) {
159
-            if (! $upload->shouldDeleteFiles()) {
159
+            if (!$upload->shouldDeleteFiles()) {
160 160
                 continue;
161 161
             }
162 162
             $values = $repeatableValues->pluck($upload->getName())->toArray();
163 163
             foreach ($values as $value) {
164
-                if (! $value) {
164
+                if (!$value) {
165 165
                     continue;
166 166
                 }
167 167
 
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
     /**
185 185
      * Given two multidimensional arrays/collections, merge them recursively.
186 186
      */
187
-    protected function mergeValuesRecursive(array|Collection $array1, array|Collection $array2): array|Collection
187
+    protected function mergeValuesRecursive(array | Collection $array1, array | Collection $array2): array | Collection
188 188
     {
189 189
         $merged = $array1;
190 190
         foreach ($array2 as $key => &$value) {
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
     {
207 207
         $items = CRUD::getRequest()->input('_order_'.$this->getRepeatableContainerName()) ?? [];
208 208
 
209
-        array_walk($items, function (&$key, $value) {
209
+        array_walk($items, function(&$key, $value) {
210 210
             $requestValue = $key[$this->getName()] ?? null;
211 211
             $key = $this->handleMultipleFiles ? (is_string($requestValue) ? explode(',', $requestValue) : $requestValue) : $requestValue;
212 212
         });
@@ -218,18 +218,18 @@  discard block
 block discarded – undo
218 218
     {
219 219
         $previousValues = json_decode($entry->getOriginal($uploader->getRepeatableContainerName()), true);
220 220
 
221
-        if (! empty($previousValues)) {
221
+        if (!empty($previousValues)) {
222 222
             $previousValues = array_column($previousValues, $uploader->getName());
223 223
         }
224 224
 
225 225
         return $previousValues ?? [];
226 226
     }
227 227
 
228
-    private function getValuesWithPathStripped(array|string|null $item, UploaderInterface $upload)
228
+    private function getValuesWithPathStripped(array | string | null $item, UploaderInterface $upload)
229 229
     {
230 230
         $uploadedValues = $item[$upload->getName()] ?? null;
231 231
         if (is_array($uploadedValues)) {
232
-            return array_map(function ($value) use ($upload) {
232
+            return array_map(function($value) use ($upload) {
233 233
                 return Str::after($value, $upload->getPath());
234 234
             }, $uploadedValues);
235 235
         }
@@ -241,19 +241,19 @@  discard block
 block discarded – undo
241 241
     {
242 242
         if (in_array($this->getRepeatableRelationType(), ['BelongsToMany', 'MorphToMany'])) {
243 243
             $pivotAttributes = $entry->getAttributes();
244
-            $connectedPivot = $entry->pivotParent->{$this->getRepeatableContainerName()}->where(function ($item) use ($pivotAttributes) {
244
+            $connectedPivot = $entry->pivotParent->{$this->getRepeatableContainerName()}->where(function($item) use ($pivotAttributes) {
245 245
                 $itemPivotAttributes = $item->pivot->only(array_keys($pivotAttributes));
246 246
 
247 247
                 return $itemPivotAttributes === $pivotAttributes;
248 248
             })->first();
249 249
 
250
-            if (! $connectedPivot) {
250
+            if (!$connectedPivot) {
251 251
                 return;
252 252
             }
253 253
 
254 254
             $files = $connectedPivot->getOriginal()['pivot_'.$this->getAttributeName()];
255 255
 
256
-            if (! $files) {
256
+            if (!$files) {
257 257
                 return;
258 258
             }
259 259
 
Please login to merge, or discard this patch.
src/app/Library/Uploaders/Support/RegisterUploadEvents.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -14,18 +14,18 @@  discard block
 block discarded – undo
14 14
     private string $crudObjectType;
15 15
 
16 16
     public function __construct(
17
-        private readonly CrudField|CrudColumn $crudObject,
17
+        private readonly CrudField | CrudColumn $crudObject,
18 18
         private readonly array $uploaderConfiguration,
19 19
         private readonly string $macro
20 20
         ) {
21 21
         $this->crudObjectType = is_a($crudObject, CrudField::class) ? 'field' : (is_a($crudObject, CrudColumn::class) ? 'column' : null);
22 22
 
23
-        if (! $this->crudObjectType) {
23
+        if (!$this->crudObjectType) {
24 24
             abort(500, 'Upload handlers only work for CrudField and CrudColumn classes.');
25 25
         }
26 26
     }
27 27
 
28
-    public static function handle(CrudField|CrudColumn $crudObject, array $uploaderConfiguration, string $macro, ?array $subfield = null, ?bool $registerModelEvents = true): void
28
+    public static function handle(CrudField | CrudColumn $crudObject, array $uploaderConfiguration, string $macro, ?array $subfield = null, ?bool $registerModelEvents = true): void
29 29
     {
30 30
         $instance = new self($crudObject, $uploaderConfiguration, $macro);
31 31
 
@@ -35,9 +35,9 @@  discard block
 block discarded – undo
35 35
     /*******************************
36 36
      * Private methods - implementation
37 37
      *******************************/
38
-    private function registerEvents(array|null $subfield = [], ?bool $registerModelEvents = true): void
38
+    private function registerEvents(array | null $subfield = [], ?bool $registerModelEvents = true): void
39 39
     {
40
-        if (! empty($subfield)) {
40
+        if (!empty($subfield)) {
41 41
             $this->registerSubfieldEvent($subfield, $registerModelEvents);
42 42
 
43 43
             return;
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
         }
82 82
 
83 83
         $subfields = collect($this->crudObject->getAttributes()['subfields']);
84
-        $subfields = $subfields->map(function ($item) use ($subfield, $uploader) {
84
+        $subfields = $subfields->map(function($item) use ($subfield, $uploader) {
85 85
             if ($item['name'] === $subfield['name']) {
86 86
                 $item['upload'] = true;
87 87
                 $item['disk'] = $uploader->getDisk();
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
         }
112 112
 
113 113
         if ($this->crudObjectType === 'field') {
114
-            $model::saving(function ($entry) use ($uploader) {
114
+            $model::saving(function($entry) use ($uploader) {
115 115
                 $updatedCountKey = 'uploaded_'.($uploader->getRepeatableContainerName() ?? $uploader->getName()).'_count';
116 116
 
117 117
                 CRUD::set($updatedCountKey, CRUD::get($updatedCountKey) ?? 0);
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
             // is not called in pivot models when loading the relations.
131 131
             $retrieveModel = $this->getModelForRetrieveEvent($model, $uploader);
132 132
 
133
-            $retrieveModel::retrieved(function ($entry) use ($uploader) {
133
+            $retrieveModel::retrieved(function($entry) use ($uploader) {
134 134
                 if ($entry->translationEnabled()) {
135 135
                     $locale = request('_locale', \App::getLocale());
136 136
                     if (in_array($locale, array_keys($entry->getAvailableLocales()))) {
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
             });
142 142
         }
143 143
 
144
-        $model::deleting(function ($entry) use ($uploader) {
144
+        $model::deleting(function($entry) use ($uploader) {
145 145
             $uploader->deleteUploadedFiles($entry);
146 146
         });
147 147
 
@@ -163,13 +163,13 @@  discard block
 block discarded – undo
163 163
         $customUploader = isset($uploaderConfiguration['uploader']) && class_exists($uploaderConfiguration['uploader']);
164 164
 
165 165
         if ($customUploader) {
166
-            return $uploaderConfiguration['uploader']::for($crudObject, $uploaderConfiguration);
166
+            return $uploaderConfiguration['uploader']::for ($crudObject, $uploaderConfiguration);
167 167
         }
168 168
 
169 169
         $uploader = app('UploadersRepository')->hasUploadFor($crudObject['type'], $this->macro);
170 170
 
171 171
         if ($uploader) {
172
-            return app('UploadersRepository')->getUploadFor($crudObject['type'], $this->macro)::for($crudObject, $uploaderConfiguration);
172
+            return app('UploadersRepository')->getUploadFor($crudObject['type'], $this->macro)::for ($crudObject, $uploaderConfiguration);
173 173
         }
174 174
 
175 175
         throw new Exception('Undefined upload type for '.$this->crudObjectType.' type: '.$crudObject['type']);
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 
186 186
     private function getSubfieldModel(array $subfield, UploaderInterface $uploader)
187 187
     {
188
-        if (! $uploader->isRelationship()) {
188
+        if (!$uploader->isRelationship()) {
189 189
             return $subfield['baseModel'] ?? get_class(app('crud')->getModel());
190 190
         }
191 191
 
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
198 198
 
199 199
     private function getModelForRetrieveEvent(string $model, UploaderInterface $uploader)
200 200
     {
201
-        if (! $uploader->isRelationship()) {
201
+        if (!$uploader->isRelationship()) {
202 202
             return $model;
203 203
         }
204 204
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Update.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         }
48 48
 
49 49
         // always have a hidden input for the entry id
50
-        if (! array_key_exists('id', $fields)) {
50
+        if (!array_key_exists('id', $fields)) {
51 51
             $fields['id'] = [
52 52
                 'name'  => $entry->getKeyName(),
53 53
                 'value' => $entry->getKey(),
@@ -72,12 +72,12 @@  discard block
 block discarded – undo
72 72
         $fieldEntity = $field['entity'] ?? false;
73 73
         $fakeField = $field['fake'] ?? false;
74 74
 
75
-        if ($fieldEntity && ! $fakeField) {
75
+        if ($fieldEntity && !$fakeField) {
76 76
             return $this->getModelAttributeValueFromRelationship($model, $field);
77 77
         }
78 78
 
79 79
         if ($this->holdsMultipleInputs($field['name'])) {
80
-            $result = array_map(function ($item) use ($model) {
80
+            $result = array_map(function($item) use ($model) {
81 81
                 return $model->{trim($item)};
82 82
             }, explode(',', $field['name']));
83 83
 
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
     {
100 100
         [$relatedModel, $relationMethod] = $this->getModelAndMethodFromEntity($model, $field);
101 101
 
102
-        if (! method_exists($relatedModel, $relationMethod)) {
102
+        if (!method_exists($relatedModel, $relationMethod)) {
103 103
             return $relatedModel->{$relationMethod};
104 104
         }
105 105
 
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
                     $model = $this->setupRelatedModelLocale($model);
119 119
                     // when subfields are NOT set we don't need to get any more values
120 120
                     // we just return the plain models as we only need the ids
121
-                    if (! isset($field['subfields'])) {
121
+                    if (!isset($field['subfields'])) {
122 122
                         $result->push($model);
123 123
 
124 124
                         continue;
@@ -146,13 +146,13 @@  discard block
 block discarded – undo
146 146
                 break;
147 147
             case 'HasOne':
148 148
             case 'MorphOne':
149
-                if (! method_exists($relatedModel, $relationMethod)) {
149
+                if (!method_exists($relatedModel, $relationMethod)) {
150 150
                     return;
151 151
                 }
152 152
 
153 153
                 $model = $relatedModel->{$relationMethod};
154 154
 
155
-                if (! $model) {
155
+                if (!$model) {
156 156
                     return;
157 157
                 }
158 158
 
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
 
234 234
         $relationArray = explode('.', $relationEntity);
235 235
 
236
-        $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function ($obj, $method) {
236
+        $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function($obj, $method) {
237 237
             // if the string ends with `_id` we strip it out
238 238
             $method = Str::endsWith($method, '_id') ? Str::replaceLast('_id', '', $method) : $method;
239 239
 
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
260 260
             // if the subfield name does not contain a dot we just need to check
261 261
             // if it has subfields and return the result accordingly.
262 262
             foreach ((array) $subfield['name'] as $name) {
263
-                if (! Str::contains($name, '.')) {
263
+                if (!Str::contains($name, '.')) {
264 264
                     // when subfields are present, $relatedModel->{$name} returns a model instance
265 265
                     // otherwise returns the model attribute.
266 266
                     if ($relatedModel->{$name}) {
Please login to merge, or discard this patch.