Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Failed
Pull Request — main (#5615)
by Pedro
17:05 queued 02:07
created
tests/Unit/CrudPanel/CrudPanelCreateTest.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -818,7 +818,7 @@  discard block
 block discarded – undo
818 818
 
819 819
     public function testCreateBelongsToFake()
820 820
     {
821
-        $belongsToField = [   // select_grouped
821
+        $belongsToField = [// select_grouped
822 822
             'label' => 'Select_grouped',
823 823
             'type' => 'select_grouped', //https://github.com/Laravel-Backpack/CRUD/issues/502
824 824
             'name' => 'bang_relation_field',
@@ -954,7 +954,7 @@  discard block
 block discarded – undo
954 954
                 'nickname' => 'i_have_has_one',
955 955
                 'profile_picture' => 'ohh my picture 1.jpg',
956 956
                 'article' => 1,
957
-                'addresses' => [ // HasOne is tested in other test function
957
+                'addresses' => [// HasOne is tested in other test function
958 958
                     [
959 959
                         'city' => 2,
960 960
                         'street' => 'test',
@@ -1707,23 +1707,23 @@  discard block
 block discarded – undo
1707 1707
         $this->crudPanel->addField([
1708 1708
             'name' => 'name',
1709 1709
             'events' => [
1710
-                'created' => function ($entry) {
1710
+                'created' => function($entry) {
1711 1711
                 },
1712
-                'creating' => function ($entry) {
1712
+                'creating' => function($entry) {
1713 1713
                     $entry->email = '[email protected]';
1714 1714
                     $entry->password = Hash::make('password');
1715 1715
                 },
1716
-                'saving' => function ($entry) {
1716
+                'saving' => function($entry) {
1717 1717
                 },
1718
-                'saved' => function ($entry) {
1718
+                'saved' => function($entry) {
1719 1719
                 },
1720
-                'updating' => function ($entry) {
1720
+                'updating' => function($entry) {
1721 1721
                 },
1722
-                'updated' => function ($entry) {
1722
+                'updated' => function($entry) {
1723 1723
                 },
1724
-                'deleting' => function ($entry) {
1724
+                'deleting' => function($entry) {
1725 1725
                 },
1726
-                'deleted' => function ($entry) {
1726
+                'deleted' => function($entry) {
1727 1727
                 },
1728 1728
             ],
1729 1729
         ]);
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelSearchTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
         $this->crudPanel->addColumn([
91 91
             'name' => 'test',
92 92
             'type' => 'my_custom_type',
93
-            'searchLogic' => function ($query, $column, $searchTerm) {
93
+            'searchLogic' => function($query, $column, $searchTerm) {
94 94
                 $query->where($column['name'], 'like', "%{$searchTerm}%");
95 95
             },
96 96
             'tableColumn' => true,
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
             'name' => 'name',
226 226
             'type' => 'text',
227 227
             'tableColumn' => true,
228
-            'orderLogic' => function ($query, $column, $searchTerm) {
228
+            'orderLogic' => function($query, $column, $searchTerm) {
229 229
                 $query->orderBy('name', 'asc');
230 230
             },
231 231
         ]);
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
             'name' => 'name',
245 245
             'type' => 'text',
246 246
             'tableColumn' => true,
247
-            'orderLogic' => function ($query, $column, $searchTerm) {
247
+            'orderLogic' => function($query, $column, $searchTerm) {
248 248
                 $query->orderBy('id', 'asc');
249 249
             },
250 250
         ]);
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Search.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -22,9 +22,9 @@  discard block
 block discarded – undo
22 22
      */
23 23
     public function applySearchTerm($searchTerm)
24 24
     {
25
-        return $this->query->where(function ($query) use ($searchTerm) {
25
+        return $this->query->where(function($query) use ($searchTerm) {
26 26
             foreach ($this->columns() as $column) {
27
-                if (! isset($column['type'])) {
27
+                if (!isset($column['type'])) {
28 28
                     abort(400, 'Missing column type when trying to apply search term.');
29 29
                 }
30 30
 
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 
85 85
                 case 'select':
86 86
                 case 'select_multiple':
87
-                    $query->orWhereHas($column['entity'], function ($q) use ($column, $searchTerm, $searchOperator) {
87
+                    $query->orWhereHas($column['entity'], function($q) use ($column, $searchTerm, $searchOperator) {
88 88
                         $q->where($this->getColumnWithTableNamePrefixed($q, $column['attribute']), $searchOperator, '%'.$searchTerm.'%');
89 89
                     });
90 90
                     break;
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
                 $column_direction = (strtolower((string) $order['dir']) == 'asc' ? 'ASC' : 'DESC');
109 109
                 $column = $this->findColumnById($column_number);
110 110
 
111
-                if ($column['tableColumn'] && ! isset($column['orderLogic'])) {
111
+                if ($column['tableColumn'] && !isset($column['orderLogic'])) {
112 112
                     if (method_exists($this->model, 'translationEnabled') &&
113 113
                         $this->model->translationEnabled() &&
114 114
                         $this->model->isTranslatableAttribute($column['name']) &&
@@ -136,12 +136,12 @@  discard block
 block discarded – undo
136 136
         $key = $this->model->getKeyName();
137 137
         $groupBy = $this->query->toBase()->groups;
138 138
 
139
-        $hasOrderByPrimaryKey = collect($orderBy)->some(function ($item) use ($key, $table) {
139
+        $hasOrderByPrimaryKey = collect($orderBy)->some(function($item) use ($key, $table) {
140 140
             return (isset($item['column']) && $item['column'] === $key)
141 141
                 || (isset($item['sql']) && str_contains($item['sql'], "$table.$key"));
142 142
         });
143 143
 
144
-        if (! $hasOrderByPrimaryKey && empty($groupBy)) {
144
+        if (!$hasOrderByPrimaryKey && empty($groupBy)) {
145 145
             $this->orderByWithPrefix($key, 'DESC');
146 146
         }
147 147
     }
@@ -320,13 +320,13 @@  discard block
 block discarded – undo
320 320
         if (isset($column['type'])) {
321 321
             // create a list of paths to column blade views
322 322
             // including the configured view_namespaces
323
-            $columnPaths = array_map(function ($item) use ($column) {
323
+            $columnPaths = array_map(function($item) use ($column) {
324 324
                 return $item.'.'.$column['type'];
325 325
             }, ViewNamespaces::getFor('columns'));
326 326
 
327 327
             // but always fall back to the stock 'text' column
328 328
             // if a view doesn't exist
329
-            if (! in_array('crud::columns.text', $columnPaths)) {
329
+            if (!in_array('crud::columns.text', $columnPaths)) {
330 330
                 $columnPaths[] = 'crud::columns.text';
331 331
             }
332 332
 
@@ -365,7 +365,7 @@  discard block
 block discarded – undo
365 365
      */
366 366
     private function renderCellView($view, $column, $entry, $rowNumber = false)
367 367
     {
368
-        if (! view()->exists($view)) {
368
+        if (!view()->exists($view)) {
369 369
             $view = 'crud::columns.text'; // fallback to text column
370 370
         }
371 371
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php 1 patch
Spacing   +8 added lines, -9 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
             return ['name' => Str::replace(' ', '', $column)];
51 51
         }
52 52
 
53
-        if (is_array($column) && ! isset($column['name'])) {
53
+        if (is_array($column) && !isset($column['name'])) {
54 54
             $column['name'] = 'anonymous_column_'.Str::random(5);
55 55
         }
56 56
 
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
      */
69 69
     protected function makeSureColumnHasLabel($column)
70 70
     {
71
-        if (! isset($column['label'])) {
71
+        if (!isset($column['label'])) {
72 72
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
73 73
         }
74 74
 
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
      */
154 154
     protected function makeSureColumnHasKey($column)
155 155
     {
156
-        if (! isset($column['key'])) {
156
+        if (!isset($column['key'])) {
157 157
             $column['key'] = str_replace('.', '__', $column['name']);
158 158
         }
159 159
 
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
      */
171 171
     protected function makeSureColumnHasWrapper($column)
172 172
     {
173
-        if (! isset($column['wrapper'])) {
173
+        if (!isset($column['wrapper'])) {
174 174
             $column['wrapper'] = [];
175 175
         }
176 176
 
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
     {
256 256
         // if this is a relation type field and no corresponding model was specified,
257 257
         // get it from the relation method defined in the main model
258
-        if (isset($column['entity']) && $column['entity'] !== false && ! isset($column['model'])) {
258
+        if (isset($column['entity']) && $column['entity'] !== false && !isset($column['model'])) {
259 259
             $column['model'] = $this->getRelationModel($column['entity']);
260 260
         }
261 261
 
@@ -292,8 +292,7 @@  discard block
 block discarded – undo
292 292
         $columnsArray = $this->columns();
293 293
 
294 294
         if (array_key_exists($targetColumnName, $columnsArray)) {
295
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
296
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
295
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
297 296
 
298 297
             $element = array_pop($columnsArray);
299 298
 
@@ -322,7 +321,7 @@  discard block
 block discarded – undo
322 321
     {
323 322
         static $cache = [];
324 323
 
325
-        if (! $this->driverIsSql()) {
324
+        if (!$this->driverIsSql()) {
326 325
             return true;
327 326
         }
328 327
 
@@ -338,7 +337,7 @@  discard block
 block discarded – undo
338 337
     /**
339 338
      * Prepare the column attributes and add it to operation settings.
340 339
      */
341
-    private function prepareAttributesAndAddColumn(array|string $column): CrudColumn
340
+    private function prepareAttributesAndAddColumn(array | string $column): CrudColumn
342 341
     {
343 342
         $column = $this->makeSureColumnHasNeededAttributes($column);
344 343
         $this->addColumnToOperationSettings($column);
Please login to merge, or discard this patch.