Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Failed
Pull Request — main (#5615)
by Pedro
17:05 queued 02:07
created
src/app/Library/CrudPanel/Traits/Access.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@  discard block
 block discarded – undo
10 10
     /**
11 11
      * Set an operation as having access using the Settings API.
12 12
      */
13
-    public function allowAccess(array|string $operation): bool
13
+    public function allowAccess(array | string $operation): bool
14 14
     {
15 15
         foreach ((array) $operation as $op) {
16 16
             $this->set($op.'.access', true);
@@ -22,13 +22,13 @@  discard block
 block discarded – undo
22 22
     /**
23 23
      * Disable the access to a certain operation, or the current one.
24 24
      */
25
-    public function denyAccess(array|string $operation): bool
25
+    public function denyAccess(array | string $operation): bool
26 26
     {
27 27
         foreach ((array) $operation as $op) {
28 28
             $this->set($op.'.access', false);
29 29
         }
30 30
 
31
-        return ! $this->hasAccessToAny($operation);
31
+        return !$this->hasAccessToAny($operation);
32 32
     }
33 33
 
34 34
     /**
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
     /**
53 53
      * Check if any operations are allowed for a Crud Panel. Return false if not.
54 54
      */
55
-    public function hasAccessToAny(array|string $operation_array, ?Model $entry = null): bool
55
+    public function hasAccessToAny(array | string $operation_array, ?Model $entry = null): bool
56 56
     {
57 57
         foreach ((array) $operation_array as $key => $operation) {
58 58
             if ($this->hasAccess($operation, $entry) == true) {
@@ -66,10 +66,10 @@  discard block
 block discarded – undo
66 66
     /**
67 67
      * Check if all operations are allowed for a Crud Panel. Return false if not.
68 68
      */
69
-    public function hasAccessToAll(array|string $operation_array, ?Model $entry = null): bool
69
+    public function hasAccessToAll(array | string $operation_array, ?Model $entry = null): bool
70 70
     {
71 71
         foreach ((array) $operation_array as $key => $operation) {
72
-            if (! $this->hasAccess($operation, $entry)) {
72
+            if (!$this->hasAccess($operation, $entry)) {
73 73
                 return false;
74 74
             }
75 75
         }
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
      */
85 85
     public function hasAccessOrFail(string $operation, ?Model $entry = null): bool
86 86
     {
87
-        if (! $this->hasAccess($operation, $entry)) {
87
+        if (!$this->hasAccess($operation, $entry)) {
88 88
             throw new AccessDeniedException(trans('backpack::crud.unauthorized_access', ['access' => $operation]));
89 89
         }
90 90
 
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
      * Get an operation's access condition, if set. A condition
96 96
      * can be anything, but usually a boolean or a callable.
97 97
      */
98
-    public function getAccessCondition(string $operation): bool|callable|null
98
+    public function getAccessCondition(string $operation): bool | callable | null
99 99
     {
100 100
         return $this->get($operation.'.access');
101 101
     }
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
     /**
104 104
      * Set the condition under which an operation is allowed for a Crud Panel.
105 105
      */
106
-    public function setAccessCondition(array|string $operation, bool|callable|null $condition): void
106
+    public function setAccessCondition(array | string $operation, bool | callable | null $condition): void
107 107
     {
108 108
         foreach ((array) $operation as $op) {
109 109
             $this->set($op.'.access', $condition);
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
      * Allow access only to operations in the array.
132 132
      * By denying access to all other operations.
133 133
      */
134
-    public function allowAccessOnlyTo(array|string $operation): void
134
+    public function allowAccessOnlyTo(array | string $operation): void
135 135
     {
136 136
         $this->denyAllAccess();
137 137
         $this->allowAccess($operation);
Please login to merge, or discard this patch.
src/routes/backpack/base.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
         'middleware' => config('backpack.base.web_middleware', 'web'),
19 19
         'prefix' => config('backpack.base.route_prefix'),
20 20
     ],
21
-    function () {
21
+    function() {
22 22
         // if not otherwise configured, setup the auth routes
23 23
         if (config('backpack.base.setup_auth_routes')) {
24 24
             // Authentication Routes...
Please login to merge, or discard this patch.
src/routes/backpack/testing.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
     (array) config('backpack.base.middleware_key', 'admin'),
16 16
     'prefix' => config('backpack.base.route_prefix', 'admin'),
17 17
 ],
18
-    function () {
18
+    function() {
19 19
         Route::crud('users', 'Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController');
20 20
     }
21 21
 );
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelValidationTest.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
             'password' => 'test',
46 46
         ]);
47 47
 
48
-        $request->setRouteResolver(function () use ($request) {
48
+        $request->setRouteResolver(function() use ($request) {
49 49
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController', 'create']))->bind($request);
50 50
         });
51 51
 
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
             'email' => '',
86 86
         ]);
87 87
 
88
-        $request->setRouteResolver(function () use ($request) {
88
+        $request->setRouteResolver(function() use ($request) {
89 89
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController', 'create']))->bind($request);
90 90
         });
91 91
 
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
             'password' => 'test',
126 126
         ]);
127 127
 
128
-        $request->setRouteResolver(function () use ($request) {
128
+        $request->setRouteResolver(function() use ($request) {
129 129
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController', 'create']))->bind($request);
130 130
         });
131 131
 
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
             'name' => 'test',
248 248
         ]);
249 249
 
250
-        $request->setRouteResolver(function () use ($request) {
250
+        $request->setRouteResolver(function() use ($request) {
251 251
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController', 'create']))->bind($request);
252 252
         });
253 253
 
Please login to merge, or discard this patch.
src/app/Library/Uploaders/Support/Traits/HandleRepeatableUploads.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@  discard block
 block discarded – undo
13 13
 {
14 14
     public bool $handleRepeatableFiles = false;
15 15
 
16
-    public null|string $repeatableContainerName = null;
16
+    public null | string $repeatableContainerName = null;
17 17
 
18 18
     /*******************************
19 19
      * Setters - fluently configure the uploader
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
     /*******************************
31 31
      * Getters
32 32
      *******************************/
33
-    public function getRepeatableContainerName(): null|string
33
+    public function getRepeatableContainerName(): null | string
34 34
     {
35 35
         return $this->repeatableContainerName;
36 36
     }
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
         foreach (app('UploadersRepository')->getRepeatableUploadersFor($this->getRepeatableContainerName()) as $uploader) {
77 77
             $uploadedValues = $uploader->uploadRepeatableFiles($values->pluck($uploader->getAttributeName())->toArray(), $this->getPreviousRepeatableValues($entry, $uploader));
78 78
 
79
-            $values = $values->map(function ($item, $key) use ($uploadedValues, $uploader) {
79
+            $values = $values->map(function($item, $key) use ($uploadedValues, $uploader) {
80 80
                 $item[$uploader->getAttributeName()] = $uploadedValues[$key] ?? null;
81 81
 
82 82
                 return $item;
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 
97 97
         $values = $entry->{$this->getRepeatableContainerName()};
98 98
         $values = is_string($values) ? json_decode($values, true) : $values;
99
-        $values = array_map(function ($item) use ($repeatableUploaders) {
99
+        $values = array_map(function($item) use ($repeatableUploaders) {
100 100
             foreach ($repeatableUploaders as $upload) {
101 101
                 $item[$upload->getAttributeName()] = $this->getValuesWithPathStripped($item, $upload);
102 102
             }
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 
112 112
     private function retrieveRepeatableRelationFiles(Model $entry)
113 113
     {
114
-        switch($this->getRepeatableRelationType()) {
114
+        switch ($this->getRepeatableRelationType()) {
115 115
             case 'BelongsToMany':
116 116
             case 'MorphToMany':
117 117
                 $pivotClass = app('crud')->getModel()->{$this->getUploaderSubfield()['baseEntity']}()->getPivotClass();
@@ -157,12 +157,12 @@  discard block
 block discarded – undo
157 157
 
158 158
         $repeatableValues = collect($entry->{$this->getName()});
159 159
         foreach (app('UploadersRepository')->getRepeatableUploadersFor($this->getRepeatableContainerName()) as $upload) {
160
-            if (! $upload->shouldDeleteFiles()) {
160
+            if (!$upload->shouldDeleteFiles()) {
161 161
                 continue;
162 162
             }
163 163
             $values = $repeatableValues->pluck($upload->getName())->toArray();
164 164
             foreach ($values as $value) {
165
-                if (! $value) {
165
+                if (!$value) {
166 166
                     continue;
167 167
                 }
168 168
 
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
     /**
186 186
      * Given two multidimensional arrays/collections, merge them recursively.
187 187
      */
188
-    protected function mergeValuesRecursive(array|Collection $array1, array|Collection $array2): array|Collection
188
+    protected function mergeValuesRecursive(array | Collection $array1, array | Collection $array2): array | Collection
189 189
     {
190 190
         $merged = $array1;
191 191
         foreach ($array2 as $key => &$value) {
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
     {
208 208
         $items = CRUD::getRequest()->input('_order_'.$this->getRepeatableContainerName()) ?? [];
209 209
 
210
-        array_walk($items, function (&$key, $value) {
210
+        array_walk($items, function(&$key, $value) {
211 211
             $requestValue = $key[$this->getName()] ?? null;
212 212
             $key = $this->handleMultipleFiles ? (is_string($requestValue) ? explode(',', $requestValue) : $requestValue) : $requestValue;
213 213
         });
@@ -219,18 +219,18 @@  discard block
 block discarded – undo
219 219
     {
220 220
         $previousValues = json_decode($entry->getOriginal($uploader->getRepeatableContainerName()), true);
221 221
 
222
-        if (! empty($previousValues)) {
222
+        if (!empty($previousValues)) {
223 223
             $previousValues = array_column($previousValues, $uploader->getName());
224 224
         }
225 225
 
226 226
         return $previousValues ?? [];
227 227
     }
228 228
 
229
-    private function getValuesWithPathStripped(array|string|null $item, UploaderInterface $upload)
229
+    private function getValuesWithPathStripped(array | string | null $item, UploaderInterface $upload)
230 230
     {
231 231
         $uploadedValues = $item[$upload->getName()] ?? null;
232 232
         if (is_array($uploadedValues)) {
233
-            return array_map(function ($value) use ($upload) {
233
+            return array_map(function($value) use ($upload) {
234 234
                 return Str::after($value, $upload->getPath());
235 235
             }, $uploadedValues);
236 236
         }
@@ -242,19 +242,19 @@  discard block
 block discarded – undo
242 242
     {
243 243
         if (in_array($this->getRepeatableRelationType(), ['BelongsToMany', 'MorphToMany'])) {
244 244
             $pivotAttributes = $entry->getAttributes();
245
-            $connectedPivot = $entry->pivotParent->{$this->getRepeatableContainerName()}->where(function ($item) use ($pivotAttributes) {
245
+            $connectedPivot = $entry->pivotParent->{$this->getRepeatableContainerName()}->where(function($item) use ($pivotAttributes) {
246 246
                 $itemPivotAttributes = $item->pivot->only(array_keys($pivotAttributes));
247 247
 
248 248
                 return $itemPivotAttributes === $pivotAttributes;
249 249
             })->first();
250 250
 
251
-            if (! $connectedPivot) {
251
+            if (!$connectedPivot) {
252 252
                 return;
253 253
             }
254 254
 
255 255
             $files = $connectedPivot->getOriginal()['pivot_'.$this->getAttributeName()];
256 256
 
257
-            if (! $files) {
257
+            if (!$files) {
258 258
                 return;
259 259
             }
260 260
 
Please login to merge, or discard this patch.
src/app/Library/Uploaders/SingleFile.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
             return $this->getPath().$fileName;
24 24
         }
25 25
 
26
-        if (! $value && CrudPanelFacade::getRequest()->has($this->getNameForRequest()) && $previousFile) {
26
+        if (!$value && CrudPanelFacade::getRequest()->has($this->getNameForRequest()) && $previousFile) {
27 27
             Storage::disk($this->getDisk())->delete($previousFile);
28 28
 
29 29
             return null;
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         }
48 48
 
49 49
         foreach ($previousRepeatableValues as $row => $file) {
50
-            if ($file && ! isset($orderedFiles[$row])) {
50
+            if ($file && !isset($orderedFiles[$row])) {
51 51
                 $orderedFiles[$row] = null;
52 52
                 Storage::disk($this->getDisk())->delete($file);
53 53
             }
Please login to merge, or discard this patch.
src/app/Library/Uploaders/Support/RegisterUploadEvents.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -14,18 +14,18 @@  discard block
 block discarded – undo
14 14
     private string $crudObjectType;
15 15
 
16 16
     public function __construct(
17
-        private readonly CrudField|CrudColumn $crudObject,
17
+        private readonly CrudField | CrudColumn $crudObject,
18 18
         private readonly array $uploaderConfiguration,
19 19
         private readonly string $macro
20 20
         ) {
21 21
         $this->crudObjectType = is_a($crudObject, CrudField::class) ? 'field' : (is_a($crudObject, CrudColumn::class) ? 'column' : null);
22 22
 
23
-        if (! $this->crudObjectType) {
23
+        if (!$this->crudObjectType) {
24 24
             abort(500, 'Upload handlers only work for CrudField and CrudColumn classes.');
25 25
         }
26 26
     }
27 27
 
28
-    public static function handle(CrudField|CrudColumn $crudObject, array $uploaderConfiguration, string $macro, ?array $subfield = null, ?bool $registerModelEvents = true): void
28
+    public static function handle(CrudField | CrudColumn $crudObject, array $uploaderConfiguration, string $macro, ?array $subfield = null, ?bool $registerModelEvents = true): void
29 29
     {
30 30
         $instance = new self($crudObject, $uploaderConfiguration, $macro);
31 31
 
@@ -35,9 +35,9 @@  discard block
 block discarded – undo
35 35
     /*******************************
36 36
      * Private methods - implementation
37 37
      *******************************/
38
-    private function registerEvents(array|null $subfield = [], ?bool $registerModelEvents = true): void
38
+    private function registerEvents(array | null $subfield = [], ?bool $registerModelEvents = true): void
39 39
     {
40
-        if (! empty($subfield)) {
40
+        if (!empty($subfield)) {
41 41
             $this->registerSubfieldEvent($subfield, $registerModelEvents);
42 42
 
43 43
             return;
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
         }
82 82
 
83 83
         $subfields = collect($this->crudObject->getAttributes()['subfields']);
84
-        $subfields = $subfields->map(function ($item) use ($subfield, $uploader) {
84
+        $subfields = $subfields->map(function($item) use ($subfield, $uploader) {
85 85
             if ($item['name'] === $subfield['name']) {
86 86
                 $item['upload'] = true;
87 87
                 $item['disk'] = $uploader->getDisk();
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
         }
112 112
 
113 113
         if ($this->crudObjectType === 'field') {
114
-            $model::saving(function ($entry) use ($uploader) {
114
+            $model::saving(function($entry) use ($uploader) {
115 115
                 $entry = $uploader->storeUploadedFiles($entry);
116 116
             });
117 117
         }
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
             // is not called in pivot models when loading the relations.
125 125
             $retrieveModel = $this->getModelForRetrieveEvent($model, $uploader);
126 126
 
127
-            $retrieveModel::retrieved(function ($entry) use ($uploader) {
127
+            $retrieveModel::retrieved(function($entry) use ($uploader) {
128 128
                 if ($entry->translationEnabled()) {
129 129
                     $locale = request('_locale', app()->getLocale());
130 130
                     if (in_array($locale, array_keys($entry->getAvailableLocales()))) {
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
             });
136 136
         }
137 137
 
138
-        $model::deleting(function ($entry) use ($uploader) {
138
+        $model::deleting(function($entry) use ($uploader) {
139 139
             $uploader->deleteUploadedFiles($entry);
140 140
         });
141 141
 
@@ -157,13 +157,13 @@  discard block
 block discarded – undo
157 157
         $customUploader = isset($uploaderConfiguration['uploader']) && class_exists($uploaderConfiguration['uploader']);
158 158
 
159 159
         if ($customUploader) {
160
-            return $uploaderConfiguration['uploader']::for($crudObject, $uploaderConfiguration);
160
+            return $uploaderConfiguration['uploader']::for ($crudObject, $uploaderConfiguration);
161 161
         }
162 162
 
163 163
         $uploader = app('UploadersRepository')->hasUploadFor($crudObject['type'], $this->macro);
164 164
 
165 165
         if ($uploader) {
166
-            return app('UploadersRepository')->getUploadFor($crudObject['type'], $this->macro)::for($crudObject, $uploaderConfiguration);
166
+            return app('UploadersRepository')->getUploadFor($crudObject['type'], $this->macro)::for ($crudObject, $uploaderConfiguration);
167 167
         }
168 168
 
169 169
         throw new Exception('Undefined upload type for '.$this->crudObjectType.' type: '.$crudObject['type']);
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
 
180 180
     private function getSubfieldModel(array $subfield, UploaderInterface $uploader)
181 181
     {
182
-        if (! $uploader->isRelationship()) {
182
+        if (!$uploader->isRelationship()) {
183 183
             return $subfield['baseModel'] ?? get_class(app('crud')->getModel());
184 184
         }
185 185
 
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
 
193 193
     private function getModelForRetrieveEvent(string $model, UploaderInterface $uploader)
194 194
     {
195
-        if (! $uploader->isRelationship()) {
195
+        if (!$uploader->isRelationship()) {
196 196
             return $model;
197 197
         }
198 198
 
Please login to merge, or discard this patch.
src/app/Library/Uploaders/SingleBase64Image.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
         $value = $value ?? CRUD::getRequest()->get($this->getName());
15 15
         $previousImage = $this->getPreviousFiles($entry);
16 16
 
17
-        if (! $value && $previousImage) {
17
+        if (!$value && $previousImage) {
18 18
             Storage::disk($this->getDisk())->delete($previousImage);
19 19
 
20 20
             return null;
@@ -67,6 +67,6 @@  discard block
 block discarded – undo
67 67
 
68 68
     protected function shouldKeepPreviousValueUnchanged(Model $entry, $entryValue): bool
69 69
     {
70
-        return $entry->exists && is_string($entryValue) && ! Str::startsWith($entryValue, 'data:image');
70
+        return $entry->exists && is_string($entryValue) && !Str::startsWith($entryValue, 'data:image');
71 71
     }
72 72
 }
Please login to merge, or discard this patch.
src/app/Library/Uploaders/MultipleFiles.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@  discard block
 block discarded – undo
10 10
 
11 11
 class MultipleFiles extends Uploader
12 12
 {
13
-    public static function for(array $field, $configuration): UploaderInterface
13
+    public static function for (array $field, $configuration): UploaderInterface
14 14
     {
15 15
         return (new self($field, $configuration))->multiple();
16 16
     }
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
             $previousFiles = [];
30 30
         }
31 31
 
32
-        if (! is_array($previousFiles) && is_string($previousFiles)) {
32
+        if (!is_array($previousFiles) && is_string($previousFiles)) {
33 33
             $previousFiles = json_decode($previousFiles, true);
34 34
         }
35 35
 
@@ -38,14 +38,14 @@  discard block
 block discarded – undo
38 38
                 if (in_array($previousFile, $filesToDelete)) {
39 39
                     Storage::disk($this->getDisk())->delete($previousFile);
40 40
 
41
-                    $previousFiles = Arr::where($previousFiles, function ($value, $key) use ($previousFile) {
41
+                    $previousFiles = Arr::where($previousFiles, function($value, $key) use ($previousFile) {
42 42
                         return $value != $previousFile;
43 43
                     });
44 44
                 }
45 45
             }
46 46
         }
47 47
 
48
-        if (! is_array($value)) {
48
+        if (!is_array($value)) {
49 49
             $value = [];
50 50
         }
51 51
 
Please login to merge, or discard this patch.