Laravel-Backpack / CRUD

src/app/Http/Controllers/CrudController.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Illuminate\Foundation\Bus\DispatchesJobs;
 use Illuminate\Foundation\Validation\ValidatesRequests;
-use Illuminate\Http\Request;
 use Illuminate\Routing\Controller;
 
 class CrudController extends Controller

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
 
         // call the setup function inside this closure to also have the request there
         // this way, developers can use things stored in session (auth variables, etc)
-        $this->middleware(function ($request, $next) {
+        $this->middleware(function($request, $next) {
             // make a new CrudPanel object, from the one stored in Laravel's service container
             $this->crud = app()->make('crud');
             // ensure crud has the latest request

src/app/Http/Controllers/Operations/ListOperation.php

Spacing +4 added lines, -4 removed lines

@@ -41,7 +41,7 @@ 
     {
         $this->crud->allowAccess('list');
 
-        $this->crud->operation('list', function () {
+        $this->crud->operation('list', function() {
             $this->crud->loadDefaultOperationSettingsFromConfig();
         });
     }
@@ -112,8 +112,8 @@ 
         // if there was an order set, this will be the last one (after all others were applied)
         $orderBy = $this->crud->query->getQuery()->orders;
         $hasOrderByPrimaryKey = false;
-        collect($orderBy)->each(function ($item, $key) use ($hasOrderByPrimaryKey) {
-            if (! isset($item['column'])) {
+        collect($orderBy)->each(function($item, $key) use ($hasOrderByPrimaryKey) {
+            if (!isset($item['column'])) {
                 return false;
             }
 
@@ -123,7 +123,7 @@ 
                 return false;
             }
         });
-        if (! $hasOrderByPrimaryKey) {
+        if (!$hasOrderByPrimaryKey) {
             $this->crud->query->orderByDesc($this->crud->model->getKeyName());
         }
 

src/resources/views/crud/columns/select_from_array.blade.php

Spacing +1 added lines, -1 removed lines

@@ -10,7 +10,7 @@
                 $array_of_values = [];
 
                 foreach ($values as $key => $value) {
-                    if (! is_null($value)) {
+                    if (!is_null($value)) {
                         $array_of_values[] = $column['options'][$value];
                     } else {
                         echo '-';

tests/Unit/Http/CrudControllerTest.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,8 +2,8 @@
 
 namespace Backpack\CRUD\Tests\Unit\Http;
 
-use Backpack\CRUD\app\Library\CrudPanel\CrudPanel;
 use Backpack\CRUD\Tests\BaseTest;
+use Backpack\CRUD\app\Library\CrudPanel\CrudPanel;
 
 class CrudControllerTest extends BaseTest
 {

Spacing +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
         $controller = '\Backpack\CRUD\Tests\Unit\Http\Controllers\UserCrudController';
         $app['router']->get('users/{id}/edit', "$controller@edit");
         $app['router']->put('users/{id}', "$controller@update");
-        $app->singleton('crud', function ($app) {
+        $app->singleton('crud', function($app) {
             return new CrudPanel($app);
         });
     }

src/app/Library/CrudPanel/CrudPanel.php

Spacing +12 added lines, -12 removed lines

@@ -69,7 +69,7 @@ 
      */
     public function setRequest($request = null)
     {
-        if (! $request) {
+        if (!$request) {
             $request = \Request::instance();
         }
         $this->request = $request;
@@ -89,11 +89,11 @@ 
      */
     public function setModel($model_namespace)
     {
-        if (! class_exists($model_namespace)) {
+        if (!class_exists($model_namespace)) {
             throw new \Exception('The model does not exist.', 500);
         }
 
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
             throw new \Exception('Please use CrudTrait on the model.', 500);
         }
 
@@ -156,7 +156,7 @@ 
     {
         $complete_route = $route.'.index';
 
-        if (! \Route::has($complete_route)) {
+        if (!\Route::has($complete_route)) {
             throw new \Exception('There are no routes for this route name.', 404);
         }
 
@@ -257,7 +257,7 @@ 
      */
     public function getFirstOfItsTypeInArray($type, $array)
     {
-        return array_first($array, function ($item) use ($type) {
+        return array_first($array, function($item) use ($type) {
             return $item['type'] == $type;
         });
     }
@@ -274,8 +274,8 @@ 
 
     public function sync($type, $fields, $attributes)
     {
-        if (! empty($this->{$type})) {
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
+        if (!empty($this->{$type})) {
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
                 if (in_array($field['name'], (array) $fields)) {
                     $field = array_merge($field, $attributes);
                 }
@@ -306,15 +306,15 @@ 
     {
         $relationArray = explode('.', $relationString);
 
-        if (! isset($length)) {
+        if (!isset($length)) {
             $length = count($relationArray);
         }
 
-        if (! isset($model)) {
+        if (!isset($model)) {
             $model = $this->model;
         }
 
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
             return $obj->$method()->getRelated();
         }, $model);
 
@@ -364,7 +364,7 @@ 
         $relation = $model->{$firstRelationName};
 
         $results = [];
-        if (! empty($relation)) {
+        if (!empty($relation)) {
             if ($relation instanceof Collection) {
                 $currentResults = $relation->toArray();
             } else {
@@ -373,7 +373,7 @@ 
 
             array_shift($relationArray);
 
-            if (! empty($relationArray)) {
+            if (!empty($relationArray)) {
                 foreach ($currentResults as $currentResult) {
                     $results = array_merge($results, $this->getRelationModelInstances($currentResult, implode('.', $relationArray)));
                 }

src/app/Console/Commands/Install.php

Doc Comments +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
     /**
      * Execute the console command.
      *
-     * @return mixed Command-line output
+     * @return false|null Command-line output
      */
     public function handle()
     {

Spacing +3 added lines, -3 removed lines

@@ -88,7 +88,7 @@ 
                     $createUploadDirectoryCommand = 'mkdir -p public/uploads';
                     break;
                 case '\\': // windows
-                    if (! file_exists('public\uploads')) {
+                    if (!file_exists('public\uploads')) {
                         $createUploadDirectoryCommand = 'mkdir public\uploads';
                     }
                     break;
@@ -133,7 +133,7 @@ 
         $this->echo('info', $beforeNotice ? ' '.$beforeNotice : $command);
 
         $process = new Process($command, null, null, null, $this->option('timeout'));
-        $process->run(function ($type, $buffer) {
+        $process->run(function($type, $buffer) {
             if (Process::ERR === $type) {
                 $this->echo('comment', $buffer);
             } else {
@@ -142,7 +142,7 @@ 
         });
 
         // executes after the command finishes
-        if (! $process->isSuccessful()) {
+        if (!$process->isSuccessful()) {
             throw new ProcessFailedException($process);
         }
 

src/app/Library/CrudPanel/Traits/SaveActions.php

Spacing +13 added lines, -14 removed lines

@@ -45,7 +45,7 @@ 
      */
     public function getSaveActionByOrder($order)
     {
-        return array_filter($this->availableSaveActions, function ($arr) use ($order) {
+        return array_filter($this->availableSaveActions, function($arr) use ($order) {
             return $arr['order'] == $order;
         });
     }
@@ -80,7 +80,7 @@ 
         if (is_array($saveAction)) {
             //check for some mandatory fields
             $saveAction['name'] ?? abort(500, 'Please define save action name.');
-            $saveAction['redirect'] = $saveAction['redirect'] ?? function ($crud, $request, $itemId) {
+            $saveAction['redirect'] = $saveAction['redirect'] ?? function($crud, $request, $itemId) {
                 return $request->has('http_referrer') ? $request->get('http_referrer') : $crud->route;
             };
             $saveAction['permissions'] = $saveAction['permissions'] ?? true;
@@ -99,11 +99,11 @@ 
      */
     public function reorderSaveActions($wantedOrder)
     {
-        if (! empty($this->availableSaveActions)) {
+        if (!empty($this->availableSaveActions)) {
             $lastOrder = max(array_column($this->availableSaveActions, 'order'));
             foreach ($this->availableSaveActions as &$sv) {
                 if ($wantedOrder == $sv['order']) {
-                    if (empty(array_filter($this->availableSaveActions, function ($arr) {
+                    if (empty(array_filter($this->availableSaveActions, function($arr) {
                         $arr['order'] == 1;
                     }))) {
                         $sv['order'] = 1;
@@ -219,12 +219,12 @@ 
         }
 
         //get only passed permissions
-        $saveOptions = array_filter($this->availableSaveActions, function ($saveOption) {
+        $saveOptions = array_filter($this->availableSaveActions, function($saveOption) {
             return $saveOption['permissions'] == true;
         }, ARRAY_FILTER_USE_BOTH);
 
         //sort by order
-        uasort($saveOptions, function ($a, $b) {
+        uasort($saveOptions, function($a, $b) {
             return $a['order'] <=> $b['order'];
         });
 
@@ -263,8 +263,7 @@ 
      */
     public function setSaveAction($forceSaveAction = null)
     {
-        $saveAction = $forceSaveAction ?:
-            \Request::input('save_action', $this->getFallBackSaveAction());
+        $saveAction = $forceSaveAction ?: \Request::input('save_action', $this->getFallBackSaveAction());
 
         $showBubble = $this->getOperationSetting('showSaveActionChange') ?? config('backpack.crud.operations.'.$this->getCurrentOperation().'.showSaveActionChange') ?? true;
 
@@ -319,10 +318,10 @@ 
         $defaultSaveActions = [
             [
                 'name' => 'save_and_back',
-                'permissions' => function ($crud) {
+                'permissions' => function($crud) {
                     return $crud->hasAccess('list');
                 },
-                'redirect' => function ($crud, $request, $itemId = null) {
+                'redirect' => function($crud, $request, $itemId = null) {
                     return $request->has('http_referrer') ? $request->get('http_referrer') : $crud->route;
                 },
                 'button_text' => trans('backpack::crud.save_action_save_and_back'),
@@ -330,10 +329,10 @@ 
             ],
             [
                 'name' => 'save_and_edit',
-                'permissions' => function ($crud) {
+                'permissions' => function($crud) {
                     return $crud->hasAccess('update');
                 },
-                'redirect' => function ($crud, $request, $itemId = null) {
+                'redirect' => function($crud, $request, $itemId = null) {
                     $itemId = $itemId ?: $request->input('id');
                     $redirectUrl = $this->route.'/'.$itemId.'/edit';
                     if ($request->has('locale')) {
@@ -350,10 +349,10 @@ 
             ],
             [
                 'name' => 'save_and_new',
-                'permissions' => function ($crud) {
+                'permissions' => function($crud) {
                     return $crud->hasAccess('create');
                 },
-                'redirect' => function ($crud, $request, $itemId = null) {
+                'redirect' => function($crud, $request, $itemId = null) {
                     return $this->route.'/create';
                 },
                 'button_text' => trans('backpack::crud.save_action_save_and_new'),

Doc Comments +1 added lines, -2 removed lines

@@ -53,7 +53,7 @@ 
     /**
      * Allow the developer to register save actions.
      *
-     * @param array $saveAction
+     * @param array $saveActions
      * @return void
      */
     public function registerSaveActions($saveActions)
@@ -165,7 +165,6 @@ 
     /**
      * Allow the developer to unset all save actions.
      *
-     * @param string $saveAction
      * @return void
      */
     public function forgetAllSaveActions()