Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#3843)
by Cristian
13:16
created
src/app/Library/CrudPanel/Traits/Read.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
      */
57 57
     public function getEntry($id)
58 58
     {
59
-        if (! $this->entry) {
59
+        if (!$this->entry) {
60 60
             $this->entry = $this->model->findOrFail($id);
61 61
             $this->entry = $this->entry->withFakes();
62 62
         }
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
                 // we will apply the same labels as the values to the menu if developer didn't
259 259
                 $this->abortIfInvalidPageLength($menu[0]);
260 260
 
261
-                if (! isset($menu[1]) || ! is_array($menu[1])) {
261
+                if (!isset($menu[1]) || !is_array($menu[1])) {
262 262
                     $menu[1] = $menu[0];
263 263
                 }
264 264
             } else {
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ListOperation.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     {
42 42
         $this->crud->allowAccess('list');
43 43
 
44
-        $this->crud->operation('list', function () {
44
+        $this->crud->operation('list', function() {
45 45
             $this->crud->loadDefaultOperationSettingsFromConfig();
46 46
         });
47 47
     }
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
                 $column_number = (int) $order['column'];
100 100
                 $column_direction = (strtolower((string) $order['dir']) == 'asc' ? 'ASC' : 'DESC');
101 101
                 $column = $this->crud->findColumnById($column_number);
102
-                if ($column['tableColumn'] && ! isset($column['orderLogic'])) {
102
+                if ($column['tableColumn'] && !isset($column['orderLogic'])) {
103 103
                     // apply the current orderBy rules
104 104
                     $this->crud->orderByWithPrefix($column['name'], $column_direction);
105 105
                 }
@@ -119,12 +119,12 @@  discard block
 block discarded – undo
119 119
         $table = $this->crud->model->getTable();
120 120
         $key = $this->crud->model->getKeyName();
121 121
 
122
-        $hasOrderByPrimaryKey = collect($orderBy)->some(function ($item) use ($key, $table) {
122
+        $hasOrderByPrimaryKey = collect($orderBy)->some(function($item) use ($key, $table) {
123 123
             return (isset($item['column']) && $item['column'] === $key)
124 124
                 || (isset($item['sql']) && str_contains($item['sql'], "$table.$key"));
125 125
         });
126 126
 
127
-        if (! $hasOrderByPrimaryKey) {
127
+        if (!$hasOrderByPrimaryKey) {
128 128
             $this->crud->orderByWithPrefix($this->crud->model->getKeyName(), 'DESC');
129 129
         }
130 130
 
Please login to merge, or discard this patch.
src/app/Console/Commands/AddCustomRouteContent.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 
84 84
         // otherwise, in case the last line HAS been modified
85 85
         // return the last line that has an ending in it
86
-        $possible_end_lines = array_filter($file_lines, function ($k) {
86
+        $possible_end_lines = array_filter($file_lines, function($k) {
87 87
             return strpos($k, '});') === 0;
88 88
         });
89 89
 
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
      */
105 105
     private function getLastLineNumberThatContains($needle, $haystack)
106 106
     {
107
-        $matchingLines = array_filter($haystack, function ($k) use ($needle) {
107
+        $matchingLines = array_filter($haystack, function($k) use ($needle) {
108 108
             return strpos($k, $needle) !== false;
109 109
         });
110 110
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Relationships.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
         $relation_model = $this->getRelationModel($relation_field['entity'], -1);
56 56
         $related_method = Str::afterLast($relation_field['entity'], '.');
57 57
 
58
-        if (! method_exists($relation_model, $related_method)) {
58
+        if (!method_exists($relation_model, $related_method)) {
59 59
             return Str::beforeLast($relation_field['entity'], '.');
60 60
         }
61 61
 
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
194 194
         return collect($this->fields())
195 195
             ->where('model')
196 196
             ->whereIn('relation_type', $relation_types)
197
-            ->filter(function ($item) {
197
+            ->filter(function($item) {
198 198
                 $related_model = get_class($this->model->{Str::before($item['entity'], '.')}()->getRelated());
199 199
 
200 200
                 return Str::contains($item['entity'], '.') && $item['model'] !== $related_model ? false : true;
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/FieldsProtectedMethods.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
      */
70 70
     public function overwriteFieldNameFromDotNotationToArray($field)
71 71
     {
72
-        if (! is_array($field['name']) && strpos($field['name'], '.') !== false) {
72
+        if (!is_array($field['name']) && strpos($field['name'], '.') !== false) {
73 73
             $entity_array = explode('.', $field['name']);
74 74
             $name_string = '';
75 75
 
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
             return ['name' => $field];
97 97
         }
98 98
 
99
-        if (is_array($field) && ! isset($field['name'])) {
99
+        if (is_array($field) && !isset($field['name'])) {
100 100
             abort(500, 'All fields must have their name defined');
101 101
         }
102 102
 
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
     protected function overwriteFieldNameFromEntity($field)
155 155
     {
156 156
         // if the entity doesn't have a dot, it means we don't need to overwrite the name
157
-        if (! Str::contains($field['entity'], '.')) {
157
+        if (!Str::contains($field['entity'], '.')) {
158 158
             return $field;
159 159
         }
160 160
 
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
         if (count(explode('.', $field['entity'])) == count(explode('.', $this->getOnlyRelationEntity($field)))) {
167 167
             $field['name'] = implode('.', array_slice(explode('.', $field['entity']), 0, -1));
168 168
             $relation = $this->getRelationInstance($field);
169
-            if (! empty($field['name'])) {
169
+            if (!empty($field['name'])) {
170 170
                 $field['name'] .= '.';
171 171
             }
172 172
             $field['name'] .= $relation->getForeignKeyName();
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
     {
180 180
         // if there's a model defined, but no attribute
181 181
         // guess an attribute using the identifiableAttribute functionality in CrudTrait
182
-        if (isset($field['model']) && ! isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
182
+        if (isset($field['model']) && !isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
183 183
             $field['attribute'] = call_user_func([(new $field['model']), 'identifiableAttribute']);
184 184
         }
185 185
 
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
      */
196 196
     protected function makeSureFieldHasLabel($field)
197 197
     {
198
-        if (! isset($field['label'])) {
198
+        if (!isset($field['label'])) {
199 199
             $name = is_array($field['name']) ? $field['name'][0] : $field['name'];
200 200
             $name = str_replace('_id', '', $name);
201 201
             $field['label'] = mb_ucfirst(str_replace('_', ' ', $name));
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
      */
214 214
     protected function makeSureFieldHasType($field)
215 215
     {
216
-        if (! isset($field['type'])) {
216
+        if (!isset($field['type'])) {
217 217
             $field['type'] = isset($field['relation_type']) ? $this->inferFieldTypeFromFieldRelation($field) : $this->inferFieldTypeFromDbColumnType($field['name']);
218 218
         }
219 219
 
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
     {
231 231
         // if a tab was mentioned, we should enable it
232 232
         if (isset($field['tab'])) {
233
-            if (! $this->tabsEnabled()) {
233
+            if (!$this->tabsEnabled()) {
234 234
                 $this->enableTabs();
235 235
             }
236 236
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
     {
86 86
         $all_relation_fields = $this->getRelationFields();
87 87
 
88
-        return Arr::where($all_relation_fields, function ($value, $key) {
88
+        return Arr::where($all_relation_fields, function($value, $key) {
89 89
             return isset($value['pivot']) && $value['pivot'];
90 90
         });
91 91
     }
@@ -164,11 +164,11 @@  discard block
 block discarded – undo
164 164
      */
165 165
     private function createRelationsForItem($item, $formattedData)
166 166
     {
167
-        if (! isset($formattedData['relations'])) {
167
+        if (!isset($formattedData['relations'])) {
168 168
             return false;
169 169
         }
170 170
         foreach ($formattedData['relations'] as $relationMethod => $relationData) {
171
-            if (! isset($relationData['model'])) {
171
+            if (!isset($relationData['model'])) {
172 172
                 continue;
173 173
             }
174 174
             $model = $relationData['model'];
@@ -222,13 +222,13 @@  discard block
 block discarded – undo
222 222
         foreach ($relation_fields as $relation_field) {
223 223
             $attributeKey = $this->parseRelationFieldNamesFromHtml([$relation_field])[0]['name'];
224 224
 
225
-            if (! is_null(Arr::get($data, $attributeKey)) && isset($relation_field['pivot']) && $relation_field['pivot'] !== true) {
225
+            if (!is_null(Arr::get($data, $attributeKey)) && isset($relation_field['pivot']) && $relation_field['pivot'] !== true) {
226 226
                 $key = implode('.relations.', explode('.', $this->getOnlyRelationEntity($relation_field)));
227 227
                 $fieldData = Arr::get($relationData, 'relations.'.$key, []);
228
-                if (! array_key_exists('model', $fieldData)) {
228
+                if (!array_key_exists('model', $fieldData)) {
229 229
                     $fieldData['model'] = $relation_field['model'];
230 230
                 }
231
-                if (! array_key_exists('parent', $fieldData)) {
231
+                if (!array_key_exists('parent', $fieldData)) {
232 232
                     $fieldData['parent'] = $this->getRelationModel($attributeKey, -1);
233 233
                 }
234 234
                 $relatedAttribute = Arr::last(explode('.', $attributeKey));
Please login to merge, or discard this patch.
src/app/Console/Commands/Install.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
         $this->info(' Backpack installation finished.');
60 60
 
61 61
         // DevTools
62
-        if (! file_exists('vendor/backpack/devtools')) {
62
+        if (!file_exists('vendor/backpack/devtools')) {
63 63
             $this->box('Did you know about Backpack DevTools?');
64 64
             $this->note('DevTools adds a dead-simple web interface to easily generate Models, Migrations, Seeders, Factories, CRUDs, etc.');
65 65
             $this->note('But it\'s a paid tool. For more info, payment and access, please visit https://backpackforlaravel.com/products/devtools');
Please login to merge, or discard this patch.
src/resources/views/crud/fields/checklist_dependency.blade.php 1 patch
Indentation   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -30,36 +30,36 @@
 block discarded – undo
30 30
             }
31 31
         }
32 32
 
33
-      //for update form, get initial state of the entity
34
-      if (isset($id) && $id) {
33
+        //for update form, get initial state of the entity
34
+        if (isset($id) && $id) {
35 35
 
36 36
         //get entity with relations for primary dependency
37
-          $entity_dependencies = $entity_model->with($primary_dependency['entity'])
38
-          ->with($primary_dependency['entity'].'.'.$primary_dependency['entity_secondary'])
39
-          ->find($id);
37
+            $entity_dependencies = $entity_model->with($primary_dependency['entity'])
38
+            ->with($primary_dependency['entity'].'.'.$primary_dependency['entity_secondary'])
39
+            ->find($id);
40 40
 
41
-          $secondaries_from_primary = [];
41
+            $secondaries_from_primary = [];
42 42
 
43
-          //convert relation in array
44
-          $primary_array = $entity_dependencies->{$primary_dependency['entity']}->toArray();
43
+            //convert relation in array
44
+            $primary_array = $entity_dependencies->{$primary_dependency['entity']}->toArray();
45 45
 
46
-          $secondary_ids = [];
46
+            $secondary_ids = [];
47 47
 
48
-          //create secondary dependency from primary relation, used to check what checkbox must be checked from second checklist
49
-          if (old($primary_dependency['name'])) {
50
-              foreach (old($primary_dependency['name']) as $primary_item) {
51
-                  foreach ($dependencyArray[$primary_item] as $second_item) {
52
-                      $secondary_ids[$second_item] = $second_item;
53
-                  }
54
-              }
55
-          } else { //create dependencies from relation if not from validate error
56
-              foreach ($primary_array as $primary_item) {
57
-                  foreach ($primary_item[$secondary_dependency['entity']] as $second_item) {
58
-                      $secondary_ids[$second_item['id']] = $second_item['id'];
59
-                  }
60
-              }
61
-          }
62
-      }
48
+            //create secondary dependency from primary relation, used to check what checkbox must be checked from second checklist
49
+            if (old($primary_dependency['name'])) {
50
+                foreach (old($primary_dependency['name']) as $primary_item) {
51
+                    foreach ($dependencyArray[$primary_item] as $second_item) {
52
+                        $secondary_ids[$second_item] = $second_item;
53
+                    }
54
+                }
55
+            } else { //create dependencies from relation if not from validate error
56
+                foreach ($primary_array as $primary_item) {
57
+                    foreach ($primary_item[$secondary_dependency['entity']] as $second_item) {
58
+                        $secondary_ids[$second_item['id']] = $second_item['id'];
59
+                    }
60
+                }
61
+            }
62
+        }
63 63
 
64 64
         //json encode of dependency matrix
65 65
         $dependencyJson = json_encode($dependencyArray);
Please login to merge, or discard this patch.
src/app/Console/Commands/RequireDevTools.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
 
58 58
         // Check if devtools is installed
59 59
         $tries = 2;
60
-        while (! file_exists('vendor/backpack/devtools/src/Console/Commands/InstallDevTools.php')) {
60
+        while (!file_exists('vendor/backpack/devtools/src/Console/Commands/InstallDevTools.php')) {
61 61
             // Abort at nth try
62 62
             if (--$tries === 0) {
63 63
                 $this->info('');
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
         $this->info(' Now running the DevTools installation command.');
90 90
 
91 91
         // manually include the command in the run-time
92
-        if (! class_exists(\Backpack\DevTools\Console\Commands\InstallDevTools::class)) {
92
+        if (!class_exists(\Backpack\DevTools\Console\Commands\InstallDevTools::class)) {
93 93
             include base_path('vendor/backpack/devtools/src/Console/Commands/InstallDevTools.php');
94 94
         }
95 95
 
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
     {
101 101
         $details = null;
102 102
         $process = new Process(['composer', 'config', 'repositories.backpack/devtools']);
103
-        $process->run(function ($type, $buffer) use (&$details) {
103
+        $process->run(function($type, $buffer) use (&$details) {
104 104
             if ($type !== Process::ERR && $buffer !== '') {
105 105
                 $details = json_decode($buffer);
106 106
             } else {
@@ -110,11 +110,11 @@  discard block
 block discarded – undo
110 110
         });
111 111
 
112 112
         // Create repositories
113
-        if (! $details) {
113
+        if (!$details) {
114 114
             $this->info(' Creating repositories entry in composer.json');
115 115
 
116 116
             $process = new Process(['composer', 'config', 'repositories.backpack/devtools', 'composer', 'https://repo.backpackforlaravel.com']);
117
-            $process->run(function ($type, $buffer) {
117
+            $process->run(function($type, $buffer) {
118 118
                 if ($type === Process::ERR) {
119 119
                     // Fallback
120 120
                     $composerJson = Str::of(File::get('composer.json'));
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
         // Check if auth exists
149 149
         $details = null;
150 150
         $process = new Process(['composer', 'config', 'http-basic.backpackforlaravel.com']);
151
-        $process->run(function ($type, $buffer) use (&$details) {
151
+        $process->run(function($type, $buffer) use (&$details) {
152 152
             if ($type !== Process::ERR && $buffer !== '') {
153 153
                 $details = json_decode($buffer);
154 154
             } elseif (File::exists('auth.json')) {
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
         });
159 159
 
160 160
         // Create an auth.json file
161
-        if (! $details) {
161
+        if (!$details) {
162 162
             $this->info(' Creating auth.json file with your authentication token');
163 163
 
164 164
             $this->line(' (Find your access token details on https://backpackforlaravel.com/user/tokens)');
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
             $password = $this->ask('Access token password');
167 167
 
168 168
             $process = new Process(['composer', 'config', 'http-basic.backpackforlaravel.com', $username, $password]);
169
-            $process->run(function ($type, $buffer) use ($username, $password) {
169
+            $process->run(function($type, $buffer) use ($username, $password) {
170 170
                 if ($type === Process::ERR) {
171 171
                     // Fallback
172 172
                     $authFile = [
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
180 180
 
181 181
                     if (File::exists('auth.json')) {
182 182
                         $currentFile = json_decode(File::get('auth.json'), true);
183
-                        if (! ($currentFile['http-basic']['backpackforlaravel.com'] ?? false)) {
183
+                        if (!($currentFile['http-basic']['backpackforlaravel.com'] ?? false)) {
184 184
                             $authFile = array_merge_recursive($authFile, $currentFile);
185 185
                         }
186 186
                     }
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
198 198
         // Require package
199 199
         $process = new Process(['composer', 'require', '--dev', '--with-all-dependencies', 'backpack/devtools']);
200 200
         $process->setTimeout(300);
201
-        $process->run(function ($type, $buffer) use ($process) {
201
+        $process->run(function($type, $buffer) use ($process) {
202 202
             if ($type === Process::ERR) {
203 203
                 // create a log channel
204 204
                 $log = new Logger('devtools_errors');
Please login to merge, or discard this patch.