Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#3410)
by Cristian
25:21 queued 10:25
created
src/app/Http/Controllers/Operations/FetchOperation.php 1 patch
Spacing   +6 added lines, -8 removed lines patch added patch discarded remove patch
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
46 46
         // otherwise assume the arguments are actually the configuration array
47 47
         $config = [];
48 48
 
49
-        if (! is_array($arg)) {
50
-            if (! class_exists($arg)) {
49
+        if (!is_array($arg)) {
50
+            if (!class_exists($arg)) {
51 51
                 return response()->json(['error' => 'Class: '.$arg.' does not exists'], 500);
52 52
             }
53 53
             $config['model'] = $arg;
@@ -77,8 +77,7 @@  discard block
 block discarded – undo
77 77
 
78 78
         if ($search_string === false) {
79 79
             return ($config['paginate'] !== false) ?
80
-            $config['query']->paginate($config['paginate']) :
81
-            $config['query']->get();
80
+            $config['query']->paginate($config['paginate']) : $config['query']->get();
82 81
         }
83 82
 
84 83
         $textColumnTypes = ['string', 'json_string', 'text', 'longText', 'json_array', 'json'];
@@ -89,8 +88,8 @@  discard block
 block discarded – undo
89 88
         // .... 'query' => function($model) { return $model->where('active', 1); }
90 89
         // So it reads: SELECT ... WHERE active = 1 AND (XXX = x OR YYY = y) and not SELECT ... WHERE active = 1 AND XXX = x OR YYY = y;
91 90
 
92
-        if (! empty($config['query']->getQuery()->wheres)) {
93
-            $config['query'] = $config['query']->where(function ($query) use ($model_instance, $config, $search_string, $textColumnTypes) {
91
+        if (!empty($config['query']->getQuery()->wheres)) {
92
+            $config['query'] = $config['query']->where(function($query) use ($model_instance, $config, $search_string, $textColumnTypes) {
94 93
                 foreach ((array) $config['searchable_attributes'] as $k => $searchColumn) {
95 94
                     $operation = ($k == 0) ? 'where' : 'orWhere';
96 95
                     $columnType = $model_instance->getColumnType($searchColumn);
@@ -122,7 +121,6 @@  discard block
 block discarded – undo
122 121
 
123 122
         // return the results with or without pagination
124 123
         return ($config['paginate'] !== false) ?
125
-                    $config['query']->paginate($config['paginate']) :
126
-                    $config['query']->get();
124
+                    $config['query']->paginate($config['paginate']) : $config['query']->get();
127 125
     }
128 126
 }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Read.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
      */
57 57
     public function getEntry($id)
58 58
     {
59
-        if (! $this->entry) {
59
+        if (!$this->entry) {
60 60
             $this->entry = $this->model->findOrFail($id);
61 61
             $this->entry = $this->entry->withFakes();
62 62
         }
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
                 // we will apply the same labels as the values to the menu if developer didn't
259 259
                 $this->abortIfInvalidPageLength($menu[0]);
260 260
 
261
-                if (! isset($menu[1]) || ! is_array($menu[1])) {
261
+                if (!isset($menu[1]) || !is_array($menu[1])) {
262 262
                     $menu[1] = $menu[0];
263 263
                 }
264 264
             } else {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Relationships.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
         return collect($this->fields())
62 62
             ->where('model')
63 63
             ->whereIn('relation_type', $relation_types)
64
-            ->filter(function ($item) {
64
+            ->filter(function($item) {
65 65
                 $related_model = get_class($this->model->{Str::before($item['entity'], '.')}()->getRelated());
66 66
 
67 67
                 return Str::contains($item['entity'], '.') && $item['model'] !== $related_model ? false : true;
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
         $relation_model = $this->getRelationModel($relation_field['entity'], -1);
207 207
         $related_method = Str::afterLast($relation_field['entity'], '.');
208 208
 
209
-        if (! method_exists($relation_model, $related_method) && $this->isNestedRelation($relation_field)) {
209
+        if (!method_exists($relation_model, $related_method) && $this->isNestedRelation($relation_field)) {
210 210
             return Str::beforeLast($relation_field['entity'], '.');
211 211
         }
212 212
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ListOperation.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     {
42 42
         $this->crud->allowAccess('list');
43 43
 
44
-        $this->crud->operation('list', function () {
44
+        $this->crud->operation('list', function() {
45 45
             $this->crud->loadDefaultOperationSettingsFromConfig();
46 46
         });
47 47
     }
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
                 $column_number = (int) $order['column'];
100 100
                 $column_direction = (strtolower((string) $order['dir']) == 'asc' ? 'ASC' : 'DESC');
101 101
                 $column = $this->crud->findColumnById($column_number);
102
-                if ($column['tableColumn'] && ! isset($column['orderLogic'])) {
102
+                if ($column['tableColumn'] && !isset($column['orderLogic'])) {
103 103
                     // apply the current orderBy rules
104 104
                     $this->crud->orderByWithPrefix($column['name'], $column_direction);
105 105
                 }
@@ -119,12 +119,12 @@  discard block
 block discarded – undo
119 119
         $table = $this->crud->model->getTable();
120 120
         $key = $this->crud->model->getKeyName();
121 121
 
122
-        $hasOrderByPrimaryKey = collect($orderBy)->some(function ($item) use ($key, $table) {
122
+        $hasOrderByPrimaryKey = collect($orderBy)->some(function($item) use ($key, $table) {
123 123
             return (isset($item['column']) && $item['column'] === $key)
124 124
                 || (isset($item['sql']) && str_contains($item['sql'], "$table.$key"));
125 125
         });
126 126
 
127
-        if (! $hasOrderByPrimaryKey) {
127
+        if (!$hasOrderByPrimaryKey) {
128 128
             $this->crud->orderByWithPrefix($this->crud->model->getKeyName(), 'DESC');
129 129
         }
130 130
 
Please login to merge, or discard this patch.
src/app/Console/Commands/AddCustomRouteContent.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 
84 84
         // otherwise, in case the last line HAS been modified
85 85
         // return the last line that has an ending in it
86
-        $possible_end_lines = array_filter($file_lines, function ($k) {
86
+        $possible_end_lines = array_filter($file_lines, function($k) {
87 87
             return strpos($k, '});') === 0;
88 88
         });
89 89
 
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
      */
105 105
     private function getLastLineNumberThatContains($needle, $haystack)
106 106
     {
107
-        $matchingLines = array_filter($haystack, function ($k) use ($needle) {
107
+        $matchingLines = array_filter($haystack, function($k) use ($needle) {
108 108
             return strpos($k, $needle) !== false;
109 109
         });
110 110
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/FieldsProtectedMethods.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
      */
70 70
     public function overwriteFieldNameFromDotNotationToArray($field)
71 71
     {
72
-        if (! is_array($field['name']) && strpos($field['name'], '.') !== false) {
72
+        if (!is_array($field['name']) && strpos($field['name'], '.') !== false) {
73 73
             $entity_array = explode('.', $field['name']);
74 74
             $name_string = '';
75 75
 
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
             return ['name' => $field];
97 97
         }
98 98
 
99
-        if (is_array($field) && ! isset($field['name'])) {
99
+        if (is_array($field) && !isset($field['name'])) {
100 100
             abort(500, 'All fields must have their name defined');
101 101
         }
102 102
 
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
     protected function overwriteFieldNameFromEntity($field)
155 155
     {
156 156
         // if the entity doesn't have a dot, it means we don't need to overwrite the name
157
-        if (! Str::contains($field['entity'], '.')) {
157
+        if (!Str::contains($field['entity'], '.')) {
158 158
             return $field;
159 159
         }
160 160
 
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
         if (count(explode('.', $field['entity'])) == count(explode('.', $this->getOnlyRelationEntity($field)))) {
167 167
             $field['name'] = implode('.', array_slice(explode('.', $field['entity']), 0, -1));
168 168
             $relation = $this->getRelationInstance($field);
169
-            if (! empty($field['name'])) {
169
+            if (!empty($field['name'])) {
170 170
                 $field['name'] .= '.';
171 171
             }
172 172
             $field['name'] .= $relation->getForeignKeyName();
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
     {
180 180
         // if there's a model defined, but no attribute
181 181
         // guess an attribute using the identifiableAttribute functionality in CrudTrait
182
-        if (isset($field['model']) && ! isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
182
+        if (isset($field['model']) && !isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
183 183
             $field['attribute'] = call_user_func([(new $field['model']), 'identifiableAttribute']);
184 184
         }
185 185
 
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
      */
196 196
     protected function makeSureFieldHasLabel($field)
197 197
     {
198
-        if (! isset($field['label'])) {
198
+        if (!isset($field['label'])) {
199 199
             $name = is_array($field['name']) ? $field['name'][0] : $field['name'];
200 200
             $name = str_replace('_id', '', $name);
201 201
             $field['label'] = mb_ucfirst(str_replace('_', ' ', $name));
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
      */
214 214
     protected function makeSureFieldHasType($field)
215 215
     {
216
-        if (! isset($field['type'])) {
216
+        if (!isset($field['type'])) {
217 217
             $field['type'] = isset($field['relation_type']) ? $this->inferFieldTypeFromFieldRelation($field) : $this->inferFieldTypeFromDbColumnType($field['name']);
218 218
         }
219 219
 
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
     {
231 231
         // if a tab was mentioned, we should enable it
232 232
         if (isset($field['tab'])) {
233
-            if (! $this->tabsEnabled()) {
233
+            if (!$this->tabsEnabled()) {
234 234
                 $this->enableTabs();
235 235
             }
236 236
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
     {
89 89
         $all_relation_fields = $this->getRelationFields();
90 90
 
91
-        return Arr::where($all_relation_fields, function ($value, $key) {
91
+        return Arr::where($all_relation_fields, function($value, $key) {
92 92
             return isset($value['pivot']) && $value['pivot'];
93 93
         });
94 94
     }
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
                             $field_data = json_decode($data[$field['name']], true);
153 153
 
154 154
                             // we grab from the parsed data the specific values for this pivot
155
-                            $pivot_data = Arr::first($field_data, function ($item) use ($pivot_id, $field) {
155
+                            $pivot_data = Arr::first($field_data, function($item) use ($pivot_id, $field) {
156 156
                                 return $item[$field['name']] === $pivot_id;
157 157
                             });
158 158
 
@@ -185,12 +185,12 @@  discard block
 block discarded – undo
185 185
      */
186 186
     private function createRelationsForItem($item, $formattedData)
187 187
     {
188
-        if (! isset($formattedData['relations'])) {
188
+        if (!isset($formattedData['relations'])) {
189 189
             return false;
190 190
         }
191 191
         
192 192
         foreach ($formattedData['relations'] as $relationMethod => $relationData) {
193
-            if (! isset($relationData['model'])) {
193
+            if (!isset($relationData['model'])) {
194 194
                 continue;
195 195
             }
196 196
 
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
                     // we first check if there are relations of the relation
205 205
                     if (isset($relationData['relations'])) {
206 206
                         // if there are nested relations, we first add the BelongsTo like in main entry
207
-                        $belongsToRelations = Arr::where($relationData['relations'], function ($relation_data) {
207
+                        $belongsToRelations = Arr::where($relationData['relations'], function($relation_data) {
208 208
                             return $relation_data['relation_type'] == 'BelongsTo';
209 209
                         });
210 210
 
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
                         $valuesWithRelations = $this->associateHasOneBelongsTo($belongsToRelations, $relationData['values'], $relation->getModel());
214 214
 
215 215
                         // remove previously added BelongsTo relations from relation data.
216
-                        $relationData['relations'] = Arr::where($relationData['relations'], function ($item) {
216
+                        $relationData['relations'] = Arr::where($relationData['relations'], function($item) {
217 217
                             return $item['relation_type'] != 'BelongsTo';
218 218
                         });
219 219
 
@@ -286,7 +286,7 @@  discard block
 block discarded – undo
286 286
     private function getRelationDataFromFormData($data)
287 287
     {
288 288
         // exclude the already attached belongs to relations but include nested belongs to.
289
-        $relation_fields = Arr::where($this->getRelationFields(), function ($field, $key) {
289
+        $relation_fields = Arr::where($this->getRelationFields(), function($field, $key) {
290 290
             return $field['relation_type'] !== 'BelongsTo' || $this->isNestedRelation($field);
291 291
         });
292 292
 
@@ -295,13 +295,13 @@  discard block
 block discarded – undo
295 295
         foreach ($relation_fields as $relation_field) {
296 296
             $attributeKey = $this->parseRelationFieldNamesFromHtml([$relation_field])[0]['name'];
297 297
 
298
-            if ((! is_null(Arr::get($data, $attributeKey)) || $this->isNestedRelation($relation_field)) && isset($relation_field['pivot']) && $relation_field['pivot'] !== true) {
298
+            if ((!is_null(Arr::get($data, $attributeKey)) || $this->isNestedRelation($relation_field)) && isset($relation_field['pivot']) && $relation_field['pivot'] !== true) {
299 299
                 $key = implode('.relations.', explode('.', $this->getOnlyRelationEntity($relation_field)));
300 300
                 $fieldData = Arr::get($relationData, 'relations.'.$key, []);
301
-                if (! array_key_exists('model', $fieldData)) {
301
+                if (!array_key_exists('model', $fieldData)) {
302 302
                     $fieldData['model'] = $relation_field['model'];
303 303
                 }
304
-                if (! array_key_exists('parent', $fieldData)) {
304
+                if (!array_key_exists('parent', $fieldData)) {
305 305
                     $fieldData['parent'] = $this->getRelationModel($attributeKey, -1);
306 306
                 }
307 307
 
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
                 // this allow developers to override that behavior and force deletion from database
316 316
                 $fieldData['force_delete'] = $relation_field['force_delete'] ?? false;
317 317
 
318
-                if (! array_key_exists('relation_type', $fieldData)) {
318
+                if (!array_key_exists('relation_type', $fieldData)) {
319 319
                     $fieldData['relation_type'] = $relation_field['relation_type'];
320 320
                 }
321 321
                 $relatedAttribute = Arr::last(explode('.', $attributeKey));
@@ -358,7 +358,7 @@  discard block
 block discarded – undo
358 358
                     ->where($relation_foreign_key, $item->{$relation_local_key})
359 359
                     ->update([$relation_foreign_key => $relationData['fallback_id']]);
360 360
             } else {
361
-                if (! $relation_column_is_nullable || $force_delete) {
361
+                if (!$relation_column_is_nullable || $force_delete) {
362 362
                     $model_instance->whereNotIn($model_instance->getKeyName(), $relation_values)
363 363
                         ->where($relation_foreign_key, $item->{$relation_local_key})
364 364
                         ->delete();
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
375 375
                 $model_instance->where($relation_foreign_key, $item->{$relation_local_key})
376 376
                     ->update([$relation_foreign_key => $relationData['fallback_id']]);
377 377
             } else {
378
-                if (! $relation_column_is_nullable || $force_delete) {
378
+                if (!$relation_column_is_nullable || $force_delete) {
379 379
                     $model_instance->where($relation_foreign_key, $item->{$relation_local_key})->delete();
380 380
                 } else {
381 381
                     $model_instance->where($relation_foreign_key, $item->{$relation_local_key})
@@ -405,7 +405,7 @@  discard block
 block discarded – undo
405 405
             $created_ids = [];
406 406
 
407 407
             foreach ($items as $item) {
408
-                if (isset($item[$relation_local_key]) && ! empty($item[$relation_local_key])) {
408
+                if (isset($item[$relation_local_key]) && !empty($item[$relation_local_key])) {
409 409
                     $entry->{$relationMethod}()->updateOrCreate([$relation_local_key => $item[$relation_local_key]], $item);
410 410
                 } else {
411 411
                     $created_ids[] = $entry->{$relationMethod}()->create($item)->{$relation_local_key};
@@ -415,7 +415,7 @@  discard block
 block discarded – undo
415 415
             // get from $items the sent ids, and merge the ones created.
416 416
             $relatedItemsSent = array_merge(array_filter(Arr::pluck($items, $relation_local_key)), $created_ids);
417 417
 
418
-            if (! empty($relatedItemsSent)) {
418
+            if (!empty($relatedItemsSent)) {
419 419
                 // we perform the cleanup of removed database items
420 420
                 $entry->{$relationMethod}()->whereNotIn($relation_local_key, $relatedItemsSent)->delete();
421 421
             }
Please login to merge, or discard this patch.