Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#3410)
by Cristian
25:21 queued 10:25
created
src/routes/backpack/custom.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,5 +13,5 @@
 block discarded – undo
13 13
         (array) config('backpack.base.middleware_key', 'admin')
14 14
     ),
15 15
     'namespace'  => 'App\Http\Controllers\Admin',
16
-], function () { // custom admin routes
16
+], function() { // custom admin routes
17 17
 }); // this should be the absolute last line of this file
Please login to merge, or discard this patch.
config/database/migrations/2017_09_08_000001_create_addresses_table.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
      */
14 14
     public function up()
15 15
     {
16
-        Schema::create('addresses', function (Blueprint $table) {
16
+        Schema::create('addresses', function(Blueprint $table) {
17 17
             $table->increments('id');
18 18
             $table->integer('account_details_id')->unsigned();
19 19
             $table->string('city')->nullable();
Please login to merge, or discard this patch.
tests/Unit/Http/CrudControllerTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 
27 27
         $app['router']->get('admin/users', "$controller@index")->name('admin.users.index');
28 28
 
29
-        $app->singleton('crud', function ($app) {
29
+        $app->singleton('crud', function($app) {
30 30
             return new CrudPanel($app);
31 31
         });
32 32
 
Please login to merge, or discard this patch.
database/migrations/2017_09_08_000001_create_account_details_table.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
      */
14 14
     public function up()
15 15
     {
16
-        Schema::create('account_details', function (Blueprint $table) {
16
+        Schema::create('account_details', function(Blueprint $table) {
17 17
             $table->increments('id');
18 18
             $table->integer('user_id')->unsigned();
19 19
             $table->string('nickname');
Please login to merge, or discard this patch.
src/app/Models/Traits/HasRelationshipFields.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
         $table = $instance->getTableWithPrefix();
73 73
 
74 74
         // MongoDB columns are alway nullable
75
-        if (! in_array($conn->getConfig()['driver'], CRUD::getSqlDriverList())) {
75
+        if (!in_array($conn->getConfig()['driver'], CRUD::getSqlDriverList())) {
76 76
             return true;
77 77
         }
78 78
 
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
             // check for NOT NULL
83 83
             $notNull = $column->getNotnull();
84 84
             // return the value of nullable (aka the inverse of NOT NULL)
85
-            return ! $notNull;
85
+            return !$notNull;
86 86
         } catch (\Exception $e) {
87 87
             return true;
88 88
         }
Please login to merge, or discard this patch.
src/helpers.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-if (! function_exists('backpack_url')) {
3
+if (!function_exists('backpack_url')) {
4 4
     /**
5 5
      * Appends the configured backpack prefix and returns
6 6
      * the URL using the standard Laravel helpers.
@@ -11,13 +11,13 @@  discard block
 block discarded – undo
11 11
      */
12 12
     function backpack_url($path = null, $parameters = [], $secure = null)
13 13
     {
14
-        $path = ! $path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
14
+        $path = !$path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
15 15
 
16 16
         return url(config('backpack.base.route_prefix', 'admin').$path, $parameters, $secure);
17 17
     }
18 18
 }
19 19
 
20
-if (! function_exists('backpack_authentication_column')) {
20
+if (!function_exists('backpack_authentication_column')) {
21 21
     /**
22 22
      * Return the username column name.
23 23
      * The Laravel default (and Backpack default) is 'email'.
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
     }
31 31
 }
32 32
 
33
-if (! function_exists('backpack_form_input')) {
33
+if (!function_exists('backpack_form_input')) {
34 34
     /**
35 35
      * Parse the submitted input in request('form') to an usable array.
36 36
      * Joins the multiple[] fields in a single key and transform the dot notation fields into arrayed ones.
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
             }
60 60
 
61 61
             if (is_null($input_arg)) {
62
-                if (! isset($result[$input_key])) {
62
+                if (!isset($result[$input_key])) {
63 63
                     $result[$input_key] = $start ? [$row['value']] : $row['value'];
64 64
                 } else {
65 65
                     array_push($result[$input_key], $row['value']);
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
     }
74 74
 }
75 75
 
76
-if (! function_exists('backpack_users_have_email')) {
76
+if (!function_exists('backpack_users_have_email')) {
77 77
     /**
78 78
      * Check if the email column is present on the user table.
79 79
      *
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
     }
89 89
 }
90 90
 
91
-if (! function_exists('backpack_avatar_url')) {
91
+if (!function_exists('backpack_avatar_url')) {
92 92
     /**
93 93
      * Returns the avatar URL of a user.
94 94
      *
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
     }
122 122
 }
123 123
 
124
-if (! function_exists('backpack_middleware')) {
124
+if (!function_exists('backpack_middleware')) {
125 125
     /**
126 126
      * Return the key of the middleware used across Backpack.
127 127
      * That middleware checks if the visitor is an admin.
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
     }
137 137
 }
138 138
 
139
-if (! function_exists('backpack_guard_name')) {
139
+if (!function_exists('backpack_guard_name')) {
140 140
     /*
141 141
      * Returns the name of the guard defined
142 142
      * by the application config
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
     }
148 148
 }
149 149
 
150
-if (! function_exists('backpack_auth')) {
150
+if (!function_exists('backpack_auth')) {
151 151
     /*
152 152
      * Returns the user instance if it exists
153 153
      * of the currently authenticated admin
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
     }
160 160
 }
161 161
 
162
-if (! function_exists('backpack_user')) {
162
+if (!function_exists('backpack_user')) {
163 163
     /*
164 164
      * Returns back a user instance without
165 165
      * the admin guard, however allows you
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
     }
172 172
 }
173 173
 
174
-if (! function_exists('mb_ucfirst')) {
174
+if (!function_exists('mb_ucfirst')) {
175 175
     /**
176 176
      * Capitalize the first letter of a string,
177 177
      * even if that string is multi-byte (non-latin alphabet).
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
     }
194 194
 }
195 195
 
196
-if (! function_exists('backpack_view')) {
196
+if (!function_exists('backpack_view')) {
197 197
     /**
198 198
      * Returns a new displayable view based on the configured backpack view namespace.
199 199
      * If that view doesn't exist, it will load the one from the original theme.
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
 
214 214
         $returnView = $theme.$view;
215 215
 
216
-        if (! view()->exists($returnView)) {
216
+        if (!view()->exists($returnView)) {
217 217
             $returnView = $originalTheme.$view;
218 218
         }
219 219
 
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
     }
222 222
 }
223 223
 
224
-if (! function_exists('square_brackets_to_dots')) {
224
+if (!function_exists('square_brackets_to_dots')) {
225 225
     /**
226 226
      * Turns a string from bracket-type array to dot-notation array.
227 227
      * Ex: array[0][property] turns into array.0.property.
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
     }
239 239
 }
240 240
 
241
-if (! function_exists('is_countable')) {
241
+if (!function_exists('is_countable')) {
242 242
     /**
243 243
      * We need this because is_countable was only introduced in PHP 7.3,
244 244
      * and in PHP 7.2 you should check if count() argument is really countable.
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Update.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 
61 61
         foreach ($fields as &$field) {
62 62
             // set the value
63
-            if (! isset($field['value'])) {
63
+            if (!isset($field['value'])) {
64 64
                 if (isset($field['subfields'])) {
65 65
                     $field['value'] = [];
66 66
                     foreach ($field['subfields'] as $subfield) {
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
         }
74 74
 
75 75
         // always have a hidden input for the entry id
76
-        if (! array_key_exists('id', $fields)) {
76
+        if (!array_key_exists('id', $fields)) {
77 77
             $fields['id'] = [
78 78
                 'name'  => $entry->getKeyName(),
79 79
                 'value' => $entry->getKey(),
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
 
100 100
             $relation_array = explode('.', $relational_entity);
101 101
 
102
-            $relatedModel = array_reduce(array_splice($relation_array, 0, -1), function ($obj, $method) {
102
+            $relatedModel = array_reduce(array_splice($relation_array, 0, -1), function($obj, $method) {
103 103
                 return $obj->{$method} ? $obj->{$method} : $obj;
104 104
             }, $model);
105 105
 
@@ -162,11 +162,11 @@  discard block
 block discarded – undo
162 162
      */
163 163
     private function getManyRelationAttributeValue($model, $relation_method, $field, $relation_type)
164 164
     {
165
-        if (! isset($field['pivotFields']) || ! is_array($field['pivotFields'])) {
165
+        if (!isset($field['pivotFields']) || !is_array($field['pivotFields'])) {
166 166
             return false;
167 167
         }
168 168
 
169
-        $pivot_fields = Arr::where($field['pivotFields'], function ($item) use ($field) {
169
+        $pivot_fields = Arr::where($field['pivotFields'], function($item) use ($field) {
170 170
             return $field['name'] != $item['name'];
171 171
         });
172 172
         $related_models = $model->{$relation_method};
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Columns.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
      */
115 115
     public function makeFirstColumn()
116 116
     {
117
-        if (! $this->columns()) {
117
+        if (!$this->columns()) {
118 118
             return false;
119 119
         }
120 120
 
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
      */
160 160
     public function removeColumns($columns)
161 161
     {
162
-        if (! empty($columns)) {
162
+        if (!empty($columns)) {
163 163
             foreach ($columns as $columnKey) {
164 164
                 $this->removeColumn($columnKey);
165 165
             }
@@ -252,8 +252,8 @@  discard block
 block discarded – undo
252 252
     {
253 253
         $columns = $this->columns();
254 254
 
255
-        return collect($columns)->pluck('entity')->reject(function ($value, $key) {
256
-            return ! $value;
255
+        return collect($columns)->pluck('entity')->reject(function($value, $key) {
256
+            return !$value;
257 257
         })->toArray();
258 258
     }
259 259
 
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
      */
330 330
     public function hasColumnWhere($attribute, $value)
331 331
     {
332
-        $match = Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
332
+        $match = Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
333 333
             return isset($column[$attribute]) && $column[$attribute] == $value;
334 334
         });
335 335
 
@@ -345,7 +345,7 @@  discard block
 block discarded – undo
345 345
      */
346 346
     public function firstColumnWhere($attribute, $value)
347 347
     {
348
-        return Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
348
+        return Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
349 349
             return isset($column[$attribute]) && $column[$attribute] == $value;
350 350
         });
351 351
     }
@@ -395,8 +395,8 @@  discard block
 block discarded – undo
395 395
      */
396 396
     public function countColumnsWithoutActions()
397 397
     {
398
-        return collect($this->columns())->filter(function ($column, $key) {
399
-            return ! isset($column['hasActions']) || $column['hasActions'] == false;
398
+        return collect($this->columns())->filter(function($column, $key) {
399
+            return !isset($column['hasActions']) || $column['hasActions'] == false;
400 400
         })->count();
401 401
     }
402 402
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/AutoSet.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
             $this->getDbColumnTypes();
17 17
         }
18 18
 
19
-        array_map(function ($field) {
19
+        array_map(function($field) {
20 20
             $new_field = [
21 21
                 'name'       => $field,
22 22
                 'label'      => $this->makeLabel($field),
@@ -28,11 +28,11 @@  discard block
 block discarded – undo
28 28
                 'autoset'    => true,
29 29
             ];
30 30
 
31
-            if (! isset($this->fields()[$field])) {
31
+            if (!isset($this->fields()[$field])) {
32 32
                 $this->addField($new_field);
33 33
             }
34 34
 
35
-            if (! in_array($field, $this->model->getHidden()) && ! in_array($field, $this->columns())) {
35
+            if (!in_array($field, $this->model->getHidden()) && !in_array($field, $this->columns())) {
36 36
                 $this->addColumn([
37 37
                     'name'    => $field,
38 38
                     'label'   => $this->makeLabel($field),
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 
111 111
         $dbColumnTypes = $this->getDbColumnTypes();
112 112
 
113
-        if (! isset($dbColumnTypes[$fieldName])) {
113
+        if (!isset($dbColumnTypes[$fieldName])) {
114 114
             return 'text';
115 115
         }
116 116
 
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
         $types = ['enum' => 'string'];
169 169
         $platform = $this->getSchema()->getConnection()->getDoctrineSchemaManager()->getDatabasePlatform();
170 170
         foreach ($types as $type_key => $type_value) {
171
-            if (! $platform->hasDoctrineTypeMappingFor($type_key)) {
171
+            if (!$platform->hasDoctrineTypeMappingFor($type_key)) {
172 172
                 $platform->registerDoctrineTypeMapping($type_key, $type_value);
173 173
             }
174 174
         }
@@ -221,13 +221,13 @@  discard block
 block discarded – undo
221 221
     {
222 222
         $fillable = $this->model->getFillable();
223 223
 
224
-        if (! $this->driverIsSql()) {
224
+        if (!$this->driverIsSql()) {
225 225
             $columns = $fillable;
226 226
         } else {
227 227
             // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model
228 228
             $columns = $this->model->getConnection()->getSchemaBuilder()->getColumnListing($this->model->getTable());
229 229
 
230
-            if (! empty($fillable)) {
230
+            if (!empty($fillable)) {
231 231
                 $columns = array_intersect($columns, $fillable);
232 232
             }
233 233
         }
Please login to merge, or discard this patch.