Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#2048)
by Tomoya
04:29
created
src/app/Http/Controllers/Operations/RevisionsOperation.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
         $this->crud->setOperation('revisions');
47 47
 
48 48
         $revisionId = \Request::input('revision_id', false);
49
-        if (! $revisionId) {
49
+        if (!$revisionId) {
50 50
             abort(500, 'Can\'t restore revision without revision_id');
51 51
         } else {
52 52
             $this->crud->restoreRevision($id, $revisionId); // do the update
Please login to merge, or discard this patch.
src/resources/views/columns/array_count.blade.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@
 block discarded – undo
5 5
 
6 6
 <span>
7 7
     <?php
8
-    $suffix = isset($column['suffix'])?$column['suffix']:'items';
8
+    $suffix = isset($column['suffix']) ? $column['suffix'] : 'items';
9 9
 
10 10
     // the value should be an array wether or not attribute casting is used
11 11
     if (!is_array($array)) {
Please login to merge, or discard this patch.
src/PanelTraits/Buttons.php 2 patches
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
          */
109 109
         $button = $this->buttons()->firstWhere('name', $name);
110 110
 
111
-        if (! $button) {
111
+        if (!$button) {
112 112
             abort(500, 'CRUD Button "'.$name.'" not found. Please check the button exists before you modify it.');
113 113
         }
114 114
 
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
      */
130 130
     public function removeButton($name, $stack = null)
131 131
     {
132
-        $this->buttons = $this->buttons->reject(function ($button) use ($name, $stack) {
132
+        $this->buttons = $this->buttons->reject(function($button) use ($name, $stack) {
133 133
             return $stack == null ? $button->name == $name : ($button->stack == $stack) && ($button->name == $name);
134 134
         });
135 135
     }
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
      */
141 141
     public function removeButtons($names, $stack = null)
142 142
     {
143
-        if (! empty($names)) {
143
+        if (!empty($names)) {
144 144
             foreach ($names as $name) {
145 145
                 $this->removeButton($name, $stack);
146 146
             }
@@ -154,14 +154,14 @@  discard block
 block discarded – undo
154 154
 
155 155
     public function removeAllButtonsFromStack($stack)
156 156
     {
157
-        $this->buttons = $this->buttons->reject(function ($button) use ($stack) {
157
+        $this->buttons = $this->buttons->reject(function($button) use ($stack) {
158 158
             return $button->stack == $stack;
159 159
         });
160 160
     }
161 161
 
162 162
     public function removeButtonFromStack($name, $stack)
163 163
     {
164
-        $this->buttons = $this->buttons->reject(function ($button) use ($name, $stack) {
164
+        $this->buttons = $this->buttons->reject(function($button) use ($name, $stack) {
165 165
             return $button->name == $name && $button->stack == $stack;
166 166
         });
167 167
     }
Please login to merge, or discard this patch.
Doc Comments   +12 added lines patch added patch discarded remove patch
@@ -62,6 +62,9 @@  discard block
 block discarded – undo
62 62
         $this->addButton($stack, $name, 'model_function', $model_function_name, $position);
63 63
     }
64 64
 
65
+    /**
66
+     * @param string $view
67
+     */
65 68
     public function addButtonFromView($stack, $name, $view, $position = false)
66 69
     {
67 70
         $view = 'crud::buttons.'.$view;
@@ -139,6 +142,9 @@  discard block
 block discarded – undo
139 142
         $this->buttons = collect([]);
140 143
     }
141 144
 
145
+    /**
146
+     * @param string $stack
147
+     */
142 148
     public function removeAllButtonsFromStack($stack)
143 149
     {
144 150
         $this->buttons = $this->buttons->reject(function ($button) use ($stack) {
@@ -161,6 +167,12 @@  discard block
 block discarded – undo
161 167
     public $type = 'view';
162 168
     public $content;
163 169
 
170
+    /**
171
+     * @param string $stack
172
+     * @param string $name
173
+     * @param string $type
174
+     * @param string $content
175
+     */
164 176
     public function __construct($stack, $name, $type, $content)
165 177
     {
166 178
         $this->stack = $stack;
Please login to merge, or discard this patch.
src/helpers.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-if (! function_exists('square_brackets_to_dots')) {
3
+if (!function_exists('square_brackets_to_dots')) {
4 4
     /**
5 5
      * Turns a string from bracket-type array to dot-notation array.
6 6
      * Ex: array[0][property] turns into array.0.property.
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
     }
18 18
 }
19 19
 
20
-if (! function_exists('is_countable')) {
20
+if (!function_exists('is_countable')) {
21 21
     /**
22 22
      * We need this because is_countable was only introduced in PHP 7.3,
23 23
      * and in PHP 7.2 you should check if count() argument is really countable.
Please login to merge, or discard this patch.
src/resources/views/columns/select_from_array.blade.php 1 patch
Indentation   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -5,24 +5,24 @@
 block discarded – undo
5 5
 
6 6
 <span>
7 7
 	<?php
8
-		if ($values !== null) {
9
-			if (is_array($values)) {
10
-				$array_of_values = [];
8
+        if ($values !== null) {
9
+            if (is_array($values)) {
10
+                $array_of_values = [];
11 11
 
12
-				foreach ($values as $key => $value) {
13
-					$array_of_values[] = $column['options'][$value];
14
-				}
12
+                foreach ($values as $key => $value) {
13
+                    $array_of_values[] = $column['options'][$value];
14
+                }
15 15
 
16
-				if (count($array_of_values) > 1) {
17
-					echo implode(', ', $array_of_values);
18
-				} else {
19
-					echo $array_of_values;
20
-				}
21
-			} else {
22
-				echo $column['options'][$values];
23
-			}
24
-	    } else {
25
-	    	echo "-";
26
-	    }
27
-	?>
16
+                if (count($array_of_values) > 1) {
17
+                    echo implode(', ', $array_of_values);
18
+                } else {
19
+                    echo $array_of_values;
20
+                }
21
+            } else {
22
+                echo $column['options'][$values];
23
+            }
24
+        } else {
25
+            echo "-";
26
+        }
27
+    ?>
28 28
 </span>
29 29
\ No newline at end of file
Please login to merge, or discard this patch.
src/resources/views/fields/datetime.blade.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@
 block discarded – undo
3 3
 <?php
4 4
 // if the column has been cast to Carbon or Date (using attribute casting)
5 5
 // get the value as a date string
6
-if (isset($field['value']) && ( $field['value'] instanceof \Carbon\CarbonInterface )) {
6
+if (isset($field['value']) && ($field['value'] instanceof \Carbon\CarbonInterface)) {
7 7
     $field['value'] = $field['value']->toDateTimeString();
8 8
 }
9 9
 ?>
Please login to merge, or discard this patch.
src/resources/views/fields/date_picker.blade.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3,11 +3,11 @@
 block discarded – undo
3 3
 <?php
4 4
     // if the column has been cast to Carbon or Date (using attribute casting)
5 5
     // get the value as a date string
6
-    if (isset($field['value']) && ( $field['value'] instanceof \Carbon\CarbonInterface )) {
6
+    if (isset($field['value']) && ($field['value'] instanceof \Carbon\CarbonInterface)) {
7 7
         $field['value'] = $field['value']->format('Y-m-d');
8 8
     }
9 9
 
10
-    $field_language = isset($field['date_picker_options']['language'])?$field['date_picker_options']['language']:\App::getLocale();
10
+    $field_language = isset($field['date_picker_options']['language']) ? $field['date_picker_options']['language'] : \App::getLocale();
11 11
 
12 12
     if (!isset($field['attributes']['style'])) {
13 13
         $field['attributes']['style'] = 'background-color: white!important;';
Please login to merge, or discard this patch.
src/resources/views/fields/date.blade.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@
 block discarded – undo
3 3
 <?php
4 4
 // if the column has been cast to Carbon or Date (using attribute casting)
5 5
 // get the value as a date string
6
-if (isset($field['value']) && ( $field['value'] instanceof \Carbon\CarbonInterface )) {
6
+if (isset($field['value']) && ($field['value'] instanceof \Carbon\CarbonInterface)) {
7 7
     $field['value'] = $field['value']->toDateString();
8 8
 }
9 9
 ?>
Please login to merge, or discard this patch.
src/resources/views/fields/datetime_picker.blade.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3,11 +3,11 @@
 block discarded – undo
3 3
 <?php
4 4
 // if the column has been cast to Carbon or Date (using attribute casting)
5 5
 // get the value as a date string
6
-if (isset($field['value']) && ( $field['value'] instanceof \Carbon\CarbonInterface )) {
6
+if (isset($field['value']) && ($field['value'] instanceof \Carbon\CarbonInterface)) {
7 7
     $field['value'] = $field['value']->format('Y-m-d H:i:s');
8 8
 }
9 9
 
10
-    $field_language = isset($field['datetime_picker_options']['language'])?$field['datetime_picker_options']['language']:\App::getLocale();
10
+    $field_language = isset($field['datetime_picker_options']['language']) ? $field['datetime_picker_options']['language'] : \App::getLocale();
11 11
 ?>
12 12
 
13 13
 <div @include('crud::inc.field_wrapper_attributes') >
Please login to merge, or discard this patch.