Backpack\CRUD\PanelTraits\Columns

Complexity

Total Complexity

32

Size/Duplication

Total Lines	236
Duplicated Lines	6.78 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

17 Methods

Rating	Name	Duplication	Size	Complexity
B	setColumns()	0	32	6
A	addColumn()	0	14	2
A	addColumns()	0	8	3
A	beforeColumn()	8	8	3
A	afterColumn()	8	8	3
A	addDefaultTypeToColumn()	0	10	2
A	addDefaultLabel()	0	10	3
A	removeColumns()	0	4	1
A	removeColumn()	0	4	1
A	remove()	0	6	1
A	setColumnsDetails()	0	4	1
A	setColumnDetails()	0	4	1
A	setColumnOrder()	0	4	1
A	setColumnsOrder()	0	4	1
A	getColumnsRelationships()	0	8	1
A	getColumns()	0	4	1
A	orderColumns()	0	4	1

<?php

namespace Backpack\CRUD\PanelTraits;

trait Columns
{
    // ------------
    // COLUMNS
    // ------------

    /**
     * Add a bunch of column names and their details to the CRUD object.
     *
     * @param [array or multi-dimensional array]
     */
    public function setColumns($columns)
    {
        // clear any columns already set
        $this->columns = [];

The property columns does not exist. Did you maybe forget to declare it?

        // if array, add a column for each of the items
        if (is_array($columns) && count($columns)) {
            foreach ($columns as $key => $column) {
                // if label and other details have been defined in the array
                if (is_array($column)) {
                    $this->addColumn($column);
                } else {
                    $this->addColumn([
                                    'name'  => $column,
                                    'label' => ucfirst($column),
                                    'type'  => 'text',
                                ]);
                }
            }
        }

        if (is_string($columns)) {
            $this->addColumn([
                                'name'  => $columns,
                                'label' => ucfirst($columns),
                                'type'  => 'text',
                                ]);
        }

        // This was the old setColumns() function, and it did not work:
        // $this->columns = array_filter(array_map([$this, 'addDefaultTypeToColumn'], $columns));

61% of this comment could be valid code. Did you maybe forget this after debugging?

    }

    /**
     * Add a column at the end of to the CRUD object's "columns" array.
     *
     * @param [string or array]
     */
    public function addColumn($column)
    {
        // if a string was passed, not an array, change it to an array
        if (! is_array($column)) {
            $column = ['name' => $column];
        }

        // make sure the column has a label
        $column_with_details = $this->addDefaultLabel($column);

        array_filter($this->columns[] = $column_with_details);

        return $this;
    }

    /**
     * Add multiple columns at the end of the CRUD object's "columns" array.
     *
     * @param [array of columns]
     */
    public function addColumns($columns)
    {
        if (count($columns)) {
            foreach ($columns as $key => $column) {
                $this->addColumn($column);
            }
        }
    }

    /**
     * Moves the recently added column to 'before' the $target_col
     *
     * @param $target_col
     */
    public function beforeColumn($target_col) {

This method seems to be duplicated in your project.

The parameter $target_col is not named in camelCase.

        foreach ($this->columns as $column => $value) {
            if ($value['name'] == $target_col) {
                array_splice($this->columns, $column, 0, array(array_pop($this->columns)));
                break;
            }
        }
    }

    /**
     * Moves the recently added column to 'after' the $target_col
     *
     * @param $target
     */
    public function afterColumn($target_col) {

This method seems to be duplicated in your project.

The parameter $target_col is not named in camelCase.

        foreach ($this->columns as $column => $value) {
            if ($value['name'] == $target_col) {
                array_splice($this->columns, $column + 1, 0, array(array_pop($this->columns)));
                break;
            }
        }
    }

    /**
     * Add the default column type to the given Column, inferring the type from the database column type.
     *
     * @param [column array]
     */
    public function addDefaultTypeToColumn($column)
    {
        if (array_key_exists('name', (array) $column)) {
            $default_type = $this->getFieldTypeFromDbColumnType($column['name']);

It seems like getFieldTypeFromDbColumnType() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return array_merge(['type' => $default_type], $column);
        }

        return false;
    }

    /**
     * If a field or column array is missing the "label" attribute, an ugly error would be show.
     * So we add the field Name as a label - it's better than nothing.
     *
     * @param [field or column]
     */
    public function addDefaultLabel($array)

The return type could not be reliably inferred; please add a @return annotation.

    {
        if (! array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
            $array = array_merge(['label' => ucfirst($this->makeLabel($array['name']))], $array);

It seems like makeLabel() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return $array;
        }

        return $array;
    }

    /**
     * Remove multiple columns from the CRUD object using their names.
     *
     * @param  [column array]
     */
    public function removeColumns($columns)
    {
        $this->columns = $this->remove('columns', $columns);
    }

    /**
     * Remove a column from the CRUD object using its name.
     *
     * @param  [column array]
     */
    public function removeColumn($column)
    {
        return $this->removeColumns([$column]);
    }

    /**
     * @param string $entity
     */
    public function remove($entity, $fields)
    {
        return array_values(array_filter($this->{$entity}, function ($field) use ($fields) {
            return ! in_array($field['name'], (array) $fields);
        }));
    }

    /**
     * Change attributes for multiple columns.
     *
     * @param [columns arrays]
     * @param [attributes and values array]
     */
    public function setColumnsDetails($columns, $attributes)
    {
        $this->sync('columns', $columns, $attributes);

It seems like sync() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Change attributes for a certain column.
     *
     * @param [string] Column name.
     * @param [attributes and values array]
     */
    public function setColumnDetails($column, $attributes)
    {
        $this->setColumnsDetails([$column], $attributes);
    }

    /**
     * Order the columns in a certain way.
     *
     * @param [string] Column name.
     * @param [attributes and values array]
     */
    public function setColumnOrder($columns)

The parameter $columns is not used and could be removed.

    {
        // TODO
    }

    // ALIAS of setColumnOrder($columns)
    public function setColumnsOrder($columns)
    {
        $this->setColumnOrder($columns);
    }

    /**
     * Get the relationships used in the CRUD columns.
     * @return [array] Relationship names

The doc-type [array] could not be parsed: Unknown type name "" at position 0. [(view supported doc-types)

     */
    public function getColumnsRelationships()
    {
        $columns = $this->getColumns();

        return collect($columns)->pluck('entity')->reject(function ($value, $key) {

The parameter $key is not used and could be removed.

            return $value == null;
        })->toArray();
    }

    // ------------
    // TONE FUNCTIONS - UNDOCUMENTED, UNTESTED, SOME MAY BE USED
    // ------------
    // TODO: check them

    public function getColumns()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->sort('columns');

It seems like sort() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function orderColumns($order)
    {
        $this->setSort('columns', (array) $order);

It seems like setSort() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
}