Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Failed
Pull Request — main (#5764)
by Pedro
24:30 queued 09:46
created
tests/Unit/CrudPanel/CrudPanelCreateTest.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
 
170 170
     public function testCreateWithOneToOneDynamicRelationship()
171 171
     {
172
-        User::resolveRelationUsing('dynamicRelation', function ($user) {
172
+        User::resolveRelationUsing('dynamicRelation', function($user) {
173 173
             return $user->hasOne(\Backpack\CRUD\Tests\config\Models\AccountDetails::class);
174 174
         });
175 175
         $this->crudPanel->setModel(User::class);
@@ -280,7 +280,7 @@  discard block
 block discarded – undo
280 280
 
281 281
     public function testCreateWithOneToManyDynamicRelationship()
282 282
     {
283
-        Article::resolveRelationUsing('dynamicRelation', function ($article) {
283
+        Article::resolveRelationUsing('dynamicRelation', function($article) {
284 284
             return $article->belongsTo(\Backpack\CRUD\Tests\config\Models\User::class, 'user_id');
285 285
         });
286 286
 
@@ -343,7 +343,7 @@  discard block
 block discarded – undo
343 343
 
344 344
     public function testCreateWithManyToManyDynamicRelationship()
345 345
     {
346
-        User::resolveRelationUsing('dynamicRelation', function ($user) {
346
+        User::resolveRelationUsing('dynamicRelation', function($user) {
347 347
             return $user->belongsToMany(\Backpack\CRUD\Tests\config\Models\Role::class, 'user_role');
348 348
         });
349 349
 
@@ -685,7 +685,7 @@  discard block
 block discarded – undo
685 685
 
686 686
     public function testBelongsToManyWithPivotDataDynamicRelationship()
687 687
     {
688
-        User::resolveRelationUsing('dynamicRelation', function ($user) {
688
+        User::resolveRelationUsing('dynamicRelation', function($user) {
689 689
             return $user->belongsToMany(\Backpack\CRUD\Tests\config\Models\Article::class, 'articles_user')->withPivot(['notes', 'start_date', 'end_date']);
690 690
         });
691 691
 
@@ -794,7 +794,7 @@  discard block
 block discarded – undo
794 794
 
795 795
     public function testBelongsToManyWithMultipleSameRelationIdAndPivotDataDynamicRelationship()
796 796
     {
797
-        User::resolveRelationUsing('dynamicRelation', function ($user) {
797
+        User::resolveRelationUsing('dynamicRelation', function($user) {
798 798
             return $user->belongsToMany(\Backpack\CRUD\Tests\config\Models\Article::class, 'articles_user')->withPivot(['notes', 'start_date', 'end_date', 'id'])->using('Backpack\CRUD\Tests\config\Models\SuperArticlePivot');
799 799
         });
800 800
 
@@ -1046,7 +1046,7 @@  discard block
 block discarded – undo
1046 1046
 
1047 1047
     public function testCreateBelongsToFake()
1048 1048
     {
1049
-        $belongsToField = [   // select_grouped
1049
+        $belongsToField = [// select_grouped
1050 1050
             'label' => 'Select_grouped',
1051 1051
             'type' => 'select_grouped', //https://github.com/Laravel-Backpack/CRUD/issues/502
1052 1052
             'name' => 'bang_relation_field',
@@ -1182,7 +1182,7 @@  discard block
 block discarded – undo
1182 1182
                 'nickname' => 'i_have_has_one',
1183 1183
                 'profile_picture' => 'ohh my picture 1.jpg',
1184 1184
                 'article' => 1,
1185
-                'addresses' => [ // HasOne is tested in other test function
1185
+                'addresses' => [// HasOne is tested in other test function
1186 1186
                     [
1187 1187
                         'city' => 2,
1188 1188
                         'street' => 'test',
@@ -1974,23 +1974,23 @@  discard block
 block discarded – undo
1974 1974
         $this->crudPanel->addField([
1975 1975
             'name' => 'name',
1976 1976
             'events' => [
1977
-                'created' => function ($entry) {
1977
+                'created' => function($entry) {
1978 1978
                 },
1979
-                'creating' => function ($entry) {
1979
+                'creating' => function($entry) {
1980 1980
                     $entry->email = '[email protected]';
1981 1981
                     $entry->password = Hash::make('password');
1982 1982
                 },
1983
-                'saving' => function ($entry) {
1983
+                'saving' => function($entry) {
1984 1984
                 },
1985
-                'saved' => function ($entry) {
1985
+                'saved' => function($entry) {
1986 1986
                 },
1987
-                'updating' => function ($entry) {
1987
+                'updating' => function($entry) {
1988 1988
                 },
1989
-                'updated' => function ($entry) {
1989
+                'updated' => function($entry) {
1990 1990
                 },
1991
-                'deleting' => function ($entry) {
1991
+                'deleting' => function($entry) {
1992 1992
                 },
1993
-                'deleted' => function ($entry) {
1993
+                'deleted' => function($entry) {
1994 1994
                 },
1995 1995
             ],
1996 1996
         ]);
@@ -2013,7 +2013,7 @@  discard block
 block discarded – undo
2013 2013
 
2014 2014
     public function testItCanCreateDynamicRelationships()
2015 2015
     {
2016
-        User::resolveRelationUsing('dynamicRelation', function ($user) {
2016
+        User::resolveRelationUsing('dynamicRelation', function($user) {
2017 2017
             return $user->belongsTo(\Backpack\CRUD\Tests\config\Models\Bang::class, 'bang_relation_field');
2018 2018
         });
2019 2019
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
                     // - a single dimensional array: [1,2,3]
125 125
                     // - an array of arrays: [[1][2][3]]
126 126
                     // if is as single dimensional array we can only attach.
127
-                    if ($relationValues === null || ! is_multidimensional_array($relationValues)) {
127
+                    if ($relationValues === null || !is_multidimensional_array($relationValues)) {
128 128
                         $this->attachManyRelation($item, $relation, $relationDetails, $relationValues);
129 129
                     } else {
130 130
                         $this->createManyEntries($item, $relation, $relationMethod, $relationDetails);
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
 
147 147
                             $toDelete = array_diff($dbValues, $sentIds);
148 148
 
149
-                            if (! empty($toDelete)) {
149
+                            if (!empty($toDelete)) {
150 150
                                 foreach ($toDelete as $id) {
151 151
                                     $relation->newPivot()->where($keyName, $id)->delete();
152 152
                                 }
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
         }
189 189
     }
190 190
 
191
-    private function preparePivotAttributesForSave(array $attributes, BelongsToMany|MorphToMany $relation, string|int $relatedItemKey, $pivotKeyName, $relationMethod): array
191
+    private function preparePivotAttributesForSave(array $attributes, BelongsToMany | MorphToMany $relation, string | int $relatedItemKey, $pivotKeyName, $relationMethod): array
192 192
     {
193 193
         $attributes[$relation->getForeignPivotKeyName()] = $relatedItemKey;
194 194
         $attributes[$relation->getRelatedPivotKeyName()] = $attributes[$relationMethod];
@@ -334,7 +334,7 @@  discard block
 block discarded – undo
334 334
         }
335 335
         // if column is not nullable in database, and there is no column default (null),
336 336
         // we will delete the entry from the database, otherwise it will throw and ugly DB error.
337
-        if (! $relationColumnIsNullable && $dbColumnDefault === null) {
337
+        if (!$relationColumnIsNullable && $dbColumnDefault === null) {
338 338
             return $removedEntries->lazy()->each->delete();
339 339
         }
340 340
 
@@ -379,7 +379,7 @@  discard block
 block discarded – undo
379 379
         }
380 380
 
381 381
         // use the collection of sent ids to match against database ids, delete the ones not found in the submitted ids.
382
-        if (! empty($relatedItemsSent)) {
382
+        if (!empty($relatedItemsSent)) {
383 383
             // we perform the cleanup of removed database items
384 384
             $entry->{$relationMethod}()->whereNotIn($relatedModelLocalKey, $relatedItemsSent)->lazy()->each->delete();
385 385
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Access.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@  discard block
 block discarded – undo
10 10
     /**
11 11
      * Set an operation as having access using the Settings API.
12 12
      */
13
-    public function allowAccess(array|string $operation): bool
13
+    public function allowAccess(array | string $operation): bool
14 14
     {
15 15
         foreach ((array) $operation as $op) {
16 16
             $this->set($op.'.access', true);
@@ -22,13 +22,13 @@  discard block
 block discarded – undo
22 22
     /**
23 23
      * Disable the access to a certain operation, or the current one.
24 24
      */
25
-    public function denyAccess(array|string $operation): bool
25
+    public function denyAccess(array | string $operation): bool
26 26
     {
27 27
         foreach ((array) $operation as $op) {
28 28
             $this->set($op.'.access', false);
29 29
         }
30 30
 
31
-        return ! $this->hasAccessToAny($operation);
31
+        return !$this->hasAccessToAny($operation);
32 32
     }
33 33
 
34 34
     /**
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
     /**
53 53
      * Check if any operations are allowed for a Crud Panel. Return false if not.
54 54
      */
55
-    public function hasAccessToAny(array|string $operation_array, ?Model $entry = null): bool
55
+    public function hasAccessToAny(array | string $operation_array, ?Model $entry = null): bool
56 56
     {
57 57
         foreach ((array) $operation_array as $key => $operation) {
58 58
             if ($this->hasAccess($operation, $entry) == true) {
@@ -66,10 +66,10 @@  discard block
 block discarded – undo
66 66
     /**
67 67
      * Check if all operations are allowed for a Crud Panel. Return false if not.
68 68
      */
69
-    public function hasAccessToAll(array|string $operation_array, ?Model $entry = null): bool
69
+    public function hasAccessToAll(array | string $operation_array, ?Model $entry = null): bool
70 70
     {
71 71
         foreach ((array) $operation_array as $key => $operation) {
72
-            if (! $this->hasAccess($operation, $entry)) {
72
+            if (!$this->hasAccess($operation, $entry)) {
73 73
                 return false;
74 74
             }
75 75
         }
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
      */
85 85
     public function hasAccessOrFail(string $operation, ?Model $entry = null): bool
86 86
     {
87
-        if (! $this->hasAccess($operation, $entry)) {
87
+        if (!$this->hasAccess($operation, $entry)) {
88 88
             throw new AccessDeniedException(trans('backpack::crud.unauthorized_access', ['access' => $operation]), 403);
89 89
         }
90 90
 
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
      * Get an operation's access condition, if set. A condition
96 96
      * can be anything, but usually a boolean or a callable.
97 97
      */
98
-    public function getAccessCondition(string $operation): bool|callable|null
98
+    public function getAccessCondition(string $operation): bool | callable | null
99 99
     {
100 100
         return $this->get($operation.'.access');
101 101
     }
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
     /**
104 104
      * Set the condition under which an operation is allowed for a Crud Panel.
105 105
      */
106
-    public function setAccessCondition(array|string $operation, bool|callable|null $condition): void
106
+    public function setAccessCondition(array | string $operation, bool | callable | null $condition): void
107 107
     {
108 108
         foreach ((array) $operation as $op) {
109 109
             $this->set($op.'.access', $condition);
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
      * Allow access only to operations in the array.
132 132
      * By denying access to all other operations.
133 133
      */
134
-    public function allowAccessOnlyTo(array|string $operation): void
134
+    public function allowAccessOnlyTo(array | string $operation): void
135 135
     {
136 136
         $this->denyAllAccess();
137 137
         $this->allowAccess($operation);
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudPanel.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -109,11 +109,11 @@  discard block
 block discarded – undo
109 109
      */
110 110
     public function setModel($model_namespace)
111 111
     {
112
-        if (! class_exists($model_namespace)) {
112
+        if (!class_exists($model_namespace)) {
113 113
             throw new Exception('The model does not exist.', 500);
114 114
         }
115 115
 
116
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
116
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
117 117
             throw new Exception('Please use CrudTrait on the model.', 500);
118 118
         }
119 119
 
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 
207 207
         $complete_route = $route.'.index';
208 208
 
209
-        if (! \Route::has($complete_route)) {
209
+        if (!\Route::has($complete_route)) {
210 210
             throw new Exception('There are no routes for this route name.', 404);
211 211
         }
212 212
 
@@ -304,7 +304,7 @@  discard block
 block discarded – undo
304 304
      */
305 305
     public function getFirstOfItsTypeInArray($type, $array)
306 306
     {
307
-        return Arr::first($array, function ($item) use ($type) {
307
+        return Arr::first($array, function($item) use ($type) {
308 308
             return $item['type'] == $type;
309 309
         });
310 310
     }
@@ -324,8 +324,8 @@  discard block
 block discarded – undo
324 324
      */
325 325
     public function sync($type, $fields, $attributes)
326 326
     {
327
-        if (! empty($this->{$type})) {
328
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
327
+        if (!empty($this->{$type})) {
328
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
329 329
                 if (in_array($field['name'], (array) $fields)) {
330 330
                     $field = array_merge($field, $attributes);
331 331
                 }
@@ -355,18 +355,18 @@  discard block
 block discarded – undo
355 355
     {
356 356
         $relationArray = explode('.', $relationString);
357 357
 
358
-        if (! isset($length)) {
358
+        if (!isset($length)) {
359 359
             $length = count($relationArray);
360 360
         }
361 361
 
362
-        if (! isset($model)) {
362
+        if (!isset($model)) {
363 363
             $model = $this->model;
364 364
         }
365 365
 
366
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
366
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
367 367
             try {
368 368
                 $result = $obj->$method();
369
-                if (! $result instanceof Relation) {
369
+                if (!$result instanceof Relation) {
370 370
                     throw new Exception('Not a relation');
371 371
                 }
372 372
 
@@ -402,7 +402,7 @@  discard block
 block discarded – undo
402 402
             if (is_array($entries)) {
403 403
                 //if attribute does not exist in main array we have more than one entry OR the attribute
404 404
                 //is an accessor that is not in $appends property of model.
405
-                if (! isset($entries[$attribute])) {
405
+                if (!isset($entries[$attribute])) {
406 406
                     //we first check if we don't have the attribute because it's an accessor that is not in appends.
407 407
                     if ($model_instance->hasGetMutator($attribute) && isset($entries[$modelKey])) {
408 408
                         $entry_in_database = $model_instance->find($entries[$modelKey]);
@@ -441,21 +441,21 @@  discard block
 block discarded – undo
441 441
      */
442 442
     public function parseTranslatableAttributes($model, $attribute, $value)
443 443
     {
444
-        if (! method_exists($model, 'isTranslatableAttribute')) {
444
+        if (!method_exists($model, 'isTranslatableAttribute')) {
445 445
             return $value;
446 446
         }
447 447
 
448
-        if (! $model->isTranslatableAttribute($attribute)) {
448
+        if (!$model->isTranslatableAttribute($attribute)) {
449 449
             return $value;
450 450
         }
451 451
 
452
-        if (! is_array($value)) {
452
+        if (!is_array($value)) {
453 453
             $decodedAttribute = json_decode($value, true) ?? ($value !== null ? [$value] : []);
454 454
         } else {
455 455
             $decodedAttribute = $value;
456 456
         }
457 457
 
458
-        if (is_array($decodedAttribute) && ! empty($decodedAttribute)) {
458
+        if (is_array($decodedAttribute) && !empty($decodedAttribute)) {
459 459
             if (isset($decodedAttribute[app()->getLocale()])) {
460 460
                 return $decodedAttribute[app()->getLocale()];
461 461
             } else {
@@ -473,7 +473,7 @@  discard block
 block discarded – undo
473 473
         if (method_exists($model, 'translationEnabled') && $model->translationEnabled()) {
474 474
             $locale = $this->getRequest()->input('_locale', app()->getLocale());
475 475
             if (in_array($locale, array_keys($model->getAvailableLocales()))) {
476
-                $model->setLocale(! is_bool($useFallbackLocale) ? $useFallbackLocale : $locale);
476
+                $model->setLocale(!is_bool($useFallbackLocale) ? $useFallbackLocale : $locale);
477 477
                 $model->useFallbackLocale = (bool) $useFallbackLocale;
478 478
             }
479 479
         }
@@ -496,7 +496,7 @@  discard block
 block discarded – undo
496 496
         $relation = $model->{$firstRelationName};
497 497
 
498 498
         $results = [];
499
-        if (! is_null($relation)) {
499
+        if (!is_null($relation)) {
500 500
             if ($relation instanceof Collection) {
501 501
                 $currentResults = $relation->all();
502 502
             } elseif (is_array($relation)) {
@@ -509,7 +509,7 @@  discard block
 block discarded – undo
509 509
 
510 510
             array_shift($relationArray);
511 511
 
512
-            if (! empty($relationArray)) {
512
+            if (!empty($relationArray)) {
513 513
                 foreach ($currentResults as $currentResult) {
514 514
                     $results = array_merge_recursive($results, $this->getRelatedEntries($currentResult, implode('.', $relationArray)));
515 515
                 }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Relationships.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
             // here we are going to iterate through all relation parts to check
25 25
             foreach ($parts as $i => $part) {
26 26
                 $relation = $model->$part();
27
-                if (! is_a($relation, \Illuminate\Database\Eloquent\Relations\Relation::class, true)) {
27
+                if (!is_a($relation, \Illuminate\Database\Eloquent\Relations\Relation::class, true)) {
28 28
                     return $model;
29 29
                 }
30 30
                 $model = $relation->getRelated();
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
         $model = new ($this->getRelationModel($entity, -1));
69 69
         $lastSegmentAfterDot = Str::of($field['entity'])->afterLast('.')->value();
70 70
 
71
-        if (! $this->modelMethodIsRelationship($model, $lastSegmentAfterDot)) {
71
+        if (!$this->modelMethodIsRelationship($model, $lastSegmentAfterDot)) {
72 72
             return (string) Str::of($field['entity'])->beforeLast('.');
73 73
         }
74 74
 
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 
90 90
         return collect($this->getCleanStateFields())
91 91
             ->whereIn('relation_type', $relation_types)
92
-            ->filter(function ($item) use ($nested) {
92
+            ->filter(function($item) use ($nested) {
93 93
                 if ($nested) {
94 94
                     return true;
95 95
                 }
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
      */
134 134
     private function getRelationFieldsWithoutRelationType($relations, $fields = [])
135 135
     {
136
-        if (! is_array($relations)) {
136
+        if (!is_array($relations)) {
137 137
             $relations = [$relations];
138 138
         }
139 139
 
@@ -142,8 +142,8 @@  discard block
 block discarded – undo
142 142
         }
143 143
 
144 144
         foreach ($relations as $relation) {
145
-            $fields = array_filter($fields, function ($field) use ($relation) {
146
-                if (! isset($field['relation_type'])) {
145
+            $fields = array_filter($fields, function($field) use ($relation) {
146
+                if (!isset($field['relation_type'])) {
147 147
                     return false;
148 148
                 }
149 149
 
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
                     $fields = array_merge($field['subfields'], $fields);
178 178
                 }
179 179
             }
180
-            $fields = array_filter($fields, function ($field) {
180
+            $fields = array_filter($fields, function($field) {
181 181
                 return isset($field['relation_type']) && $field['relation_type'] === 'BelongsTo';
182 182
             });
183 183
         }
@@ -244,8 +244,8 @@  discard block
 block discarded – undo
244 244
     {
245 245
         $all_relation_fields = $this->getRelationFields();
246 246
 
247
-        return Arr::where($all_relation_fields, function ($value, $key) {
248
-            return isset($value['pivot']) && ! $value['pivot'];
247
+        return Arr::where($all_relation_fields, function($value, $key) {
248
+            return isset($value['pivot']) && !$value['pivot'];
249 249
         });
250 250
     }
251 251
 
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
     {
259 259
         $all_relation_fields = $this->getRelationFields();
260 260
 
261
-        return Arr::where($all_relation_fields, function ($value, $key) {
261
+        return Arr::where($all_relation_fields, function($value, $key) {
262 262
             return isset($value['pivot']) && $value['pivot'];
263 263
         });
264 264
     }
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
      */
329 329
     private function modelMethodIsRelationship($model, $method)
330 330
     {
331
-        if (! method_exists($model, $method)) {
331
+        if (!method_exists($model, $method)) {
332 332
             if ($model->isRelation($method)) {
333 333
                 return $method;
334 334
             }
@@ -344,7 +344,7 @@  discard block
 block discarded – undo
344 344
         }
345 345
 
346 346
         // relationships are always public methods.
347
-        if (! $methodReflection->isPublic()) {
347
+        if (!$methodReflection->isPublic()) {
348 348
             return false;
349 349
         }
350 350
 
@@ -371,7 +371,7 @@  discard block
 block discarded – undo
371 371
      */
372 372
     public function isAttributeInRelationString(array $field): bool
373 373
     {
374
-        if (! str_contains($field['entity'], '.')) {
374
+        if (!str_contains($field['entity'], '.')) {
375 375
             return false;
376 376
         }
377 377
 
@@ -387,7 +387,7 @@  discard block
 block discarded – undo
387 387
             try {
388 388
                 $model = $model->$part();
389 389
 
390
-                if (! is_a($model, \Illuminate\Database\Eloquent\Relations\Relation::class, true)) {
390
+                if (!is_a($model, \Illuminate\Database\Eloquent\Relations\Relation::class, true)) {
391 391
                     return true;
392 392
                 }
393 393
 
Please login to merge, or discard this patch.
src/resources/views/crud/fields/checklist_dependency.blade.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
     //all items with relation
21 21
     $dependencies = $primary_dependency['model']::with($primary_dependency['entity_secondary']);
22 22
 
23
-    if(isset($primary_dependency['options']) && $primary_dependency['options'] instanceof \Closure){
23
+    if (isset($primary_dependency['options']) && $primary_dependency['options'] instanceof \Closure) {
24 24
         $dependencies = $primary_dependency['options']($dependencies);
25 25
     }
26 26
 
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 
77 77
     $primaryDependencyOptionQuery = $primary_dependency['model']::query();
78 78
 
79
-    if(isset($primary_dependency['options']) && $primary_dependency['options'] instanceof \Closure){
79
+    if (isset($primary_dependency['options']) && $primary_dependency['options'] instanceof \Closure) {
80 80
         $primaryDependencyOptionQuery = $primary_dependency['options']($primaryDependencyOptionQuery);
81 81
     }
82 82
 
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 
85 85
     $secondaryDependencyOptionQuery = $secondary_dependency['model']::query();
86 86
 
87
-    if(isset($secondary_dependency['options']) && $secondary_dependency['options'] instanceof \Closure){
87
+    if (isset($secondary_dependency['options']) && $secondary_dependency['options'] instanceof \Closure) {
88 88
         $secondaryDependencyOptionQuery = $secondary_dependency['options']($secondaryDependencyOptionQuery);
89 89
     }
90 90
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ReorderOperation.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
         $this->crud->set('reorder.enabled', true);
37 37
         $this->crud->allowAccess('reorder');
38 38
 
39
-        $this->crud->operation('reorder', function () {
39
+        $this->crud->operation('reorder', function() {
40 40
             $this->crud->loadDefaultOperationSettingsFromConfig();
41 41
             $this->crud->setOperationSetting('reorderColumnNames', [
42 42
                 'parent_id' => 'parent_id',
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
             ]);
47 47
         });
48 48
 
49
-        $this->crud->operation('list', function () {
49
+        $this->crud->operation('list', function() {
50 50
             $this->crud->addButton('top', 'reorder', 'view', 'crud::buttons.reorder');
51 51
         });
52 52
     }
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
     {
63 63
         $this->crud->hasAccessOrFail('reorder');
64 64
 
65
-        if (! $this->crud->isReorderEnabled()) {
65
+        if (!$this->crud->isReorderEnabled()) {
66 66
             abort(403, 'Reorder is disabled.');
67 67
         }
68 68
 
Please login to merge, or discard this patch.
src/resources/views/crud/reorder.blade.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -27,11 +27,11 @@  discard block
 block discarded – undo
27 27
 
28 28
 @section('content')
29 29
 <?php
30
-if(!function_exists('tree_element')) {
30
+if (!function_exists('tree_element')) {
31 31
     function tree_element($entry, $key, $all_entries, $crud) {
32 32
         $columns = $crud->getOperationSetting('reorderColumnNames');
33 33
 
34
-        if (! isset($entry->tree_element_shown)) {
34
+        if (!isset($entry->tree_element_shown)) {
35 35
             // mark the element as shown
36 36
             $all_entries[$key]->tree_element_shown = true;
37 37
             $entry->tree_element_shown = true;
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
                 <ol class="sortable mt-0 mb-0">
76 76
                 <?php
77 77
                     $all_entries = collect($entries->all())->sortBy($columns['lft'])->keyBy($crud->getModel()->getKeyName());
78
-                    $root_entries = $all_entries->filter(function ($item) use ($columns) {
78
+                    $root_entries = $all_entries->filter(function($item) use ($columns) {
79 79
                         return $item->{$columns['parent_id']} == 0;
80 80
                     });
81 81
                     foreach ($root_entries as $key => $entry) {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Reorder.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -28,9 +28,9 @@  discard block
 block discarded – undo
28 28
         $itemKeys = $this->model->query()->select($primaryKey)->get()->pluck($primaryKey);
29 29
 
30 30
         // filter the items that are not in the database and map the request
31
-        $reorderItems = collect($request)->filter(function ($item) use ($itemKeys) {
31
+        $reorderItems = collect($request)->filter(function($item) use ($itemKeys) {
32 32
             return $item['item_id'] !== '' && $item['item_id'] !== null && $itemKeys->contains($item['item_id']);
33
-        })->map(function ($item) use ($primaryKey, $columns) {
33
+        })->map(function($item) use ($primaryKey, $columns) {
34 34
             $item[$primaryKey] = $item['item_id'];
35 35
             $item[$columns['parent_id']] = empty($item['parent_id']) ? null : $item['parent_id'];
36 36
             $item[$columns['depth']] = empty($item['depth']) ? null : (int) $item['depth'];
@@ -59,12 +59,12 @@  discard block
 block discarded – undo
59 59
 
60 60
         $sentIds = array_column($reorderItems, $primaryKey);
61 61
 
62
-        $itemKeys = $itemKeys->filter(function ($id) use ($sentIds) {
62
+        $itemKeys = $itemKeys->filter(function($id) use ($sentIds) {
63 63
             return in_array($id, $sentIds);
64 64
         });
65 65
 
66 66
         // wrap the queries in a transaction to avoid partial updates
67
-        DB::connection($this->model->getConnectionName())->transaction(function () use ($reorderItems, $primaryKey, $itemKeys, $columns) {
67
+        DB::connection($this->model->getConnectionName())->transaction(function() use ($reorderItems, $primaryKey, $itemKeys, $columns) {
68 68
             // create a string of ?,?,?,? to use as bind placeholders for item keys
69 69
             $reorderItemsBindString = implode(',', array_fill(0, count($reorderItems), '?'));
70 70
 
Please login to merge, or discard this patch.