Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Failed
Pull Request — main (#5764)
by Pedro
24:30 queued 09:46
created
src/app/Library/CrudPanel/Traits/Columns.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
     /**
75 75
      * Add a column at the end of the CRUD object's "columns" array and return it.
76 76
      */
77
-    public function addAndReturnColumn(array|string $column): CrudColumn
77
+    public function addAndReturnColumn(array | string $column): CrudColumn
78 78
     {
79 79
         $column = $this->prepareAttributesAndAddColumn($column);
80 80
 
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
      */
123 123
     public function makeFirstColumn()
124 124
     {
125
-        if (! $this->columns()) {
125
+        if (!$this->columns()) {
126 126
             return false;
127 127
         }
128 128
 
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
      */
167 167
     public function removeColumns($columns)
168 168
     {
169
-        if (! empty($columns)) {
169
+        if (!empty($columns)) {
170 170
             foreach ($columns as $columnKey) {
171 171
                 $this->removeColumn($columnKey);
172 172
             }
@@ -331,7 +331,7 @@  discard block
 block discarded – undo
331 331
      */
332 332
     public function hasColumnWhere($attribute, $value)
333 333
     {
334
-        $match = Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
334
+        $match = Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
335 335
             return isset($column[$attribute]) && $column[$attribute] == $value;
336 336
         });
337 337
 
@@ -347,7 +347,7 @@  discard block
 block discarded – undo
347 347
      */
348 348
     public function firstColumnWhere($attribute, $value)
349 349
     {
350
-        return Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
350
+        return Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
351 351
             return isset($column[$attribute]) && $column[$attribute] == $value;
352 352
         });
353 353
     }
@@ -396,8 +396,8 @@  discard block
 block discarded – undo
396 396
      */
397 397
     public function countColumnsWithoutActions()
398 398
     {
399
-        return collect($this->columns())->filter(function ($column, $key) {
400
-            return ! isset($column['hasActions']) || $column['hasActions'] == false;
399
+        return collect($this->columns())->filter(function($column, $key) {
400
+            return !isset($column['hasActions']) || $column['hasActions'] == false;
401 401
         })->count();
402 402
     }
403 403
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Read.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
     {
55 55
         $entry = $this->getCurrentEntry();
56 56
 
57
-        if (! $entry) {
57
+        if (!$entry) {
58 58
             return false;
59 59
         }
60 60
 
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
      */
70 70
     public function getEntry($id)
71 71
     {
72
-        if (! $this->entry) {
72
+        if (!$this->entry) {
73 73
             if ($this->getOperationSetting('eagerLoadRelationships')) {
74 74
                 $this->eagerLoadRelationshipFields();
75 75
             }
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
         return $this->entry;
81 81
     }
82 82
 
83
-    private function shouldUseFallbackLocale(): bool|string
83
+    private function shouldUseFallbackLocale(): bool | string
84 84
     {
85 85
         $fallbackRequestValue = $this->getRequest()->get('_fallback_locale');
86 86
 
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
      */
97 97
     public function getEntryWithLocale($id)
98 98
     {
99
-        if (! $this->entry) {
99
+        if (!$this->entry) {
100 100
             $this->entry = $this->getEntry($id);
101 101
         }
102 102
 
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
         foreach ($crudObjects as $crudObjectName => $attributes) {
148 148
             $relationString = isset($attributes['entity']) && $attributes['entity'] !== false ? $attributes['entity'] : '';
149 149
 
150
-            if (! $relationString) {
150
+            if (!$relationString) {
151 151
                 continue;
152 152
             }
153 153
 
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
      */
214 214
     public function enableDetailsRow()
215 215
     {
216
-        if (! backpack_pro()) {
216
+        if (!backpack_pro()) {
217 217
             throw new BackpackProRequiredException('Details row');
218 218
         }
219 219
 
@@ -312,7 +312,7 @@  discard block
 block discarded – undo
312 312
                 // we will apply the same labels as the values to the menu if developer didn't
313 313
                 $this->abortIfInvalidPageLength($menu[0]);
314 314
 
315
-                if (! isset($menu[1]) || ! is_array($menu[1])) {
315
+                if (!isset($menu[1]) || !is_array($menu[1])) {
316 316
                     $menu[1] = $menu[0];
317 317
                 }
318 318
             } else {
@@ -400,7 +400,7 @@  discard block
 block discarded – undo
400 400
      */
401 401
     public function enableExportButtons()
402 402
     {
403
-        if (! backpack_pro()) {
403
+        if (!backpack_pro()) {
404 404
             throw new BackpackProRequiredException('Export buttons');
405 405
         }
406 406
 
Please login to merge, or discard this patch.
src/routes/backpack/custom.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
         (array) config('backpack.base.middleware_key', 'admin')
16 16
     ),
17 17
     'namespace' => 'App\Http\Controllers\Admin',
18
-], function () { // custom admin routes
18
+], function() { // custom admin routes
19 19
 }); // this should be the absolute last line of this file
20 20
 
21 21
 /**
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelButtonsTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
276 276
     public function testAddButtonFluently()
277 277
     {
278 278
         $button1 = CrudButton::name('lineTest')->to('line')->view('crud::buttons.test')->type('view');
279
-        $button2 = CrudButton::add('modelFunction')->model_function(function () {
279
+        $button2 = CrudButton::add('modelFunction')->model_function(function() {
280 280
             return 'test';
281 281
         })->section('top')->makeFirst();
282 282
         $this->assertEquals($button1->toArray(), $this->crudPanel->buttons()->last()->toArray());
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
 
291 291
         $this->expectException(\Symfony\Component\HttpKernel\Exception\HttpException::class);
292 292
 
293
-        $this->crudPanel->modifyButton('unknownButton', function ($button) {
293
+        $this->crudPanel->modifyButton('unknownButton', function($button) {
294 294
             $button->name = 'newName';
295 295
         });
296 296
     }
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
 
343 343
     private function getButtonByName($name)
344 344
     {
345
-        return $this->crudPanel->buttons()->first(function ($value) use ($name) {
345
+        return $this->crudPanel->buttons()->first(function($value) use ($name) {
346 346
             return $value->name == $name;
347 347
         });
348 348
     }
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelAccessTest.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 
106 106
     public function testItCanUseAClosureToResolveAccess()
107 107
     {
108
-        $this->crudPanel->setAccessCondition('list', function () {
108
+        $this->crudPanel->setAccessCondition('list', function() {
109 109
             return true;
110 110
         });
111 111
 
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
 
117 117
     public function testItCanUseAClosureToResolveAccessForMultipleOperations()
118 118
     {
119
-        $this->crudPanel->setAccessCondition(['list', 'create'], function () {
119
+        $this->crudPanel->setAccessCondition(['list', 'create'], function() {
120 120
             return true;
121 121
         });
122 122
 
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
 
128 128
     public function testItCanCheckIfAnOperationHasAccessConditions()
129 129
     {
130
-        $this->crudPanel->setAccessCondition(['list', 'create'], function () {
130
+        $this->crudPanel->setAccessCondition(['list', 'create'], function() {
131 131
             return true;
132 132
         });
133 133
 
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
 
138 138
     public function testItCanCheckAccessToAll()
139 139
     {
140
-        $this->crudPanel->allowAccess(['list', 'create'], function () {
140
+        $this->crudPanel->allowAccess(['list', 'create'], function() {
141 141
             return true;
142 142
         });
143 143
 
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
 
148 148
     public function testItCanAllowAccessToSomeSpecificOperationWhileDenyingOthers()
149 149
     {
150
-        $this->crudPanel->allowAccess(['list', 'create'], function () {
150
+        $this->crudPanel->allowAccess(['list', 'create'], function() {
151 151
             return true;
152 152
         });
153 153
 
Please login to merge, or discard this patch.
tests/config/CrudPanel/BaseCrudPanel.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
     {
25 25
         parent::setUp();
26 26
 
27
-        $this->app->singleton('crud', function ($app) {
27
+        $this->app->singleton('crud', function($app) {
28 28
             return new CrudPanel($app);
29 29
         });
30 30
         $this->crudPanel = app('crud');
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
         $app['config']->set('database.default', 'testing');
44 44
         $app['config']->set('backpack.base.route_prefix', 'admin');
45 45
 
46
-        $app->bind('App\Http\Middleware\CheckIfAdmin', function () {
46
+        $app->bind('App\Http\Middleware\CheckIfAdmin', function() {
47 47
             return new class
48 48
             {
49 49
                 public function handle($request, $next)
Please login to merge, or discard this patch.
src/app/Console/Commands/AddCustomRouteContent.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
     {
44 44
         $routeFilePath = base_path($this->option('route-file'));
45 45
 
46
-        if (! file_exists($routeFilePath)) {
46
+        if (!file_exists($routeFilePath)) {
47 47
             if ($routeFilePath !== base_path($this->backpackCustomRouteFile)) {
48 48
                 $this->info('The route file <fg=blue>'.$routeFilePath.'</> does not exist. Please create it first.');
49 49
 
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 
101 101
     private function cleanContentArray(array $content)
102 102
     {
103
-        return array_filter(array_map(function ($line) {
103
+        return array_filter(array_map(function($line) {
104 104
             $lineText = trim($line);
105 105
             if ($lineText === '' ||
106 106
                 $lineText === '\n' ||
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
      */
134 134
     private function getLastLineNumberThatContains($needle, $haystack)
135 135
     {
136
-        $matchingLines = array_filter($haystack, function ($k) use ($needle) {
136
+        $matchingLines = array_filter($haystack, function($k) use ($needle) {
137 137
             return strpos($k, $needle) !== false;
138 138
         });
139 139
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Fields.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
      */
137 137
     public function afterField($targetFieldName)
138 138
     {
139
-        $this->transformFields(function ($fields) use ($targetFieldName) {
139
+        $this->transformFields(function($fields) use ($targetFieldName) {
140 140
             return $this->moveField($fields, $targetFieldName, false);
141 141
         });
142 142
     }
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
      */
149 149
     public function beforeField($targetFieldName)
150 150
     {
151
-        $this->transformFields(function ($fields) use ($targetFieldName) {
151
+        $this->transformFields(function($fields) use ($targetFieldName) {
152 152
             return $this->moveField($fields, $targetFieldName, true);
153 153
         });
154 154
     }
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
      */
161 161
     public function makeFirstField()
162 162
     {
163
-        if (! $this->fields()) {
163
+        if (!$this->fields()) {
164 164
             return false;
165 165
         }
166 166
 
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
      */
176 176
     public function removeField($name)
177 177
     {
178
-        $this->transformFields(function ($fields) use ($name) {
178
+        $this->transformFields(function($fields) use ($name) {
179 179
             Arr::forget($fields, $name);
180 180
 
181 181
             return $fields;
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
      */
190 190
     public function removeFields($array_of_names)
191 191
     {
192
-        if (! empty($array_of_names)) {
192
+        if (!empty($array_of_names)) {
193 193
             foreach ($array_of_names as $name) {
194 194
                 $this->removeField($name);
195 195
             }
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
     public function removeAllFields()
203 203
     {
204 204
         $current_fields = $this->getCleanStateFields();
205
-        if (! empty($current_fields)) {
205
+        if (!empty($current_fields)) {
206 206
             foreach ($current_fields as $field) {
207 207
                 $this->removeField($field['name']);
208 208
             }
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
      */
291 291
     public function orderFields($order)
292 292
     {
293
-        $this->transformFields(function ($fields) use ($order) {
293
+        $this->transformFields(function($fields) use ($order) {
294 294
             return $this->applyOrderToFields($fields, $order);
295 295
         });
296 296
     }
@@ -314,7 +314,7 @@  discard block
 block discarded – undo
314 314
     public function hasUploadFields()
315 315
     {
316 316
         $fields = $this->getCleanStateFields();
317
-        $upload_fields = Arr::where($fields, function ($value, $key) {
317
+        $upload_fields = Arr::where($fields, function($value, $key) {
318 318
             // check if any subfields have uploads
319 319
             if (isset($value['subfields'])) {
320 320
                 foreach ($value['subfields'] as $subfield) {
@@ -386,7 +386,7 @@  discard block
 block discarded – undo
386 386
         $alreadyLoaded = $this->getLoadedFieldTypes();
387 387
         $type = $this->getFieldTypeWithNamespace($field);
388 388
 
389
-        if (! in_array($type, $this->getLoadedFieldTypes(), true)) {
389
+        if (!in_array($type, $this->getLoadedFieldTypes(), true)) {
390 390
             $alreadyLoaded[] = $type;
391 391
             $this->setLoadedFieldTypes($alreadyLoaded);
392 392
 
@@ -427,7 +427,7 @@  discard block
 block discarded – undo
427 427
      */
428 428
     public function fieldTypeNotLoaded($field)
429 429
     {
430
-        return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
430
+        return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
431 431
     }
432 432
 
433 433
     /**
@@ -439,7 +439,7 @@  discard block
 block discarded – undo
439 439
     {
440 440
         $fieldNamesArray = array_column($this->getCleanStateFields(), 'name');
441 441
 
442
-        return array_reduce($fieldNamesArray, function ($names, $item) {
442
+        return array_reduce($fieldNamesArray, function($names, $item) {
443 443
             if (strpos($item, ',') === false) {
444 444
                 $names[] = $item;
445 445
 
@@ -490,7 +490,7 @@  discard block
 block discarded – undo
490 490
      */
491 491
     public function hasFieldWhere($attribute, $value)
492 492
     {
493
-        $match = Arr::first($this->getCleanStateFields(), function ($field, $fieldKey) use ($attribute, $value) {
493
+        $match = Arr::first($this->getCleanStateFields(), function($field, $fieldKey) use ($attribute, $value) {
494 494
             return isset($field[$attribute]) && $field[$attribute] == $value;
495 495
         });
496 496
 
@@ -506,7 +506,7 @@  discard block
 block discarded – undo
506 506
      */
507 507
     public function firstFieldWhere($attribute, $value)
508 508
     {
509
-        return Arr::first($this->getCleanStateFields(), function ($field, $fieldKey) use ($attribute, $value) {
509
+        return Arr::first($this->getCleanStateFields(), function($field, $fieldKey) use ($attribute, $value) {
510 510
             return isset($field[$attribute]) && $field[$attribute] == $value;
511 511
         });
512 512
     }
Please login to merge, or discard this patch.
src/app/Models/Traits/HasIdentifiableAttribute.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
         // we get the first column from database
56 56
         // that is NOT indexed (usually primary, foreign keys)
57 57
         foreach ($columnNames as $columnName) {
58
-            if (! in_array($columnName, $indexes)) {
58
+            if (!in_array($columnName, $indexes)) {
59 59
                 //check for convention "field<_id>" in case developer didn't add foreign key constraints.
60 60
                 if (strpos($columnName, '_id') !== false) {
61 61
                     continue;
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 
68 68
         // in case everything fails we just return the first column in database
69 69
         $firstColumnInTable = Arr::first($columnNames);
70
-        if (! empty($firstColumnInTable)) {
70
+        if (!empty($firstColumnInTable)) {
71 71
             return $firstColumnInTable;
72 72
         }
73 73
 
Please login to merge, or discard this patch.