Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — fix-uploaders (#5518)
by Pedro
26:32 queued 11:35
created
tests/Feature/UploadersTest.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
 
60 60
         $this->assertDatabaseHas('uploaders', [
61 61
             'upload' => 'avatar.jpg',
62
-            'upload_multiple' => json_encode(['avatar1.jpg',  'avatar2.jpg']),
62
+            'upload_multiple' => json_encode(['avatar1.jpg', 'avatar2.jpg']),
63 63
         ]);
64 64
 
65 65
         $this->assertTrue(Storage::disk('uploaders')->exists('avatar.jpg'));
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
         $response = $this->put($this->testBaseUrl.'/1', [
95 95
             'upload' => UploadedFile::fake()->image('avatar4.jpg'),
96 96
             'upload_multiple' => [UploadedFile::fake()->image('avatar5.jpg'), UploadedFile::fake()->image('avatar6.jpg')],
97
-            'clear_upload_multiple' => ['avatar2.jpg',  'avatar3.jpg'],
97
+            'clear_upload_multiple' => ['avatar2.jpg', 'avatar3.jpg'],
98 98
             'id' => 1,
99 99
         ]);
100 100
 
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
 
107 107
         $this->assertDatabaseHas('uploaders', [
108 108
             'upload' => 'avatar4.jpg',
109
-            'upload_multiple' => json_encode(['avatar5.jpg',  'avatar6.jpg']),
109
+            'upload_multiple' => json_encode(['avatar5.jpg', 'avatar6.jpg']),
110 110
         ]);
111 111
 
112 112
         $files = Storage::disk('uploaders')->allFiles();
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
 
136 136
         $this->assertDatabaseHas('uploaders', [
137 137
             'upload' => null,
138
-            'upload_multiple' => json_encode(['avatar2.jpg',  'avatar3.jpg']),
138
+            'upload_multiple' => json_encode(['avatar2.jpg', 'avatar3.jpg']),
139 139
         ]);
140 140
 
141 141
         $files = Storage::disk('uploaders')->allFiles();
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
         self::initUploaderWithFiles();
166 166
 
167 167
         $response = $this->put($this->testBaseUrl.'/1', [
168
-            'upload_multiple' => ['avatar2.jpg',  'avatar3.jpg'],
168
+            'upload_multiple' => ['avatar2.jpg', 'avatar3.jpg'],
169 169
             'id' => 1,
170 170
         ]);
171 171
 
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
 
178 178
         $this->assertDatabaseHas('uploaders', [
179 179
             'upload' => 'avatar1.jpg',
180
-            'upload_multiple' => json_encode(['avatar2.jpg',  'avatar3.jpg']),
180
+            'upload_multiple' => json_encode(['avatar2.jpg', 'avatar3.jpg']),
181 181
         ]);
182 182
 
183 183
         $files = Storage::disk('uploaders')->allFiles();
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
 
208 208
         $this->assertDatabaseHas('uploaders', [
209 209
             'upload' => 'avatar1.jpg',
210
-            'upload_multiple' => json_encode(['avatar3.jpg', 'avatar4.jpg',  'avatar5.jpg']),
210
+            'upload_multiple' => json_encode(['avatar3.jpg', 'avatar4.jpg', 'avatar5.jpg']),
211 211
         ]);
212 212
 
213 213
         $files = Storage::disk('uploaders')->allFiles();
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
228 228
 
229 229
         Uploader::create([
230 230
             'upload' => 'avatar1.jpg',
231
-            'upload_multiple' => json_encode(['avatar2.jpg',  'avatar3.jpg']),
231
+            'upload_multiple' => json_encode(['avatar2.jpg', 'avatar3.jpg']),
232 232
         ]);
233 233
     }
234 234
 
Please login to merge, or discard this patch.
src/app/Library/Uploaders/Uploader.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 
26 26
     private bool $deleteWhenEntryIsDeleted = true;
27 27
 
28
-    private bool|string $attachedToFakeField = false;
28
+    private bool | string $attachedToFakeField = false;
29 29
 
30 30
     /**
31 31
      * Cloud disks have the ability to generate temporary URLs to files, should we do it?
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
     /*******************************
63 63
      * Static methods
64 64
      *******************************/
65
-    public static function for(array $crudObject, array $definition): UploaderInterface
65
+    public static function for (array $crudObject, array $definition): UploaderInterface
66 66
     {
67 67
         return new static($crudObject, $definition);
68 68
     }
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
     public function deleteUploadedFiles(Model $entry): void
104 104
     {
105 105
         if ($this->deleteWhenEntryIsDeleted) {
106
-            if (! in_array(SoftDeletes::class, class_uses_recursive($entry), true)) {
106
+            if (!in_array(SoftDeletes::class, class_uses_recursive($entry), true)) {
107 107
                 $this->performFileDeletion($entry);
108 108
 
109 109
                 return;
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
 
180 180
     public function getPreviousFiles(Model $entry): mixed
181 181
     {
182
-        if (! $this->attachedToFakeField) {
182
+        if (!$this->attachedToFakeField) {
183 183
             return $this->getOriginalValue($entry);
184 184
         }
185 185
         $value = $this->getOriginalValue($entry, $this->attachedToFakeField);
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
198 198
         return $this->attachedToFakeField !== false;
199 199
     }
200 200
 
201
-    public function getFakeAttribute(): bool|string
201
+    public function getFakeAttribute(): bool | string
202 202
     {
203 203
         return $this->attachedToFakeField;
204 204
     }
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
         return $this;
221 221
     }
222 222
 
223
-    public function fake(bool|string $isFake): self
223
+    public function fake(bool | string $isFake): self
224 224
     {
225 225
         $this->attachedToFakeField = $isFake;
226 226
 
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
251 251
         }
252 252
 
253 253
         if ($this->handleMultipleFiles) {
254
-            if (! isset($entry->getCasts()[$this->getName()]) && is_string($value)) {
254
+            if (!isset($entry->getCasts()[$this->getName()]) && is_string($value)) {
255 255
                 $entry->{$this->getAttributeName()} = json_decode($value, true);
256 256
             }
257 257
 
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
 
266 266
     private function deleteFiles(Model $entry)
267 267
     {
268
-        if (! $this->shouldDeleteFiles()) {
268
+        if (!$this->shouldDeleteFiles()) {
269 269
             return;
270 270
         }
271 271
 
@@ -283,7 +283,7 @@  discard block
 block discarded – undo
283 283
 
284 284
         if ($this->handleMultipleFiles) {
285 285
             // ensure we have an array of values when field is not casted in model.
286
-            if (! isset($entry->getCasts()[$this->name]) && is_string($values)) {
286
+            if (!isset($entry->getCasts()[$this->name]) && is_string($values)) {
287 287
                 $values = json_decode($values, true);
288 288
             }
289 289
             foreach ($values ?? [] as $value) {
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
300 300
 
301 301
     private function performFileDeletion(Model $entry)
302 302
     {
303
-        if (! $this->handleRepeatableFiles) {
303
+        if (!$this->handleRepeatableFiles) {
304 304
             $this->deleteFiles($entry);
305 305
 
306 306
             return;
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
 
330 330
         $previousValue = $entry->getOriginal($field);
331 331
 
332
-        if (! $previousValue) {
332
+        if (!$previousValue) {
333 333
             return $previousValue;
334 334
         }
335 335
 
Please login to merge, or discard this patch.
tests/Feature/FakeUploadersTest.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
             '_method' => 'PUT',
89 89
             'upload' => $this->getUploadedFile('avatar4.jpg'),
90 90
             'upload_multiple' => $this->getUploadedFiles(['avatar5.jpg', 'avatar6.jpg']),
91
-            'clear_upload_multiple' => ['avatar2.jpg',  'avatar3.jpg'],
91
+            'clear_upload_multiple' => ['avatar2.jpg', 'avatar3.jpg'],
92 92
             'id' => 1,
93 93
         ]);
94 94
 
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
         $this->assertDatabaseCount('uploaders', 1);
169 169
 
170 170
         $this->assertDatabaseHas('uploaders', [
171
-            'extras' => json_encode(['upload_multiple' => ['avatar2.jpg',  'avatar3.jpg'], 'upload' => 'avatar1.jpg']),
171
+            'extras' => json_encode(['upload_multiple' => ['avatar2.jpg', 'avatar3.jpg'], 'upload' => 'avatar1.jpg']),
172 172
         ]);
173 173
 
174 174
         $files = Storage::disk('uploaders')->allFiles();
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
         self::initUploaderWithFiles();
186 186
 
187 187
         $response = $this->put($this->testBaseUrl.'/1', [
188
-            'upload_multiple' => $this->getUploadedFiles(['avatar4.jpg',  'avatar5.jpg']),
188
+            'upload_multiple' => $this->getUploadedFiles(['avatar4.jpg', 'avatar5.jpg']),
189 189
             'clear_upload_multiple' => ['avatar2.jpg'],
190 190
             'id' => 1,
191 191
         ]);
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
         $this->assertDatabaseCount('uploaders', 1);
198 198
 
199 199
         $this->assertDatabaseHas('uploaders', [
200
-            'extras' => json_encode(['upload_multiple' => ['avatar3.jpg', 'avatar4.jpg',  'avatar5.jpg'], 'upload' => 'avatar1.jpg']),
200
+            'extras' => json_encode(['upload_multiple' => ['avatar3.jpg', 'avatar4.jpg', 'avatar5.jpg'], 'upload' => 'avatar1.jpg']),
201 201
         ]);
202 202
 
203 203
         $files = Storage::disk('uploaders')->allFiles();
@@ -217,7 +217,7 @@  discard block
 block discarded – undo
217 217
         UploadedFile::fake()->image('avatar3.jpg')->storeAs('', 'avatar3.jpg', ['disk' => 'uploaders']);
218 218
 
219 219
         FakeUploader::create([
220
-            'extras' => ['upload' => 'avatar1.jpg', 'upload_multiple' => ['avatar2.jpg',  'avatar3.jpg']],
220
+            'extras' => ['upload' => 'avatar1.jpg', 'upload_multiple' => ['avatar2.jpg', 'avatar3.jpg']],
221 221
         ]);
222 222
     }
223 223
 
@@ -235,7 +235,7 @@  discard block
 block discarded – undo
235 235
 
236 236
     protected function getUploadedFiles(array $fileNames)
237 237
     {
238
-        return array_map(function ($fileName) {
238
+        return array_map(function($fileName) {
239 239
             return new UploadedFile(__DIR__.'/../config/assets/'.$fileName, $fileName, 'image/jpg', null, true);
240 240
         }, $fileNames);
241 241
     }
Please login to merge, or discard this patch.