Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#2311)
by Cristian
06:32
created
src/resources/views/crud/fields/table.blade.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
 <?php
4 4
     $max = isset($field['max']) && (int) $field['max'] > 0 ? $field['max'] : -1;
5 5
     $min = isset($field['min']) && (int) $field['min'] > 0 ? $field['min'] : -1;
6
-    $item_name = strtolower(isset($field['entity_singular']) && ! empty($field['entity_singular']) ? $field['entity_singular'] : $field['label']);
6
+    $item_name = strtolower(isset($field['entity_singular']) && !empty($field['entity_singular']) ? $field['entity_singular'] : $field['label']);
7 7
 
8 8
     $items = old(square_brackets_to_dots($field['name'])) ?? $field['value'] ?? $field['default'] ?? '';
9 9
 
@@ -15,12 +15,12 @@  discard block
 block discarded – undo
15 15
         } else {
16 16
             $items = '[]';
17 17
         }
18
-    } elseif (is_string($items) && ! is_array(json_decode($items))) {
18
+    } elseif (is_string($items) && !is_array(json_decode($items))) {
19 19
         $items = '[]';
20 20
     }
21 21
 
22 22
     // make sure columns are defined
23
-    if (! isset($field['columns'])) {
23
+    if (!isset($field['columns'])) {
24 24
         $field['columns'] = ['value' => 'Value'];
25 25
     }
26 26
 ?>
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ListOperation.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     {
42 42
         $this->crud->allowAccess('list');
43 43
 
44
-        $this->crud->operation('list', function () {
44
+        $this->crud->operation('list', function() {
45 45
             $this->crud->loadDefaultOperationSettingsFromConfig();
46 46
         });
47 47
     }
@@ -112,8 +112,8 @@  discard block
 block discarded – undo
112 112
         // if there was an order set, this will be the last one (after all others were applied)
113 113
         $orderBy = $this->crud->query->getQuery()->orders;
114 114
         $hasOrderByPrimaryKey = false;
115
-        collect($orderBy)->each(function ($item, $key) use ($hasOrderByPrimaryKey) {
116
-            if (! isset($item['column'])) {
115
+        collect($orderBy)->each(function($item, $key) use ($hasOrderByPrimaryKey) {
116
+            if (!isset($item['column'])) {
117 117
                 return false;
118 118
             }
119 119
 
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
                 return false;
124 124
             }
125 125
         });
126
-        if (! $hasOrderByPrimaryKey) {
126
+        if (!$hasOrderByPrimaryKey) {
127 127
             $this->crud->query->orderByDesc($this->crud->model->getKeyName());
128 128
         }
129 129
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
 
28 28
         // call the setup function inside this closure to also have the request there
29 29
         // this way, developers can use things stored in session (auth variables, etc)
30
-        $this->middleware(function ($request, $next) {
30
+        $this->middleware(function($request, $next) {
31 31
             // make a new CrudPanel object, from the one stored in Laravel's service container
32 32
             $this->crud = app()->make('crud');
33 33
             // ensure crud has the latest request
Please login to merge, or discard this patch.
tests/Unit/Http/CrudControllerTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
         $controller = '\Backpack\CRUD\Tests\Unit\Http\Controllers\UserCrudController';
20 20
         $app['router']->get('users/{id}/edit', "$controller@edit");
21 21
         $app['router']->put('users/{id}', "$controller@update");
22
-        $app->singleton('crud', function ($app) {
22
+        $app->singleton('crud', function($app) {
23 23
             return new CrudPanel($app);
24 24
         });
25 25
     }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudPanel.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
      */
70 70
     public function setRequest($request = null)
71 71
     {
72
-        if (! $request) {
72
+        if (!$request) {
73 73
             $request = \Request::instance();
74 74
         }
75 75
         $this->request = $request;
@@ -89,11 +89,11 @@  discard block
 block discarded – undo
89 89
      */
90 90
     public function setModel($model_namespace)
91 91
     {
92
-        if (! class_exists($model_namespace)) {
92
+        if (!class_exists($model_namespace)) {
93 93
             throw new \Exception('The model does not exist.', 500);
94 94
         }
95 95
 
96
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
96
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
97 97
             throw new \Exception('Please use CrudTrait on the model.', 500);
98 98
         }
99 99
 
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
     {
157 157
         $complete_route = $route.'.index';
158 158
 
159
-        if (! \Route::has($complete_route)) {
159
+        if (!\Route::has($complete_route)) {
160 160
             throw new \Exception('There are no routes for this route name.', 404);
161 161
         }
162 162
 
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
      */
258 258
     public function getFirstOfItsTypeInArray($type, $array)
259 259
     {
260
-        return array_first($array, function ($item) use ($type) {
260
+        return array_first($array, function($item) use ($type) {
261 261
             return $item['type'] == $type;
262 262
         });
263 263
     }
@@ -274,8 +274,8 @@  discard block
 block discarded – undo
274 274
 
275 275
     public function sync($type, $fields, $attributes)
276 276
     {
277
-        if (! empty($this->{$type})) {
278
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
277
+        if (!empty($this->{$type})) {
278
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
279 279
                 if (in_array($field['name'], (array) $fields)) {
280 280
                     $field = array_merge($field, $attributes);
281 281
                 }
@@ -306,15 +306,15 @@  discard block
 block discarded – undo
306 306
     {
307 307
         $relationArray = explode('.', $relationString);
308 308
 
309
-        if (! isset($length)) {
309
+        if (!isset($length)) {
310 310
             $length = count($relationArray);
311 311
         }
312 312
 
313
-        if (! isset($model)) {
313
+        if (!isset($model)) {
314 314
             $model = $this->model;
315 315
         }
316 316
 
317
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
317
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
318 318
             return $obj->$method()->getRelated();
319 319
         }, $model);
320 320
 
@@ -364,7 +364,7 @@  discard block
 block discarded – undo
364 364
         $relation = $model->{$firstRelationName};
365 365
 
366 366
         $results = [];
367
-        if (! empty($relation)) {
367
+        if (!empty($relation)) {
368 368
             if ($relation instanceof Collection) {
369 369
                 $currentResults = $relation->toArray();
370 370
             } else {
@@ -373,7 +373,7 @@  discard block
 block discarded – undo
373 373
 
374 374
             array_shift($relationArray);
375 375
 
376
-            if (! empty($relationArray)) {
376
+            if (!empty($relationArray)) {
377 377
                 foreach ($currentResults as $currentResult) {
378 378
                     $results = array_merge($results, $this->getRelationModelInstances($currentResult, implode('.', $relationArray)));
379 379
                 }
Please login to merge, or discard this patch.
src/app/Console/Commands/Install.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
                     $createUploadDirectoryCommand = 'mkdir -p public/uploads';
89 89
                     break;
90 90
                 case '\\': // windows
91
-                    if (! file_exists('public\uploads')) {
91
+                    if (!file_exists('public\uploads')) {
92 92
                         $createUploadDirectoryCommand = 'mkdir public\uploads';
93 93
                     }
94 94
                     break;
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
         $this->echo('info', $beforeNotice ? ' '.$beforeNotice : $command);
134 134
 
135 135
         $process = new Process($command, null, null, null, $this->option('timeout'));
136
-        $process->run(function ($type, $buffer) {
136
+        $process->run(function($type, $buffer) {
137 137
             if (Process::ERR === $type) {
138 138
                 $this->echo('comment', $buffer);
139 139
             } else {
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
         });
143 143
 
144 144
         // executes after the command finishes
145
-        if (! $process->isSuccessful()) {
145
+        if (!$process->isSuccessful()) {
146 146
             throw new ProcessFailedException($process);
147 147
         }
148 148
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Relationships.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -52,9 +52,9 @@
 block discarded – undo
52 52
     public function checkIfFieldNameBelongsToAnyRelation($fieldName)
53 53
     {
54 54
         $relations = $this->getAvailableRelationsInModel();
55
-        if (! empty($relations)) {
55
+        if (!empty($relations)) {
56 56
             if (in_array($fieldName, array_column($relations, 'name'))) {
57
-                return array_filter($relations, function ($arr) use ($fieldName) {
57
+                return array_filter($relations, function($arr) use ($fieldName) {
58 58
                     if (isset($arr['name'])) {
59 59
                         return $arr['name'] == $fieldName;
60 60
                     }
Please login to merge, or discard this patch.
src/resources/views/crud/columns/select_from_array.blade.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@
 block discarded – undo
10 10
                 $array_of_values = [];
11 11
 
12 12
                 foreach ($values as $key => $value) {
13
-                    if (! is_null($value)) {
13
+                    if (!is_null($value)) {
14 14
                         $array_of_values[] = $column['options'][$value] ?? $value;
15 15
                     } else {
16 16
                         echo '-';
Please login to merge, or discard this patch.
src/app/Models/Traits/CrudTrait.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
             //check if column exists in database
73 73
             $conn->getDoctrineColumn($table, $column_name);
74 74
 
75
-            return ! $conn->getDoctrineColumn($table, $column_name)->getNotnull();
75
+            return !$conn->getDoctrineColumn($table, $column_name)->getNotnull();
76 76
         } catch (\Exception $e) {
77 77
             return true;
78 78
         }
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
     public function addFakes($columns = ['extras'])
93 93
     {
94 94
         foreach ($columns as $key => $column) {
95
-            if (! isset($this->attributes[$column])) {
95
+            if (!isset($this->attributes[$column])) {
96 96
                 continue;
97 97
             }
98 98
 
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
      */
142 142
     public function shouldDecodeFake($column)
143 143
     {
144
-        return ! in_array($column, array_keys($this->casts));
144
+        return !in_array($column, array_keys($this->casts));
145 145
     }
146 146
 
147 147
     /**
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
      */
154 154
     public function shouldEncodeFake($column)
155 155
     {
156
-        return ! in_array($column, array_keys($this->casts));
156
+        return !in_array($column, array_keys($this->casts));
157 157
     }
158 158
 
159 159
     /*
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
      */
225 225
     public function uploadMultipleFilesToDisk($value, $attribute_name, $disk, $destination_path)
226 226
     {
227
-        if (! is_array($this->{$attribute_name})) {
227
+        if (!is_array($this->{$attribute_name})) {
228 228
             $attribute_value = json_decode($this->{$attribute_name}, true) ?? [];
229 229
         } else {
230 230
             $attribute_value = $this->{$attribute_name};
@@ -236,7 +236,7 @@  discard block
 block discarded – undo
236 236
         if ($files_to_clear) {
237 237
             foreach ($files_to_clear as $key => $filename) {
238 238
                 \Storage::disk($disk)->delete($filename);
239
-                $attribute_value = array_where($attribute_value, function ($value, $key) use ($filename) {
239
+                $attribute_value = array_where($attribute_value, function($value, $key) use ($filename) {
240 240
                     return $value != $filename;
241 241
                 });
242 242
             }
Please login to merge, or discard this patch.