Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#248)
by Owen
02:44
created
src/resources/views/fields/table.blade.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,13 +3,13 @@
 block discarded – undo
3 3
 <?php
4 4
     $max = isset($field['max']) ? $field['max'] : -1;
5 5
     $min = isset($field['min']) ? $field['min'] : -1;
6
-    $item_name = strtolower( isset($field['entity_singular']) && !empty($field['entity_singular']) ? $field['entity_singular'] : $field['label']);
6
+    $item_name = strtolower(isset($field['entity_singular']) && !empty($field['entity_singular']) ? $field['entity_singular'] : $field['label']);
7 7
 
8
-    $items = old($field['name']) ? (old($field['name'])) : (isset($field['value']) ? ($field['value']) : (isset($field['default']) ? ($field['default']) : '' ));
8
+    $items = old($field['name']) ? (old($field['name'])) : (isset($field['value']) ? ($field['value']) : (isset($field['default']) ? ($field['default']) : ''));
9 9
 
10 10
     // make sure not matter the attribute casting
11 11
     // the $items variable contains a properly defined JSON
12
-    if(is_array($items)) {
12
+    if (is_array($items)) {
13 13
         if (count($items)) {
14 14
             $items = json_encode($items);
15 15
         }
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -12,8 +12,7 @@
 block discarded – undo
12 12
     if(is_array($items)) {
13 13
         if (count($items)) {
14 14
             $items = json_encode($items);
15
-        }
16
-        else
15
+        } else
17 16
         {
18 17
             $items = '[]';
19 18
         }
Please login to merge, or discard this patch.
src/resources/views/fields/video.blade.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,11 +1,11 @@
 block discarded – undo
1 1
 <!-- text input -->
2 2
 <?php
3 3
 
4
-$value = old($field['name']) ? (old($field['name'])) : (isset($field['value']) ? ($field['value']) : (isset($field['default']) ? ($field['default']) : '' ));
4
+$value = old($field['name']) ? (old($field['name'])) : (isset($field['value']) ? ($field['value']) : (isset($field['default']) ? ($field['default']) : ''));
5 5
 
6 6
 // if attribute casting is used, convert to JSON
7 7
 if (is_array($value)) {
8
-    $value = json_encode((object)$value);
8
+    $value = json_encode((object) $value);
9 9
 } elseif (is_object($value)) {
10 10
     $value = json_encode($value);
11 11
 } else {
Please login to merge, or discard this patch.
src/resources/views/fields/date_picker.blade.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,11 +3,11 @@
 block discarded – undo
3 3
 <?php
4 4
     // if the column has been cast to Carbon or Date (using attribute casting)
5 5
     // get the value as a date string
6
-    if (isset($field['value']) && ( $field['value'] instanceof \Carbon\Carbon || $field['value'] instanceof \Jenssegers\Date\Date )) {
7
-        $field['value'] = $field['value']->format( 'Y-m-d' );
6
+    if (isset($field['value']) && ($field['value'] instanceof \Carbon\Carbon || $field['value'] instanceof \Jenssegers\Date\Date)) {
7
+        $field['value'] = $field['value']->format('Y-m-d');
8 8
     }
9 9
 
10
-    $field_language = isset($field['date_picker_options']['language'])?$field['date_picker_options']['language']:\App::getLocale();
10
+    $field_language = isset($field['date_picker_options']['language']) ? $field['date_picker_options']['language'] : \App::getLocale();
11 11
 ?>
12 12
 
13 13
 <div @include('crud::inc.field_wrapper_attributes') >
Please login to merge, or discard this patch.
src/resources/views/fields/datetime_picker.blade.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,11 +3,11 @@
 block discarded – undo
3 3
 <?php
4 4
     // if the column has been cast to Carbon or Date (using attribute casting)
5 5
     // get the value as a date string
6
-    if (isset($field['value']) && ( $field['value'] instanceof \Carbon\Carbon || $field['value'] instanceof \Jenssegers\Date\Date )) {
7
-        $field['value'] = $field['value']->format( 'Y-m-d H:i:s' );
6
+    if (isset($field['value']) && ($field['value'] instanceof \Carbon\Carbon || $field['value'] instanceof \Jenssegers\Date\Date)) {
7
+        $field['value'] = $field['value']->format('Y-m-d H:i:s');
8 8
     }
9 9
 
10
-    $field_language = isset($field['datetime_picker_options']['language'])?$field['datetime_picker_options']['language']:\App::getLocale();
10
+    $field_language = isset($field['datetime_picker_options']['language']) ? $field['datetime_picker_options']['language'] : \App::getLocale();
11 11
 ?>
12 12
 
13 13
 <div @include('crud::inc.field_wrapper_attributes') >
Please login to merge, or discard this patch.
src/PanelTraits/Filters.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@
 block discarded – undo
124 124
 
125 125
     /**
126 126
      * Determine if the current CRUD action is a list operation (using standard or ajax DataTables).
127
-     * @return bool
127
+     * @return boolean|null
128 128
      */
129 129
     public function doingListOperation()
130 130
     {
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
         }
34 34
 
35 35
         // check if another filter with the same name exists
36
-        if (! isset($options['name'])) {
36
+        if (!isset($options['name'])) {
37 37
             abort(500, 'All your filters need names.');
38 38
         }
39 39
         if ($this->filters->contains('name', $options['name'])) {
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
 
113 113
     public function removeFilter($name)
114 114
     {
115
-        $this->filters = $this->filters->reject(function ($filter) use ($name) {
115
+        $this->filters = $this->filters->reject(function($filter) use ($name) {
116 116
             return $filter->name == $name;
117 117
         });
118 118
     }
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
         $this->type = $options['type'];
178 178
         $this->label = $options['label'];
179 179
 
180
-        if (! isset($options['placeholder'])) {
180
+        if (!isset($options['placeholder'])) {
181 181
             $this->placeholder = '';
182 182
         } else {
183 183
             $this->placeholder = $options['placeholder'];
@@ -194,16 +194,16 @@  discard block
 block discarded – undo
194 194
 
195 195
     public function checkOptionsIntegrity($options)
196 196
     {
197
-        if (! isset($options['name'])) {
197
+        if (!isset($options['name'])) {
198 198
             abort(500, 'Please make sure all your filters have names.');
199 199
         }
200
-        if (! isset($options['type'])) {
200
+        if (!isset($options['type'])) {
201 201
             abort(500, 'Please make sure all your filters have types.');
202 202
         }
203
-        if (! \View::exists('crud::filters.'.$options['type'])) {
203
+        if (!\View::exists('crud::filters.'.$options['type'])) {
204 204
             abort(500, 'No filter view named "'.$options['type'].'.blade.php" was found.');
205 205
         }
206
-        if (! isset($options['label'])) {
206
+        if (!isset($options['label'])) {
207 207
             abort(500, 'Please make sure all your filters have labels.');
208 208
         }
209 209
     }
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudController.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -27,12 +27,12 @@  discard block
 block discarded – undo
27 27
 
28 28
     public function __construct()
29 29
     {
30
-        if (! $this->crud) {
30
+        if (!$this->crud) {
31 31
             $this->crud = new CrudPanel();
32 32
 
33 33
             // call the setup function inside this closure to also have the request there
34 34
             // this way, developers can use things stored in session (auth variables, etc)
35
-            $this->middleware(function ($request, $next) {
35
+            $this->middleware(function($request, $next) {
36 36
                 $this->request = $request;
37 37
                 $this->crud->request = $request;
38 38
                 $this->setup();
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
         $this->data['title'] = ucfirst($this->crud->entity_name_plural);
63 63
 
64 64
         // get all entries if AJAX is not enabled
65
-        if (! $this->data['crud']->ajaxTable()) {
65
+        if (!$this->data['crud']->ajaxTable()) {
66 66
             $this->data['entries'] = $this->data['crud']->getEntries();
67 67
         }
68 68
 
Please login to merge, or discard this patch.
Unused Use Statements   +4 added lines, -6 removed lines patch added patch discarded remove patch
@@ -2,20 +2,18 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD\app\Http\Controllers;
4 4
 
5
+use Backpack\CRUD\CrudPanel;
6
+use Backpack\CRUD\app\Http\Requests\CrudRequest as UpdateRequest;
5 7
 use Illuminate\Foundation\Bus\DispatchesJobs;
6 8
 use Illuminate\Foundation\Validation\ValidatesRequests;
7
-use Illuminate\Routing\Controller as BaseController;
8
-use Illuminate\Support\Facades\Form as Form;
9 9
 use Illuminate\Http\Request;
10
-use Backpack\CRUD\app\Http\Requests\CrudRequest as StoreRequest;
11
-use Backpack\CRUD\app\Http\Requests\CrudRequest as UpdateRequest;
12
-use Backpack\CRUD\CrudPanel;
10
+use Illuminate\Routing\Controller as BaseController;
13 11
 // CRUD Traits for non-core features
14 12
 use Backpack\CRUD\app\Http\Controllers\CrudFeatures\AjaxTable;
15 13
 use Backpack\CRUD\app\Http\Controllers\CrudFeatures\Reorder;
16 14
 use Backpack\CRUD\app\Http\Controllers\CrudFeatures\Revisions;
17
-use Backpack\CRUD\app\Http\Controllers\CrudFeatures\ShowDetailsRow;
18 15
 use Backpack\CRUD\app\Http\Controllers\CrudFeatures\SaveActions;
16
+use Backpack\CRUD\app\Http\Controllers\CrudFeatures\ShowDetailsRow;
19 17
 
20 18
 class CrudController extends BaseController
21 19
 {
Please login to merge, or discard this patch.