Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#248)
by Owen
02:44
created
src/resources/views/fields/table.blade.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,13 +3,13 @@
 block discarded – undo
3 3
 <?php
4 4
     $max = isset($field['max']) ? $field['max'] : -1;
5 5
     $min = isset($field['min']) ? $field['min'] : -1;
6
-    $item_name = strtolower( isset($field['entity_singular']) && !empty($field['entity_singular']) ? $field['entity_singular'] : $field['label']);
6
+    $item_name = strtolower(isset($field['entity_singular']) && !empty($field['entity_singular']) ? $field['entity_singular'] : $field['label']);
7 7
 
8
-    $items = old($field['name']) ? (old($field['name'])) : (isset($field['value']) ? ($field['value']) : (isset($field['default']) ? ($field['default']) : '' ));
8
+    $items = old($field['name']) ? (old($field['name'])) : (isset($field['value']) ? ($field['value']) : (isset($field['default']) ? ($field['default']) : ''));
9 9
 
10 10
     // make sure not matter the attribute casting
11 11
     // the $items variable contains a properly defined JSON
12
-    if(is_array($items)) {
12
+    if (is_array($items)) {
13 13
         if (count($items)) {
14 14
             $items = json_encode($items);
15 15
         }
Please login to merge, or discard this patch.
src/resources/views/fields/video.blade.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,11 +1,11 @@
 block discarded – undo
1 1
 <!-- text input -->
2 2
 <?php
3 3
 
4
-$value = old($field['name']) ? (old($field['name'])) : (isset($field['value']) ? ($field['value']) : (isset($field['default']) ? ($field['default']) : '' ));
4
+$value = old($field['name']) ? (old($field['name'])) : (isset($field['value']) ? ($field['value']) : (isset($field['default']) ? ($field['default']) : ''));
5 5
 
6 6
 // if attribute casting is used, convert to JSON
7 7
 if (is_array($value)) {
8
-    $value = json_encode((object)$value);
8
+    $value = json_encode((object) $value);
9 9
 } elseif (is_object($value)) {
10 10
     $value = json_encode($value);
11 11
 } else {
Please login to merge, or discard this patch.
src/CrudTrait.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
     public static function isColumnNullable($column_name)
31 31
     {
32 32
         $instance = new static(); // create an instance of the model to be able to get the table name
33
-        return ! DB::connection()->getDoctrineColumn($instance->getTable(), $column_name)->getNotnull();
33
+        return !DB::connection()->getDoctrineColumn($instance->getTable(), $column_name)->getNotnull();
34 34
     }
35 35
 
36 36
     /*
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
         foreach ($columns as $key => $column) {
50 50
             $column_contents = $this->{$column};
51 51
 
52
-            if (! is_object($this->{$column})) {
52
+            if (!is_object($this->{$column})) {
53 53
                 $column_contents = json_decode($this->{$column});
54 54
             }
55 55
 
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
     {
73 73
         $model = '\\'.get_class($this);
74 74
 
75
-        if (! count($columns)) {
75
+        if (!count($columns)) {
76 76
             $columns = (property_exists($model, 'fakeColumns')) ? $this->fakeColumns : ['extras'];
77 77
         }
78 78
 
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
             $attribute_value = (array) $this->{$attribute_name};
163 163
             foreach ($files_to_clear as $key => $filename) {
164 164
                 \Storage::disk($disk)->delete($filename);
165
-                $attribute_value = array_where($attribute_value, function ($value, $key) use ($filename) {
165
+                $attribute_value = array_where($attribute_value, function($value, $key) use ($filename) {
166 166
                     return $value != $filename;
167 167
                 });
168 168
             }
Please login to merge, or discard this patch.
src/PanelTraits/Buttons.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 
78 78
     public function removeButton($name)
79 79
     {
80
-        $this->buttons = $this->buttons->reject(function ($button) use ($name) {
80
+        $this->buttons = $this->buttons->reject(function($button) use ($name) {
81 81
             return $button->name == $name;
82 82
         });
83 83
     }
@@ -89,14 +89,14 @@  discard block
 block discarded – undo
89 89
 
90 90
     public function removeAllButtonsFromStack($stack)
91 91
     {
92
-        $this->buttons = $this->buttons->reject(function ($button) use ($stack) {
92
+        $this->buttons = $this->buttons->reject(function($button) use ($stack) {
93 93
             return $button->stack == $stack;
94 94
         });
95 95
     }
96 96
 
97 97
     public function removeButtonFromStack($name, $stack)
98 98
     {
99
-        $this->buttons = $this->buttons->reject(function ($button) use ($name, $stack) {
99
+        $this->buttons = $this->buttons->reject(function($button) use ($name, $stack) {
100 100
             return $button->name == $name && $button->stack == $stack;
101 101
         });
102 102
     }
Please login to merge, or discard this patch.
src/resources/views/fields/date_picker.blade.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,11 +3,11 @@
 block discarded – undo
3 3
 <?php
4 4
     // if the column has been cast to Carbon or Date (using attribute casting)
5 5
     // get the value as a date string
6
-    if (isset($field['value']) && ( $field['value'] instanceof \Carbon\Carbon || $field['value'] instanceof \Jenssegers\Date\Date )) {
7
-        $field['value'] = $field['value']->format( 'Y-m-d' );
6
+    if (isset($field['value']) && ($field['value'] instanceof \Carbon\Carbon || $field['value'] instanceof \Jenssegers\Date\Date)) {
7
+        $field['value'] = $field['value']->format('Y-m-d');
8 8
     }
9 9
 
10
-    $field_language = isset($field['date_picker_options']['language'])?$field['date_picker_options']['language']:\App::getLocale();
10
+    $field_language = isset($field['date_picker_options']['language']) ? $field['date_picker_options']['language'] : \App::getLocale();
11 11
 ?>
12 12
 
13 13
 <div @include('crud::inc.field_wrapper_attributes') >
Please login to merge, or discard this patch.
src/resources/views/fields/datetime_picker.blade.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,11 +3,11 @@
 block discarded – undo
3 3
 <?php
4 4
     // if the column has been cast to Carbon or Date (using attribute casting)
5 5
     // get the value as a date string
6
-    if (isset($field['value']) && ( $field['value'] instanceof \Carbon\Carbon || $field['value'] instanceof \Jenssegers\Date\Date )) {
7
-        $field['value'] = $field['value']->format( 'Y-m-d H:i:s' );
6
+    if (isset($field['value']) && ($field['value'] instanceof \Carbon\Carbon || $field['value'] instanceof \Jenssegers\Date\Date)) {
7
+        $field['value'] = $field['value']->format('Y-m-d H:i:s');
8 8
     }
9 9
 
10
-    $field_language = isset($field['datetime_picker_options']['language'])?$field['datetime_picker_options']['language']:\App::getLocale();
10
+    $field_language = isset($field['datetime_picker_options']['language']) ? $field['datetime_picker_options']['language'] : \App::getLocale();
11 11
 ?>
12 12
 
13 13
 <div @include('crud::inc.field_wrapper_attributes') >
Please login to merge, or discard this patch.
src/PanelTraits/Filters.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
         }
34 34
 
35 35
         // check if another filter with the same name exists
36
-        if (! isset($options['name'])) {
36
+        if (!isset($options['name'])) {
37 37
             abort(500, 'All your filters need names.');
38 38
         }
39 39
         if ($this->filters->contains('name', $options['name'])) {
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
 
113 113
     public function removeFilter($name)
114 114
     {
115
-        $this->filters = $this->filters->reject(function ($filter) use ($name) {
115
+        $this->filters = $this->filters->reject(function($filter) use ($name) {
116 116
             return $filter->name == $name;
117 117
         });
118 118
     }
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
         $this->type = $options['type'];
178 178
         $this->label = $options['label'];
179 179
 
180
-        if (! isset($options['placeholder'])) {
180
+        if (!isset($options['placeholder'])) {
181 181
             $this->placeholder = '';
182 182
         } else {
183 183
             $this->placeholder = $options['placeholder'];
@@ -194,16 +194,16 @@  discard block
 block discarded – undo
194 194
 
195 195
     public function checkOptionsIntegrity($options)
196 196
     {
197
-        if (! isset($options['name'])) {
197
+        if (!isset($options['name'])) {
198 198
             abort(500, 'Please make sure all your filters have names.');
199 199
         }
200
-        if (! isset($options['type'])) {
200
+        if (!isset($options['type'])) {
201 201
             abort(500, 'Please make sure all your filters have types.');
202 202
         }
203
-        if (! \View::exists('crud::filters.'.$options['type'])) {
203
+        if (!\View::exists('crud::filters.'.$options['type'])) {
204 204
             abort(500, 'No filter view named "'.$options['type'].'.blade.php" was found.');
205 205
         }
206
-        if (! isset($options['label'])) {
206
+        if (!isset($options['label'])) {
207 207
             abort(500, 'Please make sure all your filters have labels.');
208 208
         }
209 209
     }
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -27,12 +27,12 @@  discard block
 block discarded – undo
27 27
 
28 28
     public function __construct()
29 29
     {
30
-        if (! $this->crud) {
30
+        if (!$this->crud) {
31 31
             $this->crud = new CrudPanel();
32 32
 
33 33
             // call the setup function inside this closure to also have the request there
34 34
             // this way, developers can use things stored in session (auth variables, etc)
35
-            $this->middleware(function ($request, $next) {
35
+            $this->middleware(function($request, $next) {
36 36
                 $this->request = $request;
37 37
                 $this->crud->request = $request;
38 38
                 $this->setup();
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
         $this->data['title'] = ucfirst($this->crud->entity_name_plural);
63 63
 
64 64
         // get all entries if AJAX is not enabled
65
-        if (! $this->data['crud']->ajaxTable()) {
65
+        if (!$this->data['crud']->ajaxTable()) {
66 66
             $this->data['entries'] = $this->data['crud']->getEntries();
67 67
         }
68 68
 
Please login to merge, or discard this patch.