Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Failed
Pull Request — master (#3470)
by Cristian
25:18 queued 10:21
created
src/app/Library/CrudPanel/Traits/AutoSet.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
             $this->getDbColumnTypes();
17 17
         }
18 18
 
19
-        array_map(function ($field) {
19
+        array_map(function($field) {
20 20
             $new_field = [
21 21
                 'name'       => $field,
22 22
                 'label'      => $this->makeLabel($field),
@@ -28,11 +28,11 @@  discard block
 block discarded – undo
28 28
                 'autoset'    => true,
29 29
             ];
30 30
 
31
-            if (! isset($this->fields()[$field])) {
31
+            if (!isset($this->fields()[$field])) {
32 32
                 $this->addField($new_field);
33 33
             }
34 34
 
35
-            if (! in_array($field, $this->model->getHidden()) && ! in_array($field, $this->columns())) {
35
+            if (!in_array($field, $this->model->getHidden()) && !in_array($field, $this->columns())) {
36 36
                 $this->addColumn([
37 37
                     'name'    => $field,
38 38
                     'label'   => $this->makeLabel($field),
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 
111 111
         $dbColumnTypes = $this->getDbColumnTypes();
112 112
 
113
-        if (! isset($dbColumnTypes[$fieldName])) {
113
+        if (!isset($dbColumnTypes[$fieldName])) {
114 114
             return 'text';
115 115
         }
116 116
 
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
         $types = ['enum' => 'string'];
169 169
         $platform = $this->getSchema()->getConnection()->getDoctrineConnection()->getDatabasePlatform();
170 170
         foreach ($types as $type_key => $type_value) {
171
-            if (! $platform->hasDoctrineTypeMappingFor($type_key)) {
171
+            if (!$platform->hasDoctrineTypeMappingFor($type_key)) {
172 172
                 $platform->registerDoctrineTypeMapping($type_key, $type_value);
173 173
             }
174 174
         }
@@ -221,13 +221,13 @@  discard block
 block discarded – undo
221 221
     {
222 222
         $fillable = $this->model->getFillable();
223 223
 
224
-        if (! $this->driverIsSql()) {
224
+        if (!$this->driverIsSql()) {
225 225
             $columns = $fillable;
226 226
         } else {
227 227
             // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model
228 228
             $columns = $this->model->getConnection()->getSchemaBuilder()->getColumnListing($this->model->getTable());
229 229
 
230
-            if (! empty($fillable)) {
230
+            if (!empty($fillable)) {
231 231
                 $columns = array_intersect($columns, $fillable);
232 232
             }
233 233
         }
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ListOperation.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     {
42 42
         $this->crud->allowAccess('list');
43 43
 
44
-        $this->crud->operation('list', function () {
44
+        $this->crud->operation('list', function() {
45 45
             $this->crud->loadDefaultOperationSettingsFromConfig();
46 46
         });
47 47
     }
@@ -114,8 +114,8 @@  discard block
 block discarded – undo
114 114
         // if there was an order set, this will be the last one (after all others were applied)
115 115
         $orderBy = $this->crud->query->getQuery()->orders;
116 116
         $hasOrderByPrimaryKey = false;
117
-        collect($orderBy)->each(function ($item, $key) use ($hasOrderByPrimaryKey) {
118
-            if (! isset($item['column'])) {
117
+        collect($orderBy)->each(function($item, $key) use ($hasOrderByPrimaryKey) {
118
+            if (!isset($item['column'])) {
119 119
                 return false;
120 120
             }
121 121
 
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
                 return false;
126 126
             }
127 127
         });
128
-        if (! $hasOrderByPrimaryKey) {
128
+        if (!$hasOrderByPrimaryKey) {
129 129
             $this->crud->orderByWithPrefix($this->crud->model->getKeyName(), 'DESC');
130 130
         }
131 131
 
Please login to merge, or discard this patch.
src/app/Models/Traits/HasRelationshipFields.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
         $table = $instance->getTableWithPrefix();
73 73
 
74 74
         // MongoDB columns are alway nullable
75
-        if (! in_array($conn->getConfig()['driver'], CRUD::getSqlDriverList())) {
75
+        if (!in_array($conn->getConfig()['driver'], CRUD::getSqlDriverList())) {
76 76
             return true;
77 77
         }
78 78
 
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
             // check for NOT NULL
83 83
             $notNull = $column->getNotnull();
84 84
             // return the value of nullable (aka the inverse of NOT NULL)
85
-            return ! $notNull;
85
+            return !$notNull;
86 86
         } catch (\Exception $e) {
87 87
             return true;
88 88
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Read.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
     {
39 39
         $id = $this->getCurrentEntryId();
40 40
 
41
-        if (! $id) {
41
+        if (!$id) {
42 42
             return false;
43 43
         }
44 44
 
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
      */
55 55
     public function getEntry($id)
56 56
     {
57
-        if (! $this->entry) {
57
+        if (!$this->entry) {
58 58
             $this->entry = $this->model->findOrFail($id);
59 59
             $this->entry = $this->entry->withFakes();
60 60
         }
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
                 // we will apply the same labels as the values to the menu if developer didn't
245 245
                 $this->abortIfInvalidPageLength($menu[0]);
246 246
 
247
-                if (! isset($menu[1]) || ! is_array($menu[1])) {
247
+                if (!isset($menu[1]) || !is_array($menu[1])) {
248 248
                     $menu[1] = $menu[0];
249 249
                 }
250 250
             } else {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Columns.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
      */
115 115
     public function makeFirstColumn()
116 116
     {
117
-        if (! $this->columns()) {
117
+        if (!$this->columns()) {
118 118
             return false;
119 119
         }
120 120
 
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
      */
160 160
     public function removeColumns($columns)
161 161
     {
162
-        if (! empty($columns)) {
162
+        if (!empty($columns)) {
163 163
             foreach ($columns as $columnKey) {
164 164
                 $this->removeColumn($columnKey);
165 165
             }
@@ -252,8 +252,8 @@  discard block
 block discarded – undo
252 252
     {
253 253
         $columns = $this->columns();
254 254
 
255
-        return collect($columns)->pluck('entity')->reject(function ($value, $key) {
256
-            return ! $value;
255
+        return collect($columns)->pluck('entity')->reject(function($value, $key) {
256
+            return !$value;
257 257
         })->toArray();
258 258
     }
259 259
 
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
      */
330 330
     public function hasColumnWhere($attribute, $value)
331 331
     {
332
-        $match = Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
332
+        $match = Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
333 333
             return isset($column[$attribute]) && $column[$attribute] == $value;
334 334
         });
335 335
 
@@ -345,7 +345,7 @@  discard block
 block discarded – undo
345 345
      */
346 346
     public function firstColumnWhere($attribute, $value)
347 347
     {
348
-        return Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
348
+        return Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
349 349
             return isset($column[$attribute]) && $column[$attribute] == $value;
350 350
         });
351 351
     }
@@ -380,10 +380,10 @@  discard block
 block discarded – undo
380 380
         // check if method exists in model so it's a possible relation
381 381
         // but exclude possible matches if developer setup entity => false
382 382
         $could_be_relation = method_exists($this->model, $column['name'])
383
-            ? ! isset($column['entity']) || $column['entity'] !== false
383
+            ? !isset($column['entity']) || $column['entity'] !== false
384 384
             : isset($column['entity']) && $column['entity'] !== false;
385 385
 
386
-        if (! $column_exists_in_db && $could_be_relation) {
386
+        if (!$column_exists_in_db && $could_be_relation) {
387 387
             $related_model = $this->model->{$column['name']}()->getRelated();
388 388
             $column['entity'] = $column['name'];
389 389
             $column['model'] = get_class($related_model);
@@ -402,8 +402,8 @@  discard block
 block discarded – undo
402 402
      */
403 403
     public function countColumnsWithoutActions()
404 404
     {
405
-        return collect($this->columns())->filter(function ($column, $key) {
406
-            return ! isset($column['hasActions']) || $column['hasActions'] == false;
405
+        return collect($this->columns())->filter(function($column, $key) {
406
+            return !isset($column['hasActions']) || $column['hasActions'] == false;
407 407
         })->count();
408 408
     }
409 409
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php 1 patch
Spacing   +10 added lines, -11 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
             $column = ['name' => $column];
50 50
         }
51 51
 
52
-        if (is_array($column) && ! isset($column['name'])) {
52
+        if (is_array($column) && !isset($column['name'])) {
53 53
             $column['name'] = 'anonymous_column_'.Str::random(5);
54 54
         }
55 55
 
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      */
66 66
     protected function makeSureColumnHasLabel($column)
67 67
     {
68
-        if (! isset($column['label'])) {
68
+        if (!isset($column['label'])) {
69 69
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
70 70
         }
71 71
 
@@ -83,14 +83,14 @@  discard block
 block discarded – undo
83 83
         // check if method exists in model so it's a possible relation
84 84
         // but exclude possible matches if developer setup entity => false
85 85
         $could_be_relation = method_exists($this->model, $column['name'])
86
-            ? ! isset($column['entity']) || $column['entity'] !== false
86
+            ? !isset($column['entity']) || $column['entity'] !== false
87 87
             : isset($column['entity']) && $column['entity'] !== false;
88 88
 
89
-        if (! isset($column['type']) && $could_be_relation) {
89
+        if (!isset($column['type']) && $could_be_relation) {
90 90
             $column['type'] = 'relationship';
91 91
         }
92 92
 
93
-        if (! isset($column['type'])) {
93
+        if (!isset($column['type'])) {
94 94
             $column['type'] = 'text';
95 95
         }
96 96
 
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
      */
108 108
     protected function makeSureColumnHasKey($column)
109 109
     {
110
-        if (! isset($column['key'])) {
110
+        if (!isset($column['key'])) {
111 111
             $column['key'] = str_replace('.', '__', $column['name']);
112 112
         }
113 113
 
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
      */
126 126
     protected function makeSureColumnHasWrapper($column)
127 127
     {
128
-        if (! isset($column['wrapper'])) {
128
+        if (!isset($column['wrapper'])) {
129 129
             $column['wrapper'] = [];
130 130
         }
131 131
 
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
     {
144 144
         // if this is a relation type field and no corresponding model was specified,
145 145
         // get it from the relation method defined in the main model
146
-        if (isset($column['entity']) && ! isset($column['model'])) {
146
+        if (isset($column['entity']) && !isset($column['model'])) {
147 147
             $column['model'] = $this->getRelationModel($column['entity']);
148 148
         }
149 149
 
@@ -164,8 +164,7 @@  discard block
 block discarded – undo
164 164
         $columnsArray = $this->columns();
165 165
 
166 166
         if (array_key_exists($targetColumnName, $columnsArray)) {
167
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
168
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
167
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
169 168
 
170 169
             $element = array_pop($columnsArray);
171 170
             $beginningPart = array_slice($columnsArray, 0, $targetColumnPosition, true);
@@ -188,7 +187,7 @@  discard block
 block discarded – undo
188 187
     {
189 188
         static $cache = [];
190 189
 
191
-        if (! $this->driverIsSql()) {
190
+        if (!$this->driverIsSql()) {
192 191
             return true;
193 192
         }
194 193
 
Please login to merge, or discard this patch.
src/helpers.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-if (! function_exists('backpack_url')) {
3
+if (!function_exists('backpack_url')) {
4 4
     /**
5 5
      * Appends the configured backpack prefix and returns
6 6
      * the URL using the standard Laravel helpers.
@@ -11,13 +11,13 @@  discard block
 block discarded – undo
11 11
      */
12 12
     function backpack_url($path = null, $parameters = [], $secure = null)
13 13
     {
14
-        $path = ! $path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
14
+        $path = !$path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
15 15
 
16 16
         return url(config('backpack.base.route_prefix', 'admin').$path, $parameters, $secure);
17 17
     }
18 18
 }
19 19
 
20
-if (! function_exists('backpack_authentication_column')) {
20
+if (!function_exists('backpack_authentication_column')) {
21 21
     /**
22 22
      * Return the username column name.
23 23
      * The Laravel default (and Backpack default) is 'email'.
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
     }
31 31
 }
32 32
 
33
-if (! function_exists('backpack_form_input')) {
33
+if (!function_exists('backpack_form_input')) {
34 34
     /**
35 35
      * Parse the submitted input in request('form') to an usable array.
36 36
      * Joins the multiple[] fields in a single key and transform the dot notation fields into arrayed ones.
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
             }
60 60
 
61 61
             if (is_null($input_arg)) {
62
-                if (! isset($result[$input_key])) {
62
+                if (!isset($result[$input_key])) {
63 63
                     $result[$input_key] = $start ? [$row['value']] : $row['value'];
64 64
                 } else {
65 65
                     array_push($result[$input_key], $row['value']);
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
     }
74 74
 }
75 75
 
76
-if (! function_exists('backpack_users_have_email')) {
76
+if (!function_exists('backpack_users_have_email')) {
77 77
     /**
78 78
      * Check if the email column is present on the user table.
79 79
      *
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
     }
89 89
 }
90 90
 
91
-if (! function_exists('backpack_avatar_url')) {
91
+if (!function_exists('backpack_avatar_url')) {
92 92
     /**
93 93
      * Returns the avatar URL of a user.
94 94
      *
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
     }
122 122
 }
123 123
 
124
-if (! function_exists('backpack_middleware')) {
124
+if (!function_exists('backpack_middleware')) {
125 125
     /**
126 126
      * Return the key of the middleware used across Backpack.
127 127
      * That middleware checks if the visitor is an admin.
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
     }
137 137
 }
138 138
 
139
-if (! function_exists('backpack_guard_name')) {
139
+if (!function_exists('backpack_guard_name')) {
140 140
     /*
141 141
      * Returns the name of the guard defined
142 142
      * by the application config
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
     }
148 148
 }
149 149
 
150
-if (! function_exists('backpack_auth')) {
150
+if (!function_exists('backpack_auth')) {
151 151
     /*
152 152
      * Returns the user instance if it exists
153 153
      * of the currently authenticated admin
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
     }
160 160
 }
161 161
 
162
-if (! function_exists('backpack_user')) {
162
+if (!function_exists('backpack_user')) {
163 163
     /*
164 164
      * Returns back a user instance without
165 165
      * the admin guard, however allows you
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
     }
172 172
 }
173 173
 
174
-if (! function_exists('mb_ucfirst')) {
174
+if (!function_exists('mb_ucfirst')) {
175 175
     /**
176 176
      * Capitalize the first letter of a string,
177 177
      * even if that string is multi-byte (non-latin alphabet).
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
     }
194 194
 }
195 195
 
196
-if (! function_exists('backpack_view')) {
196
+if (!function_exists('backpack_view')) {
197 197
     /**
198 198
      * Returns a new displayable view based on the configured backpack view namespace.
199 199
      * If that view doesn't exist, it will load the one from the original theme.
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
 
214 214
         $returnView = $theme.$view;
215 215
 
216
-        if (! view()->exists($returnView)) {
216
+        if (!view()->exists($returnView)) {
217 217
             $returnView = $originalTheme.$view;
218 218
         }
219 219
 
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
     }
222 222
 }
223 223
 
224
-if (! function_exists('square_brackets_to_dots')) {
224
+if (!function_exists('square_brackets_to_dots')) {
225 225
     /**
226 226
      * Turns a string from bracket-type array to dot-notation array.
227 227
      * Ex: array[0][property] turns into array.0.property.
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
     }
239 239
 }
240 240
 
241
-if (! function_exists('is_countable')) {
241
+if (!function_exists('is_countable')) {
242 242
     /**
243 243
      * We need this because is_countable was only introduced in PHP 7.3,
244 244
      * and in PHP 7.2 you should check if count() argument is really countable.
Please login to merge, or discard this patch.