We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
Total Complexity | 60 |
Total Lines | 305 |
Duplicated Lines | 0 % |
Changes | 22 | ||
Bugs | 13 | Features | 0 |
Complex classes like Uploader often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Uploader, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
13 | abstract class Uploader implements UploaderInterface |
||
14 | { |
||
15 | use HandleFileNaming; |
||
16 | use HandleRepeatableUploads; |
||
|
|||
17 | |||
18 | private string $name; |
||
19 | |||
20 | private string $disk = 'public'; |
||
21 | |||
22 | private string $path = ''; |
||
23 | |||
24 | private bool $handleMultipleFiles = false; |
||
25 | |||
26 | private bool $deleteWhenEntryIsDeleted = true; |
||
27 | |||
28 | private bool|string $attachedToFakeField = false; |
||
29 | |||
30 | /** |
||
31 | * Cloud disks have the ability to generate temporary URLs to files, should we do it? |
||
32 | */ |
||
33 | private bool $useTemporaryUrl = false; |
||
34 | |||
35 | /** |
||
36 | * When using temporary urls, define the time that the url will be valid. |
||
37 | */ |
||
38 | private int $temporaryUrlExpirationTimeInMinutes = 1; |
||
39 | |||
40 | /** |
||
41 | * Indicates if the upload is relative to a relationship field/column. |
||
42 | */ |
||
43 | private bool $isRelationship = false; |
||
44 | |||
45 | /** |
||
46 | * When previous files are updated, we need to keep track of them so that we don't add deleted files to the new list. |
||
47 | */ |
||
48 | private $updatedPreviousFiles = null; |
||
49 | |||
50 | public function __construct(array $crudObject, array $configuration) |
||
51 | { |
||
52 | $this->name = $crudObject['name']; |
||
53 | $this->disk = $configuration['disk'] ?? $crudObject['disk'] ?? $this->disk; |
||
54 | $this->path = $this->getPathFromConfiguration($crudObject, $configuration); |
||
55 | $this->attachedToFakeField = isset($crudObject['fake']) && $crudObject['fake'] ? ($crudObject['store_in'] ?? 'extras') : ($crudObject['store_in'] ?? false); |
||
56 | $this->useTemporaryUrl = $configuration['temporaryUrl'] ?? $this->useTemporaryUrl; |
||
57 | $this->temporaryUrlExpirationTimeInMinutes = $configuration['temporaryUrlExpirationTime'] ?? $this->temporaryUrlExpirationTimeInMinutes; |
||
58 | $this->deleteWhenEntryIsDeleted = $configuration['deleteWhenEntryIsDeleted'] ?? $this->deleteWhenEntryIsDeleted; |
||
59 | $this->fileNamer = is_callable($configuration['fileNamer'] ?? null) ? $configuration['fileNamer'] : $this->getFileNameGeneratorInstance($configuration['fileNamer'] ?? null); |
||
60 | } |
||
61 | |||
62 | /******************************* |
||
63 | * Static methods |
||
64 | *******************************/ |
||
65 | public static function for(array $crudObject, array $definition): UploaderInterface |
||
66 | { |
||
67 | return new static($crudObject, $definition); |
||
68 | } |
||
69 | |||
70 | /******************************* |
||
71 | * public methods - event handler methods |
||
72 | *******************************/ |
||
73 | public function storeUploadedFiles(Model $entry): Model |
||
74 | { |
||
75 | if ($this->handleRepeatableFiles) { |
||
76 | return $this->handleRepeatableFiles($entry); |
||
77 | } |
||
78 | |||
79 | if ($this->attachedToFakeField) { |
||
80 | $fakeFieldValue = $entry->{$this->attachedToFakeField}; |
||
81 | $fakeFieldValue = is_string($fakeFieldValue) ? json_decode($fakeFieldValue, true) : (array) $fakeFieldValue; |
||
82 | $fakeFieldValue[$this->getAttributeName()] = $this->uploadFiles($entry); |
||
83 | |||
84 | $entry->{$this->attachedToFakeField} = isset($entry->getCasts()[$this->attachedToFakeField]) ? $fakeFieldValue : json_encode($fakeFieldValue); |
||
85 | |||
86 | return $entry; |
||
87 | } |
||
88 | |||
89 | $entry->{$this->getAttributeName()} = $this->uploadFiles($entry); |
||
90 | |||
91 | return $entry; |
||
92 | } |
||
93 | |||
94 | public function retrieveUploadedFiles(Model $entry): Model |
||
95 | { |
||
96 | if ($this->handleRepeatableFiles) { |
||
97 | return $this->retrieveRepeatableFiles($entry); |
||
98 | } |
||
99 | |||
100 | return $this->retrieveFiles($entry); |
||
101 | } |
||
102 | |||
103 | public function deleteUploadedFiles(Model $entry): void |
||
104 | { |
||
105 | if ($this->deleteWhenEntryIsDeleted) { |
||
106 | if (! in_array(SoftDeletes::class, class_uses_recursive($entry), true)) { |
||
107 | $this->performFileDeletion($entry); |
||
108 | |||
109 | return; |
||
110 | } |
||
111 | |||
112 | if ($entry->isForceDeleting() === true) { |
||
113 | $this->performFileDeletion($entry); |
||
114 | } |
||
115 | } |
||
116 | } |
||
117 | |||
118 | /******************************* |
||
119 | * Getters |
||
120 | *******************************/ |
||
121 | public function getName(): string |
||
122 | { |
||
123 | return $this->name; |
||
124 | } |
||
125 | |||
126 | public function getAttributeName(): string |
||
129 | } |
||
130 | |||
131 | public function getDisk(): string |
||
132 | { |
||
133 | return $this->disk; |
||
134 | } |
||
135 | |||
136 | public function getPath(): string |
||
137 | { |
||
138 | return $this->path; |
||
139 | } |
||
140 | |||
141 | public function useTemporaryUrl(): bool |
||
142 | { |
||
143 | return $this->useTemporaryUrl; |
||
144 | } |
||
145 | |||
146 | public function getExpirationTimeInMinutes(): int |
||
149 | } |
||
150 | |||
151 | public function shouldDeleteFiles(): bool |
||
152 | { |
||
153 | return $this->deleteWhenEntryIsDeleted; |
||
154 | } |
||
155 | |||
156 | public function getIdentifier(): string |
||
157 | { |
||
158 | if ($this->handleRepeatableFiles) { |
||
159 | return $this->repeatableContainerName.'_'.$this->name; |
||
160 | } |
||
161 | |||
162 | return $this->name; |
||
163 | } |
||
164 | |||
165 | public function getNameForRequest(): string |
||
166 | { |
||
167 | return $this->repeatableContainerName ?? $this->name; |
||
168 | } |
||
169 | |||
170 | public function canHandleMultipleFiles(): bool |
||
171 | { |
||
172 | return $this->handleMultipleFiles; |
||
173 | } |
||
174 | |||
175 | public function isRelationship(): bool |
||
176 | { |
||
177 | return $this->isRelationship; |
||
178 | } |
||
179 | |||
180 | public function getPreviousFiles(Model $entry): mixed |
||
190 | } |
||
191 | |||
192 | public function getValueWithoutPath(?string $value = null): ?string |
||
193 | { |
||
194 | return $value ? Str::after($value, $this->path) : null; |
||
195 | } |
||
196 | |||
197 | /******************************* |
||
198 | * Setters - fluently configure the uploader |
||
199 | *******************************/ |
||
200 | public function multiple(): self |
||
201 | { |
||
202 | $this->handleMultipleFiles = true; |
||
203 | |||
204 | return $this; |
||
205 | } |
||
206 | |||
207 | public function relationship(bool $isRelationship): self |
||
208 | { |
||
209 | $this->isRelationship = $isRelationship; |
||
210 | |||
211 | return $this; |
||
212 | } |
||
213 | |||
214 | /******************************* |
||
215 | * Default implementation functions |
||
216 | *******************************/ |
||
217 | public function uploadFiles(Model $entry, $values = null) |
||
219 | } |
||
220 | |||
221 | private function retrieveFiles(Model $entry): Model |
||
222 | { |
||
223 | $value = $entry->{$this->getAttributeName()}; |
||
224 | |||
246 | } |
||
247 | |||
248 | private function deleteFiles(Model $entry) |
||
249 | { |
||
250 | $values = $entry->{$this->getAttributeName()}; |
||
251 | |||
252 | if(! $this->shouldDeleteFiles() || $values === null) |
||
253 | { |
||
254 | return; |
||
255 | } |
||
256 | |||
257 | if ($this->handleMultipleFiles) { |
||
258 | // ensure we have an array of values when field is not casted in model. |
||
259 | if (! isset($entry->getCasts()[$this->name]) && is_string($values)) { |
||
260 | $values = json_decode($values, true); |
||
261 | } |
||
262 | foreach ($values ?? [] as $value) { |
||
263 | $value = Str::start($value, $this->path); |
||
264 | Storage::disk($this->disk)->delete($value); |
||
265 | } |
||
266 | |||
267 | return; |
||
268 | } |
||
269 | |||
270 | $values = Str::start($values, $this->path); |
||
271 | Storage::disk($this->disk)->delete($values); |
||
272 | } |
||
273 | |||
274 | private function performFileDeletion(Model $entry) |
||
283 | } |
||
284 | |||
285 | /******************************* |
||
286 | * helper methods |
||
287 | *******************************/ |
||
288 | private function getPathFromConfiguration(array $crudObject, array $configuration): string |
||
293 | } |
||
294 | |||
295 | private function getOriginalValue(Model $entry, $field = null) |
||
320 |