Backpack\CRUD\app\Library\Validation\Rules\ValidUpload

Complexity

Total Complexity

15

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	validate()	0	17	6
A	field()	0	3	1
A	createValidator()	0	9	3
A	validateUploadInSubfield()	0	16	5

<?php

namespace Backpack\CRUD\app\Library\Validation\Rules;

use Backpack\CRUD\app\Library\CrudPanel\CrudPanelFacade;
use Backpack\CRUD\app\Library\Uploaders\Uploader;
use Backpack\CRUD\app\Library\Validation\Rules\Support\HasFiles;
use Closure;
use Illuminate\Contracts\Validation\Rule;
use Illuminate\Contracts\Validation\ValidationRule;
use Illuminate\Support\Facades\Validator;
use Illuminate\Support\Str;

class ValidUpload extends BackpackCustomRule
{
    use HasFiles;

    /**
     * Run the validation rule.
     *
     * @param  string  $attribute
     * @param  mixed  $value
     * @param  Closure(string): \Illuminate\Translation\PotentiallyTranslatedString  $fail
     * @return void
     */
    public function validate(string $attribute, mixed $value, Closure $fail): void
    {
        $entry = CrudPanelFacade::getCurrentEntry();

The method getCurrentEntry() does not exist on Backpack\CRUD\app\Library\CrudPanel\CrudPanelFacade. Since you implemented __callStatic, consider adding a @method annotation.

        if(Str::contains($attribute, '.')) {
            $this->validateUploadInSubfield($attribute, $value, $fail, $entry);
            return;
        }
       
        if (! array_key_exists($attribute, $this->data) && $entry) {
            return;
        }

        $this->createValidator($attribute, $this->getFieldRules(), $value, $fail);

        if (! empty($value) && ! empty($this->getFileRules())) {
            $this->createValidator($attribute, $this->getFileRules(), $value, $fail);
        }
    }

    public static function field(string|array|ValidationRule|Rule $rules = []): self
    {
        return parent::field($rules);

The expression return parent::field($rules) returns the type Backpack\CRUD\app\Library\Validation\Rules\BackpackCustomRule which includes types incompatible with the type-hinted return Backpack\CRUD\app\Library\Validation\Rules\ValidUpload.

    }

    protected function validateUploadInSubfield($attribute, $value, Closure $fail, $entry = null)
    {
        $mainField = Str::before($attribute, '.');
        $subfield = Str::afterLast($attribute, '.');
        $row = (int)Str::before(Str::after($attribute, '.'), '.');

        $values[$mainField] = Uploader::mergeFilesAndValuesRecursive($this->data[$mainField], $this->data['_order_'.$mainField] ?? []);

$values was never initialized. Although not strictly required by PHP, it is generally a good practice to add $values = array(); before regardless.

        if (! array_key_exists($subfield, $values[$mainField][$row]) && $entry) {
            return;
        }

        $this->createValidator($subfield, $this->getFieldRules(), $values[$mainField][$row][$subfield] ?? null, $fail);
        
        if(!empty($value) && !empty($this->getFileRules())) {
            $this->createValidator($subfield, $this->getFileRules(), $values[$mainField][$row][$subfield] ?? null, $fail);
        }
    }

    protected function createValidator(string $attribute, array $rules, mixed $value, Closure $fail): void
    {
        $validator = Validator::make([$attribute => $value], [
            $attribute => $rules,
        ], $this->validator->customMessages, $this->validator->customAttributes);

Accessing customAttributes on the interface Illuminate\Contracts\Validation\Validator suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing customMessages on the interface Illuminate\Contracts\Validation\Validator suggest that you code against a concrete implementation. How about adding an instanceof check?

        if ($validator->fails()) {
            foreach ($validator->errors()->messages()[$attribute] as $message) {
                $fail($message)->translate();
            }
        }
    }
}