Backpack\CRUD\PanelTraits\Tabs

Complexity

Total Complexity

20

Size/Duplication

Total Lines	126
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	1

Test Coverage

Coverage

85.71%

Importance

Changes

0

15 Methods

Rating	Name	Duplication	Size	Complexity
A	enableTabs()	0	7	1
A	disableTabs()	0	6	1
A	tabsEnabled()	0	4	1
A	tabsDisabled()	0	4	1
A	setTabsType()	0	6	1
A	getTabsType()	0	4	1
A	enableVerticalTabs()	0	4	1
A	disableVerticalTabs()	0	4	1
A	enableHorizontalTabs()	0	4	1
A	disableHorizontalTabs()	0	4	1
A	tabExists()	0	6	1
A	getLastTab()	0	10	2
A	isLastTab()	0	4	1
A	getTabs()	0	17	2
B	getTabFields()	0	22	4

<?php

namespace Backpack\CRUD\PanelTraits;

trait Tabs
{
    public $tabsEnabled = false;
    public $tabsType = 'horizontal';

    public function enableTabs()
    {
        $this->tabsEnabled = true;
        $this->setTabsType(config('backpack.crud.tabs_type', 'horizontal'));

        return $this->tabsEnabled;
    }

    public function disableTabs()
    {
        $this->tabsEnabled = false;

        return $this->tabsEnabled;
    }

    public function tabsEnabled()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->tabsEnabled;
    }

    public function tabsDisabled()
    {
        return ! $this->tabsEnabled;
    }

    public function setTabsType($type)

The return type could not be reliably inferred; please add a @return annotation.

    {
        $this->tabsType = $type;

        return $this->tabsType;
    }

    public function getTabsType()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->tabsType;
    }

    public function enableVerticalTabs()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->setTabsType('vertical');
    }

    public function disableVerticalTabs()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->setTabsType('horizontal');
    }

    public function enableHorizontalTabs()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->setTabsType('horizontal');
    }

    public function disableHorizontalTabs()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->setTabsType('vertical');
    }

    public function tabExists($label)
    {
        $tabs = $this->getTabs();

        return in_array($label, $tabs);
    }

    public function getLastTab()
    {
        $tabs = $this->getTabs();

        if (count($tabs)) {
            return last($tabs);
        }

        return false;
    }

    public function isLastTab($label)
    {
        return $this->getLastTab() == $label;
    }

    public function getTabFields($label)
    {
        if ($this->tabExists($label)) {
            $all_fields = $this->getCurrentFields();

It seems like getCurrentFields() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $fields_for_current_tab = collect($all_fields)->filter(function ($value, $key) use ($label) {

The parameter $key is not used and could be removed.

                return isset($value['tab']) && $value['tab'] == $label;
            });

            if ($this->isLastTab($label)) {
                $fields_without_a_tab = collect($all_fields)->filter(function ($value, $key) {

The parameter $key is not used and could be removed.

                    return ! isset($value['tab']);
                });

                $fields_for_current_tab = $fields_for_current_tab->merge($fields_without_a_tab);
            }

            return $fields_for_current_tab;
        }

        return [];
    }

    public function getTabs()
    {
        $tabs = [];
        $fields = $this->getCurrentFields();

It seems like getCurrentFields() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $fields_with_tabs = collect($fields)

$fields_with_tabs is not used, you could remove the assignment.

            ->filter(function ($value, $key) {

The parameter $key is not used and could be removed.

                return isset($value['tab']);
            })
            ->each(function ($value, $key) use (&$tabs) {

The parameter $key is not used and could be removed.

                if (! in_array($value['tab'], $tabs)) {
                    $tabs[] = $value['tab'];
                }
            });

        return $tabs;
    }
}