Laravel-Backpack / CRUD

tests/Unit/CrudPanel/CrudPanelMacroTest.php

Spacing +2 added lines, -2 removed lines

@@ -9,7 +9,7 @@ 
 {
     public function testItCanRegisterMacro()
     {
-        $this->crudPanel::macro('validMacro', function () {
+        $this->crudPanel::macro('validMacro', function() {
             return true;
         });
 
@@ -19,7 +19,7 @@ 
     public function testThrowsErrorIfMacroExists()
     {
         try {
-            $this->crudPanel::macro('setModel', function () {
+            $this->crudPanel::macro('setModel', function() {
                 return true;
             });
         } catch (\Throwable $e) {

tests/Unit/CrudPanel/CrudPanelCreateTest.php

Spacing +2 added lines, -2 removed lines

@@ -605,7 +605,7 @@ 
 
     public function testCreateBelongsToFake()
     {
-        $belongsToField = [   // select_grouped
+        $belongsToField = [// select_grouped
             'label'                      => 'Select_grouped',
             'type'                       => 'select_grouped', //https://github.com/Laravel-Backpack/CRUD/issues/502
             'name'                       => 'bang_relation_field',
@@ -741,7 +741,7 @@ 
                 'nickname'        => 'i_have_has_one',
                 'profile_picture' => 'ohh my picture 1.jpg',
                 'article'         => 1,
-                'addresses'       => [ // HasOne is tested in other test function
+                'addresses'       => [// HasOne is tested in other test function
                     [
                         'city'   => 2,
                         'street' => 'test',

src/app/Library/CrudPanel/Traits/Validation.php

Spacing +11 added lines, -11 removed lines

@@ -46,10 +46,10 @@ 
     private function getValidationRulesFromFieldsAndSubfields($fields)
     {
         $rules = collect($fields)
-            ->filter(function ($value, $key) {
+            ->filter(function($value, $key) {
                 // only keep fields where 'validationRules' OR there are subfields
                 return array_key_exists('validationRules', $value) || array_key_exists('subfields', $value);
-            })->map(function ($item, $key) {
+            })->map(function($item, $key) {
                 $validationRules = [];
                 // only keep the rules, not the entire field definition
                 if (isset($item['validationRules'])) {
@@ -57,7 +57,7 @@ 
                 }
                 // add validation rules for subfields
                 if (array_key_exists('subfields', $item)) {
-                    $subfieldsWithValidation = array_filter($item['subfields'], function ($subfield) {
+                    $subfieldsWithValidation = array_filter($item['subfields'], function($subfield) {
                         return array_key_exists('validationRules', $subfield);
                     });
 
@@ -82,10 +82,10 @@ 
     {
         $messages = [];
         collect($fields)
-            ->filter(function ($value, $key) {
+            ->filter(function($value, $key) {
                 // only keep fields where 'validationMessages' OR there are subfields
                 return array_key_exists('validationMessages', $value) || array_key_exists('subfields', $value);
-            })->each(function ($item, $key) use (&$messages) {
+            })->each(function($item, $key) use (&$messages) {
                 if (isset($item['validationMessages'])) {
                     foreach ($item['validationMessages'] as $rule => $message) {
                         $messages[$key.'.'.$rule] = $message;
@@ -93,7 +93,7 @@ 
                 }
                 // add messages from subfields
                 if (array_key_exists('subfields', $item)) {
-                    $subfieldsWithValidationMessages = array_filter($item['subfields'], function ($subfield) {
+                    $subfieldsWithValidationMessages = array_filter($item['subfields'], function($subfield) {
                         return array_key_exists('validationRules', $subfield);
                     });
 
@@ -129,7 +129,7 @@ 
      */
     public function setValidation($classOrRulesArray = false, $messages = [])
     {
-        if (! $classOrRulesArray) {
+        if (!$classOrRulesArray) {
             $this->setValidationFromFields();
         } elseif (is_array($classOrRulesArray)) {
             $this->setValidationFromArray($classOrRulesArray, $messages);
@@ -210,7 +210,7 @@ 
             return $this->checkRequestValidity($extendedRules, $extendedMessages, $formRequest);
         }
 
-        return ! empty($rules) ? $this->checkRequestValidity($rules, $messages) : $this->getRequest();
+        return !empty($rules) ? $this->checkRequestValidity($rules, $messages) : $this->getRequest();
     }
 
     /**
@@ -225,7 +225,7 @@ 
     {
         $extendedRules = [];
         $requestRules = $this->getRequestRulesAsArray($request);
-        $rules = array_map(function ($ruleDefinition) {
+        $rules = array_map(function($ruleDefinition) {
             return is_array($ruleDefinition) ? $ruleDefinition : explode('|', $ruleDefinition);
         }, $rules);
 
@@ -322,7 +322,7 @@ 
      */
     public function isRequired($inputKey)
     {
-        if (! $this->hasOperationSetting('requiredFields')) {
+        if (!$this->hasOperationSetting('requiredFields')) {
             return false;
         }
 
@@ -343,7 +343,7 @@ 
     {
         [$rules, $messages] = $this->getValidationRulesAndMessagesFromField($field, $parent);
 
-        if (! empty($rules)) {
+        if (!empty($rules)) {
             $this->setValidation($rules, $messages);
         }
     }

src/app/Console/Commands/PublishAssets.php

Spacing +2 added lines, -2 removed lines

@@ -41,12 +41,12 @@
     private function runConsoleCommand($command)
     {
         $process = new Process($command, null, null, null, 60, null);
-        $process->run(function ($type, $buffer) {
+        $process->run(function($type, $buffer) {
             $this->line($buffer);
         });
 
         // executes after the command finishes
-        if (! $process->isSuccessful()) {
+        if (!$process->isSuccessful()) {
             throw new ProcessFailedException($process);
         }
     }

src/helpers.php

Spacing +20 added lines, -20 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-if (! function_exists('backpack_url')) {
+if (!function_exists('backpack_url')) {
     /**
      * Appends the configured backpack prefix and returns
      * the URL using the standard Laravel helpers.
@@ -10,13 +10,13 @@ 
      */
     function backpack_url($path = null, $parameters = [], $secure = null)
     {
-        $path = ! $path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
+        $path = !$path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
 
         return url(config('backpack.base.route_prefix', 'admin').$path, $parameters, $secure);
     }
 }
 
-if (! function_exists('backpack_authentication_column')) {
+if (!function_exists('backpack_authentication_column')) {
     /**
      * Return the username column name.
      * The Laravel default (and Backpack default) is 'email'.
@@ -29,7 +29,7 @@ 
     }
 }
 
-if (! function_exists('backpack_email_column')) {
+if (!function_exists('backpack_email_column')) {
     /**
      * Return the email column name.
      * The Laravel default (and Backpack default) is 'email'.
@@ -42,7 +42,7 @@ 
     }
 }
 
-if (! function_exists('backpack_form_input')) {
+if (!function_exists('backpack_form_input')) {
     /**
      * Parse the submitted input in request('form') to an usable array.
      * Joins the multiple[] fields in a single key and transform the dot notation fields into arrayed ones.
@@ -99,7 +99,7 @@ 
     }
 }
 
-if (! function_exists('backpack_users_have_email')) {
+if (!function_exists('backpack_users_have_email')) {
     /**
      * Check if the email column is present on the user table.
      *
@@ -114,7 +114,7 @@ 
     }
 }
 
-if (! function_exists('backpack_avatar_url')) {
+if (!function_exists('backpack_avatar_url')) {
     /**
      * Returns the avatar URL of a user.
      *
@@ -125,7 +125,7 @@ 
     {
         switch (config('backpack.base.avatar_type')) {
             case 'gravatar':
-                if (backpack_users_have_email() && ! empty($user->email)) {
+                if (backpack_users_have_email() && !empty($user->email)) {
                     return Gravatar::fallback(config('backpack.base.gravatar_fallback'))->get($user->email);
                 }
                 break;
@@ -136,7 +136,7 @@ 
     }
 }
 
-if (! function_exists('backpack_middleware')) {
+if (!function_exists('backpack_middleware')) {
     /**
      * Return the key of the middleware used across Backpack.
      * That middleware checks if the visitor is an admin.
@@ -150,7 +150,7 @@ 
     }
 }
 
-if (! function_exists('backpack_guard_name')) {
+if (!function_exists('backpack_guard_name')) {
     /*
      * Returns the name of the guard defined
      * by the application config
@@ -161,7 +161,7 @@ 
     }
 }
 
-if (! function_exists('backpack_auth')) {
+if (!function_exists('backpack_auth')) {
     /*
      * Returns the user instance if it exists
      * of the currently authenticated admin
@@ -173,7 +173,7 @@ 
     }
 }
 
-if (! function_exists('backpack_user')) {
+if (!function_exists('backpack_user')) {
     /*
      * Returns back a user instance without
      * the admin guard, however allows you
@@ -185,7 +185,7 @@ 
     }
 }
 
-if (! function_exists('mb_ucfirst')) {
+if (!function_exists('mb_ucfirst')) {
     /**
      * Capitalize the first letter of a string,
      * even if that string is multi-byte (non-latin alphabet).
@@ -206,7 +206,7 @@ 
     }
 }
 
-if (! function_exists('backpack_view')) {
+if (!function_exists('backpack_view')) {
     /**
      * Returns a new displayable view based on the configured backpack view namespace.
      * If that view doesn't exist, it will load the one from the original theme.
@@ -225,7 +225,7 @@ 
 
         $returnView = $theme.$view;
 
-        if (! view()->exists($returnView)) {
+        if (!view()->exists($returnView)) {
             $returnView = $originalTheme.$view;
         }
 
@@ -233,7 +233,7 @@ 
     }
 }
 
-if (! function_exists('square_brackets_to_dots')) {
+if (!function_exists('square_brackets_to_dots')) {
     /**
      * Turns a string from bracket-type array to dot-notation array.
      * Ex: array[0][property] turns into array.0.property.
@@ -249,7 +249,7 @@ 
     }
 }
 
-if (! function_exists('old_empty_or_null')) {
+if (!function_exists('old_empty_or_null')) {
     /**
      * This method is an alternative to Laravel's old() helper, which mistakenly
      * returns NULL it two cases:
@@ -281,7 +281,7 @@ 
     }
 }
 
-if (! function_exists('is_multidimensional_array')) {
+if (!function_exists('is_multidimensional_array')) {
     /**
      * If any of the items inside a given array is an array, the array is considered multidimensional.
      *
@@ -300,7 +300,7 @@ 
     }
 }
 
-if (! function_exists('backpack_pro')) {
+if (!function_exists('backpack_pro')) {
     /**
      * Check if the backpack/pro package is installed.
      *
@@ -311,7 +311,7 @@ 
         if (app()->runningUnitTests()) {
             return true;
         }
-        if (! \Composer\InstalledVersions::isInstalled('backpack/pro')) {
+        if (!\Composer\InstalledVersions::isInstalled('backpack/pro')) {
             return false;
         }
 

tests/Unit/CrudPanel/CrudPanelOperationsTest.php

Spacing +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
 
     public function testItCanConfigureOperations()
     {
-        $this->crudPanel->operation(['create', 'update'], function () {
+        $this->crudPanel->operation(['create', 'update'], function() {
             $this->crudPanel->addField(['name' => 'test', 'type' => 'text']);
         });
         $this->crudPanel->applyConfigurationFromSettings('create');

src/app/Library/CrudPanel/Traits/SaveActions.php

Spacing +16 added lines, -17 removed lines

@@ -28,7 +28,7 @@ 
         $higherAction = $this->getSaveActionByOrder(1);
 
         //if there is an higher action and that action is not the backpack default higher one `save_and_back` we return it.
-        if (! empty($higherAction) && key($higherAction) !== 'save_and_back') {
+        if (!empty($higherAction) && key($higherAction) !== 'save_and_back') {
             return key($higherAction);
         }
 
@@ -47,7 +47,7 @@ 
      */
     public function getSaveActionByOrder($order)
     {
-        return array_filter($this->getOperationSetting('save_actions') ?? [], function ($arr) use ($order) {
+        return array_filter($this->getOperationSetting('save_actions') ?? [], function($arr) use ($order) {
             return $arr['order'] == $order;
         });
     }
@@ -81,7 +81,7 @@ 
         $orderCounter = $this->getOperationSetting('save_actions') !== null ? (count($this->getOperationSetting('save_actions')) + 1) : 1;
         //check for some mandatory fields
         $saveAction['name'] ?? abort(500, 'Please define save action name.');
-        $saveAction['redirect'] = $saveAction['redirect'] ?? function ($crud, $request, $itemId) {
+        $saveAction['redirect'] = $saveAction['redirect'] ?? function($crud, $request, $itemId) {
             return $request->has('_http_referrer') ? $request->get('_http_referrer') : $crud->route;
         };
         $saveAction['visible'] = $saveAction['visible'] ?? true;
@@ -90,7 +90,7 @@ 
 
         $actions = $this->getOperationSetting('save_actions') ?? [];
 
-        if (! in_array($saveAction['name'], $actions)) {
+        if (!in_array($saveAction['name'], $actions)) {
             $actions[$saveAction['name']] = $saveAction;
         }
 
@@ -107,7 +107,7 @@ 
     public function orderSaveAction(string $saveAction, int $wantedOrder)
     {
         $actions = $this->getOperationSetting('save_actions') ?? [];
-        if (! empty($actions)) {
+        if (!empty($actions)) {
             $replaceOrder = isset($actions[$saveAction]) ? $actions[$saveAction]['order'] : count($actions) + 1;
 
             foreach ($actions as $key => $sv) {
@@ -201,7 +201,7 @@ 
     public function orderSaveActions(array $saveActions)
     {
         foreach ($saveActions as $sv => $order) {
-            if (! is_int($order)) {
+            if (!is_int($order)) {
                 $this->orderSaveAction($order, $sv + 1);
             } else {
                 $this->orderSaveAction($sv, $order);
@@ -218,7 +218,7 @@ 
     {
         $actions = $this->getOperationSetting('save_actions') ?? [];
 
-        uasort($actions, function ($a, $b) {
+        uasort($actions, function($a, $b) {
             return $a['order'] <=> $b['order'];
         });
 
@@ -240,7 +240,7 @@ 
             }
         }
 
-        return array_filter($actions, function ($action) {
+        return array_filter($actions, function($action) {
             return $action['visible'] == true;
         }, ARRAY_FILTER_USE_BOTH);
     }
@@ -303,8 +303,7 @@ 
      */
     public function setSaveAction($forceSaveAction = null)
     {
-        $saveAction = $forceSaveAction ?:
-            \Request::input('_save_action', $this->getFallBackSaveAction());
+        $saveAction = $forceSaveAction ?: \Request::input('_save_action', $this->getFallBackSaveAction());
 
         $showBubble = $this->getOperationSetting('showSaveActionChange') ?? config('backpack.crud.operations.'.$this->getCurrentOperation().'.showSaveActionChange') ?? true;
 
@@ -371,20 +370,20 @@ 
         $defaultSaveActions = [
             [
                 'name' => 'save_and_back',
-                'visible' => function ($crud) {
+                'visible' => function($crud) {
                     return $crud->hasAccess('list');
                 },
-                'redirect' => function ($crud, $request, $itemId = null) {
+                'redirect' => function($crud, $request, $itemId = null) {
                     return $request->request->has('_http_referrer') ? $request->request->get('_http_referrer') : $crud->route;
                 },
                 'button_text' => trans('backpack::crud.save_action_save_and_back'),
             ],
             [
                 'name' => 'save_and_edit',
-                'visible' => function ($crud) {
+                'visible' => function($crud) {
                     return $crud->hasAccess('update');
                 },
-                'redirect' => function ($crud, $request, $itemId = null) {
+                'redirect' => function($crud, $request, $itemId = null) {
                     $itemId = $itemId ?: $request->request->get('id');
                     $redirectUrl = $crud->route.'/'.$itemId.'/edit';
                     if ($request->request->has('_locale')) {
@@ -396,17 +395,17 @@ 
 
                     return $redirectUrl;
                 },
-                'referrer_url' => function ($crud, $request, $itemId) {
+                'referrer_url' => function($crud, $request, $itemId) {
                     return url($crud->route.'/'.$itemId.'/edit');
                 },
                 'button_text' => trans('backpack::crud.save_action_save_and_edit'),
             ],
             [
                 'name' => 'save_and_new',
-                'visible' => function ($crud) {
+                'visible' => function($crud) {
                     return $crud->hasAccess('create');
                 },
-                'redirect' => function ($crud, $request, $itemId = null) {
+                'redirect' => function($crud, $request, $itemId = null) {
                     return $this->route.'/create';
                 },
                 'button_text' => trans('backpack::crud.save_action_save_and_new'),

tests/Unit/CrudPanel/CrudPanelFieldsTest.php

Spacing +3 added lines, -3 removed lines

@@ -609,7 +609,7 @@ 
     {
         $this->crudPanel->setOperationSetting(
             'strippedRequest',
-            static function (Request $request) {
+            static function(Request $request) {
                 return $request->toArray();
             },
             'update'
@@ -743,7 +743,7 @@ 
                         ->validationMessages(['required' => 'is_required', 'min' => 'min_2'])
                         ->store_in('some')
                         ->size(6)
-                        ->on('created', function () {
+                        ->on('created', function() {
                         })
                         ->subfields([['name' => 'sub_1']])
                         ->entity('bang');
@@ -775,7 +775,7 @@ 
                 'class' => 'form-group col-md-6',
             ],
             'events' => [
-                'created' => function () {
+                'created' => function() {
                 },
             ],
             'subfields' => [

tests/Unit/CrudPanel/CrudPanelFiltersTest.php

Spacing +8 added lines, -8 removed lines

@@ -48,7 +48,7 @@ 
     {
         $this->crudPanel->setModel(User::class);
         $request = request()->create('/admin/users', 'GET', ['my_custom_filter' => 'foo']);
-        $request->setRouteResolver(function () use ($request) {
+        $request->setRouteResolver(function() use ($request) {
             return (new Route('GET', 'admin/users', ['UserCrudController', 'index']))->bind($request);
         });
         $this->crudPanel->setRequest($request);
@@ -64,10 +64,10 @@ 
                     ->options(['test' => 'test'])
                     ->view('simple')
                     ->viewNamespace('crud::filters')
-                    ->ifActive(function () {
+                    ->ifActive(function() {
                         return true;
                     })
-                    ->ifInactive(function () {
+                    ->ifInactive(function() {
                         return true;
                     });
 
@@ -84,10 +84,10 @@ 
     public function testWhenActiveAndWhenInactiveAliases()
     {
         $filter = CrudFilter::name('my_filter')
-                        ->whenActive(function () {
+                        ->whenActive(function() {
                             return true;
                         })
-                        ->whenInactive(function () {
+                        ->whenInactive(function() {
                             return true;
                         });
 
@@ -98,7 +98,7 @@ 
 
     public function testWhenNotActiveAlias()
     {
-        $filter = CrudFilter::name('my_filter')->whenNotActive(function () {
+        $filter = CrudFilter::name('my_filter')->whenNotActive(function() {
             return true;
         });
         $this->assertCount(1, $this->crudPanel->filters());
@@ -107,7 +107,7 @@ 
 
     public function testIfNotActiveAlias()
     {
-        $filter = CrudFilter::name('my_filter')->ifNotActive(function () {
+        $filter = CrudFilter::name('my_filter')->ifNotActive(function() {
             return true;
         });
         $this->assertCount(1, $this->crudPanel->filters());
@@ -116,7 +116,7 @@ 
 
     public function testElseAlias()
     {
-        $filter = CrudFilter::name('my_filter')->else(function () {
+        $filter = CrudFilter::name('my_filter')->else(function() {
             return true;
         });
         $this->assertCount(1, $this->crudPanel->filters());