Laravel-Backpack / CRUD

src/PanelTraits/Fields.php

Doc Comments -7 removed lines

@@ -22,7 +22,6 @@ 
      * Add a field to the create/update form or both.
      *
      * @param string|array $field The new field.
-     * @param string       $form  The CRUD form. Can be 'create', 'update' or 'both'. Default is 'both'.
      *
      * @return self
      */
@@ -70,7 +69,6 @@ 
      * Add multiple fields to the create/update form or both.
      *
      * @param array  $fields The new fields.
-     * @param string $form   The CRUD form. Can be 'create', 'update' or 'both'. Default is 'both'.
      */
     public function addFields($fields)
     {
@@ -85,7 +83,6 @@ 
      * Move the most recently added field after the given target field.
      *
      * @param string $targetFieldName The target field name.
-     * @param string $form            The CRUD form. Can be 'create', 'update' or 'both'. Default is 'both'.
      */
     public function afterField($targetFieldName)
     {
@@ -98,7 +95,6 @@ 
      * Move the most recently added field before the given target field.
      *
      * @param string $targetFieldName The target field name.
-     * @param string $form            The CRUD form. Can be 'create', 'update' or 'both'. Default is 'both'.
      */
     public function beforeField($targetFieldName)
     {
@@ -141,7 +137,6 @@ 
      * Remove a certain field from the create/update/both forms by its name.
      *
      * @param string $name Field name (as defined with the addField() procedure)
-     * @param string $form update/create/both
      */
     public function removeField($name)
     {
@@ -330,8 +325,6 @@ 
      * Check if the create/update form has upload fields.
      * Upload fields are the ones that have "upload" => true defined on them.
      *
-     * @param  string   $form create/update/both - defaults to 'both'
-     * @param  bool|int $id   id of the entity - defaults to false
      *
      * @return bool
      */

Spacing +12 added lines, -12 removed lines

@@ -38,23 +38,23 @@ 
 
         // if this is a relation type field and no corresponding model was specified, get it from the relation method
         // defined in the main model
-        if (isset($newField['entity']) && ! isset($newField['model'])) {
+        if (isset($newField['entity']) && !isset($newField['model'])) {
             $newField['model'] = $this->getRelationModel($newField['entity']);
         }
 
         // if the label is missing, we should set it
-        if (! isset($newField['label'])) {
+        if (!isset($newField['label'])) {
             $newField['label'] = mb_ucfirst(str_replace('_', ' ', $newField['name']));
         }
 
         // if the field type is missing, we should set it
-        if (! isset($newField['type'])) {
+        if (!isset($newField['type'])) {
             $newField['type'] = $this->getFieldTypeFromDbColumnType($newField['name']);
         }
 
         // if a tab was mentioned, we should enable it
         if (isset($newField['tab'])) {
-            if (! $this->tabsEnabled()) {
+            if (!$this->tabsEnabled()) {
                 $this->enableTabs();
             }
         }
@@ -89,7 +89,7 @@ 
      */
     public function afterField($targetFieldName)
     {
-        $this->transformFields(function ($fields) use ($targetFieldName) {
+        $this->transformFields(function($fields) use ($targetFieldName) {
             return $this->moveField($fields, $targetFieldName, false);
         });
     }
@@ -102,7 +102,7 @@ 
      */
     public function beforeField($targetFieldName)
     {
-        $this->transformFields(function ($fields) use ($targetFieldName) {
+        $this->transformFields(function($fields) use ($targetFieldName) {
             return $this->moveField($fields, $targetFieldName, true);
         });
     }
@@ -145,7 +145,7 @@ 
      */
     public function removeField($name)
     {
-        $this->transformFields(function ($fields) use ($name) {
+        $this->transformFields(function($fields) use ($name) {
             array_forget($fields, $name);
 
             return $fields;
@@ -159,7 +159,7 @@ 
      */
     public function removeFields($array_of_names)
     {
-        if (! empty($array_of_names)) {
+        if (!empty($array_of_names)) {
             foreach ($array_of_names as $name) {
                 $this->removeField($name);
             }
@@ -172,7 +172,7 @@ 
     public function removeAllFields()
     {
         $current_fields = $this->getCurrentFields();
-        if (! empty($current_fields)) {
+        if (!empty($current_fields)) {
             foreach ($current_fields as $field) {
                 $this->removeField($field['name']);
             }
@@ -246,7 +246,7 @@ 
                 $jsonCastables = ['array', 'object', 'json'];
                 $fieldCasting = $casted_attributes[$field['name']];
 
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
                     try {
                         $data[$field['name']] = json_decode($data[$field['name']]);
                     } catch (\Exception $e) {
@@ -275,7 +275,7 @@ 
      */
     public function orderFields($order)
     {
-        $this->transformFields(function ($fields) use ($order) {
+        $this->transformFields(function($fields) use ($order) {
             return $this->applyOrderToFields($fields, $order);
         });
     }
@@ -338,7 +338,7 @@ 
     public function hasUploadFields()
     {
         $fields = $this->getFields();
-        $upload_fields = array_where($fields, function ($value, $key) {
+        $upload_fields = array_where($fields, function($value, $key) {
             return isset($value['upload']) && $value['upload'] == true;
         });
 

src/PanelTraits/Operations.php

Doc Comments +2 added lines, -2 removed lines

@@ -56,7 +56,7 @@ 
     /**
      * Convenience method to make sure all calls are made to a particular operation.
      *
-     * @param  string|array     $operation      Operation name in string form
+     * @param  string|array     $operations      Operation name in string form
      * @param  bool|\Closure    $closure        Code that calls CrudPanel methods.
      * @return void
      */
@@ -70,7 +70,7 @@ 
      * Allc configurations are put inside that operation's namespace.
      * Ex: show.configuration.
      *
-     * @param  string|array     $operation      Operation name in string form
+     * @param  string|array     $operations      Operation name in string form
      * @param  bool|\Closure    $closure        Code that calls CrudPanel methods.
      * @return void
      */

src/PanelTraits/Tabs.php

Doc Comments +3 added lines

@@ -35,6 +35,9 @@
         return ! $this->tabsEnabled();
     }
 
+    /**
+     * @param string $type
+     */
     public function setTabsType($type)
     {
         $this->enableTabs();

Spacing +7 added lines, -7 removed lines

@@ -32,7 +32,7 @@ 
      */
     public function tabsDisabled()
     {
-        return ! $this->tabsEnabled();
+        return !$this->tabsEnabled();
     }
 
     public function setTabsType($type)
@@ -114,8 +114,8 @@ 
     {
         $all_fields = $this->getCurrentFields();
 
-        $fields_without_a_tab = collect($all_fields)->filter(function ($value, $key) {
-            return ! isset($value['tab']);
+        $fields_without_a_tab = collect($all_fields)->filter(function($value, $key) {
+            return !isset($value['tab']);
         });
 
         return $fields_without_a_tab;
@@ -131,7 +131,7 @@ 
         if ($this->tabExists($label)) {
             $all_fields = $this->getCurrentFields();
 
-            $fields_for_current_tab = collect($all_fields)->filter(function ($value, $key) use ($label) {
+            $fields_for_current_tab = collect($all_fields)->filter(function($value, $key) use ($label) {
                 return isset($value['tab']) && $value['tab'] == $label;
             });
 
@@ -150,11 +150,11 @@ 
         $fields = $this->getCurrentFields();
 
         $fields_with_tabs = collect($fields)
-            ->filter(function ($value, $key) {
+            ->filter(function($value, $key) {
                 return isset($value['tab']);
             })
-            ->each(function ($value, $key) use (&$tabs) {
-                if (! in_array($value['tab'], $tabs)) {
+            ->each(function($value, $key) use (&$tabs) {
+                if (!in_array($value['tab'], $tabs)) {
                     $tabs[] = $value['tab'];
                 }
             });

tests/Unit/CrudPanel/CrudPanelFakeFieldsTest.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,8 +2,8 @@
 
 namespace Backpack\CRUD\Tests\Unit\CrudPanel;
 
-use Illuminate\Support\Facades\DB;
 use Backpack\CRUD\Tests\Unit\Models\Article;
+use Illuminate\Support\Facades\DB;
 
 class CrudPanelFakeFieldsTest extends BaseDBCrudPanelTest
 {

src/app/Http/Controllers/Operations/RevisionsOperation.php

Spacing +1 added lines, -1 removed lines

@@ -82,7 +82,7 @@
         $this->crud->applyConfigurationFromSettings('revisions');
 
         $revisionId = \Request::input('revision_id', false);
-        if (! $revisionId) {
+        if (!$revisionId) {
             abort(500, 'Can\'t restore revision without revision_id');
         } else {
             $this->crud->restoreRevision($id, $revisionId); // do the update

src/app/Http/Controllers/Operations/BulkDeleteOperation.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
     {
         $this->crud->allowAccess('bulkDelete');
 
-        $this->crud->operation('list', function () {
+        $this->crud->operation('list', function() {
             $this->crud->enableBulkActions();
             $this->crud->addButton('bottom', 'bulk_delete', 'view', 'crud::buttons.bulk_delete');
         });

src/app/Http/Controllers/Operations/ShowOperation.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
     {
         $this->crud->allowAccess('show');
 
-        $this->crud->operation('list', function () {
+        $this->crud->operation('list', function() {
             $this->crud->addButton('line', 'show', 'view', 'crud::buttons.show', 'beginning');
         });
     }

src/app/Http/Controllers/Operations/DeleteOperation.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
     {
         $this->crud->allowAccess('delete');
 
-        $this->crud->operation(['list', 'show'], function () {
+        $this->crud->operation(['list', 'show'], function() {
             $this->crud->addButton('line', 'delete', 'view', 'crud::buttons.delete', 'end');
         });
     }

src/app/Http/Controllers/CrudController.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
 
         // call the setup function inside this closure to also have the request there
         // this way, developers can use things stored in session (auth variables, etc)
-        $this->middleware(function ($request, $next) {
+        $this->middleware(function($request, $next) {
             // make a new CrudPanel object, from the one stored in Laravel's service container
             $this->crud = app()->make('crud');
             $this->request = $request;