Laravel-Backpack / CRUD

src/app/Http/Controllers/Operations/BulkDeleteOperation.php

Spacing +2 added lines, -2 removed lines

@@ -29,11 +29,11 @@
     {
         $this->crud->allowAccess('bulkDelete');
 
-        $this->crud->operation('bulkDelete', function () {
+        $this->crud->operation('bulkDelete', function() {
             $this->crud->loadDefaultOperationSettingsFromConfig();
         });
 
-        $this->crud->operation('list', function () {
+        $this->crud->operation('list', function() {
             $this->crud->enableBulkActions();
             $this->crud->addButton('bottom', 'bulk_delete', 'view', 'crud::buttons.bulk_delete');
         });

src/app/Library/CrudPanel/Traits/Operations.php

Doc Comments +3 added lines, -3 removed lines

@@ -56,7 +56,7 @@ 
     /**
      * Convenience method to make sure all calls are made to a particular operation.
      *
-     * @param string|array  $operation Operation name in string form
+     * @param string|array  $operations Operation name in string form
      * @param bool|\Closure $closure   Code that calls CrudPanel methods.
      *
      * @return void
@@ -71,7 +71,7 @@ 
      * Allc configurations are put inside that operation's namespace.
      * Ex: show.configuration.
      *
-     * @param string|array  $operation Operation name in string form
+     * @param string|array  $operations Operation name in string form
      * @param bool|\Closure $closure   Code that calls CrudPanel methods.
      *
      * @return void
@@ -93,7 +93,7 @@ 
      * This is called when an operation does setCurrentOperation().
      *
      *
-     * @param string|array $operations [description]
+     * @param string $operations [description]
      *
      * @return void
      */

src/resources/views/crud/fields/table.blade.php

Spacing +3 added lines, -3 removed lines

@@ -3,7 +3,7 @@ 
 <?php
     $max = isset($field['max']) && (int) $field['max'] > 0 ? $field['max'] : -1;
     $min = isset($field['min']) && (int) $field['min'] > 0 ? $field['min'] : -1;
-    $item_name = strtolower(isset($field['entity_singular']) && ! empty($field['entity_singular']) ? $field['entity_singular'] : $field['label']);
+    $item_name = strtolower(isset($field['entity_singular']) && !empty($field['entity_singular']) ? $field['entity_singular'] : $field['label']);
 
     $items = old(square_brackets_to_dots($field['name'])) ?? $field['value'] ?? $field['default'] ?? '';
 
@@ -15,12 +15,12 @@ 
         } else {
             $items = '[]';
         }
-    } elseif (is_string($items) && ! is_array(json_decode($items))) {
+    } elseif (is_string($items) && !is_array(json_decode($items))) {
         $items = '[]';
     }
 
     // make sure columns are defined
-    if (! isset($field['columns'])) {
+    if (!isset($field['columns'])) {
         $field['columns'] = ['value' => 'Value'];
     }
 ?>

src/app/Http/Controllers/Operations/ListOperation.php

Spacing +4 added lines, -4 removed lines

@@ -41,7 +41,7 @@ 
     {
         $this->crud->allowAccess('list');
 
-        $this->crud->operation('list', function () {
+        $this->crud->operation('list', function() {
             $this->crud->loadDefaultOperationSettingsFromConfig();
         });
     }
@@ -112,8 +112,8 @@ 
         // if there was an order set, this will be the last one (after all others were applied)
         $orderBy = $this->crud->query->getQuery()->orders;
         $hasOrderByPrimaryKey = false;
-        collect($orderBy)->each(function ($item, $key) use ($hasOrderByPrimaryKey) {
-            if (! isset($item['column'])) {
+        collect($orderBy)->each(function($item, $key) use ($hasOrderByPrimaryKey) {
+            if (!isset($item['column'])) {
                 return false;
             }
 
@@ -123,7 +123,7 @@ 
                 return false;
             }
         });
-        if (! $hasOrderByPrimaryKey) {
+        if (!$hasOrderByPrimaryKey) {
             $this->crud->query->orderByDesc($this->crud->model->getKeyName());
         }
 

src/app/Http/Controllers/CrudController.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
 
         // call the setup function inside this closure to also have the request there
         // this way, developers can use things stored in session (auth variables, etc)
-        $this->middleware(function ($request, $next) {
+        $this->middleware(function($request, $next) {
             // make a new CrudPanel object, from the one stored in Laravel's service container
             $this->crud = app()->make('crud');
             // ensure crud has the latest request

tests/Unit/Http/CrudControllerTest.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,8 +2,8 @@
 
 namespace Backpack\CRUD\Tests\Unit\Http;
 
-use Backpack\CRUD\app\Library\CrudPanel\CrudPanel;
 use Backpack\CRUD\Tests\BaseTest;
+use Backpack\CRUD\app\Library\CrudPanel\CrudPanel;
 
 class CrudControllerTest extends BaseTest
 {

Spacing +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
         $controller = '\Backpack\CRUD\Tests\Unit\Http\Controllers\UserCrudController';
         $app['router']->get('users/{id}/edit', "$controller@edit");
         $app['router']->put('users/{id}', "$controller@update");
-        $app->singleton('crud', function ($app) {
+        $app->singleton('crud', function($app) {
             return new CrudPanel($app);
         });
     }

src/app/Library/CrudPanel/CrudPanel.php

Spacing +12 added lines, -12 removed lines

@@ -69,7 +69,7 @@ 
      */
     public function setRequest($request = null)
     {
-        if (! $request) {
+        if (!$request) {
             $request = \Request::instance();
         }
         $this->request = $request;
@@ -89,11 +89,11 @@ 
      */
     public function setModel($model_namespace)
     {
-        if (! class_exists($model_namespace)) {
+        if (!class_exists($model_namespace)) {
             throw new \Exception('The model does not exist.', 500);
         }
 
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
             throw new \Exception('Please use CrudTrait on the model.', 500);
         }
 
@@ -156,7 +156,7 @@ 
     {
         $complete_route = $route.'.index';
 
-        if (! \Route::has($complete_route)) {
+        if (!\Route::has($complete_route)) {
             throw new \Exception('There are no routes for this route name.', 404);
         }
 
@@ -257,7 +257,7 @@ 
      */
     public function getFirstOfItsTypeInArray($type, $array)
     {
-        return array_first($array, function ($item) use ($type) {
+        return array_first($array, function($item) use ($type) {
             return $item['type'] == $type;
         });
     }
@@ -274,8 +274,8 @@ 
 
     public function sync($type, $fields, $attributes)
     {
-        if (! empty($this->{$type})) {
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
+        if (!empty($this->{$type})) {
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
                 if (in_array($field['name'], (array) $fields)) {
                     $field = array_merge($field, $attributes);
                 }
@@ -306,15 +306,15 @@ 
     {
         $relationArray = explode('.', $relationString);
 
-        if (! isset($length)) {
+        if (!isset($length)) {
             $length = count($relationArray);
         }
 
-        if (! isset($model)) {
+        if (!isset($model)) {
             $model = $this->model;
         }
 
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
             return $obj->$method()->getRelated();
         }, $model);
 
@@ -364,7 +364,7 @@ 
         $relation = $model->{$firstRelationName};
 
         $results = [];
-        if (! empty($relation)) {
+        if (!empty($relation)) {
             if ($relation instanceof Collection) {
                 $currentResults = $relation->toArray();
             } else {
@@ -373,7 +373,7 @@ 
 
             array_shift($relationArray);
 
-            if (! empty($relationArray)) {
+            if (!empty($relationArray)) {
                 foreach ($currentResults as $currentResult) {
                     $results = array_merge($results, $this->getRelationModelInstances($currentResult, implode('.', $relationArray)));
                 }

src/app/Library/CrudPanel/Traits/Columns.php

Doc Comments +2 added lines, -2 removed lines

@@ -141,7 +141,7 @@ 
     /**
      * Move the most recently added column after the given target column.
      *
-     * @param string|array $targetColumn The target column name or array.
+     * @param string $targetColumn The target column name or array.
      */
     public function afterColumn($targetColumn)
     {
@@ -161,7 +161,7 @@ 
     /**
      * Move this column to be first in the columns list.
      *
-     * @return bool|null
+     * @return false|null
      */
     public function makeFirstColumn()
     {

Spacing +3 added lines, -3 removed lines

@@ -112,7 +112,7 @@ 
      */
     public function makeFirstColumn()
     {
-        if (! $this->columns()) {
+        if (!$this->columns()) {
             return false;
         }
 
@@ -157,7 +157,7 @@ 
      */
     public function removeColumns($columns)
     {
-        if (! empty($columns)) {
+        if (!empty($columns)) {
             foreach ($columns as $columnKey) {
                 $this->removeColumn($columnKey);
             }
@@ -236,7 +236,7 @@ 
     {
         $columns = $this->columns();
 
-        return collect($columns)->pluck('entity')->reject(function ($value, $key) {
+        return collect($columns)->pluck('entity')->reject(function($value, $key) {
             return $value == null;
         })->toArray();
     }

src/app/Library/CrudPanel/Traits/Fields.php

Doc Comments +2 added lines, -4 removed lines

@@ -326,8 +326,6 @@ 
      * Check if the create/update form has upload fields.
      * Upload fields are the ones that have "upload" => true defined on them.
      *
-     * @param string   $form create/update/both - defaults to 'both'
-     * @param bool|int $id   id of the entity - defaults to false
      *
      * @return bool
      */
@@ -358,7 +356,7 @@ 
     /**
      * Set an array of field type names as already loaded for the current operation.
      *
-     * @param array $fieldTypes
+     * @param string[] $fieldTypes
      */
     public function setLoadedFieldTypes($fieldTypes)
     {
@@ -369,7 +367,7 @@ 
      * Get a namespaced version of the field type name.
      * Appends the 'view_namespace' attribute of the field to the `type', using dot notation.
      *
-     * @param  array $field Field array
+     * @param  string $field Field array
      * @return string Namespaced version of the field type name. Ex: 'text', 'custom.view.path.text'
      */
     public function getFieldTypeWithNamespace($field)

Spacing +14 added lines, -14 removed lines

@@ -37,24 +37,24 @@ 
 
         // if this is a relation type field and no corresponding model was specified, get it from the relation method
         // defined in the main model
-        if (isset($newField['entity']) && ! isset($newField['model'])) {
+        if (isset($newField['entity']) && !isset($newField['model'])) {
             $newField['model'] = $this->getRelationModel($newField['entity']);
         }
 
         // if the label is missing, we should set it
-        if (! isset($newField['label'])) {
+        if (!isset($newField['label'])) {
             $label = is_array($newField['name']) ? $newField['name'][0] : $newField['name'];
             $newField['label'] = mb_ucfirst(str_replace('_', ' ', $label));
         }
 
         // if the field type is missing, we should set it
-        if (! isset($newField['type'])) {
+        if (!isset($newField['type'])) {
             $newField['type'] = $this->getFieldTypeFromDbColumnType($newField['name']);
         }
 
         // if a tab was mentioned, we should enable it
         if (isset($newField['tab'])) {
-            if (! $this->tabsEnabled()) {
+            if (!$this->tabsEnabled()) {
                 $this->enableTabs();
             }
         }
@@ -88,7 +88,7 @@ 
      */
     public function afterField($targetFieldName)
     {
-        $this->transformFields(function ($fields) use ($targetFieldName) {
+        $this->transformFields(function($fields) use ($targetFieldName) {
             return $this->moveField($fields, $targetFieldName, false);
         });
     }
@@ -100,7 +100,7 @@ 
      */
     public function beforeField($targetFieldName)
     {
-        $this->transformFields(function ($fields) use ($targetFieldName) {
+        $this->transformFields(function($fields) use ($targetFieldName) {
             return $this->moveField($fields, $targetFieldName, true);
         });
     }
@@ -142,7 +142,7 @@ 
      */
     public function removeField($name)
     {
-        $this->transformFields(function ($fields) use ($name) {
+        $this->transformFields(function($fields) use ($name) {
             array_forget($fields, $name);
 
             return $fields;
@@ -156,7 +156,7 @@ 
      */
     public function removeFields($array_of_names)
     {
-        if (! empty($array_of_names)) {
+        if (!empty($array_of_names)) {
             foreach ($array_of_names as $name) {
                 $this->removeField($name);
             }
@@ -169,7 +169,7 @@ 
     public function removeAllFields()
     {
         $current_fields = $this->getCurrentFields();
-        if (! empty($current_fields)) {
+        if (!empty($current_fields)) {
             foreach ($current_fields as $field) {
                 $this->removeField($field['name']);
             }
@@ -243,7 +243,7 @@ 
                 $jsonCastables = ['array', 'object', 'json'];
                 $fieldCasting = $casted_attributes[$field['name']];
 
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
                     try {
                         $data[$field['name']] = json_decode($data[$field['name']]);
                     } catch (\Exception $e) {
@@ -272,7 +272,7 @@ 
      */
     public function orderFields($order)
     {
-        $this->transformFields(function ($fields) use ($order) {
+        $this->transformFields(function($fields) use ($order) {
             return $this->applyOrderToFields($fields, $order);
         });
     }
@@ -335,7 +335,7 @@ 
     public function hasUploadFields()
     {
         $fields = $this->getFields();
-        $upload_fields = array_where($fields, function ($value, $key) {
+        $upload_fields = array_where($fields, function($value, $key) {
             return isset($value['upload']) && $value['upload'] == true;
         });
 
@@ -395,7 +395,7 @@ 
         $alreadyLoaded = $this->getLoadedFieldTypes();
         $type = $this->getFieldTypeWithNamespace($field);
 
-        if (! in_array($type, $this->getLoadedFieldTypes(), true)) {
+        if (!in_array($type, $this->getLoadedFieldTypes(), true)) {
             $alreadyLoaded[] = $type;
             $this->setLoadedFieldTypes($alreadyLoaded);
 
@@ -436,7 +436,7 @@ 
      */
     public function fieldTypeNotLoaded($field)
     {
-        return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
+        return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
     }
 
     /**