Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Failed
Pull Request — master (#2448)
by Cristian
35:18 queued 23:45
created
src/app/Http/Controllers/Operations/ListOperation.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     {
42 42
         $this->crud->allowAccess('list');
43 43
 
44
-        $this->crud->operation('list', function () {
44
+        $this->crud->operation('list', function() {
45 45
             $this->crud->loadDefaultOperationSettingsFromConfig();
46 46
         });
47 47
     }
@@ -112,8 +112,8 @@  discard block
 block discarded – undo
112 112
         // if there was an order set, this will be the last one (after all others were applied)
113 113
         $orderBy = $this->crud->query->getQuery()->orders;
114 114
         $hasOrderByPrimaryKey = false;
115
-        collect($orderBy)->each(function ($item, $key) use ($hasOrderByPrimaryKey) {
116
-            if (! isset($item['column'])) {
115
+        collect($orderBy)->each(function($item, $key) use ($hasOrderByPrimaryKey) {
116
+            if (!isset($item['column'])) {
117 117
                 return false;
118 118
             }
119 119
 
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
                 return false;
124 124
             }
125 125
         });
126
-        if (! $hasOrderByPrimaryKey) {
126
+        if (!$hasOrderByPrimaryKey) {
127 127
             $this->crud->query->orderByDesc($this->crud->model->getKeyName());
128 128
         }
129 129
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
 
28 28
         // call the setup function inside this closure to also have the request there
29 29
         // this way, developers can use things stored in session (auth variables, etc)
30
-        $this->middleware(function ($request, $next) {
30
+        $this->middleware(function($request, $next) {
31 31
             // make a new CrudPanel object, from the one stored in Laravel's service container
32 32
             $this->crud = app()->make('crud');
33 33
             // ensure crud has the latest request
Please login to merge, or discard this patch.
tests/Unit/Http/CrudControllerTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
         $controller = '\Backpack\CRUD\Tests\Unit\Http\Controllers\UserCrudController';
20 20
         $app['router']->get('users/{id}/edit', "$controller@edit");
21 21
         $app['router']->put('users/{id}', "$controller@update");
22
-        $app->singleton('crud', function ($app) {
22
+        $app->singleton('crud', function($app) {
23 23
             return new CrudPanel($app);
24 24
         });
25 25
     }
Please login to merge, or discard this patch.
src/app/Console/Commands/Install.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
                     $createUploadDirectoryCommand = 'mkdir -p public/uploads';
89 89
                     break;
90 90
                 case '\\': // windows
91
-                    if (! file_exists('public\uploads')) {
91
+                    if (!file_exists('public\uploads')) {
92 92
                         $createUploadDirectoryCommand = 'mkdir public\uploads';
93 93
                     }
94 94
                     break;
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
         $this->echo('info', $beforeNotice ? ' '.$beforeNotice : $command);
134 134
 
135 135
         $process = new Process($command, null, null, null, $this->option('timeout'));
136
-        $process->run(function ($type, $buffer) {
136
+        $process->run(function($type, $buffer) {
137 137
             if (Process::ERR === $type) {
138 138
                 $this->echo('comment', $buffer);
139 139
             } else {
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
         });
143 143
 
144 144
         // executes after the command finishes
145
-        if (! $process->isSuccessful()) {
145
+        if (!$process->isSuccessful()) {
146 146
             throw new ProcessFailedException($process);
147 147
         }
148 148
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Fields.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -37,24 +37,24 @@  discard block
 block discarded – undo
37 37
 
38 38
         // if this is a relation type field and no corresponding model was specified, get it from the relation method
39 39
         // defined in the main model
40
-        if (isset($newField['entity']) && ! isset($newField['model'])) {
40
+        if (isset($newField['entity']) && !isset($newField['model'])) {
41 41
             $newField['model'] = $this->getRelationModel($newField['entity']);
42 42
         }
43 43
 
44 44
         // if the label is missing, we should set it
45
-        if (! isset($newField['label'])) {
45
+        if (!isset($newField['label'])) {
46 46
             $label = is_array($newField['name']) ? $newField['name'][0] : $newField['name'];
47 47
             $newField['label'] = mb_ucfirst(str_replace('_', ' ', $label));
48 48
         }
49 49
 
50 50
         // if the field type is missing, we should set it
51
-        if (! isset($newField['type'])) {
51
+        if (!isset($newField['type'])) {
52 52
             $newField['type'] = $this->getFieldTypeFromDbColumnType($newField['name']);
53 53
         }
54 54
 
55 55
         // if a tab was mentioned, we should enable it
56 56
         if (isset($newField['tab'])) {
57
-            if (! $this->tabsEnabled()) {
57
+            if (!$this->tabsEnabled()) {
58 58
                 $this->enableTabs();
59 59
             }
60 60
         }
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
      */
89 89
     public function afterField($targetFieldName)
90 90
     {
91
-        $this->transformFields(function ($fields) use ($targetFieldName) {
91
+        $this->transformFields(function($fields) use ($targetFieldName) {
92 92
             return $this->moveField($fields, $targetFieldName, false);
93 93
         });
94 94
     }
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
      */
101 101
     public function beforeField($targetFieldName)
102 102
     {
103
-        $this->transformFields(function ($fields) use ($targetFieldName) {
103
+        $this->transformFields(function($fields) use ($targetFieldName) {
104 104
             return $this->moveField($fields, $targetFieldName, true);
105 105
         });
106 106
     }
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
      */
143 143
     public function removeField($name)
144 144
     {
145
-        $this->transformFields(function ($fields) use ($name) {
145
+        $this->transformFields(function($fields) use ($name) {
146 146
             array_forget($fields, $name);
147 147
 
148 148
             return $fields;
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
      */
157 157
     public function removeFields($array_of_names)
158 158
     {
159
-        if (! empty($array_of_names)) {
159
+        if (!empty($array_of_names)) {
160 160
             foreach ($array_of_names as $name) {
161 161
                 $this->removeField($name);
162 162
             }
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
     public function removeAllFields()
170 170
     {
171 171
         $current_fields = $this->getCurrentFields();
172
-        if (! empty($current_fields)) {
172
+        if (!empty($current_fields)) {
173 173
             foreach ($current_fields as $field) {
174 174
                 $this->removeField($field['name']);
175 175
             }
@@ -243,7 +243,7 @@  discard block
 block discarded – undo
243 243
                 $jsonCastables = ['array', 'object', 'json'];
244 244
                 $fieldCasting = $casted_attributes[$field['name']];
245 245
 
246
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
246
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
247 247
                     try {
248 248
                         $data[$field['name']] = json_decode($data[$field['name']]);
249 249
                     } catch (\Exception $e) {
@@ -272,7 +272,7 @@  discard block
 block discarded – undo
272 272
      */
273 273
     public function orderFields($order)
274 274
     {
275
-        $this->transformFields(function ($fields) use ($order) {
275
+        $this->transformFields(function($fields) use ($order) {
276 276
             return $this->applyOrderToFields($fields, $order);
277 277
         });
278 278
     }
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
     public function hasUploadFields()
336 336
     {
337 337
         $fields = $this->getFields();
338
-        $upload_fields = array_where($fields, function ($value, $key) {
338
+        $upload_fields = array_where($fields, function($value, $key) {
339 339
             return isset($value['upload']) && $value['upload'] == true;
340 340
         });
341 341
 
@@ -395,7 +395,7 @@  discard block
 block discarded – undo
395 395
         $alreadyLoaded = $this->getLoadedFieldTypes();
396 396
         $type = $this->getFieldTypeWithNamespace($field);
397 397
 
398
-        if (! in_array($type, $this->getLoadedFieldTypes(), true)) {
398
+        if (!in_array($type, $this->getLoadedFieldTypes(), true)) {
399 399
             $alreadyLoaded[] = $type;
400 400
             $this->setLoadedFieldTypes($alreadyLoaded);
401 401
 
@@ -436,7 +436,7 @@  discard block
 block discarded – undo
436 436
      */
437 437
     public function fieldTypeNotLoaded($field)
438 438
     {
439
-        return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
439
+        return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
440 440
     }
441 441
 
442 442
     /**
Please login to merge, or discard this patch.
src/resources/views/crud/columns/array_count.blade.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@
 block discarded – undo
8 8
     $suffix = isset($column['suffix']) ? $column['suffix'] : 'items';
9 9
 
10 10
     // the value should be an array wether or not attribute casting is used
11
-    if (! is_array($array)) {
11
+    if (!is_array($array)) {
12 12
         $array = json_decode($array, true);
13 13
     }
14 14
     ?>
Please login to merge, or discard this patch.
src/resources/views/crud/columns/select_from_array.blade.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@
 block discarded – undo
10 10
                 $array_of_values = [];
11 11
 
12 12
                 foreach ($values as $key => $value) {
13
-                    if (! is_null($value)) {
13
+                    if (!is_null($value)) {
14 14
                         $array_of_values[] = $column['options'][$value] ?? $value;
15 15
                     } else {
16 16
                         echo '-';
Please login to merge, or discard this patch.
src/app/Models/Traits/CrudTrait.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
             //check if column exists in database
73 73
             $conn->getDoctrineColumn($table, $column_name);
74 74
 
75
-            return ! $conn->getDoctrineColumn($table, $column_name)->getNotnull();
75
+            return !$conn->getDoctrineColumn($table, $column_name)->getNotnull();
76 76
         } catch (\Exception $e) {
77 77
             return true;
78 78
         }
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
     public function addFakes($columns = ['extras'])
93 93
     {
94 94
         foreach ($columns as $key => $column) {
95
-            if (! isset($this->attributes[$column])) {
95
+            if (!isset($this->attributes[$column])) {
96 96
                 continue;
97 97
             }
98 98
 
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
      */
142 142
     public function shouldDecodeFake($column)
143 143
     {
144
-        return ! in_array($column, array_keys($this->casts));
144
+        return !in_array($column, array_keys($this->casts));
145 145
     }
146 146
 
147 147
     /**
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
      */
154 154
     public function shouldEncodeFake($column)
155 155
     {
156
-        return ! in_array($column, array_keys($this->casts));
156
+        return !in_array($column, array_keys($this->casts));
157 157
     }
158 158
 
159 159
     /*
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
      */
225 225
     public function uploadMultipleFilesToDisk($value, $attribute_name, $disk, $destination_path)
226 226
     {
227
-        if (! is_array($this->{$attribute_name})) {
227
+        if (!is_array($this->{$attribute_name})) {
228 228
             $attribute_value = json_decode($this->{$attribute_name}, true) ?? [];
229 229
         } else {
230 230
             $attribute_value = $this->{$attribute_name};
@@ -236,7 +236,7 @@  discard block
 block discarded – undo
236 236
         if ($files_to_clear) {
237 237
             foreach ($files_to_clear as $key => $filename) {
238 238
                 \Storage::disk($disk)->delete($filename);
239
-                $attribute_value = array_where($attribute_value, function ($value, $key) use ($filename) {
239
+                $attribute_value = array_where($attribute_value, function($value, $key) use ($filename) {
240 240
                     return $value != $filename;
241 241
                 });
242 242
             }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudPanel.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
      */
70 70
     public function setRequest($request = null)
71 71
     {
72
-        if (! $request) {
72
+        if (!$request) {
73 73
             $request = \Request::instance();
74 74
         }
75 75
         $this->request = $request;
@@ -89,11 +89,11 @@  discard block
 block discarded – undo
89 89
      */
90 90
     public function setModel($model_namespace)
91 91
     {
92
-        if (! class_exists($model_namespace)) {
92
+        if (!class_exists($model_namespace)) {
93 93
             throw new \Exception('The model does not exist.', 500);
94 94
         }
95 95
 
96
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
96
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
97 97
             throw new \Exception('Please use CrudTrait on the model.', 500);
98 98
         }
99 99
 
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
     {
157 157
         $complete_route = $route.'.index';
158 158
 
159
-        if (! \Route::has($complete_route)) {
159
+        if (!\Route::has($complete_route)) {
160 160
             throw new \Exception('There are no routes for this route name.', 404);
161 161
         }
162 162
 
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
      */
258 258
     public function getFirstOfItsTypeInArray($type, $array)
259 259
     {
260
-        return array_first($array, function ($item) use ($type) {
260
+        return array_first($array, function($item) use ($type) {
261 261
             return $item['type'] == $type;
262 262
         });
263 263
     }
@@ -274,8 +274,8 @@  discard block
 block discarded – undo
274 274
 
275 275
     public function sync($type, $fields, $attributes)
276 276
     {
277
-        if (! empty($this->{$type})) {
278
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
277
+        if (!empty($this->{$type})) {
278
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
279 279
                 if (in_array($field['name'], (array) $fields)) {
280 280
                     $field = array_merge($field, $attributes);
281 281
                 }
@@ -306,15 +306,15 @@  discard block
 block discarded – undo
306 306
     {
307 307
         $relationArray = explode('.', $relationString);
308 308
 
309
-        if (! isset($length)) {
309
+        if (!isset($length)) {
310 310
             $length = count($relationArray);
311 311
         }
312 312
 
313
-        if (! isset($model)) {
313
+        if (!isset($model)) {
314 314
             $model = $this->model;
315 315
         }
316 316
 
317
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
317
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
318 318
             return $obj->$method()->getRelated();
319 319
         }, $model);
320 320
 
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
             //if (!$model instanceof Collection) {
343 343
             $modelKey = (new $model())->getKeyName();
344 344
             //}
345
-            if (is_array($entries) && ! isset($entries[$attribute])) {
345
+            if (is_array($entries) && !isset($entries[$attribute])) {
346 346
                 foreach ($entries as $entry) {
347 347
                     $attributes[$entry[$modelKey]] = $entry[$attribute];
348 348
                 }
@@ -373,21 +373,21 @@  discard block
 block discarded – undo
373 373
         $currentResults = [];
374 374
 
375 375
         $results = [];
376
-        if (! is_null($relation)) {
377
-            if ($relation instanceof Collection && ! $relation->isEmpty()) {
376
+        if (!is_null($relation)) {
377
+            if ($relation instanceof Collection && !$relation->isEmpty()) {
378 378
                 $currentResults[get_class($relation->first())] = $relation->toArray();
379
-            } elseif (is_array($relation) && ! empty($relation)) {
379
+            } elseif (is_array($relation) && !empty($relation)) {
380 380
                 $currentResults[get_class($relation->first())] = $relation;
381 381
             } else {
382 382
                 //relation must be App\Models\Article or App\Models\Category
383
-                if (! $relation instanceof Collection && ! empty($relation)) {
383
+                if (!$relation instanceof Collection && !empty($relation)) {
384 384
                     $currentResults[get_class($relation)] = $relation->toArray();
385 385
                 }
386 386
             }
387 387
 
388 388
             array_shift($relationArray);
389 389
 
390
-            if (! empty($relationArray)) {
390
+            if (!empty($relationArray)) {
391 391
                 foreach ($currentResults as $model => $currentResult) {
392 392
                     $results[$model] = array_merge($results[$model], $this->getRelationModelInstances($currentResult, implode('.', $relationArray)));
393 393
                 }
Please login to merge, or discard this patch.