Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Failed
Pull Request — master (#3113)
by Cristian
25:27 queued 10:27
created
tests/Unit/Http/CrudControllerTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 
27 27
         $app['router']->get('admin/users', "$controller@index")->name('admin.users.index');
28 28
 
29
-        $app->singleton('crud', function ($app) {
29
+        $app->singleton('crud', function($app) {
30 30
             return new CrudPanel($app);
31 31
         });
32 32
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php 1 patch
Spacing   +9 added lines, -10 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
             $column = ['name' => $column];
50 50
         }
51 51
 
52
-        if (is_array($column) && ! isset($column['name'])) {
52
+        if (is_array($column) && !isset($column['name'])) {
53 53
             $column['name'] = 'anonymous_column_'.Str::random(5);
54 54
         }
55 55
 
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      */
66 66
     protected function makeSureColumnHasLabel($column)
67 67
     {
68
-        if (! isset($column['label'])) {
68
+        if (!isset($column['label'])) {
69 69
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
70 70
         }
71 71
 
@@ -82,11 +82,11 @@  discard block
 block discarded – undo
82 82
     {
83 83
         // if it's got a method on the model with the same name
84 84
         // then it should be a relationship
85
-        if (! isset($column['type']) && method_exists($this->model, $column['name'])) {
85
+        if (!isset($column['type']) && method_exists($this->model, $column['name'])) {
86 86
             $column['type'] = 'relationship';
87 87
         }
88 88
 
89
-        if (! isset($column['type'])) {
89
+        if (!isset($column['type'])) {
90 90
             $column['type'] = 'text';
91 91
         }
92 92
 
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
      */
104 104
     protected function makeSureColumnHasKey($column)
105 105
     {
106
-        if (! isset($column['key'])) {
106
+        if (!isset($column['key'])) {
107 107
             $column['key'] = str_replace('.', '__', $column['name']);
108 108
         }
109 109
 
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
      */
122 122
     protected function makeSureColumnHasWrapper($column)
123 123
     {
124
-        if (! isset($column['wrapper'])) {
124
+        if (!isset($column['wrapper'])) {
125 125
             $column['wrapper'] = [];
126 126
         }
127 127
 
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
     {
140 140
         // if this is a relation type field and no corresponding model was specified,
141 141
         // get it from the relation method defined in the main model
142
-        if (isset($column['entity']) && ! isset($column['model'])) {
142
+        if (isset($column['entity']) && !isset($column['model'])) {
143 143
             $column['model'] = $this->getRelationModel($column['entity']);
144 144
         }
145 145
 
@@ -160,8 +160,7 @@  discard block
 block discarded – undo
160 160
         $columnsArray = $this->columns();
161 161
 
162 162
         if (array_key_exists($targetColumnName, $columnsArray)) {
163
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
164
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
163
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
165 164
 
166 165
             $element = array_pop($columnsArray);
167 166
             $beginningPart = array_slice($columnsArray, 0, $targetColumnPosition, true);
@@ -184,7 +183,7 @@  discard block
 block discarded – undo
184 183
     {
185 184
         static $cache = [];
186 185
 
187
-        if (! $this->driverIsSql()) {
186
+        if (!$this->driverIsSql()) {
188 187
             return true;
189 188
         }
190 189
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/AutoSet.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
             $this->getDbColumnTypes();
17 17
         }
18 18
 
19
-        array_map(function ($field) {
19
+        array_map(function($field) {
20 20
             $new_field = [
21 21
                 'name'       => $field,
22 22
                 'label'      => $this->makeLabel($field),
@@ -28,11 +28,11 @@  discard block
 block discarded – undo
28 28
                 'autoset'    => true,
29 29
             ];
30 30
 
31
-            if (! isset($this->fields()[$field])) {
31
+            if (!isset($this->fields()[$field])) {
32 32
                 $this->addField($new_field);
33 33
             }
34 34
 
35
-            if (! in_array($field, $this->model->getHidden()) && ! in_array($field, $this->columns())) {
35
+            if (!in_array($field, $this->model->getHidden()) && !in_array($field, $this->columns())) {
36 36
                 $this->addColumn([
37 37
                     'name'    => $field,
38 38
                     'label'   => $this->makeLabel($field),
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 
111 111
         $dbColumnTypes = $this->getDbColumnTypes();
112 112
 
113
-        if (! isset($dbColumnTypes[$fieldName])) {
113
+        if (!isset($dbColumnTypes[$fieldName])) {
114 114
             return 'text';
115 115
         }
116 116
 
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
         $types = ['enum' => 'string'];
169 169
         $platform = $this->getSchema()->getConnection()->getDoctrineConnection()->getDatabasePlatform();
170 170
         foreach ($types as $type_key => $type_value) {
171
-            if (! $platform->hasDoctrineTypeMappingFor($type_key)) {
171
+            if (!$platform->hasDoctrineTypeMappingFor($type_key)) {
172 172
                 $platform->registerDoctrineTypeMapping($type_key, $type_value);
173 173
             }
174 174
         }
@@ -221,13 +221,13 @@  discard block
 block discarded – undo
221 221
     {
222 222
         $fillable = $this->model->getFillable();
223 223
 
224
-        if (! $this->driverIsSql()) {
224
+        if (!$this->driverIsSql()) {
225 225
             $columns = $fillable;
226 226
         } else {
227 227
             // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model
228 228
             $columns = $this->model->getConnection()->getSchemaBuilder()->getColumnListing($this->model->getTable());
229 229
 
230
-            if (! empty($fillable)) {
230
+            if (!empty($fillable)) {
231 231
                 $columns = array_intersect($columns, $fillable);
232 232
             }
233 233
         }
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ListOperation.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     {
42 42
         $this->crud->allowAccess('list');
43 43
 
44
-        $this->crud->operation('list', function () {
44
+        $this->crud->operation('list', function() {
45 45
             $this->crud->loadDefaultOperationSettingsFromConfig();
46 46
         });
47 47
     }
@@ -114,8 +114,8 @@  discard block
 block discarded – undo
114 114
         // if there was an order set, this will be the last one (after all others were applied)
115 115
         $orderBy = $this->crud->query->getQuery()->orders;
116 116
         $hasOrderByPrimaryKey = false;
117
-        collect($orderBy)->each(function ($item, $key) use ($hasOrderByPrimaryKey) {
118
-            if (! isset($item['column'])) {
117
+        collect($orderBy)->each(function($item, $key) use ($hasOrderByPrimaryKey) {
118
+            if (!isset($item['column'])) {
119 119
                 return false;
120 120
             }
121 121
 
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
                 return false;
126 126
             }
127 127
         });
128
-        if (! $hasOrderByPrimaryKey) {
128
+        if (!$hasOrderByPrimaryKey) {
129 129
             $this->crud->orderByWithPrefix($this->crud->model->getKeyName(), 'DESC');
130 130
         }
131 131
 
Please login to merge, or discard this patch.
src/app/Models/Traits/HasRelationshipFields.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
         $table = $instance->getTableWithPrefix();
73 73
 
74 74
         // MongoDB columns are alway nullable
75
-        if (! in_array($conn->getConfig()['driver'], CRUD::getSqlDriverList())) {
75
+        if (!in_array($conn->getConfig()['driver'], CRUD::getSqlDriverList())) {
76 76
             return true;
77 77
         }
78 78
 
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
             // check for NOT NULL
83 83
             $notNull = $column->getNotnull();
84 84
             // return the value of nullable (aka the inverse of NOT NULL)
85
-            return ! $notNull;
85
+            return !$notNull;
86 86
         } catch (\Exception $e) {
87 87
             return true;
88 88
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Read.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
     {
39 39
         $id = $this->getCurrentEntryId();
40 40
 
41
-        if (! $id) {
41
+        if (!$id) {
42 42
             return false;
43 43
         }
44 44
 
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
      */
55 55
     public function getEntry($id)
56 56
     {
57
-        if (! $this->entry) {
57
+        if (!$this->entry) {
58 58
             $this->entry = $this->model->findOrFail($id);
59 59
             $this->entry = $this->entry->withFakes();
60 60
         }
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
                 // we will apply the same labels as the values to the menu if developer didn't
245 245
                 $this->abortIfInvalidPageLength($menu[0]);
246 246
 
247
-                if (! isset($menu[1]) || ! is_array($menu[1])) {
247
+                if (!isset($menu[1]) || !is_array($menu[1])) {
248 248
                     $menu[1] = $menu[0];
249 249
                 }
250 250
             } else {
Please login to merge, or discard this patch.
src/helpers.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-if (! function_exists('backpack_url')) {
3
+if (!function_exists('backpack_url')) {
4 4
     /**
5 5
      * Appends the configured backpack prefix and returns
6 6
      * the URL using the standard Laravel helpers.
@@ -11,13 +11,13 @@  discard block
 block discarded – undo
11 11
      */
12 12
     function backpack_url($path = null, $parameters = [], $secure = null)
13 13
     {
14
-        $path = ! $path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
14
+        $path = !$path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
15 15
 
16 16
         return url(config('backpack.base.route_prefix', 'admin').$path, $parameters, $secure);
17 17
     }
18 18
 }
19 19
 
20
-if (! function_exists('backpack_authentication_column')) {
20
+if (!function_exists('backpack_authentication_column')) {
21 21
     /**
22 22
      * Return the username column name.
23 23
      * The Laravel default (and Backpack default) is 'email'.
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
     }
31 31
 }
32 32
 
33
-if (! function_exists('backpack_form_input')) {
33
+if (!function_exists('backpack_form_input')) {
34 34
     /**
35 35
      * Parse the submitted input in request('form') to an usable array.
36 36
      * Joins the multiple[] fields in a single key and transform the dot notation fields into arrayed ones.
@@ -59,10 +59,10 @@  discard block
 block discarded – undo
59 59
             }
60 60
 
61 61
             if (is_null($input_arg)) {
62
-                if (! isset($result[$input_key])) {
62
+                if (!isset($result[$input_key])) {
63 63
                     $result[$input_key] = $row['value'];
64 64
                 } else {
65
-                    $result[$input_key] = ! is_array($result[$input_key]) ? [$result[$input_key]] : $result[$input_key];
65
+                    $result[$input_key] = !is_array($result[$input_key]) ? [$result[$input_key]] : $result[$input_key];
66 66
 
67 67
                     array_push($result[$input_key], $row['value']);
68 68
                 }
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
     }
76 76
 }
77 77
 
78
-if (! function_exists('backpack_users_have_email')) {
78
+if (!function_exists('backpack_users_have_email')) {
79 79
     /**
80 80
      * Check if the email column is present on the user table.
81 81
      *
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
     }
91 91
 }
92 92
 
93
-if (! function_exists('backpack_avatar_url')) {
93
+if (!function_exists('backpack_avatar_url')) {
94 94
     /**
95 95
      * Returns the avatar URL of a user.
96 96
      *
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
     }
124 124
 }
125 125
 
126
-if (! function_exists('backpack_middleware')) {
126
+if (!function_exists('backpack_middleware')) {
127 127
     /**
128 128
      * Return the key of the middleware used across Backpack.
129 129
      * That middleware checks if the visitor is an admin.
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
     }
139 139
 }
140 140
 
141
-if (! function_exists('backpack_guard_name')) {
141
+if (!function_exists('backpack_guard_name')) {
142 142
     /*
143 143
      * Returns the name of the guard defined
144 144
      * by the application config
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
     }
150 150
 }
151 151
 
152
-if (! function_exists('backpack_auth')) {
152
+if (!function_exists('backpack_auth')) {
153 153
     /*
154 154
      * Returns the user instance if it exists
155 155
      * of the currently authenticated admin
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
     }
162 162
 }
163 163
 
164
-if (! function_exists('backpack_user')) {
164
+if (!function_exists('backpack_user')) {
165 165
     /*
166 166
      * Returns back a user instance without
167 167
      * the admin guard, however allows you
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
     }
174 174
 }
175 175
 
176
-if (! function_exists('mb_ucfirst')) {
176
+if (!function_exists('mb_ucfirst')) {
177 177
     /**
178 178
      * Capitalize the first letter of a string,
179 179
      * even if that string is multi-byte (non-latin alphabet).
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
     }
196 196
 }
197 197
 
198
-if (! function_exists('backpack_view')) {
198
+if (!function_exists('backpack_view')) {
199 199
     /**
200 200
      * Returns a new displayable view based on the configured backpack view namespace.
201 201
      * If that view doesn't exist, it will load the one from the original theme.
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
 
216 216
         $returnView = $theme.$view;
217 217
 
218
-        if (! view()->exists($returnView)) {
218
+        if (!view()->exists($returnView)) {
219 219
             $returnView = $originalTheme.$view;
220 220
         }
221 221
 
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
     }
224 224
 }
225 225
 
226
-if (! function_exists('square_brackets_to_dots')) {
226
+if (!function_exists('square_brackets_to_dots')) {
227 227
     /**
228 228
      * Turns a string from bracket-type array to dot-notation array.
229 229
      * Ex: array[0][property] turns into array.0.property.
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
     }
241 241
 }
242 242
 
243
-if (! function_exists('is_countable')) {
243
+if (!function_exists('is_countable')) {
244 244
     /**
245 245
      * We need this because is_countable was only introduced in PHP 7.3,
246 246
      * and in PHP 7.2 you should check if count() argument is really countable.
Please login to merge, or discard this patch.