Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#3410)
by
unknown
26:48 queued 11:51
created
src/app/Library/CrudPanel/Traits/Update.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 
61 61
         foreach ($fields as &$field) {
62 62
             // set the value
63
-            if (! isset($field['value'])) {
63
+            if (!isset($field['value'])) {
64 64
                 if (isset($field['subfields'])) {
65 65
                     $field['value'] = [];
66 66
                     foreach ($field['subfields'] as $subfield) {
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
         }
74 74
 
75 75
         // always have a hidden input for the entry id
76
-        if (! array_key_exists('id', $fields)) {
76
+        if (!array_key_exists('id', $fields)) {
77 77
             $fields['id'] = [
78 78
                 'name'  => $entry->getKeyName(),
79 79
                 'value' => $entry->getKey(),
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
 
100 100
             $relation_array = explode('.', $relational_entity);
101 101
 
102
-            $relatedModel = array_reduce(array_splice($relation_array, 0, -1), function ($obj, $method) {
102
+            $relatedModel = array_reduce(array_splice($relation_array, 0, -1), function($obj, $method) {
103 103
                 return $obj->{$method} ? $obj->{$method} : $obj;
104 104
             }, $model);
105 105
 
@@ -162,11 +162,11 @@  discard block
 block discarded – undo
162 162
      */
163 163
     private function getManyRelationAttributeValue($model, $relation_method, $field, $relation_type)
164 164
     {
165
-        if (! isset($field['pivotFields']) || ! is_array($field['pivotFields'])) {
165
+        if (!isset($field['pivotFields']) || !is_array($field['pivotFields'])) {
166 166
             return false;
167 167
         }
168 168
 
169
-        $pivot_fields = Arr::where($field['pivotFields'], function ($item) use ($field) {
169
+        $pivot_fields = Arr::where($field['pivotFields'], function($item) use ($field) {
170 170
             return $field['name'] != $item['name'];
171 171
         });
172 172
         $related_models = $model->{$relation_method};
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Columns.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
      */
115 115
     public function makeFirstColumn()
116 116
     {
117
-        if (! $this->columns()) {
117
+        if (!$this->columns()) {
118 118
             return false;
119 119
         }
120 120
 
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
      */
160 160
     public function removeColumns($columns)
161 161
     {
162
-        if (! empty($columns)) {
162
+        if (!empty($columns)) {
163 163
             foreach ($columns as $columnKey) {
164 164
                 $this->removeColumn($columnKey);
165 165
             }
@@ -252,8 +252,8 @@  discard block
 block discarded – undo
252 252
     {
253 253
         $columns = $this->columns();
254 254
 
255
-        return collect($columns)->pluck('entity')->reject(function ($value, $key) {
256
-            return ! $value;
255
+        return collect($columns)->pluck('entity')->reject(function($value, $key) {
256
+            return !$value;
257 257
         })->toArray();
258 258
     }
259 259
 
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
      */
330 330
     public function hasColumnWhere($attribute, $value)
331 331
     {
332
-        $match = Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
332
+        $match = Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
333 333
             return isset($column[$attribute]) && $column[$attribute] == $value;
334 334
         });
335 335
 
@@ -345,7 +345,7 @@  discard block
 block discarded – undo
345 345
      */
346 346
     public function firstColumnWhere($attribute, $value)
347 347
     {
348
-        return Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
348
+        return Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
349 349
             return isset($column[$attribute]) && $column[$attribute] == $value;
350 350
         });
351 351
     }
@@ -395,8 +395,8 @@  discard block
 block discarded – undo
395 395
      */
396 396
     public function countColumnsWithoutActions()
397 397
     {
398
-        return collect($this->columns())->filter(function ($column, $key) {
399
-            return ! isset($column['hasActions']) || $column['hasActions'] == false;
398
+        return collect($this->columns())->filter(function($column, $key) {
399
+            return !isset($column['hasActions']) || $column['hasActions'] == false;
400 400
         })->count();
401 401
     }
402 402
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/AutoSet.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
             $this->getDbColumnTypes();
17 17
         }
18 18
 
19
-        array_map(function ($field) {
19
+        array_map(function($field) {
20 20
             $new_field = [
21 21
                 'name'       => $field,
22 22
                 'label'      => $this->makeLabel($field),
@@ -28,11 +28,11 @@  discard block
 block discarded – undo
28 28
                 'autoset'    => true,
29 29
             ];
30 30
 
31
-            if (! isset($this->fields()[$field])) {
31
+            if (!isset($this->fields()[$field])) {
32 32
                 $this->addField($new_field);
33 33
             }
34 34
 
35
-            if (! in_array($field, $this->model->getHidden()) && ! in_array($field, $this->columns())) {
35
+            if (!in_array($field, $this->model->getHidden()) && !in_array($field, $this->columns())) {
36 36
                 $this->addColumn([
37 37
                     'name'    => $field,
38 38
                     'label'   => $this->makeLabel($field),
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 
111 111
         $dbColumnTypes = $this->getDbColumnTypes();
112 112
 
113
-        if (! isset($dbColumnTypes[$fieldName])) {
113
+        if (!isset($dbColumnTypes[$fieldName])) {
114 114
             return 'text';
115 115
         }
116 116
 
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
         $types = ['enum' => 'string'];
169 169
         $platform = $this->getSchema()->getConnection()->getDoctrineSchemaManager()->getDatabasePlatform();
170 170
         foreach ($types as $type_key => $type_value) {
171
-            if (! $platform->hasDoctrineTypeMappingFor($type_key)) {
171
+            if (!$platform->hasDoctrineTypeMappingFor($type_key)) {
172 172
                 $platform->registerDoctrineTypeMapping($type_key, $type_value);
173 173
             }
174 174
         }
@@ -221,13 +221,13 @@  discard block
 block discarded – undo
221 221
     {
222 222
         $fillable = $this->model->getFillable();
223 223
 
224
-        if (! $this->driverIsSql()) {
224
+        if (!$this->driverIsSql()) {
225 225
             $columns = $fillable;
226 226
         } else {
227 227
             // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model
228 228
             $columns = $this->model->getConnection()->getSchemaBuilder()->getColumnListing($this->model->getTable());
229 229
 
230
-            if (! empty($fillable)) {
230
+            if (!empty($fillable)) {
231 231
                 $columns = array_intersect($columns, $fillable);
232 232
             }
233 233
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php 1 patch
Spacing   +9 added lines, -10 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
             $column = ['name' => $column];
50 50
         }
51 51
 
52
-        if (is_array($column) && ! isset($column['name'])) {
52
+        if (is_array($column) && !isset($column['name'])) {
53 53
             $column['name'] = 'anonymous_column_'.Str::random(5);
54 54
         }
55 55
 
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      */
66 66
     protected function makeSureColumnHasLabel($column)
67 67
     {
68
-        if (! isset($column['label'])) {
68
+        if (!isset($column['label'])) {
69 69
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
70 70
         }
71 71
 
@@ -82,11 +82,11 @@  discard block
 block discarded – undo
82 82
     {
83 83
         $could_be_relation = isset($column['entity']) && $column['entity'] !== false;
84 84
 
85
-        if (! isset($column['type']) && $could_be_relation) {
85
+        if (!isset($column['type']) && $could_be_relation) {
86 86
             $column['type'] = 'relationship';
87 87
         }
88 88
 
89
-        if (! isset($column['type'])) {
89
+        if (!isset($column['type'])) {
90 90
             $column['type'] = 'text';
91 91
         }
92 92
 
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
      */
104 104
     protected function makeSureColumnHasKey($column)
105 105
     {
106
-        if (! isset($column['key'])) {
106
+        if (!isset($column['key'])) {
107 107
             $column['key'] = str_replace('.', '__', $column['name']);
108 108
         }
109 109
 
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
      */
122 122
     protected function makeSureColumnHasWrapper($column)
123 123
     {
124
-        if (! isset($column['wrapper'])) {
124
+        if (!isset($column['wrapper'])) {
125 125
             $column['wrapper'] = [];
126 126
         }
127 127
 
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
     {
186 186
         // if this is a relation type field and no corresponding model was specified,
187 187
         // get it from the relation method defined in the main model
188
-        if (isset($column['entity']) && $column['entity'] !== false && ! isset($column['model'])) {
188
+        if (isset($column['entity']) && $column['entity'] !== false && !isset($column['model'])) {
189 189
             $column['model'] = $this->getRelationModel($column['entity']);
190 190
         }
191 191
 
@@ -206,8 +206,7 @@  discard block
 block discarded – undo
206 206
         $columnsArray = $this->columns();
207 207
 
208 208
         if (array_key_exists($targetColumnName, $columnsArray)) {
209
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
210
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
209
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
211 210
 
212 211
             $element = array_pop($columnsArray);
213 212
             $beginningPart = array_slice($columnsArray, 0, $targetColumnPosition, true);
@@ -230,7 +229,7 @@  discard block
 block discarded – undo
230 229
     {
231 230
         static $cache = [];
232 231
 
233
-        if (! $this->driverIsSql()) {
232
+        if (!$this->driverIsSql()) {
234 233
             return true;
235 234
         }
236 235
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/FetchOperation.php 1 patch
Spacing   +6 added lines, -8 removed lines patch added patch discarded remove patch
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
46 46
         // otherwise assume the arguments are actually the configuration array
47 47
         $config = [];
48 48
 
49
-        if (! is_array($arg)) {
50
-            if (! class_exists($arg)) {
49
+        if (!is_array($arg)) {
50
+            if (!class_exists($arg)) {
51 51
                 return response()->json(['error' => 'Class: '.$arg.' does not exists'], 500);
52 52
             }
53 53
             $config['model'] = $arg;
@@ -77,8 +77,7 @@  discard block
 block discarded – undo
77 77
 
78 78
         if ($search_string === false) {
79 79
             return ($config['paginate'] !== false) ?
80
-            $config['query']->paginate($config['paginate']) :
81
-            $config['query']->get();
80
+            $config['query']->paginate($config['paginate']) : $config['query']->get();
82 81
         }
83 82
 
84 83
         $textColumnTypes = ['string', 'json_string', 'text', 'longText', 'json_array', 'json'];
@@ -89,8 +88,8 @@  discard block
 block discarded – undo
89 88
         // .... 'query' => function($model) { return $model->where('active', 1); }
90 89
         // So it reads: SELECT ... WHERE active = 1 AND (XXX = x OR YYY = y) and not SELECT ... WHERE active = 1 AND XXX = x OR YYY = y;
91 90
 
92
-        if (! empty($config['query']->getQuery()->wheres)) {
93
-            $config['query'] = $config['query']->where(function ($query) use ($model_instance, $config, $search_string, $textColumnTypes) {
91
+        if (!empty($config['query']->getQuery()->wheres)) {
92
+            $config['query'] = $config['query']->where(function($query) use ($model_instance, $config, $search_string, $textColumnTypes) {
94 93
                 foreach ((array) $config['searchable_attributes'] as $k => $searchColumn) {
95 94
                     $operation = ($k == 0) ? 'where' : 'orWhere';
96 95
                     $columnType = $model_instance->getColumnType($searchColumn);
@@ -122,7 +121,6 @@  discard block
 block discarded – undo
122 121
 
123 122
         // return the results with or without pagination
124 123
         return ($config['paginate'] !== false) ?
125
-                    $config['query']->paginate($config['paginate']) :
126
-                    $config['query']->get();
124
+                    $config['query']->paginate($config['paginate']) : $config['query']->get();
127 125
     }
128 126
 }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Read.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
      */
57 57
     public function getEntry($id)
58 58
     {
59
-        if (! $this->entry) {
59
+        if (!$this->entry) {
60 60
             $this->entry = $this->model->findOrFail($id);
61 61
             $this->entry = $this->entry->withFakes();
62 62
         }
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
                 // we will apply the same labels as the values to the menu if developer didn't
259 259
                 $this->abortIfInvalidPageLength($menu[0]);
260 260
 
261
-                if (! isset($menu[1]) || ! is_array($menu[1])) {
261
+                if (!isset($menu[1]) || !is_array($menu[1])) {
262 262
                     $menu[1] = $menu[0];
263 263
                 }
264 264
             } else {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
     {
92 92
         $all_relation_fields = $this->getRelationFields();
93 93
 
94
-        return Arr::where($all_relation_fields, function ($value, $key) {
94
+        return Arr::where($all_relation_fields, function($value, $key) {
95 95
             return isset($value['pivot']) && $value['pivot'];
96 96
         });
97 97
     }
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
                             $field_data = json_decode($data[$field['name']], true);
156 156
 
157 157
                             // we grab from the parsed data the specific values for this pivot
158
-                            $pivot_data = Arr::first($field_data, function ($item) use ($pivot_id, $field) {
158
+                            $pivot_data = Arr::first($field_data, function($item) use ($pivot_id, $field) {
159 159
                                 return $item[$field['name']] === $pivot_id;
160 160
                             });
161 161
 
@@ -188,12 +188,12 @@  discard block
 block discarded – undo
188 188
      */
189 189
     private function createRelationsForItem($item, $formattedData)
190 190
     {
191
-        if (! isset($formattedData['relations'])) {
191
+        if (!isset($formattedData['relations'])) {
192 192
             return false;
193 193
         }
194 194
 
195 195
         foreach ($formattedData['relations'] as $relationMethod => $relationData) {
196
-            if (! isset($relationData['model'])) {
196
+            if (!isset($relationData['model'])) {
197 197
                 continue;
198 198
             }
199 199
 
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
                     // we first check if there are relations of the relation
207 207
                     if (isset($relationData['relations'])) {
208 208
                         // if there are nested relations, we first add the BelongsTo like in main entry
209
-                        $belongsToRelations = Arr::where($relationData['relations'], function ($relation_data) {
209
+                        $belongsToRelations = Arr::where($relationData['relations'], function($relation_data) {
210 210
                             return $relation_data['relation_type'] == 'BelongsTo';
211 211
                         });
212 212
 
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
                         $valuesWithRelations = $this->associateHasOneBelongsTo($belongsToRelations, $relationData['values'], $relation->getModel());
216 216
 
217 217
                         // remove previously added BelongsTo relations from relation data.
218
-                        $relationData['relations'] = Arr::where($relationData['relations'], function ($item) {
218
+                        $relationData['relations'] = Arr::where($relationData['relations'], function($item) {
219 219
                             return $item['relation_type'] != 'BelongsTo';
220 220
                         });
221 221
 
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
     private function getRelationDataFromFormData($data)
316 316
     {
317 317
         // exclude the already attached belongs to relations but include nested belongs to.
318
-        $relation_fields = Arr::where($this->getRelationFields(), function ($field, $key) {
318
+        $relation_fields = Arr::where($this->getRelationFields(), function($field, $key) {
319 319
             return $field['relation_type'] !== 'BelongsTo' || $this->isNestedRelation($field);
320 320
         });
321 321
 
@@ -326,10 +326,10 @@  discard block
 block discarded – undo
326 326
             if (isset($relation_field['pivot']) && $relation_field['pivot'] !== true) {
327 327
                 $key = implode('.relations.', explode('.', $this->getOnlyRelationEntity($relation_field)));
328 328
                 $fieldData = Arr::get($relationData, 'relations.'.$key, []);
329
-                if (! array_key_exists('model', $fieldData)) {
329
+                if (!array_key_exists('model', $fieldData)) {
330 330
                     $fieldData['model'] = $relation_field['model'];
331 331
                 }
332
-                if (! array_key_exists('parent', $fieldData)) {
332
+                if (!array_key_exists('parent', $fieldData)) {
333 333
                     $fieldData['parent'] = $this->getRelationModel($attributeKey, -1);
334 334
                 }
335 335
 
@@ -343,7 +343,7 @@  discard block
 block discarded – undo
343 343
                 // this allow developers to override that behavior and force deletion from database
344 344
                 $fieldData['force_delete'] = $relation_field['force_delete'] ?? false;
345 345
 
346
-                if (! array_key_exists('relation_type', $fieldData)) {
346
+                if (!array_key_exists('relation_type', $fieldData)) {
347 347
                     $fieldData['relation_type'] = $relation_field['relation_type'];
348 348
                 }
349 349
                 $relatedAttribute = Arr::last(explode('.', $attributeKey));
@@ -386,7 +386,7 @@  discard block
 block discarded – undo
386 386
                     ->where($relation_foreign_key, $item->{$relation_local_key})
387 387
                     ->update([$relation_foreign_key => $relationData['fallback_id']]);
388 388
             } else {
389
-                if (! $relation_column_is_nullable || $force_delete) {
389
+                if (!$relation_column_is_nullable || $force_delete) {
390 390
                     $model_instance->whereNotIn($model_instance->getKeyName(), $relation_values)
391 391
                         ->where($relation_foreign_key, $item->{$relation_local_key})
392 392
                         ->delete();
@@ -403,7 +403,7 @@  discard block
 block discarded – undo
403 403
                 $model_instance->where($relation_foreign_key, $item->{$relation_local_key})
404 404
                     ->update([$relation_foreign_key => $relationData['fallback_id']]);
405 405
             } else {
406
-                if (! $relation_column_is_nullable || $force_delete) {
406
+                if (!$relation_column_is_nullable || $force_delete) {
407 407
                     $model_instance->where($relation_foreign_key, $item->{$relation_local_key})->delete();
408 408
                 } else {
409 409
                     $model_instance->where($relation_foreign_key, $item->{$relation_local_key})
@@ -433,7 +433,7 @@  discard block
 block discarded – undo
433 433
             $created_ids = [];
434 434
 
435 435
             foreach ($items as $item) {
436
-                if (isset($item[$relation_local_key]) && ! empty($item[$relation_local_key])) {
436
+                if (isset($item[$relation_local_key]) && !empty($item[$relation_local_key])) {
437 437
                     $entry->{$relationMethod}()->updateOrCreate([$relation_local_key => $item[$relation_local_key]], $item);
438 438
                 } else {
439 439
                     $created_ids[] = $entry->{$relationMethod}()->create($item)->{$relation_local_key};
@@ -443,7 +443,7 @@  discard block
 block discarded – undo
443 443
             // get from $items the sent ids, and merge the ones created.
444 444
             $relatedItemsSent = array_merge(array_filter(Arr::pluck($items, $relation_local_key)), $created_ids);
445 445
 
446
-            if (! empty($relatedItemsSent)) {
446
+            if (!empty($relatedItemsSent)) {
447 447
                 // we perform the cleanup of removed database items
448 448
                 $entry->{$relationMethod}()->whereNotIn($relation_local_key, $relatedItemsSent)->delete();
449 449
             }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Relationships.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
         return collect($this->fields())
62 62
             ->where('model')
63 63
             ->whereIn('relation_type', $relation_types)
64
-            ->filter(function ($item) {
64
+            ->filter(function($item) {
65 65
                 $related_model = get_class($this->model->{Str::before($item['entity'], '.')}()->getRelated());
66 66
 
67 67
                 return Str::contains($item['entity'], '.') && $item['model'] !== $related_model ? false : true;
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
         $relation_model = $this->getRelationModel($relation_field['entity'], -1);
207 207
         $related_method = Str::afterLast($relation_field['entity'], '.');
208 208
 
209
-        if (! method_exists($relation_model, $related_method) && $this->isNestedRelation($relation_field)) {
209
+        if (!method_exists($relation_model, $related_method) && $this->isNestedRelation($relation_field)) {
210 210
             return Str::beforeLast($relation_field['entity'], '.');
211 211
         }
212 212
 
Please login to merge, or discard this patch.