Backpack\CRUD\app\Library\Validation\Rules\ValidUpload::validateRules()

Complexity

Conditions	5
Paths	3

Size

Total Lines	15
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function validateRules(string $attribute, mixed $value): array
    {
        $entry = CrudPanelFacade::getCurrentEntry();

The method getCurrentEntry() does not exist on Backpack\CRUD\app\Library\CrudPanel\CrudPanelFacade. Since you implemented __callStatic, consider adding a @method annotation.

        if (! array_key_exists($attribute, $this->data) && $entry) {
            return [];

The expression return array() returns the type array which is incompatible with the documented return type void.

        }

        $fieldErrors = $this->validateFieldRules($attribute, $value);

        if (! empty($value) && ! empty($this->getFileRules())) {
            $fileErrors = $this->validateFileRules($attribute, $value);
        }

        return array_merge($fieldErrors, $fileErrors ?? []);

The expression return array_merge($fieldErrors, $fileErrors ?? array()) returns the type array which is incompatible with the documented return type void.