Laravel-Backpack / CRUD

tests/Unit/CrudPanel/CrudPanelButtonsTest.php

Spacing +1 added lines, -1 removed lines

@@ -217,7 +217,7 @@
 
     private function getButtonByName($name)
     {
-        return $this->crudPanel->buttons->first(function ($value) use ($name) {
+        return $this->crudPanel->buttons->first(function($value) use ($name) {
             return $value->name == $name;
         });
     }

src/resources/views/columns/select_from_array.blade.php

Indentation +6 added lines, -6 removed lines

@@ -1,10 +1,10 @@
 {{-- select_from_array column --}}
 <td>
 	<?php
-		if ($entry->{$column['name']} !== null) {
-	    	echo $column['options'][$entry->{$column['name']}];
-	    } else {
-	    	echo "-";
-	    }
-	?>
+        if ($entry->{$column['name']} !== null) {
+            echo $column['options'][$entry->{$column['name']}];
+        } else {
+            echo "-";
+        }
+    ?>
 </td>

src/PanelTraits/Columns.php

Doc Comments +3 added lines, -2 removed lines

@@ -94,7 +94,7 @@ 
     /**
      * Move the most recently added column after the given target column.
      *
-     * @param string|array $targetColumn The target column name or array.
+     * @param string $targetColumn The target column name or array.
      */
     public function afterColumn($targetColumn)
     {
@@ -104,7 +104,7 @@ 
     /**
      * Move the most recently added column before the given target column.
      *
-     * @param string|array $targetColumn The target column name or array.
+     * @param string $targetColumn The target column name or array.
      */
     public function beforeColumn($targetColumn)
     {
@@ -227,6 +227,7 @@ 
      *
      * @param [string] Column name.
      * @param [attributes and values array]
+     * @param string $column
      */
     public function setColumnDetails($column, $attributes)
     {

Spacing +14 added lines, -15 removed lines

@@ -64,7 +64,7 @@ 
     public function addColumn($column)
     {
         // if a string was passed, not an array, change it to an array
-        if (! is_array($column)) {
+        if (!is_array($column)) {
             $column = ['name' => $column];
         }
 
@@ -72,7 +72,7 @@ 
         $column_with_details = $this->addDefaultLabel($column);
 
         // make sure the column has a name
-        if (! array_key_exists('name', $column_with_details)) {
+        if (!array_key_exists('name', $column_with_details)) {
             $column_with_details['name'] = 'anonymous_column_'.str_random(5);
         }
 
@@ -80,27 +80,27 @@ 
         $columnExistsInDb = $this->hasColumn($this->model->getTable(), $column_with_details['name']);
 
         // make sure the column has a type
-        if (! array_key_exists('type', $column_with_details)) {
+        if (!array_key_exists('type', $column_with_details)) {
             $column_with_details['type'] = 'text';
         }
 
         // make sure the column has a key
-        if (! array_key_exists('key', $column_with_details)) {
+        if (!array_key_exists('key', $column_with_details)) {
             $column_with_details['key'] = $column_with_details['name'];
         }
 
         // make sure the column has a tableColumn boolean
-        if (! array_key_exists('tableColumn', $column_with_details)) {
+        if (!array_key_exists('tableColumn', $column_with_details)) {
             $column_with_details['tableColumn'] = $columnExistsInDb ? true : false;
         }
 
         // make sure the column has a orderable boolean
-        if (! array_key_exists('orderable', $column_with_details)) {
+        if (!array_key_exists('orderable', $column_with_details)) {
             $column_with_details['orderable'] = $columnExistsInDb ? true : false;
         }
 
         // make sure the column has a searchLogic
-        if (! array_key_exists('searchLogic', $column_with_details)) {
+        if (!array_key_exists('searchLogic', $column_with_details)) {
             $column_with_details['searchLogic'] = $columnExistsInDb ? true : false;
         }
 
@@ -108,7 +108,7 @@ 
 
         // if this is a relation type field and no corresponding model was specified, get it from the relation method
         // defined in the main model
-        if (isset($column_with_details['entity']) && ! isset($column_with_details['model'])) {
+        if (isset($column_with_details['entity']) && !isset($column_with_details['model'])) {
             $column_with_details['model'] = $this->getRelationModel($column_with_details['entity']);
         }
 
@@ -162,8 +162,7 @@ 
         $targetColumnName = is_array($targetColumn) ? $targetColumn['name'] : $targetColumn;
 
         if (array_key_exists($targetColumnName, $this->columns)) {
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($this->columns)) :
-                array_search($targetColumnName, array_keys($this->columns)) + 1;
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($this->columns)) : array_search($targetColumnName, array_keys($this->columns)) + 1;
 
             $element = array_pop($this->columns);
             $beginningPart = array_slice($this->columns, 0, $targetColumnPosition, true);
@@ -197,7 +196,7 @@ 
      */
     public function addDefaultLabel($array)
     {
-        if (! array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
+        if (!array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
             $array = array_merge(['label' => ucfirst($this->makeLabel($array['name']))], $array);
 
             return $array;
@@ -223,7 +222,7 @@ 
      */
     public function removeColumns($columns)
     {
-        if (! empty($columns)) {
+        if (!empty($columns)) {
             foreach ($columns as $columnName) {
                 $this->removeColumn($columnName);
             }
@@ -244,8 +243,8 @@ 
      */
     public function remove($entity, $fields)
     {
-        return array_values(array_filter($this->{$entity}, function ($field) use ($fields) {
-            return ! in_array($field['name'], (array) $fields);
+        return array_values(array_filter($this->{$entity}, function($field) use ($fields) {
+            return !in_array($field['name'], (array) $fields);
         }));
     }
 
@@ -290,7 +289,7 @@ 
     {
         $columns = $this->getColumns();
 
-        return collect($columns)->pluck('entity')->reject(function ($value, $key) {
+        return collect($columns)->pluck('entity')->reject(function($value, $key) {
             return $value == null;
         })->toArray();
     }

src/PanelTraits/Fields.php

Spacing +11 added lines, -11 removed lines

@@ -26,28 +26,28 @@ 
 
         // if this is a relation type field and no corresponding model was specified, get it from the relation method
         // defined in the main model
-        if (isset($completeFieldsArray['entity']) && ! isset($completeFieldsArray['model'])) {
+        if (isset($completeFieldsArray['entity']) && !isset($completeFieldsArray['model'])) {
             $completeFieldsArray['model'] = $this->getRelationModel($completeFieldsArray['entity']);
         }
 
         // if the label is missing, we should set it
-        if (! isset($completeFieldsArray['label'])) {
+        if (!isset($completeFieldsArray['label'])) {
             $completeFieldsArray['label'] = ucfirst($completeFieldsArray['name']);
         }
 
         // if the field type is missing, we should set it
-        if (! isset($completeFieldsArray['type'])) {
+        if (!isset($completeFieldsArray['type'])) {
             $completeFieldsArray['type'] = $this->getFieldTypeFromDbColumnType($completeFieldsArray['name']);
         }
 
         // if a tab was mentioned, we should enable it
         if (isset($completeFieldsArray['tab'])) {
-            if (! $this->tabsEnabled()) {
+            if (!$this->tabsEnabled()) {
                 $this->enableTabs();
             }
         }
 
-        $this->transformFields($form, function ($fields) use ($completeFieldsArray) {
+        $this->transformFields($form, function($fields) use ($completeFieldsArray) {
             $fields[$completeFieldsArray['name']] = $completeFieldsArray;
 
             return $fields;
@@ -79,7 +79,7 @@ 
      */
     public function afterField($targetFieldName, $form = 'both')
     {
-        $this->transformFields($form, function ($fields) use ($targetFieldName) {
+        $this->transformFields($form, function($fields) use ($targetFieldName) {
             return $this->moveField($fields, $targetFieldName, false);
         });
     }
@@ -92,7 +92,7 @@ 
      */
     public function beforeField($targetFieldName, $form = 'both')
     {
-        $this->transformFields($form, function ($fields) use ($targetFieldName) {
+        $this->transformFields($form, function($fields) use ($targetFieldName) {
             return $this->moveField($fields, $targetFieldName, true);
         });
     }
@@ -134,7 +134,7 @@ 
      */
     public function removeField($name, $form = 'both')
     {
-        $this->transformFields($form, function ($fields) use ($name) {
+        $this->transformFields($form, function($fields) use ($name) {
             array_forget($fields, $name);
 
             return $fields;
@@ -149,7 +149,7 @@ 
      */
     public function removeFields($array_of_names, $form = 'both')
     {
-        if (! empty($array_of_names)) {
+        if (!empty($array_of_names)) {
             foreach ($array_of_names as $name) {
                 $this->removeField($name, $form);
             }
@@ -212,7 +212,7 @@ 
                 $jsonCastables = ['array', 'object', 'json'];
                 $fieldCasting = $casted_attributes[$field['name']];
 
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
                     try {
                         $data[$field['name']] = json_decode($data[$field['name']]);
                     } catch (\Exception $e) {
@@ -243,7 +243,7 @@ 
      */
     public function orderFields($order, $form = 'both')
     {
-        $this->transformFields($form, function ($fields) use ($order) {
+        $this->transformFields($form, function($fields) use ($order) {
             return $this->applyOrderToFields($fields, $order);
         });
     }

src/app/Http/Controllers/CrudController.php

Spacing +2 added lines, -2 removed lines

@@ -33,12 +33,12 @@
 
     public function __construct()
     {
-        if (! $this->crud) {
+        if (!$this->crud) {
             $this->crud = app()->make(CrudPanel::class);
 
             // call the setup function inside this closure to also have the request there
             // this way, developers can use things stored in session (auth variables, etc)
-            $this->middleware(function ($request, $next) {
+            $this->middleware(function($request, $next) {
                 $this->request = $request;
                 $this->crud->request = $request;
                 $this->setup();

Unused Use Statements +5 added lines, -8 removed lines

@@ -3,18 +3,15 @@
 namespace Backpack\CRUD\app\Http\Controllers;
 
 use Backpack\CRUD\CrudPanel;
-use Illuminate\Http\Request;
-use Illuminate\Http\Request as StoreRequest;
-use Illuminate\Support\Facades\Form as Form;
-use Illuminate\Foundation\Bus\DispatchesJobs;
-use Illuminate\Http\Request as UpdateRequest;
-use Illuminate\Routing\Controller as BaseController;
-use Illuminate\Foundation\Validation\ValidatesRequests;
-use Backpack\CRUD\app\Http\Controllers\CrudFeatures\Reorder;
 use Backpack\CRUD\app\Http\Controllers\CrudFeatures\AjaxTable;
+use Backpack\CRUD\app\Http\Controllers\CrudFeatures\Reorder;
 use Backpack\CRUD\app\Http\Controllers\CrudFeatures\Revisions;
 use Backpack\CRUD\app\Http\Controllers\CrudFeatures\SaveActions;
 use Backpack\CRUD\app\Http\Controllers\CrudFeatures\ShowDetailsRow;
+use Illuminate\Foundation\Bus\DispatchesJobs;
+use Illuminate\Foundation\Validation\ValidatesRequests;
+use Illuminate\Http\Request as UpdateRequest;
+use Illuminate\Routing\Controller as BaseController;
 
 class CrudController extends BaseController
 {

src/PanelTraits/Read.php

Spacing +2 added lines, -2 removed lines

@@ -19,7 +19,7 @@ 
      */
     public function getEntry($id)
     {
-        if (! $this->entry) {
+        if (!$this->entry) {
             $this->entry = $this->model->findOrFail($id);
             $this->entry = $this->entry->withFakes();
         }
@@ -94,7 +94,7 @@ 
     public function hasUploadFields($form, $id = false)
     {
         $fields = $this->getFields($form, $id);
-        $upload_fields = array_where($fields, function ($value, $key) {
+        $upload_fields = array_where($fields, function($value, $key) {
             return isset($value['upload']) && $value['upload'] == true;
         });
 

Doc Comments +2 added lines

@@ -89,6 +89,7 @@ 
      * Upload fields are the ones that have "upload" => true defined on them.
      * @param  [form] create / update / both - defaults to 'both'
      * @param  [id] id of the entity - defaults to false
+     * @param string $form
      * @return bool
      */
     public function hasUploadFields($form, $id = false)
@@ -122,6 +123,7 @@ 
 
     /**
      * Set the number of rows that should be show on the list view.
+     * @param integer $value
      */
     public function setDefaultPageLength($value)
     {

src/PanelTraits/Search.php

Indentation +3 added lines, -3 removed lines

@@ -116,9 +116,9 @@
         // add the details_row buttons as the first column
         if ($this->details_row) {
             array_unshift($row_items, \View::make('crud::columns.details_row_button')
-                                           ->with('crud', $this)
-                                           ->with('entry', $entry)
-                                           ->render());
+                                            ->with('crud', $this)
+                                            ->with('entry', $entry)
+                                            ->render());
         }
 
         return $row_items;

Spacing +4 added lines, -4 removed lines

@@ -19,9 +19,9 @@ 
      */
     public function applySearchTerm($searchTerm)
     {
-        return $this->query->where(function ($query) use ($searchTerm) {
+        return $this->query->where(function($query) use ($searchTerm) {
             foreach ($this->getColumns() as $column) {
-                if (! isset($column['type'])) {
+                if (!isset($column['type'])) {
                     abort(400, 'Missing column type when trying to apply search term.');
                 }
 
@@ -60,7 +60,7 @@ 
 
                 case 'select':
                 case 'select_multiple':
-                    $query->orWhereHas($column['entity'], function ($q) use ($column, $searchTerm) {
+                    $query->orWhereHas($column['entity'], function($q) use ($column, $searchTerm) {
                         $q->where($column['attribute'], 'like', '%'.$searchTerm.'%');
                     });
                     break;
@@ -133,7 +133,7 @@ 
     public function getCellView($column, $entry)
     {
         // if column type not set, show as text
-        if (! isset($column['type'])) {
+        if (!isset($column['type'])) {
             return \View::make('crud::columns.text')
                             ->with('crud', $this)
                             ->with('column', $column)

src/PanelTraits/AutoSet.php

Spacing +7 added lines, -7 removed lines

@@ -22,7 +22,7 @@ 
         $this->setDoctrineTypesMapping();
         $this->getDbColumnTypes();
 
-        array_map(function ($field) {
+        array_map(function($field) {
             $new_field = [
                 'name'       => $field,
                 'label'      => $this->makeLabel($field),
@@ -33,14 +33,14 @@ 
                 'attributes' => [],
                 'autoset'    => true,
             ];
-            if (! isset($this->create_fields[$field])) {
+            if (!isset($this->create_fields[$field])) {
                 $this->create_fields[$field] = $new_field;
             }
-            if (! isset($this->update_fields[$field])) {
+            if (!isset($this->update_fields[$field])) {
                 $this->update_fields[$field] = $new_field;
             }
 
-            if (! in_array($field, $this->model->getHidden()) && ! isset($this->columns[$field])) {
+            if (!in_array($field, $this->model->getHidden()) && !isset($this->columns[$field])) {
                 $this->addColumn([
                     'name'  => $field,
                     'label' => $this->makeLabel($field),
@@ -80,7 +80,7 @@ 
      */
     public function getFieldTypeFromDbColumnType($field)
     {
-        if (! array_key_exists($field, $this->db_column_types)) {
+        if (!array_key_exists($field, $this->db_column_types)) {
             return 'text';
         }
 
@@ -147,7 +147,7 @@ 
         $types = ['enum' => 'string'];
         $platform = \DB::getDoctrineConnection()->getDatabasePlatform();
         foreach ($types as $type_key => $type_value) {
-            if (! $platform->hasDoctrineTypeMappingFor($type_key)) {
+            if (!$platform->hasDoctrineTypeMappingFor($type_key)) {
                 $platform->registerDoctrineTypeMapping($type_key, $type_value);
             }
         }
@@ -202,7 +202,7 @@ 
         $columns = $this->model->getConnection()->getSchemaBuilder()->getColumnListing($this->model->getTable());
         $fillable = $this->model->getFillable();
 
-        if (! empty($fillable)) {
+        if (!empty($fillable)) {
             $columns = array_intersect($columns, $fillable);
         }