Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — crud-uploads ( 434478...b85d8a )
by Pedro
13:34
created
src/app/Library/CrudPanel/Traits/Buttons.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
         $otherButtons = collect([]);
26 26
 
27 27
         // we get the buttons that belong to the specified stack
28
-        $stackButtons = $this->buttons()->reject(function ($item) use ($stack, $otherButtons) {
28
+        $stackButtons = $this->buttons()->reject(function($item) use ($stack, $otherButtons) {
29 29
             if ($item->stack != $stack) {
30 30
                 // if the button does not belong to this stack we just add it for merging later
31 31
                 $otherButtons->push($item);
@@ -37,8 +37,8 @@  discard block
 block discarded – undo
37 37
         });
38 38
 
39 39
         // we parse the ordered buttons
40
-        collect($order)->each(function ($btnKey) use ($newButtons, $stackButtons) {
41
-            if (! $button = $stackButtons->where('name', $btnKey)->first()) {
40
+        collect($order)->each(function($btnKey) use ($newButtons, $stackButtons) {
41
+            if (!$button = $stackButtons->where('name', $btnKey)->first()) {
42 42
                 abort(500, 'Button name [«'.$btnKey.'»] not found.');
43 43
             }
44 44
             $newButtons->push($button);
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
         // we add the remaining buttons to the end of the ordered ones
49 49
         if (count($newButtons) < count($stackButtons)) {
50 50
             foreach ($stackButtons as $button) {
51
-                if (! $newButtons->where('name', $button->name)->first()) {
51
+                if (!$newButtons->where('name', $button->name)->first()) {
52 52
                     $newButtons->push($button);
53 53
                 }
54 54
             }
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
          */
115 115
         $button = $this->buttons()->firstWhere('name', $name);
116 116
 
117
-        if (! $button) {
117
+        if (!$button) {
118 118
             abort(500, 'CRUD Button "'.$name.'" not found. Please check the button exists before you modify it.');
119 119
         }
120 120
 
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
      */
136 136
     public function removeButton($name, $stack = null)
137 137
     {
138
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
138
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
139 139
             return $stack == null ? $button->name == $name : ($button->stack == $stack) && ($button->name == $name);
140 140
         }));
141 141
     }
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
      */
147 147
     public function removeButtons($names, $stack = null)
148 148
     {
149
-        if (! empty($names)) {
149
+        if (!empty($names)) {
150 150
             foreach ($names as $name) {
151 151
                 $this->removeButton($name, $stack);
152 152
             }
@@ -160,14 +160,14 @@  discard block
 block discarded – undo
160 160
 
161 161
     public function removeAllButtonsFromStack($stack)
162 162
     {
163
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($stack) {
163
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($stack) {
164 164
             return $button->stack == $stack;
165 165
         }));
166 166
     }
167 167
 
168 168
     public function removeButtonFromStack($name, $stack)
169 169
     {
170
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
170
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
171 171
             return $button->name == $name && $button->stack == $stack;
172 172
         }));
173 173
     }
@@ -185,15 +185,15 @@  discard block
 block discarded – undo
185 185
         $destinationButton = $this->firstButtonWhere('name', $destination);
186 186
         $destinationKey = $this->getButtonKey($destination);
187 187
         $newDestinationKey = ($where == 'before' ? $destinationKey : $destinationKey + 1);
188
-        $newButtons = $this->buttons()->filter(function ($value, $key) use ($target) {
188
+        $newButtons = $this->buttons()->filter(function($value, $key) use ($target) {
189 189
             return $value->name != $target;
190 190
         });
191 191
 
192
-        if (! $targetButton) {
192
+        if (!$targetButton) {
193 193
             return;
194 194
         }
195 195
 
196
-        if (! $destinationButton) {
196
+        if (!$destinationButton) {
197 197
             return;
198 198
         }
199 199
 
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
         $lastSlice = $newButtons->slice($newDestinationKey, null);
202 202
 
203 203
         $newButtons = $firstSlice->push($targetButton);
204
-        $lastSlice->each(function ($item, $key) use ($newButtons) {
204
+        $lastSlice->each(function($item, $key) use ($newButtons) {
205 205
             $newButtons->push($item);
206 206
         });
207 207
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Filters.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
         $this->enableFilters();
73 73
 
74 74
         // check if another filter with the same name exists
75
-        if (! isset($options['name'])) {
75
+        if (!isset($options['name'])) {
76 76
             abort(500, 'All your filters need names.');
77 77
         }
78 78
 
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
     {
121 121
         $unappliedFilters = $this->filters()->where('applied', false);
122 122
         if ($unappliedFilters->count()) {
123
-            $unappliedFilters->each(function ($filter) {
123
+            $unappliedFilters->each(function($filter) {
124 124
                 $filter->apply();
125 125
             });
126 126
         }
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
     {
171 171
         $filter = $this->filters()->firstWhere('name', $name);
172 172
 
173
-        if (! $filter) {
173
+        if (!$filter) {
174 174
             abort(500, 'CRUD Filter "'.$name.'" not found. Please check the filter exists before you modify it.');
175 175
         }
176 176
 
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 
186 186
     public function replaceFilter($name, $newFilter)
187 187
     {
188
-        $newFilters = $this->filters()->map(function ($filter, $key) use ($name, $newFilter) {
188
+        $newFilters = $this->filters()->map(function($filter, $key) use ($name, $newFilter) {
189 189
             if ($filter->name != $name) {
190 190
                 return $filter;
191 191
             }
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
198 198
 
199 199
     public function removeFilter($name)
200 200
     {
201
-        $strippedCollection = $this->filters()->reject(function ($filter) use ($name) {
201
+        $strippedCollection = $this->filters()->reject(function($filter) use ($name) {
202 202
             return $filter->name == $name;
203 203
         });
204 204
 
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
      */
242 242
     public function makeFirstFilter()
243 243
     {
244
-        if (! $this->filters()) {
244
+        if (!$this->filters()) {
245 245
             return false;
246 246
         }
247 247
 
@@ -271,15 +271,15 @@  discard block
 block discarded – undo
271 271
         $destinationFilter = $this->firstFilterWhere('name', $destination);
272 272
         $destinationKey = $this->getFilterKey($destination);
273 273
         $newDestinationKey = ($where == 'before' ? $destinationKey : $destinationKey + 1);
274
-        $newFilters = $this->filters()->filter(function ($value, $key) use ($target) {
274
+        $newFilters = $this->filters()->filter(function($value, $key) use ($target) {
275 275
             return $value->name != $target;
276 276
         });
277 277
 
278
-        if (! $targetFilter) {
278
+        if (!$targetFilter) {
279 279
             return;
280 280
         }
281 281
 
282
-        if (! $destinationFilter) {
282
+        if (!$destinationFilter) {
283 283
             return;
284 284
         }
285 285
 
@@ -287,7 +287,7 @@  discard block
 block discarded – undo
287 287
         $lastSlice = $newFilters->slice($newDestinationKey, null);
288 288
 
289 289
         $newFilters = $firstSlice->push($targetFilter);
290
-        $lastSlice->each(function ($item, $key) use ($newFilters) {
290
+        $lastSlice->each(function($item, $key) use ($newFilters) {
291 291
             $newFilters->push($item);
292 292
         });
293 293
 
Please login to merge, or discard this patch.
src/routes/backpack/custom.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,5 +13,5 @@
 block discarded – undo
13 13
         (array) config('backpack.base.middleware_key', 'admin')
14 14
     ),
15 15
     'namespace'  => 'App\Http\Controllers\Admin',
16
-], function () { // custom admin routes
16
+], function() { // custom admin routes
17 17
 }); // this should be the absolute last line of this file
Please login to merge, or discard this patch.
config/database/migrations/2017_09_08_000001_create_addresses_table.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
      */
14 14
     public function up()
15 15
     {
16
-        Schema::create('addresses', function (Blueprint $table) {
16
+        Schema::create('addresses', function(Blueprint $table) {
17 17
             $table->increments('id');
18 18
             $table->integer('account_details_id')->unsigned();
19 19
             $table->string('city')->nullable();
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php 1 patch
Spacing   +7 added lines, -8 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
             $column = ['name' => $column];
50 50
         }
51 51
 
52
-        if (is_array($column) && ! isset($column['name'])) {
52
+        if (is_array($column) && !isset($column['name'])) {
53 53
             $column['name'] = 'anonymous_column_'.Str::random(5);
54 54
         }
55 55
 
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      */
66 66
     protected function makeSureColumnHasLabel($column)
67 67
     {
68
-        if (! isset($column['label'])) {
68
+        if (!isset($column['label'])) {
69 69
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
70 70
         }
71 71
 
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
      */
147 147
     protected function makeSureColumnHasKey($column)
148 148
     {
149
-        if (! isset($column['key'])) {
149
+        if (!isset($column['key'])) {
150 150
             $column['key'] = str_replace('.', '__', $column['name']);
151 151
         }
152 152
 
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
      */
165 165
     protected function makeSureColumnHasWrapper($column)
166 166
     {
167
-        if (! isset($column['wrapper'])) {
167
+        if (!isset($column['wrapper'])) {
168 168
             $column['wrapper'] = [];
169 169
         }
170 170
 
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
     {
256 256
         // if this is a relation type field and no corresponding model was specified,
257 257
         // get it from the relation method defined in the main model
258
-        if (isset($column['entity']) && $column['entity'] !== false && ! isset($column['model'])) {
258
+        if (isset($column['entity']) && $column['entity'] !== false && !isset($column['model'])) {
259 259
             $column['model'] = $this->getRelationModel($column['entity']);
260 260
         }
261 261
 
@@ -276,8 +276,7 @@  discard block
 block discarded – undo
276 276
         $columnsArray = $this->columns();
277 277
 
278 278
         if (array_key_exists($targetColumnName, $columnsArray)) {
279
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
280
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
279
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
281 280
 
282 281
             $element = array_pop($columnsArray);
283 282
             $beginningPart = array_slice($columnsArray, 0, $targetColumnPosition, true);
@@ -299,7 +298,7 @@  discard block
 block discarded – undo
299 298
     {
300 299
         static $cache = [];
301 300
 
302
-        if (! $this->driverIsSql()) {
301
+        if (!$this->driverIsSql()) {
303 302
             return true;
304 303
         }
305 304
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ShowOperation.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -30,25 +30,25 @@
 block discarded – undo
30 30
         $this->crud->allowAccess('show');
31 31
         $this->crud->setOperationSetting('setFromDb', true);
32 32
 
33
-        $this->crud->operation('show', function () {
33
+        $this->crud->operation('show', function() {
34 34
             $this->crud->loadDefaultOperationSettingsFromConfig();
35 35
 
36
-            if (! method_exists($this, 'setupShowOperation')) {
36
+            if (!method_exists($this, 'setupShowOperation')) {
37 37
                 $this->autoSetupShowOperation();
38 38
             }
39 39
         });
40 40
 
41
-        $this->crud->operation('list', function () {
41
+        $this->crud->operation('list', function() {
42 42
             $this->crud->addButton('line', 'show', 'view', 'crud::buttons.show', 'beginning');
43 43
         });
44 44
 
45
-        $this->crud->operation(['create', 'update'], function () {
45
+        $this->crud->operation(['create', 'update'], function() {
46 46
             $this->crud->addSaveAction([
47 47
                 'name' => 'save_and_preview',
48
-                'visible' => function ($crud) {
48
+                'visible' => function($crud) {
49 49
                     return $crud->hasAccess('show');
50 50
                 },
51
-                'redirect' => function ($crud, $request, $itemId = null) {
51
+                'redirect' => function($crud, $request, $itemId = null) {
52 52
                     $itemId = $itemId ?: $request->input('id');
53 53
                     $redirectUrl = $crud->route.'/'.$itemId.'/show';
54 54
                     if ($request->has('_locale')) {
Please login to merge, or discard this patch.
database/migrations/2020_03_31_114745_create_pivotable_relations_tables.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -13,14 +13,14 @@  discard block
 block discarded – undo
13 13
      */
14 14
     public function up()
15 15
     {
16
-        Schema::create('comments', function (Blueprint $table) {
16
+        Schema::create('comments', function(Blueprint $table) {
17 17
             $table->bigIncrements('id');
18 18
             $table->string('text')->nullable();
19 19
             $table->morphs('commentable');
20 20
             $table->timestamps();
21 21
         });
22 22
 
23
-        Schema::create('recommendables', function (Blueprint $table) {
23
+        Schema::create('recommendables', function(Blueprint $table) {
24 24
             $table->bigIncrements('id');
25 25
             $table->string('text')->nullable();
26 26
             $table->morphs('recommendable');
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
             $table->timestamps();
29 29
         });
30 30
 
31
-        Schema::create('billables', function (Blueprint $table) {
31
+        Schema::create('billables', function(Blueprint $table) {
32 32
             $table->bigIncrements('id');
33 33
             $table->string('text')->nullable();
34 34
             $table->morphs('billable');
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
             $table->timestamps();
37 37
         });
38 38
 
39
-        Schema::create('articles_user', function (Blueprint $table) {
39
+        Schema::create('articles_user', function(Blueprint $table) {
40 40
             $table->increments('id');
41 41
             $table->integer('article_id')->unsigned();
42 42
             $table->integer('user_id')->unsigned();
@@ -46,26 +46,26 @@  discard block
 block discarded – undo
46 46
             $table->nullableTimestamps();
47 47
         });
48 48
 
49
-        Schema::create('recommends', function (Blueprint $table) {
49
+        Schema::create('recommends', function(Blueprint $table) {
50 50
             $table->bigIncrements('id');
51 51
             $table->string('title')->nullable();
52 52
             $table->timestamps();
53 53
         });
54 54
 
55
-        Schema::create('bills', function (Blueprint $table) {
55
+        Schema::create('bills', function(Blueprint $table) {
56 56
             $table->bigIncrements('id');
57 57
             $table->string('title')->nullable();
58 58
             $table->timestamps();
59 59
         });
60 60
 
61
-        Schema::create('stars', function (Blueprint $table) {
61
+        Schema::create('stars', function(Blueprint $table) {
62 62
             $table->bigIncrements('id');
63 63
             $table->string('starable_type');
64 64
             $table->bigInteger('starable_id');
65 65
             $table->string('title')->nullable();
66 66
         });
67 67
 
68
-        Schema::create('universes', function (Blueprint $table) {
68
+        Schema::create('universes', function(Blueprint $table) {
69 69
             $table->bigIncrements('id');
70 70
             $table->bigInteger('user_id');
71 71
             $table->string('title')->nullable();
@@ -73,13 +73,13 @@  discard block
 block discarded – undo
73 73
             $table->date('end_date')->nullable();
74 74
         });
75 75
 
76
-        Schema::create('planets', function (Blueprint $table) {
76
+        Schema::create('planets', function(Blueprint $table) {
77 77
             $table->bigIncrements('id');
78 78
             $table->bigInteger('user_id')->nullable();
79 79
             $table->string('title')->nullable();
80 80
         });
81 81
 
82
-        Schema::create('transactions', function (Blueprint $table) {
82
+        Schema::create('transactions', function(Blueprint $table) {
83 83
             $table->bigIncrements('id')->unique();
84 84
             $table->bigInteger('user_id');
85 85
             $table->string('label')->nullable();
@@ -87,29 +87,29 @@  discard block
 block discarded – undo
87 87
             $table->string('type');
88 88
         });
89 89
 
90
-        Schema::create('planets_non_nullable', function (Blueprint $table) {
90
+        Schema::create('planets_non_nullable', function(Blueprint $table) {
91 91
             $table->bigIncrements('id');
92 92
             $table->bigInteger('user_id');
93 93
             $table->string('title')->nullable();
94 94
         });
95 95
 
96
-        Schema::create('comets', function (Blueprint $table) {
96
+        Schema::create('comets', function(Blueprint $table) {
97 97
             $table->bigIncrements('id');
98 98
             $table->bigInteger('user_id')->default(0);
99 99
         });
100 100
 
101
-        Schema::create('bangs', function (Blueprint $table) {
101
+        Schema::create('bangs', function(Blueprint $table) {
102 102
             $table->bigIncrements('id');
103 103
             $table->string('name');
104 104
         });
105 105
 
106
-        Schema::create('account_details_bang', function (Blueprint $table) {
106
+        Schema::create('account_details_bang', function(Blueprint $table) {
107 107
             $table->bigIncrements('id');
108 108
             $table->bigInteger('account_details_id');
109 109
             $table->bigInteger('bang_id');
110 110
         });
111 111
 
112
-        Schema::create('account_details_bangs_pivot', function (Blueprint $table) {
112
+        Schema::create('account_details_bangs_pivot', function(Blueprint $table) {
113 113
             $table->bigIncrements('id');
114 114
             $table->bigInteger('account_details_id');
115 115
             $table->bigInteger('bang_id');
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelReadTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -284,7 +284,7 @@  discard block
 block discarded – undo
284 284
 
285 285
     public function testEnableDetailsRow()
286 286
     {
287
-        if (! backpack_pro()) {
287
+        if (!backpack_pro()) {
288 288
             $this->expectException(\Backpack\CRUD\app\Exceptions\BackpackProRequiredException::class);
289 289
         }
290 290
 
@@ -319,7 +319,7 @@  discard block
 block discarded – undo
319 319
 
320 320
     public function testEnableExportButtons()
321 321
     {
322
-        if (! backpack_pro()) {
322
+        if (!backpack_pro()) {
323 323
             $this->expectException(\Backpack\CRUD\app\Exceptions\BackpackProRequiredException::class);
324 324
         }
325 325
 
Please login to merge, or discard this patch.
src/app/Console/Commands/Install.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
         $this->closeProgressBlock();
79 79
 
80 80
         // Optional commands
81
-        if (! $this->option('no-interaction')) {
81
+        if (!$this->option('no-interaction')) {
82 82
             // Create users
83 83
             $this->createUsers();
84 84
 
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
 
154 154
         $this->deleteLines(3);
155 155
 
156
-        if (! $total) {
156
+        if (!$total) {
157 157
             $this->deleteLines();
158 158
             $this->note('Skipping creating an admin user.');
159 159
             $this->newLine();
@@ -162,14 +162,14 @@  discard block
 block discarded – undo
162 162
 
163 163
     private function isEveryAddonInstalled()
164 164
     {
165
-        return collect($this->addons)->every(function ($addon) {
165
+        return collect($this->addons)->every(function($addon) {
166 166
             return file_exists($addon->path);
167 167
         });
168 168
     }
169 169
 
170 170
     private function updateAddonsStatus()
171 171
     {
172
-        $this->addons = $this->addons->each(function (&$addon) {
172
+        $this->addons = $this->addons->each(function(&$addon) {
173 173
             $isInstalled = file_exists($addon->path);
174 174
             $addon->status = $isInstalled ? 'installed' : 'not installed';
175 175
             $addon->statusColor = $isInstalled ? 'green' : 'yellow';
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
180 180
     {
181 181
         // map the addons
182 182
         $this->addons = collect($this->addons)
183
-            ->map(function ($class) {
183
+            ->map(function($class) {
184 184
                 return (object) $class::$addon;
185 185
             });
186 186
 
@@ -199,15 +199,15 @@  discard block
 block discarded – undo
199 199
 
200 200
         // Calculate the printed line count
201 201
         $printedLines = $this->addons
202
-            ->map(function ($e) {
202
+            ->map(function($e) {
203 203
                 return count($e->description);
204 204
             })
205
-            ->reduce(function ($sum, $item) {
205
+            ->reduce(function($sum, $item) {
206 206
                 return $sum + $item + 2;
207 207
             }, 0);
208 208
 
209 209
         $total = 0;
210
-        while (! $this->isEveryAddonInstalled()) {
210
+        while (!$this->isEveryAddonInstalled()) {
211 211
             $input = (int) $this->listChoice('Would you like to install a premium Backpack add-on? <fg=gray>(enter option number)</>', $this->addons->toArray());
212 212
 
213 213
             if ($input < 1 || $input > $this->addons->count()) {
Please login to merge, or discard this patch.