Backpack\CRUD\app\Library\Uploaders\SingleFile

Complexity

Total Complexity

16

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	uploadFile()	0	23	8
B	uploadRepeatableFile()	0	25	8

<?php

namespace Backpack\CRUD\app\Library\Uploaders;

use Backpack\CRUD\app\Library\CrudPanel\CrudPanelFacade;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Facades\Storage;

class SingleFile extends Uploader
{
    public function uploadRepeatableFile(Model $entry, $values = null)
    {
        $orderedFiles = $this->getFileOrderFromRequest();
        $previousFiles = $this->getPreviousRepeatableValues($entry);

        foreach ($values as $row => $file) {
            if ($file && is_file($file) && $file->isValid()) {
                $fileName = $this->getFileName($file);

                $file->storeAs($this->getPath(), $fileName, $this->getDisk());

                $orderedFiles[$row] = $this->getPath().$fileName;

                continue;
            }
        }

        foreach ($previousFiles as $row => $file) {
            if ($file && ! isset($orderedFiles[$row])) {
                $orderedFiles[$row] = null;
                Storage::disk($this->getDisk())->delete($file);
            }
        }

        return $orderedFiles;
    }

    public function uploadFile(Model $entry, $value = null)
    {
        $value = $value ?? CrudPanelFacade::getRequest()->file($this->getName());

The method getRequest() does not exist on Backpack\CRUD\app\Library\CrudPanel\CrudPanelFacade. Since you implemented __callStatic, consider adding a @method annotation.

        $previousFile = $entry->getOriginal($this->getName());

        if ($value && is_file($value) && $value->isValid()) {
            if ($previousFile) {
                Storage::disk($this->getDisk())->delete($previousFile);
            }
            $fileName = $this->getFileName($value);

            $value->storeAs($this->getPath(), $fileName, $this->getDisk());

            return $this->getPath().$fileName;

The expression return $this->getPath() . $fileName returns the type string which is incompatible with the return type mandated by Backpack\CRUD\app\Library\Uploaders\Support\Interfaces\UploaderInterface::uploadFile() of void.

        }

        if (! $value && CrudPanelFacade::getRequest()->has($this->getName()) && $previousFile) {
            Storage::disk($this->getDisk())->delete($previousFile);

            return null;
        }

        return $previousFile;

The expression return $previousFile also could return the type array which is incompatible with the return type mandated by Backpack\CRUD\app\Library\Uploaders\Support\Interfaces\UploaderInterface::uploadFile() of void.

    }
}