Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#890)
by Oliver
08:16
created
src/PanelTraits/Tabs.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 
30 30
     public function tabsDisabled()
31 31
     {
32
-        return ! $this->tabsEnabled;
32
+        return !$this->tabsEnabled;
33 33
     }
34 34
 
35 35
     public function setTabsType($type)
@@ -92,13 +92,13 @@  discard block
 block discarded – undo
92 92
         if ($this->tabExists($label)) {
93 93
             $all_fields = $this->getCurrentFields();
94 94
 
95
-            $fields_for_current_tab = collect($all_fields)->filter(function ($value, $key) use ($label) {
95
+            $fields_for_current_tab = collect($all_fields)->filter(function($value, $key) use ($label) {
96 96
                 return isset($value['tab']) && $value['tab'] == $label;
97 97
             });
98 98
 
99 99
             if ($this->isLastTab($label)) {
100
-                $fields_without_a_tab = collect($all_fields)->filter(function ($value, $key) {
101
-                    return ! isset($value['tab']);
100
+                $fields_without_a_tab = collect($all_fields)->filter(function($value, $key) {
101
+                    return !isset($value['tab']);
102 102
                 });
103 103
 
104 104
                 $fields_for_current_tab = $fields_for_current_tab->merge($fields_without_a_tab);
@@ -116,11 +116,11 @@  discard block
 block discarded – undo
116 116
         $fields = $this->getCurrentFields();
117 117
 
118 118
         $fields_with_tabs = collect($fields)
119
-            ->filter(function ($value, $key) {
119
+            ->filter(function($value, $key) {
120 120
                 return isset($value['tab']);
121 121
             })
122
-            ->each(function ($value, $key) use (&$tabs) {
123
-                if (! in_array($value['tab'], $tabs)) {
122
+            ->each(function($value, $key) use (&$tabs) {
123
+                if (!in_array($value['tab'], $tabs)) {
124 124
                     $tabs[] = $value['tab'];
125 125
                 }
126 126
             });
Please login to merge, or discard this patch.
src/PanelTraits/Read.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
      */
20 20
     public function getEntry($id)
21 21
     {
22
-        if (! $this->entry) {
22
+        if (!$this->entry) {
23 23
             $this->entry = $this->model->findOrFail($id);
24 24
             $this->entry = $this->entry->withFakes();
25 25
         }
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
     public function hasUploadFields($form, $id = false)
95 95
     {
96 96
         $fields = $this->getFields($form, $id);
97
-        $upload_fields = array_where($fields, function ($value, $key) {
97
+        $upload_fields = array_where($fields, function($value, $key) {
98 98
             return isset($value['upload']) && $value['upload'] == true;
99 99
         });
100 100
 
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
      */
193 193
     public function getCellView($column, $entry)
194 194
     {
195
-        if (! isset($column['type'])) {
195
+        if (!isset($column['type'])) {
196 196
             return \View::make('crud::columns.text')->with('crud', $this)->with('column', $column)->with('entry', $entry)->render();
197 197
         } else {
198 198
             if (view()->exists('vendor.backpack.crud.columns.'.$column['type'])) {
Please login to merge, or discard this patch.
src/PanelTraits/AutoSet.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
     {
17 17
         $this->getDbColumnTypes();
18 18
 
19
-        array_map(function ($field) {
19
+        array_map(function($field) {
20 20
             // $this->labels[$field] = $this->makeLabel($field);
21 21
 
22 22
             $new_field = [
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
             $this->create_fields[$field] = $new_field;
31 31
             $this->update_fields[$field] = $new_field;
32 32
 
33
-            if (! in_array($field, $this->model->getHidden())) {
33
+            if (!in_array($field, $this->model->getHidden())) {
34 34
                 $this->columns[] = [
35 35
                     'name'  => $field,
36 36
                     'label' => ucfirst($field),
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
      */
68 68
     public function getFieldTypeFromDbColumnType($field)
69 69
     {
70
-        if (! array_key_exists($field, $this->db_column_types)) {
70
+        if (!array_key_exists($field, $this->db_column_types)) {
71 71
             return 'text';
72 72
         }
73 73
 
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
         $columns = $this->model->getConnection()->getSchemaBuilder()->getColumnListing($this->model->getTable());
149 149
         $fillable = $this->model->getFillable();
150 150
 
151
-        if (! empty($fillable)) {
151
+        if (!empty($fillable)) {
152 152
             $columns = array_intersect($columns, $fillable);
153 153
         }
154 154
 
Please login to merge, or discard this patch.
src/PanelTraits/Fields.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -25,23 +25,23 @@  discard block
 block discarded – undo
25 25
 
26 26
         // if this is a relation type field and no corresponding model was specified, get it from the relation method
27 27
         // defined in the main model
28
-        if (isset($complete_field_array['entity']) && ! isset($complete_field_array['model'])) {
28
+        if (isset($complete_field_array['entity']) && !isset($complete_field_array['model'])) {
29 29
             $complete_field_array['model'] = $this->getRelationModel($complete_field_array['entity']);
30 30
         }
31 31
 
32 32
         // if the label is missing, we should set it
33
-        if (! isset($complete_field_array['label'])) {
33
+        if (!isset($complete_field_array['label'])) {
34 34
             $complete_field_array['label'] = ucfirst($complete_field_array['name']);
35 35
         }
36 36
 
37 37
         // if the field type is missing, we should set it
38
-        if (! isset($complete_field_array['type'])) {
38
+        if (!isset($complete_field_array['type'])) {
39 39
             $complete_field_array['type'] = $this->getFieldTypeFromDbColumnType($complete_field_array['name']);
40 40
         }
41 41
 
42 42
         // if a tab was mentioned, we should enable it
43 43
         if (isset($complete_field_array['tab'])) {
44
-            if (! $this->tabsEnabled()) {
44
+            if (!$this->tabsEnabled()) {
45 45
                 $this->enableTabs();
46 46
             }
47 47
         }
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
      */
155 155
     public function removeFields($array_of_names, $form = 'both')
156 156
     {
157
-        if (! empty($array_of_names)) {
157
+        if (!empty($array_of_names)) {
158 158
             foreach ($array_of_names as $name) {
159 159
                 $this->removeField($name, $form);
160 160
             }
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
                 $jsonCastables = ['array', 'object', 'json'];
219 219
                 $fieldCasting = $casted_attributes[$field['name']];
220 220
 
221
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
221
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
222 222
                     try {
223 223
                         $data[$field['name']] = json_decode($data[$field['name']]);
224 224
                     } catch (Exception $e) {
Please login to merge, or discard this patch.
src/PanelTraits/Columns.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
     public function addColumn($column)
55 55
     {
56 56
         // if a string was passed, not an array, change it to an array
57
-        if (! is_array($column)) {
57
+        if (!is_array($column)) {
58 58
             $column = ['name' => $column];
59 59
         }
60 60
 
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
         $column_with_details = $this->addDefaultLabel($column);
63 63
 
64 64
         // make sure the column has a name
65
-        if (! array_key_exists('name', $column_with_details)) {
65
+        if (!array_key_exists('name', $column_with_details)) {
66 66
             $column_with_details['name'] = 'anonymous_column_'.str_random(5);
67 67
         }
68 68
 
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 
71 71
         // if this is a relation type field and no corresponding model was specified, get it from the relation method
72 72
         // defined in the main model
73
-        if (isset($column_with_details['entity']) && ! isset($column_with_details['model'])) {
73
+        if (isset($column_with_details['entity']) && !isset($column_with_details['model'])) {
74 74
             $column_with_details['model'] = $this->getRelationModel($column_with_details['entity']);
75 75
         }
76 76
 
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
      */
148 148
     public function addDefaultLabel($array)
149 149
     {
150
-        if (! array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
150
+        if (!array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
151 151
             $array = array_merge(['label' => ucfirst($this->makeLabel($array['name']))], $array);
152 152
 
153 153
             return $array;
@@ -181,8 +181,8 @@  discard block
 block discarded – undo
181 181
      */
182 182
     public function remove($entity, $fields)
183 183
     {
184
-        return array_values(array_filter($this->{$entity}, function ($field) use ($fields) {
185
-            return ! in_array($field['name'], (array) $fields);
184
+        return array_values(array_filter($this->{$entity}, function($field) use ($fields) {
185
+            return !in_array($field['name'], (array) $fields);
186 186
         }));
187 187
     }
188 188
 
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
     {
234 234
         $columns = $this->getColumns();
235 235
 
236
-        return collect($columns)->pluck('entity')->reject(function ($value, $key) {
236
+        return collect($columns)->pluck('entity')->reject(function($value, $key) {
237 237
             return $value == null;
238 238
         })->toArray();
239 239
     }
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudFeatures/AjaxTable.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
 
15 15
         // create an array with the names of the searchable columns
16 16
         $columns = collect($this->crud->columns)
17
-                    ->reject(function ($column, $key) {
17
+                    ->reject(function($column, $key) {
18 18
                         // the select_multiple, model_function and model_function_attribute columns are not searchable
19 19
                         return isset($column['type']) && ($column['type'] == 'select_multiple' || $column['type'] == 'model_function' || $column['type'] == 'model_function_attribute');
20 20
                     })
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
         $dataTable = new \LiveControl\EloquentDataTable\DataTable($this->crud->query, $columns);
30 30
 
31 31
         // make the datatable use the column types instead of just echoing the text
32
-        $dataTable->setFormatRowFunction(function ($entry) {
32
+        $dataTable->setFormatRowFunction(function($entry) {
33 33
             // get the actual HTML for each row's cell
34 34
             $row_items = $this->crud->getRowViews($entry, $this->crud);
35 35
 
Please login to merge, or discard this patch.