Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#1687)
by Cristian
03:56
created
src/ModelTraits/SpatieTranslatable/SlugService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
      */
50 50
     protected function makeSlugUnique(string $slug, array $config, string $attribute): string
51 51
     {
52
-        if (! $config['unique']) {
52
+        if (!$config['unique']) {
53 53
             return $slug;
54 54
         }
55 55
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,12 +33,12 @@
 block discarded – undo
33 33
 
34 34
     public function __construct()
35 35
     {
36
-        if (! $this->crud) {
36
+        if (!$this->crud) {
37 37
             $this->crud = app()->make(CrudPanel::class);
38 38
 
39 39
             // call the setup function inside this closure to also have the request there
40 40
             // this way, developers can use things stored in session (auth variables, etc)
41
-            $this->middleware(function ($request, $next) {
41
+            $this->middleware(function($request, $next) {
42 42
                 $this->request = $request;
43 43
                 $this->crud->request = $request;
44 44
                 $this->setup();
Please login to merge, or discard this patch.
src/PanelTraits/FakeFields.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
                 $fakeFieldKey = isset($field['store_in']) ? $field['store_in'] : 'extras';
30 30
                 $this->addCompactedField($requestInput, $field['name'], $fakeFieldKey);
31 31
 
32
-                if (! in_array($fakeFieldKey, $compactedFakeFields)) {
32
+                if (!in_array($fakeFieldKey, $compactedFakeFields)) {
33 33
                     $compactedFakeFields[] = $fakeFieldKey;
34 34
                 }
35 35
             }
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
 
38 38
         // json_encode all fake_value columns if applicable in the database, so they can be properly stored and interpreted
39 39
         foreach ($compactedFakeFields as $value) {
40
-            if (! (property_exists($this->model, 'translatable') && in_array($value, $this->model->getTranslatableAttributes(), true)) && $this->model->shouldEncodeFake($value)) {
40
+            if (!(property_exists($this->model, 'translatable') && in_array($value, $this->model->getTranslatableAttributes(), true)) && $this->model->shouldEncodeFake($value)) {
41 41
                 $requestInput[$value] = json_encode($requestInput[$value]);
42 42
             }
43 43
         }
Please login to merge, or discard this patch.
src/PanelTraits/AutoSet.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
         $this->setDoctrineTypesMapping();
23 23
         $this->getDbColumnTypes();
24 24
 
25
-        array_map(function ($field) {
25
+        array_map(function($field) {
26 26
             $new_field = [
27 27
                 'name'       => $field,
28 28
                 'label'      => $this->makeLabel($field),
@@ -33,14 +33,14 @@  discard block
 block discarded – undo
33 33
                 'attributes' => [],
34 34
                 'autoset'    => true,
35 35
             ];
36
-            if (! isset($this->create_fields[$field])) {
36
+            if (!isset($this->create_fields[$field])) {
37 37
                 $this->create_fields[$field] = $new_field;
38 38
             }
39
-            if (! isset($this->update_fields[$field])) {
39
+            if (!isset($this->update_fields[$field])) {
40 40
                 $this->update_fields[$field] = $new_field;
41 41
             }
42 42
 
43
-            if (! in_array($field, $this->model->getHidden()) && ! isset($this->columns[$field])) {
43
+            if (!in_array($field, $this->model->getHidden()) && !isset($this->columns[$field])) {
44 44
                 $this->addColumn([
45 45
                     'name'  => $field,
46 46
                     'label' => $this->makeLabel($field),
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
      */
81 81
     public function getFieldTypeFromDbColumnType($field)
82 82
     {
83
-        if (! array_key_exists($field, $this->db_column_types)) {
83
+        if (!array_key_exists($field, $this->db_column_types)) {
84 84
             return 'text';
85 85
         }
86 86
 
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
         $types = ['enum' => 'string'];
148 148
         $platform = \DB::getDoctrineConnection()->getDatabasePlatform();
149 149
         foreach ($types as $type_key => $type_value) {
150
-            if (! $platform->hasDoctrineTypeMappingFor($type_key)) {
150
+            if (!$platform->hasDoctrineTypeMappingFor($type_key)) {
151 151
                 $platform->registerDoctrineTypeMapping($type_key, $type_value);
152 152
             }
153 153
         }
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
         $columns = $this->model->getConnection()->getSchemaBuilder()->getColumnListing($this->model->getTable());
203 203
         $fillable = $this->model->getFillable();
204 204
 
205
-        if (! empty($fillable)) {
205
+        if (!empty($fillable)) {
206 206
             $columns = array_intersect($columns, $fillable);
207 207
         }
208 208
 
Please login to merge, or discard this patch.
src/app/Console/Commands/Install.php 3 patches
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD\app\Console\Commands;
4 4
 
5
-use Illuminate\Console\Command;
6
-use Symfony\Component\Process\Process;
7 5
 use Backpack\Base\app\Console\Commands\Install as BaseInstall;
8 6
 
9 7
 class Install extends BaseInstall
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
                     $this->executeProcess('mkdir -p public/uploads');
54 54
                     break;
55 55
                 case '\\': // windows
56
-                    if (! file_exists('public\uploads')) {
56
+                    if (!file_exists('public\uploads')) {
57 57
                         $this->executeProcess('mkdir public\uploads');
58 58
                     }
59 59
                     break;
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
     /**
31 31
      * Execute the console command.
32 32
      *
33
-     * @return mixed
33
+     * @return false|null
34 34
      */
35 35
     public function handle()
36 36
     {
Please login to merge, or discard this patch.
src/PanelTraits/Create.php 3 patches
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2,8 +2,8 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD\PanelTraits;
4 4
 
5
-use Illuminate\Database\Eloquent\Relations\HasOne;
6 5
 use Illuminate\Database\Eloquent\Relations\BelongsTo;
6
+use Illuminate\Database\Eloquent\Relations\HasOne;
7 7
 
8 8
 trait Create
9 9
 {
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
     {
91 91
         $all_relation_fields = $this->getRelationFields($form);
92 92
 
93
-        return array_where($all_relation_fields, function ($value, $key) {
93
+        return array_where($all_relation_fields, function($value, $key) {
94 94
             return isset($value['pivot']) && $value['pivot'];
95 95
         });
96 96
     }
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
      */
162 162
     private function createRelationsForItem($item, $formattedData)
163 163
     {
164
-        if (! isset($formattedData['relations'])) {
164
+        if (!isset($formattedData['relations'])) {
165 165
             return false;
166 166
         }
167 167
 
@@ -219,11 +219,11 @@  discard block
 block discarded – undo
219 219
                 $key = implode('.relations.', explode('.', $relationField['entity']));
220 220
                 $fieldData = array_get($relationData, 'relations.'.$key, []);
221 221
 
222
-                if (! array_key_exists('model', $fieldData)) {
222
+                if (!array_key_exists('model', $fieldData)) {
223 223
                     $fieldData['model'] = $relationField['model'];
224 224
                 }
225 225
 
226
-                if (! array_key_exists('parent', $fieldData)) {
226
+                if (!array_key_exists('parent', $fieldData)) {
227 227
                     $fieldData['parent'] = $this->getRelationModel($relationField['entity'], -1);
228 228
                 }
229 229
 
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -159,7 +159,7 @@
 block discarded – undo
159 159
      * @param \Illuminate\Database\Eloquent\Model $item          The current CRUD model.
160 160
      * @param array                               $formattedData The form data.
161 161
      *
162
-     * @return bool|null
162
+     * @return false|null
163 163
      */
164 164
     private function createRelationsForItem($item, $formattedData)
165 165
     {
Please login to merge, or discard this patch.
src/PanelTraits/Update.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 
52 52
         foreach ($fields as &$field) {
53 53
             // set the value
54
-            if (! isset($field['value'])) {
54
+            if (!isset($field['value'])) {
55 55
                 if (isset($field['subfields'])) {
56 56
                     $field['value'] = [];
57 57
                     foreach ($field['subfields'] as $subfield) {
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
         }
65 65
 
66 66
         // always have a hidden input for the entry id
67
-        if (! array_key_exists('id', $fields)) {
67
+        if (!array_key_exists('id', $fields)) {
68 68
             $fields['id'] = [
69 69
                 'name'  => $entry->getKeyName(),
70 70
                 'value' => $entry->getKey(),
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
     {
88 88
         if (isset($field['entity'])) {
89 89
             $relationArray = explode('.', $field['entity']);
90
-            $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function ($obj, $method) {
90
+            $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function($obj, $method) {
91 91
                 return $obj->{$method} ? $obj->{$method} : $obj;
92 92
             }, $model);
93 93
 
Please login to merge, or discard this patch.
src/resources/views/fields/select.blade.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@
 block discarded – undo
5 5
     <label>{!! $field['label'] !!}</label>
6 6
     @include('crud::inc.field_translatable_icon')
7 7
 
8
-    <?php $entity_model = $crud->getRelationModel($field['entity'],  - 1); ?>
8
+    <?php $entity_model = $crud->getRelationModel($field['entity'], - 1); ?>
9 9
     <select
10 10
         name="{{ $field['name'] }}"
11 11
         @include('crud::inc.field_attributes')
Please login to merge, or discard this patch.
src/resources/views/fields/select2.blade.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,7 @@
 block discarded – undo
2 2
 <div @include('crud::inc.field_wrapper_attributes') >
3 3
     <label>{!! $field['label'] !!}</label>
4 4
     @include('crud::inc.field_translatable_icon')
5
-    <?php $entity_model = $crud->getRelationModel($field['entity'],  - 1); ?>
5
+    <?php $entity_model = $crud->getRelationModel($field['entity'], - 1); ?>
6 6
     <select
7 7
         name="{{ $field['name'] }}"
8 8
         style="width: 100%"
Please login to merge, or discard this patch.