Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#224)
by Owen
10:24
created
src/PanelTraits/Read.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
     public function hasUploadFields($form)
76 76
     {
77 77
         $fields = $this->getFields($form);
78
-        $upload_fields = array_where($fields, function ($value, $key) {
78
+        $upload_fields = array_where($fields, function($value, $key) {
79 79
             return isset($value['upload']) && $value['upload'] == true;
80 80
         });
81 81
 
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
      */
174 174
     public function getCellView($column, $entry)
175 175
     {
176
-        if (! isset($column['type'])) {
176
+        if (!isset($column['type'])) {
177 177
             return \View::make('crud::columns.text')->with('crud', $this)->with('column', $column)->with('entry', $entry)->render();
178 178
         } else {
179 179
             if (view()->exists('vendor.backpack.crud.columns.'.$column['type'])) {
Please login to merge, or discard this patch.
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -33,6 +33,7 @@
 block discarded – undo
33 33
      * Get all fields needed for the EDIT ENTRY form.
34 34
      *
35 35
      * @param  [integer] The id of the entry that is being edited.
36
+     * @param integer $id
36 37
      *
37 38
      * @return [array] The fields with attributes, fake attributes and values.
38 39
      */
Please login to merge, or discard this patch.
src/CrudServiceProvider.php 2 patches
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -89,33 +89,33 @@
 block discarded – undo
89 89
         Route::post($name.'/search', [
90 90
             'as' => 'crud.'.$name.'.search',
91 91
             'uses' => $controller.'@search',
92
-          ]);
92
+            ]);
93 93
         Route::get($name.'/reorder', [
94 94
             'as' => 'crud.'.$name.'.reorder',
95 95
             'uses' => $controller.'@reorder',
96
-          ]);
96
+            ]);
97 97
         Route::post($name.'/reorder', [
98 98
             'as' => 'crud.'.$name.'.save.reorder',
99 99
             'uses' => $controller.'@saveReorder',
100
-          ]);
100
+            ]);
101 101
         Route::get($name.'/{id}/details', [
102 102
             'as' => 'crud.'.$name.'.showDetailsRow',
103 103
             'uses' => $controller.'@showDetailsRow',
104
-          ]);
104
+            ]);
105 105
         Route::get($name.'/{id}/translate/{lang}', [
106 106
             'as' => 'crud.'.$name.'.translateItem',
107 107
             'uses' => $controller.'@translateItem',
108
-          ]);
108
+            ]);
109 109
 
110 110
         Route::get($name.'/{id}/revisions', [
111 111
             'as' => 'crud.'.$name.'.listRevisions',
112 112
             'uses' => $controller.'@listRevisions',
113
-          ]);
113
+            ]);
114 114
 
115 115
         Route::post($name.'/{id}/revisions/{revisionId}/restore', [
116 116
             'as' => 'crud.'.$name.'.restoreRevision',
117 117
             'uses' => $controller.'@restoreRevision',
118
-          ]);
118
+            ]);
119 119
 
120 120
         $options_with_default_route_names = array_merge([
121 121
             'names' => [
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
      */
76 76
     public function register()
77 77
     {
78
-        $this->app->bind('CRUD', function ($app) {
78
+        $this->app->bind('CRUD', function($app) {
79 79
             return new CRUD($app);
80 80
         });
81 81
 
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
     {
151 151
         $crudPubPath = public_path('vendor/backpack/crud');
152 152
 
153
-        if (! is_dir($crudPubPath)) {
153
+        if (!is_dir($crudPubPath)) {
154 154
             return true;
155 155
         }
156 156
 
Please login to merge, or discard this patch.
src/PanelTraits/ViewsAndRestoresRevisions.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@
 block discarded – undo
21 21
             $revisionDate = date('Y-m-d', strtotime((string) $history->created_at));
22 22
 
23 23
             // Be sure to instantiate the initial grouping array
24
-            if (! array_key_exists($revisionDate, $revisions)) {
24
+            if (!array_key_exists($revisionDate, $revisions)) {
25 25
                 $revisions[$revisionDate] = [];
26 26
             }
27 27
 
Please login to merge, or discard this patch.
src/resources/views/columns/array.blade.php 1 patch
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,11 +1,11 @@
 block discarded – undo
1 1
 {{-- enumerate the values in an array  --}}
2 2
 <td>
3 3
     <?php
4
-    	$value = $entry->{$column['name']};
5
-    	// the value should be an array wether or not attribute casting is used
6
-    	if (!is_array($value)) {
7
-    		$value = json_decode($value, true);
8
-    	}
4
+        $value = $entry->{$column['name']};
5
+        // the value should be an array wether or not attribute casting is used
6
+        if (!is_array($value)) {
7
+            $value = json_decode($value, true);
8
+        }
9 9
         if ($value && count($value)) {
10 10
             echo implode(', ', $value);
11 11
         } else {
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudController.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
 
32 32
         // call the setup function inside this closure to also have the request there
33 33
         // this way, developers can use things stored in session (auth variables, etc)
34
-        $this->middleware(function ($request, $next) {
34
+        $this->middleware(function($request, $next) {
35 35
             $this->setup();
36 36
             return $next($request);
37 37
         });
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
         $this->data['title'] = ucfirst($this->crud->entity_name_plural);
57 57
 
58 58
         // get all entries if AJAX is not enabled
59
-        if (! $this->data['crud']->ajaxTable()) {
59
+        if (!$this->data['crud']->ajaxTable()) {
60 60
             $this->data['entries'] = $this->data['crud']->getEntries();
61 61
         }
62 62
 
Please login to merge, or discard this patch.
Unused Use Statements   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -2,13 +2,11 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD\app\Http\Controllers;
4 4
 
5
+use Backpack\CRUD\CrudPanel;
6
+use Backpack\CRUD\app\Http\Requests\CrudRequest as UpdateRequest;
5 7
 use Illuminate\Foundation\Bus\DispatchesJobs;
6 8
 use Illuminate\Foundation\Validation\ValidatesRequests;
7 9
 use Illuminate\Routing\Controller as BaseController;
8
-use Illuminate\Support\Facades\Form as Form;
9
-use Backpack\CRUD\app\Http\Requests\CrudRequest as StoreRequest;
10
-use Backpack\CRUD\app\Http\Requests\CrudRequest as UpdateRequest;
11
-use Backpack\CRUD\CrudPanel;
12 10
 // CRUD Traits for non-core features
13 11
 use Backpack\CRUD\app\Http\Controllers\CrudFeatures\AjaxTable;
14 12
 use Backpack\CRUD\app\Http\Controllers\CrudFeatures\Reorder;
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudFeatures/Revisions.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
         // is somewhat superfluous.. however if we are POSTing, it makes sense to actually have data to post.
45 45
         // Perhaps the route shoud be better named to reflect this (e.g. just /model/{id}/revisions) (??)
46 46
         $revisionId = \Request::input('revision_id', false);
47
-        if (! $revisionId) {
47
+        if (!$revisionId) {
48 48
             abort(500, 'Can\'t restore revision without revision_id');
49 49
         } else {
50 50
             $this->crud->restoreRevision($id, $revisionId); // do the update
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudFeatures/Reorder.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -174,7 +174,7 @@
 block discarded – undo
174 174
     {
175 175
         $this->crud->hasAccessOrFail('reorder');
176 176
 
177
-        if (! $this->crud->isReorderEnabled()) {
177
+        if (!$this->crud->isReorderEnabled()) {
178 178
             abort(403, 'Reorder is disabled.');
179 179
         }
180 180
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudFeatures/AjaxTable.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
 
15 15
         // crate an array with the names of the searchable columns
16 16
         $columns = collect($this->crud->columns)
17
-                    ->reject(function ($column, $key) {
17
+                    ->reject(function($column, $key) {
18 18
                         // the select_multiple columns are not searchable
19 19
                         return isset($column['type']) && $column['type'] == 'select_multiple';
20 20
                     })
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
         $dataTable = new \LiveControl\EloquentDataTable\DataTable($this->crud->query, $columns);
28 28
 
29 29
         // make the datatable use the column types instead of just echoing the text
30
-        $dataTable->setFormatRowFunction(function ($entry) {
30
+        $dataTable->setFormatRowFunction(function($entry) {
31 31
             // get the actual HTML for each row's cell
32 32
             $row_items = $this->crud->getRowViews($entry, $this->crud);
33 33
 
Please login to merge, or discard this patch.
src/PanelTraits/AutoFocus.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -11,6 +11,9 @@
 block discarded – undo
11 11
         return $this->autoFocusOnFirstField;
12 12
     }
13 13
 
14
+    /**
15
+     * @param boolean $value
16
+     */
14 17
     public function setAutoFocusOnFirstField($value)
15 18
     {
16 19
         return $this->autoFocusOnFirstField = (bool) $value;
Please login to merge, or discard this patch.